You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tvm.apache.org by GitBox <gi...@apache.org> on 2020/09/05 22:55:56 UTC

[GitHub] [incubator-tvm] zhiics opened a new pull request #6403: [RELAY][REFACTOR] Mix mode context analysis

zhiics opened a new pull request #6403:
URL: https://github.com/apache/incubator-tvm/pull/6403


   https://discuss.tvm.apache.org/t/vm-an-error-from-context-analysis-pass/7818


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [incubator-tvm] masahi merged pull request #6403: [RELAY][REFACTOR] Mix mode context analysis

Posted by GitBox <gi...@apache.org>.
masahi merged pull request #6403:
URL: https://github.com/apache/incubator-tvm/pull/6403


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [incubator-tvm] masahi commented on pull request #6403: [RELAY][REFACTOR] Mix mode context analysis

Posted by GitBox <gi...@apache.org>.
masahi commented on pull request #6403:
URL: https://github.com/apache/incubator-tvm/pull/6403#issuecomment-689759374


   I need this fix for a new PyTorch frontend test I'm working on, so merging now. Thanks @zhiics @mbrookhart @leandron 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [incubator-tvm] zhiics commented on pull request #6403: [RELAY][REFACTOR] Mix mode context analysis

Posted by GitBox <gi...@apache.org>.
zhiics commented on pull request #6403:
URL: https://github.com/apache/incubator-tvm/pull/6403#issuecomment-688959065


   cc @mbrookhart @masahi @icemelon9 @jroesch 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [incubator-tvm] leandron commented on a change in pull request #6403: [RELAY][REFACTOR] Mix mode context analysis

Posted by GitBox <gi...@apache.org>.
leandron commented on a change in pull request #6403:
URL: https://github.com/apache/incubator-tvm/pull/6403#discussion_r484247948



##########
File path: tests/python/relay/test_any.py
##########
@@ -40,6 +40,7 @@ def check_result(args, mod, expected, flatten=False, assert_shape=False,
             if kind == "debug" and (only_vm or ctx.device_type !=
                                     tvm.cpu().device_type):
                 continue
+            print(tgt)

Review comment:
       nitpick: leftover debug `print` here?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org