You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@superset.apache.org by ma...@apache.org on 2024/08/23 16:22:24 UTC

(superset) branch master updated: fix: Removed fixed width constraint from Save button (#29686)

This is an automated email from the ASF dual-hosted git repository.

maximebeauchemin pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/superset.git


The following commit(s) were added to refs/heads/master by this push:
     new cb23d6f1a8 fix: Removed fixed width constraint from Save button (#29686)
cb23d6f1a8 is described below

commit cb23d6f1a8046b93aadcf5cf00cda8e9c50ce9f0
Author: Daniel <72...@users.noreply.github.com>
AuthorDate: Fri Aug 23 19:22:18 2024 +0300

    fix: Removed fixed width constraint from Save button (#29686)
---
 .../src/SqlLab/components/SaveDatasetActionButton/index.tsx      | 9 +--------
 superset-frontend/src/components/DropdownButton/index.tsx        | 1 -
 2 files changed, 1 insertion(+), 9 deletions(-)

diff --git a/superset-frontend/src/SqlLab/components/SaveDatasetActionButton/index.tsx b/superset-frontend/src/SqlLab/components/SaveDatasetActionButton/index.tsx
index 57d721503d..2acd7665bf 100644
--- a/superset-frontend/src/SqlLab/components/SaveDatasetActionButton/index.tsx
+++ b/superset-frontend/src/SqlLab/components/SaveDatasetActionButton/index.tsx
@@ -38,9 +38,6 @@ const SaveDatasetActionButton = ({
     DropdownButton as FC<DropdownButtonProps>,
   )`
     &.ant-dropdown-button button.ant-btn.ant-btn-default {
-      &:first-of-type {
-        width: ${theme.gridUnit * 16}px;
-      }
       font-weight: ${theme.gridUnit * 150};
       background-color: ${theme.colors.primary.light4};
       color: ${theme.colors.primary.dark1};
@@ -58,11 +55,7 @@ const SaveDatasetActionButton = ({
   `;
 
   return !overlayMenu ? (
-    <Button
-      onClick={() => setShowSave(true)}
-      buttonStyle="primary"
-      css={{ width: theme.gridUnit * 25 }}
-    >
+    <Button onClick={() => setShowSave(true)} buttonStyle="primary">
       {t('Save')}
     </Button>
   ) : (
diff --git a/superset-frontend/src/components/DropdownButton/index.tsx b/superset-frontend/src/components/DropdownButton/index.tsx
index f8910c4cbc..32a7739e3c 100644
--- a/superset-frontend/src/components/DropdownButton/index.tsx
+++ b/superset-frontend/src/components/DropdownButton/index.tsx
@@ -35,7 +35,6 @@ const StyledDropdownButton = styled.div`
         border-radius: ${({ theme }) =>
           `${theme.gridUnit}px 0 0 ${theme.gridUnit}px`};
         margin: 0;
-        width: 120px;
       }
 
       &:disabled {