You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@bigtop.apache.org by guyuqi <gi...@git.apache.org> on 2017/07/28 04:40:06 UTC

[GitHub] bigtop pull request #268: BIGTOP-2860:Fix TestSpark.groovy syntax error

GitHub user guyuqi opened a pull request:

    https://github.com/apache/bigtop/pull/268

    BIGTOP-2860:Fix TestSpark.groovy syntax error

    Change-Id: If3dba95133219dd16b9870b54f072c01328fbdaf
    
    Signed-off-by: Yuqi Gu <yu...@arm.com>

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/guyuqi/bigtop BIGTOP-2860

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/bigtop/pull/268.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #268
    
----
commit c20abedefa76763a96c08f3cc1ecb25fe0790da0
Author: Yuqi Gu <yu...@arm.com>
Date:   2017-07-28T03:34:44Z

    BIGTOP-2860:Fix TestSpark.groovy syntax error
    
    Change-Id: If3dba95133219dd16b9870b54f072c01328fbdaf
    
    Signed-off-by: Yuqi Gu <yu...@arm.com>

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] bigtop issue #268: BIGTOP-2860:Fix TestSpark.groovy syntax error

Posted by c0s <gi...@git.apache.org>.
Github user c0s commented on the issue:

    https://github.com/apache/bigtop/pull/268
  
    I will squash the commits to a single one before pushing to the master branch



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] bigtop issue #268: BIGTOP-2860:Fix TestSpark.groovy syntax error

Posted by nareshgbhat <gi...@git.apache.org>.
Github user nareshgbhat commented on the issue:

    https://github.com/apache/bigtop/pull/268
  
    As far as I understand the below code change must be by mistake in the patch
    
    static final String SPARK_PORT = System.getenv("SPARK_MASTER_PORT")
    
    should be changed to as below ?
    
    static final String SPARK_MASTER_PORT = System.getenv("SPARK_MASTER_PORT")



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] bigtop issue #268: BIGTOP-2860:Fix TestSpark.groovy syntax error

Posted by guyuqi <gi...@git.apache.org>.
Github user guyuqi commented on the issue:

    https://github.com/apache/bigtop/pull/268
  
    Fixed! thanks naresh!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] bigtop pull request #268: BIGTOP-2860:Fix TestSpark.groovy syntax error

Posted by c0s <gi...@git.apache.org>.
Github user c0s commented on a diff in the pull request:

    https://github.com/apache/bigtop/pull/268#discussion_r130446888
  
    --- Diff: bigtop-tests/smoke-tests/spark/TestSpark.groovy ---
    @@ -40,6 +40,8 @@ class TestSpark {
     
       static Shell sh = new Shell("/bin/bash -s")
       static final String SPARK_HOME = System.getenv("SPARK_HOME")
    --- End diff --
    
    In Groovy, you can use property-like access to map's entries. Like below:
    `System.env.SPARK_MASTER_IP`


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] bigtop pull request #268: BIGTOP-2860:Fix TestSpark.groovy syntax error

Posted by c0s <gi...@git.apache.org>.
Github user c0s commented on a diff in the pull request:

    https://github.com/apache/bigtop/pull/268#discussion_r130447063
  
    --- Diff: bigtop-tests/smoke-tests/spark/TestSpark.groovy ---
    @@ -73,7 +75,7 @@ class TestSpark {
         // 'yarn-client' mode
         String masterMode = 'yarn-client'
         if (System.env.SPARK_MASTER_IP != null && System.env.SPARK_MASTER_PORT != null)
    --- End diff --
    
    As you introduce new constants above for these environment variables, you can as well use them for this check.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---