You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues-all@impala.apache.org by "Wenzhe Zhou (Jira)" <ji...@apache.org> on 2024/03/20 03:53:00 UTC
[jira] [Comment Edited] (IMPALA-12925) Support decimal data type for external JDBC table
[ https://issues.apache.org/jira/browse/IMPALA-12925?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17828587#comment-17828587 ]
Wenzhe Zhou edited comment on IMPALA-12925 at 3/20/24 3:52 AM:
---------------------------------------------------------------
JDBC driver return decimal type of data as java.math.BigDecimal type. JDBC data source saves the decimal data in column data at https://github.com/apache/impala/blob/master/fe/src/main/java/org/apache/impala/extdatasource/jdbc/dao/JdbcRecordIterator.java#L150-L153.
Impala backend DataSourceScanNode set the decimal column in function SetDecimalVal() https://github.com/apache/impala/blob/master/be/src/exec/data-source-scan-node.cc#L180-L215.
Need to check if the binary formats of decimal type are compatible.
was (Author: wzhou):
JDBC driver return decimal type of data as java.math.BigDecimal type. JDBC data source saves the decimal data in column data at https://github.com/apache/impala/blob/master/fe/src/main/java/org/apache/impala/extdatasource/jdbc/dao/JdbcRecordIterator.java#L150-L153.
Impala backend DataSourceScanNode set the decimal column in function SetDecimalVal() https://github.com/apache/impala/blob/master/be/src/exec/data-source-scan-node.cc#L180-L215.
> Support decimal data type for external JDBC table
> -------------------------------------------------
>
> Key: IMPALA-12925
> URL: https://issues.apache.org/jira/browse/IMPALA-12925
> Project: IMPALA
> Issue Type: Sub-task
> Components: Frontend
> Reporter: Wenzhe Zhou
> Priority: Major
>
> The data types in unit-test table alltypes do not include decimal. The decimal data type is not handled in DataSourceScanNode.java (https://github.com/apache/impala/blob/master/fe/src/main/java/org/apache/impala/planner/DataSourceScanNode.java#L152), but decimal type is listed as supported primitive data type in DataSourceTable.java. (https://github.com/apache/impala/blob/master/fe/src/main/java/org/apache/impala/catalog/DataSourceTable.java#L153)
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-all-unsubscribe@impala.apache.org
For additional commands, e-mail: issues-all-help@impala.apache.org