You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@dubbo.apache.org by GitBox <gi...@apache.org> on 2021/08/01 04:32:22 UTC
[GitHub] [dubbo-spi-extensions] hclown9804 opened a new pull request #45: Extend rpc webservice service
hclown9804 opened a new pull request #45:
URL: https://github.com/apache/dubbo-spi-extensions/pull/45
## What is the purpose of the change
Make dubbo3 support webservice protocol.
## Brief changelog
## Verifying this change
Follow this checklist to help us incorporate your contribution quickly and easily:
- [x] Make sure there is a [GITHUB_issue](https://github.com/apache/dubbo/issues) field for the change (usually before you start working on it). Trivial changes like typos do not require a GITHUB issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
- [ ] Format the pull request title like `[Dubbo-XXX] Fix UnknownException when host config not exist #XXX`. Each commit in the pull request should have a meaningful subject line and body.
- [ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
- [ ] Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add sample in [dubbo samples](https://github.com/apache/dubbo-samples) project.
- [ ] Run `mvn clean install -DskipTests=false` & `mvn clean test-compile failsafe:integration-test` to make sure unit-test and integration-test pass.
- [ ] If this contribution is large, please follow the [Software Donation Guide](https://github.com/apache/dubbo/wiki/Software-donation-guide).
#44
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-spi-extensions] codecov-commenter edited a comment on pull request #45: Extend rpc webservice service
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #45:
URL: https://github.com/apache/dubbo-spi-extensions/pull/45#issuecomment-890449277
# [Codecov](https://codecov.io/gh/apache/dubbo-spi-extensions/pull/45?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#45](https://codecov.io/gh/apache/dubbo-spi-extensions/pull/45?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (59c4e37) into [master](https://codecov.io/gh/apache/dubbo-spi-extensions/commit/c082718523d79733f7d60b7d6bc8648ce5093ceb?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (c082718) will **increase** coverage by `12.16%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/dubbo-spi-extensions/pull/45?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #45 +/- ##
=============================================
+ Coverage 44.44% 56.61% +12.16%
- Complexity 10 15 +5
=============================================
Files 3 4 +1
Lines 108 189 +81
Branches 16 28 +12
=============================================
+ Hits 48 107 +59
- Misses 55 68 +13
- Partials 5 14 +9
```
| [Impacted Files](https://codecov.io/gh/apache/dubbo-spi-extensions/pull/45?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...bo/rpc/protocol/webservice/WebServiceProtocol.java](https://codecov.io/gh/apache/dubbo-spi-extensions/pull/45/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tc3BpLWV4dGVuc2lvbnMvZHViYm8tcnBjLWV4dGVuc2lvbnMvZHViYm8tcnBjLXdlYnNlcnZpY2Uvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC93ZWJzZXJ2aWNlL1dlYlNlcnZpY2VQcm90b2NvbC5qYXZh) | `72.83% <0.00%> (ø)` | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo-spi-extensions/pull/45?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/dubbo-spi-extensions/pull/45?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [c082718...59c4e37](https://codecov.io/gh/apache/dubbo-spi-extensions/pull/45?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-spi-extensions] codecov-commenter edited a comment on pull request #45: Extend rpc webservice service
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #45:
URL: https://github.com/apache/dubbo-spi-extensions/pull/45#issuecomment-890449277
# [Codecov](https://codecov.io/gh/apache/dubbo-spi-extensions/pull/45?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#45](https://codecov.io/gh/apache/dubbo-spi-extensions/pull/45?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (1995d91) into [master](https://codecov.io/gh/apache/dubbo-spi-extensions/commit/c0f6b731fa48212a88635466e499d0f6668b2b6e?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (c0f6b73) will **not change** coverage.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/dubbo-spi-extensions/pull/45?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #45 +/- ##
======================================
Coverage 0.00% 0.00%
======================================
Files 26 26
Lines 879 879
Branches 106 106
======================================
Misses 879 879
```
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo-spi-extensions/pull/45?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/dubbo-spi-extensions/pull/45?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [c0f6b73...1995d91](https://codecov.io/gh/apache/dubbo-spi-extensions/pull/45?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-spi-extensions] codecov-commenter commented on pull request #45: Extend rpc webservice service
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on pull request #45:
URL: https://github.com/apache/dubbo-spi-extensions/pull/45#issuecomment-890449277
# [Codecov](https://codecov.io/gh/apache/dubbo-spi-extensions/pull/45?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#45](https://codecov.io/gh/apache/dubbo-spi-extensions/pull/45?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (1995d91) into [master](https://codecov.io/gh/apache/dubbo-spi-extensions/commit/c0f6b731fa48212a88635466e499d0f6668b2b6e?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (c0f6b73) will **not change** coverage.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/dubbo-spi-extensions/pull/45?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #45 +/- ##
======================================
Coverage 0.00% 0.00%
======================================
Files 26 26
Lines 879 879
Branches 106 106
======================================
Misses 879 879
```
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo-spi-extensions/pull/45?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/dubbo-spi-extensions/pull/45?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [c0f6b73...1995d91](https://codecov.io/gh/apache/dubbo-spi-extensions/pull/45?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-spi-extensions] xiaoheng1 merged pull request #45: Extend rpc webservice service
Posted by GitBox <gi...@apache.org>.
xiaoheng1 merged pull request #45:
URL: https://github.com/apache/dubbo-spi-extensions/pull/45
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org