You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "zanmato1984 (via GitHub)" <gi...@apache.org> on 2025/05/03 06:50:19 UTC
[PR] GH-46224: [C++][Acero] Fix the hang in asof join [arrow]
zanmato1984 opened a new pull request, #46300:
URL: https://github.com/apache/arrow/pull/46300
Thanks for opening a pull request!
If this is your first pull request you can find detailed information on how to contribute here:
* [New Contributor's Guide](https://arrow.apache.org/docs/dev/developers/guide/step_by_step/pr_lifecycle.html#reviews-and-merge-of-the-pull-request)
* [Contributing Overview](https://arrow.apache.org/docs/dev/developers/overview.html)
Please remove this line and the above text before creating your pull request.
### Rationale for this change
### What changes are included in this PR?
### Are these changes tested?
### Are there any user-facing changes?
**This PR includes breaking changes to public APIs.** (If there are any breaking changes to public APIs, please explain which changes are breaking. If not, you can remove this.)
**This PR contains a "Critical Fix".** (If the changes fix either (a) a security vulnerability, (b) a bug that caused incorrect or invalid data to be produced, or (c) a bug that causes a crash (even when the API contract is upheld), please provide explanation. If not, you can remove this.)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-46224: [C++][Acero] Fix the hang in asof join [arrow]
Posted by "pitrou (via GitHub)" <gi...@apache.org>.
pitrou commented on code in PR #46300:
URL: https://github.com/apache/arrow/pull/46300#discussion_r2076996694
##########
cpp/src/arrow/acero/asof_join_node.cc:
##########
@@ -639,12 +639,8 @@ class InputState : public util::SerialSequencingQueue::Processor {
// hit the end of the batch, need to get the next batch if possible.
++batches_processed_;
latest_ref_row_ = 0;
- have_active_batch &= !queue_.TryPop();
- if (have_active_batch) {
- DCHECK_GT(queue_.Front()->num_rows(), 0); // empty batches disallowed
- memo_.UpdateTime(GetTime(queue_.Front().get(), time_type_id_, time_col_index_,
- 0)); // time changed
- }
+ std::ignore = queue_.TryPop();
Review Comment:
Perhaps we can add some debug checking?
```suggestion
bool did_pop = queue_.TryPop().has_value();
DCHECK(did_pop);
ARROW_UNUSED(did_pop);
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-46224: [C++][Acero] Fix the hang in asof join [arrow]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #46300:
URL: https://github.com/apache/arrow/pull/46300#issuecomment-2848472536
Revision: aa5a9bec23e156473091ea44acee590dde38bb4c
Submitted crossbow builds: [ursacomputing/crossbow @ actions-d733af0ab3](https://github.com/ursacomputing/crossbow/branches/all?query=actions-d733af0ab3)
|Task|Status|
|----|------|
|example-cpp-minimal-build-static|[](https://github.com/ursacomputing/crossbow/actions/runs/14808517402/job/41580248336)|
|example-cpp-minimal-build-static-system-dependency|[](https://github.com/ursacomputing/crossbow/actions/runs/14808517316/job/41580247865)|
|example-cpp-tutorial|[](https://github.com/ursacomputing/crossbow/actions/runs/14808517430/job/41580248549)|
|r-binary-packages|[](https://github.com/ursacomputing/crossbow/actions/runs/14808517471/job/41580248892)|
|r-recheck-most|[](https://github.com/ursacomputing/crossbow/actions/runs/14808517438/job/41580248979)|
|test-alpine-linux-cpp|[](https://github.com/ursacomputing/crossbow/actions/runs/14808517384/job/41580248089)|
|test-build-cpp-fuzz|[](https://github.com/ursacomputing/crossbow/actions/runs/14808517405/job/41580248357)|
|test-conda-cpp|[](https://github.com/ursacomputing/crossbow/actions/runs/14808517416/job/41580248428)|
|test-conda-cpp-meson|[](https://github.com/ursacomputing/crossbow/actions/runs/14808517457/job/41580248621)|
|test-conda-cpp-valgrind|[](https://github.com/ursacomputing/crossbow/actions/runs/14808517330/job/41580247939)|
|test-cuda-cpp-ubuntu-22.04-cuda-11.7.1|[](https://github.com/ursacomputing/crossbow/actions/runs/14808517352/job/41580248087)|
|test-debian-12-cpp-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/14808517288/job/41580247556)|
|test-debian-12-cpp-i386|[](https://github.com/ursacomputing/crossbow/actions/runs/14808517392/job/41580248308)|
|test-fedora-39-cpp|[](https://github.com/ursacomputing/crossbow/actions/runs/14808517479/job/41580248756)|
|test-r-arrow-backwards-compatibility|[](https://github.com/ursacomputing/crossbow/actions/runs/14808517421/job/41580248446)|
|test-r-clang-sanitizer|[](https://github.com/ursacomputing/crossbow/actions/runs/14808517321/job/41580247888)|
|test-r-depsource-bundled|[](https://github.com/ursacomputing/crossbow/runs/41580248591)|
|test-r-depsource-system|[](https://github.com/ursacomputing/crossbow/actions/runs/14808517309/job/41580247570)|
|test-r-dev-duckdb|[](https://github.com/ursacomputing/crossbow/actions/runs/14808517381/job/41580248094)|
|test-r-devdocs|[](https://github.com/ursacomputing/crossbow/actions/runs/14808517456/job/41580248839)|
|test-r-extra-packages|[](https://github.com/ursacomputing/crossbow/actions/runs/14808517499/job/41580249036)|
|test-r-gcc-11|[](https://github.com/ursacomputing/crossbow/actions/runs/14808517422/job/41580248550)|
|test-r-gcc-12|[](https://github.com/ursacomputing/crossbow/actions/runs/14808517236/job/41580247357)|
|test-r-install-local|[](https://github.com/ursacomputing/crossbow/actions/runs/14808517535/job/41580249571)|
|test-r-install-local-minsizerel|[](https://github.com/ursacomputing/crossbow/actions/runs/14808517376/job/41580248412)|
|test-r-linux-as-cran|[](https://github.com/ursacomputing/crossbow/actions/runs/14808517294/job/41580248399)|
|test-r-linux-rchk|[](https://github.com/ursacomputing/crossbow/actions/runs/14808517401/job/41580248243)|
|test-r-linux-sanitizer|[](https://github.com/ursacomputing/crossbow/actions/runs/14808517262/job/41580247448)|
|test-r-linux-valgrind|[](https://github.com/ursacomputing/crossbow/actions/runs/14808517407/job/41580248501)|
|test-r-macos-as-cran|[](https://github.com/ursacomputing/crossbow/actions/runs/14808517388/job/41580248222)|
|test-r-minimal-build|[](https://github.com/ursacomputing/crossbow/runs/41580248199)|
|test-r-offline-maximal|[](https://github.com/ursacomputing/crossbow/actions/runs/14808517437/job/41580254909)|
|test-r-offline-minimal|[](https://github.com/ursacomputing/crossbow/runs/41580248686)|
|test-r-rhub-debian-gcc-devel-lto-latest|[](https://github.com/ursacomputing/crossbow/runs/41580248680)|
|test-r-rhub-debian-gcc-release-custom-ccache|[](https://github.com/ursacomputing/crossbow/runs/41580248311)|
|test-r-rhub-ubuntu-release-latest|[](https://github.com/ursacomputing/crossbow/runs/41580248411)|
|test-r-rocker-r-ver-latest|[](https://github.com/ursacomputing/crossbow/runs/41580248508)|
|test-r-rstudio-r-base-4.1-opensuse155|[](https://github.com/ursacomputing/crossbow/runs/41580248000)|
|test-r-rstudio-r-base-4.2-focal|[](https://github.com/ursacomputing/crossbow/runs/41580248781)|
|test-r-ubuntu-22.04|[](https://github.com/ursacomputing/crossbow/actions/runs/14808517332/job/41580247928)|
|test-r-versions|[](https://github.com/ursacomputing/crossbow/actions/runs/14808517423/job/41580249090)|
|test-ubuntu-22.04-cpp|[](https://github.com/ursacomputing/crossbow/actions/runs/14808517536/job/41580249444)|
|test-ubuntu-22.04-cpp-20|[](https://github.com/ursacomputing/crossbow/actions/runs/14808517280/job/41580247514)|
|test-ubuntu-22.04-cpp-bundled|[](https://github.com/ursacomputing/crossbow/actions/runs/14808517472/job/41580248799)|
|test-ubuntu-22.04-cpp-emscripten|[](https://github.com/ursacomputing/crossbow/actions/runs/14808517400/job/41580248280)|
|test-ubuntu-22.04-cpp-no-threading|[](https://github.com/ursacomputing/crossbow/actions/runs/14808517455/job/41580248622)|
|test-ubuntu-24.04-cpp|[](https://github.com/ursacomputing/crossbow/actions/runs/14808517305/job/41580247637)|
|test-ubuntu-24.04-cpp-bundled-offline|[](https://github.com/ursacomputing/crossbow/actions/runs/14808517520/job/41580249326)|
|test-ubuntu-24.04-cpp-gcc-13-bundled|[](https://github.com/ursacomputing/crossbow/actions/runs/14808517313/job/41580247636)|
|test-ubuntu-24.04-cpp-gcc-14|[](https://github.com/ursacomputing/crossbow/actions/runs/14808517326/job/41580247905)|
|test-ubuntu-24.04-cpp-minimal-with-formats|[](https://github.com/ursacomputing/crossbow/actions/runs/14808517221/job/41580247324)|
|test-ubuntu-24.04-cpp-thread-sanitizer|[](https://github.com/ursacomputing/crossbow/actions/runs/14808517265/job/41580247456)|
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-46224: [C++][Acero] Fix the hang in asof join [arrow]
Posted by "pitrou (via GitHub)" <gi...@apache.org>.
pitrou commented on code in PR #46300:
URL: https://github.com/apache/arrow/pull/46300#discussion_r2084228040
##########
cpp/src/arrow/acero/asof_join_node_test.cc:
##########
@@ -1770,5 +1771,53 @@ TEST(AsofJoinTest, DestroyNonStartedAsofJoinNode) {
DeclarationToStatus(std::move(sink)));
}
+// Reproduction of GH-46224: Hang when all left timestamps are greater than right
+// timestamps.
+TEST(AsofJoinTest, OneSideTsAllGreaterThanTheOther) {
Review Comment:
Just one thing: I see that it takes around 8s on a regular debug build (on my machine anyway). Should we make sure that it's not too costly under Valgrind?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-46224: [C++][Acero] Fix the hang in asof join [arrow]
Posted by "zanmato1984 (via GitHub)" <gi...@apache.org>.
zanmato1984 commented on code in PR #46300:
URL: https://github.com/apache/arrow/pull/46300#discussion_r2085181427
##########
cpp/src/arrow/acero/asof_join_node_test.cc:
##########
@@ -1770,5 +1771,53 @@ TEST(AsofJoinTest, DestroyNonStartedAsofJoinNode) {
DeclarationToStatus(std::move(sink)));
}
+// Reproduction of GH-46224: Hang when all left timestamps are greater than right
+// timestamps.
+TEST(AsofJoinTest, OneSideTsAllGreaterThanTheOther) {
Review Comment:
It was costly indeed. For the record: sanitizer time increases from 43.16s to 98.33s, valgrind time increases from 58.15s to 162.90s.
I reduced the iteration for sanitizer and valgrind to one in the latest commit.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-46224: [C++][Acero] Fix the hang in asof join [arrow]
Posted by "zanmato1984 (via GitHub)" <gi...@apache.org>.
zanmato1984 commented on PR #46300:
URL: https://github.com/apache/arrow/pull/46300#issuecomment-2856452005
Hi, @westonpace @icexelloss @pitrou would you help to review? Thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-46224: [C++][Acero] Fix the hang in asof join [arrow]
Posted by "zanmato1984 (via GitHub)" <gi...@apache.org>.
zanmato1984 commented on PR #46300:
URL: https://github.com/apache/arrow/pull/46300#issuecomment-2873489153
@github-actions crossbow submit -g cpp
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-46224: [C++][Acero] Fix the hang in asof join [arrow]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #46300:
URL: https://github.com/apache/arrow/pull/46300#issuecomment-2848471282
:warning: GitHub issue #46224 **has been automatically assigned in GitHub** to PR creator.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-46224: [C++][Acero] Fix the hang in asof join [arrow]
Posted by "zanmato1984 (via GitHub)" <gi...@apache.org>.
zanmato1984 commented on PR #46300:
URL: https://github.com/apache/arrow/pull/46300#issuecomment-2873373393
@github-actions crossbow submit -g cpp
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-46224: [C++][Acero] Fix the hang in asof join [arrow]
Posted by "zanmato1984 (via GitHub)" <gi...@apache.org>.
zanmato1984 commented on code in PR #46300:
URL: https://github.com/apache/arrow/pull/46300#discussion_r2076509438
##########
cpp/src/arrow/acero/asof_join_node.cc:
##########
@@ -639,12 +639,8 @@ class InputState : public util::SerialSequencingQueue::Processor {
// hit the end of the batch, need to get the next batch if possible.
++batches_processed_;
latest_ref_row_ = 0;
- have_active_batch &= !queue_.TryPop();
Review Comment:
IMO this code is apparently NOT doing what it is supposed to do: by here the `have_active_batch` must be `true`, meaning `queue_` must be non-empty. Then popping the queue always gets a valid `std::optional` and effectively setting `have_active_batch` to false. The `if` branch below won't be executed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-46224: [C++][Acero] Fix the hang in asof join [arrow]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #46300:
URL: https://github.com/apache/arrow/pull/46300#issuecomment-2856757702
Revision: af70071bd8938c1be0759ad0b34b20a99eb8ed40
Submitted crossbow builds: [ursacomputing/crossbow @ actions-ccf7708cfd](https://github.com/ursacomputing/crossbow/branches/all?query=actions-ccf7708cfd)
|Task|Status|
|----|------|
|example-cpp-minimal-build-static|[](https://github.com/ursacomputing/crossbow/actions/runs/14873058485/job/41765158215)|
|example-cpp-minimal-build-static-system-dependency|[](https://github.com/ursacomputing/crossbow/actions/runs/14873056530/job/41765149595)|
|example-cpp-tutorial|[](https://github.com/ursacomputing/crossbow/actions/runs/14873057110/job/41765151564)|
|example-python-minimal-build-fedora-conda|[](https://github.com/ursacomputing/crossbow/actions/runs/14873057717/job/41765154496)|
|example-python-minimal-build-ubuntu-venv|[](https://github.com/ursacomputing/crossbow/actions/runs/14873058040/job/41765156592)|
|r-binary-packages|[](https://github.com/ursacomputing/crossbow/actions/runs/14873058250/job/41765157479)|
|r-recheck-most|[](https://github.com/ursacomputing/crossbow/actions/runs/14873057925/job/41765157729)|
|test-alpine-linux-cpp|[](https://github.com/ursacomputing/crossbow/actions/runs/14873057742/job/41765154951)|
|test-build-cpp-fuzz|[](https://github.com/ursacomputing/crossbow/actions/runs/14873057010/job/41765150945)|
|test-conda-cpp|[](https://github.com/ursacomputing/crossbow/actions/runs/14873056888/job/41765150677)|
|test-conda-cpp-meson|[](https://github.com/ursacomputing/crossbow/actions/runs/14873056778/job/41765150435)|
|test-conda-cpp-valgrind|[](https://github.com/ursacomputing/crossbow/actions/runs/14873058220/job/41765157475)|
|test-conda-python-3.10|[](https://github.com/ursacomputing/crossbow/actions/runs/14873057623/job/41765154136)|
|test-conda-python-3.10-hdfs-2.9.2|[](https://github.com/ursacomputing/crossbow/actions/runs/14873058068/job/41765156782)|
|test-conda-python-3.10-hdfs-3.2.1|[](https://github.com/ursacomputing/crossbow/actions/runs/14873058025/job/41765156421)|
|test-conda-python-3.10-pandas-latest-numpy-latest|[](https://github.com/ursacomputing/crossbow/actions/runs/14873058384/job/41765157988)|
|test-conda-python-3.11|[](https://github.com/ursacomputing/crossbow/actions/runs/14873057228/job/41765151673)|
|test-conda-python-3.11-dask-latest|[](https://github.com/ursacomputing/crossbow/actions/runs/14873056744/job/41765150163)|
|test-conda-python-3.11-dask-upstream_devel|[](https://github.com/ursacomputing/crossbow/actions/runs/14873058423/job/41765158174)|
|test-conda-python-3.11-hypothesis|[](https://github.com/ursacomputing/crossbow/actions/runs/14873057748/job/41765154878)|
|test-conda-python-3.11-pandas-latest-numpy-1.26|[](https://github.com/ursacomputing/crossbow/actions/runs/14873057371/job/41765152610)|
|test-conda-python-3.11-pandas-latest-numpy-latest|[](https://github.com/ursacomputing/crossbow/actions/runs/14873058137/job/41765157032)|
|test-conda-python-3.11-pandas-nightly-numpy-nightly|[](https://github.com/ursacomputing/crossbow/actions/runs/14873057542/job/41765153245)|
|test-conda-python-3.11-pandas-upstream_devel-numpy-nightly|[](https://github.com/ursacomputing/crossbow/actions/runs/14873057833/job/41765155833)|
|test-conda-python-3.11-spark-master|[](https://github.com/ursacomputing/crossbow/actions/runs/14873058618/job/41765158538)|
|test-conda-python-3.12|[](https://github.com/ursacomputing/crossbow/actions/runs/14873057092/job/41765151227)|
|test-conda-python-3.12-cpython-debug|[](https://github.com/ursacomputing/crossbow/actions/runs/14873057913/job/41765155965)|
|test-conda-python-3.13|[](https://github.com/ursacomputing/crossbow/actions/runs/14873058146/job/41765157248)|
|test-conda-python-3.9|[](https://github.com/ursacomputing/crossbow/actions/runs/14873057816/job/41765155170)|
|test-conda-python-3.9-pandas-1.1.3-numpy-1.19.5|[](https://github.com/ursacomputing/crossbow/actions/runs/14873057946/job/41765156232)|
|test-conda-python-emscripten|[](https://github.com/ursacomputing/crossbow/actions/runs/14873058285/job/41765157652)|
|test-cuda-cpp-ubuntu-22.04-cuda-11.7.1|[](https://github.com/ursacomputing/crossbow/actions/runs/14873058347/job/41765157918)|
|test-cuda-python-ubuntu-22.04-cuda-11.7.1|[](https://github.com/ursacomputing/crossbow/actions/runs/14873057788/job/41765155124)|
|test-debian-12-cpp-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/14873057094/job/41765151154)|
|test-debian-12-cpp-i386|[](https://github.com/ursacomputing/crossbow/actions/runs/14873058578/job/41765158534)|
|test-debian-12-python-3-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/14873057573/job/41765153535)|
|test-debian-12-python-3-i386|[](https://github.com/ursacomputing/crossbow/actions/runs/14873057550/job/41765153425)|
|test-fedora-39-cpp|[](https://github.com/ursacomputing/crossbow/actions/runs/14873057282/job/41765152051)|
|test-fedora-39-python-3|[](https://github.com/ursacomputing/crossbow/actions/runs/14873056738/job/41765150109)|
|test-r-arrow-backwards-compatibility|[](https://github.com/ursacomputing/crossbow/actions/runs/14873057868/job/41765155572)|
|test-r-clang-asan|[](https://github.com/ursacomputing/crossbow/actions/runs/14873057589/job/41765153924)|
|test-r-clang-ubsan|[](https://github.com/ursacomputing/crossbow/actions/runs/14873057076/job/41765151046)|
|test-r-depsource-bundled|[](https://github.com/ursacomputing/crossbow/runs/41765154295)|
|test-r-depsource-system|[](https://github.com/ursacomputing/crossbow/actions/runs/14873057243/job/41765152025)|
|test-r-dev-duckdb|[](https://github.com/ursacomputing/crossbow/actions/runs/14873057321/job/41765152131)|
|test-r-devdocs|[](https://github.com/ursacomputing/crossbow/actions/runs/14873056672/job/41765150360)|
|test-r-extra-packages|[](https://github.com/ursacomputing/crossbow/actions/runs/14873057633/job/41765154259)|
|test-r-gcc-11|[](https://github.com/ursacomputing/crossbow/actions/runs/14873056534/job/41765149642)|
|test-r-gcc-12|[](https://github.com/ursacomputing/crossbow/actions/runs/14873058026/job/41765156553)|
|test-r-install-local|[](https://github.com/ursacomputing/crossbow/actions/runs/14873056816/job/41765150839)|
|test-r-install-local-minsizerel|[](https://github.com/ursacomputing/crossbow/actions/runs/14873057724/job/41765155504)|
|test-r-linux-as-cran|[](https://github.com/ursacomputing/crossbow/actions/runs/14873058758/job/41765161520)|
|test-r-linux-rchk|[](https://github.com/ursacomputing/crossbow/actions/runs/14873057467/job/41765153072)|
|test-r-linux-sanitizer|[](https://github.com/ursacomputing/crossbow/actions/runs/14873057759/job/41765154821)|
|test-r-linux-valgrind|[](https://github.com/ursacomputing/crossbow/actions/runs/14873057625/job/41765154128)|
|test-r-m1-san|[](https://github.com/ursacomputing/crossbow/actions/runs/14873057241/job/41765151843)|
|test-r-macos-as-cran|[](https://github.com/ursacomputing/crossbow/actions/runs/14873057629/job/41765154245)|
|test-r-minimal-build|[](https://github.com/ursacomputing/crossbow/runs/41765154958)|
|test-r-offline-maximal|[](https://github.com/ursacomputing/crossbow/actions/runs/14873057204/job/41765205049)|
|test-r-offline-minimal|[](https://github.com/ursacomputing/crossbow/runs/41765153365)|
|test-r-rhub-debian-gcc-devel-lto-latest|[](https://github.com/ursacomputing/crossbow/runs/41765151584)|
|test-r-rhub-debian-gcc-release-custom-ccache|[](https://github.com/ursacomputing/crossbow/runs/41765153954)|
|test-r-rhub-ubuntu-release-latest|[](https://github.com/ursacomputing/crossbow/runs/41765155001)|
|test-r-rocker-r-ver-latest|[](https://github.com/ursacomputing/crossbow/runs/41765152701)|
|test-r-rstudio-r-base-4.1-opensuse155|[](https://github.com/ursacomputing/crossbow/runs/41765152368)|
|test-r-rstudio-r-base-4.2-focal|[](https://github.com/ursacomputing/crossbow/runs/41765156099)|
|test-r-ubuntu-22.04|[](https://github.com/ursacomputing/crossbow/actions/runs/14873057856/job/41765155381)|
|test-r-versions|[](https://github.com/ursacomputing/crossbow/actions/runs/14873057915/job/41765158002)|
|test-ubuntu-22.04-cpp|[](https://github.com/ursacomputing/crossbow/actions/runs/14873058587/job/41765158505)|
|test-ubuntu-22.04-cpp-20|[](https://github.com/ursacomputing/crossbow/actions/runs/14873056578/job/41765149851)|
|test-ubuntu-22.04-cpp-bundled|[](https://github.com/ursacomputing/crossbow/actions/runs/14873057333/job/41765152285)|
|test-ubuntu-22.04-cpp-emscripten|[](https://github.com/ursacomputing/crossbow/actions/runs/14873058178/job/41765157255)|
|test-ubuntu-22.04-cpp-no-threading|[](https://github.com/ursacomputing/crossbow/actions/runs/14873058354/job/41765157891)|
|test-ubuntu-22.04-python-3|[](https://github.com/ursacomputing/crossbow/actions/runs/14873057863/job/41765155416)|
|test-ubuntu-22.04-python-313-freethreading|[](https://github.com/ursacomputing/crossbow/actions/runs/14873057702/job/41765154622)|
|test-ubuntu-24.04-cpp|[](https://github.com/ursacomputing/crossbow/actions/runs/14873057090/job/41765151115)|
|test-ubuntu-24.04-cpp-bundled-offline|[](https://github.com/ursacomputing/crossbow/actions/runs/14873058484/job/41765158185)|
|test-ubuntu-24.04-cpp-gcc-13-bundled|[](https://github.com/ursacomputing/crossbow/actions/runs/14873058517/job/41765158346)|
|test-ubuntu-24.04-cpp-gcc-14|[](https://github.com/ursacomputing/crossbow/actions/runs/14873058089/job/41765156793)|
|test-ubuntu-24.04-cpp-minimal-with-formats|[](https://github.com/ursacomputing/crossbow/actions/runs/14873057563/job/41765153889)|
|test-ubuntu-24.04-cpp-thread-sanitizer|[](https://github.com/ursacomputing/crossbow/actions/runs/14873058317/job/41765157722)|
|test-ubuntu-24.04-python-3|[](https://github.com/ursacomputing/crossbow/actions/runs/14873056485/job/41765149614)|
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-46224: [C++][Acero] Fix the hang in asof join [arrow]
Posted by "zanmato1984 (via GitHub)" <gi...@apache.org>.
zanmato1984 commented on PR #46300:
URL: https://github.com/apache/arrow/pull/46300#issuecomment-2856751238
@github-actions crossbow submit -g cpp -g python -g r
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-46224: [C++][Acero] Fix the hang in asof join [arrow]
Posted by "pitrou (via GitHub)" <gi...@apache.org>.
pitrou commented on code in PR #46300:
URL: https://github.com/apache/arrow/pull/46300#discussion_r2076998883
##########
cpp/src/arrow/acero/asof_join_node_test.cc:
##########
@@ -1770,5 +1771,38 @@ TEST(AsofJoinTest, DestroyNonStartedAsofJoinNode) {
DeclarationToStatus(std::move(sink)));
}
+// Reproduction of GH-46224: Hang when all left timestamps are greater than right
+// timestamps.
Review Comment:
For completeness, can we have a test for the reverse situation?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-46224: [C++][Acero] Fix the hang in asof join [arrow]
Posted by "zanmato1984 (via GitHub)" <gi...@apache.org>.
zanmato1984 commented on PR #46300:
URL: https://github.com/apache/arrow/pull/46300#issuecomment-2877317594
Thanks @pitrou for reviewing. Is there anything else to address?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-46224: [C++][Acero] Fix the hang in asof join [arrow]
Posted by "zanmato1984 (via GitHub)" <gi...@apache.org>.
zanmato1984 commented on code in PR #46300:
URL: https://github.com/apache/arrow/pull/46300#discussion_r2085217669
##########
cpp/src/arrow/acero/asof_join_node_test.cc:
##########
@@ -1770,5 +1771,53 @@ TEST(AsofJoinTest, DestroyNonStartedAsofJoinNode) {
DeclarationToStatus(std::move(sink)));
}
+// Reproduction of GH-46224: Hang when all left timestamps are greater than right
+// timestamps.
+TEST(AsofJoinTest, OneSideTsAllGreaterThanTheOther) {
Review Comment:
And the execution time remains about the same as existing (sanitizer: 44.11s vs 43.16s, valgrind: 59.68s vs 58.15s).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-46224: [C++][Acero] Fix the hang in asof join [arrow]
Posted by "zanmato1984 (via GitHub)" <gi...@apache.org>.
zanmato1984 commented on PR #46300:
URL: https://github.com/apache/arrow/pull/46300#issuecomment-2848476926
@github-actions crossbow submit -g cpp -g r
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-46224: [C++][Acero] Fix the hang in asof join [arrow]
Posted by "zanmato1984 (via GitHub)" <gi...@apache.org>.
zanmato1984 commented on code in PR #46300:
URL: https://github.com/apache/arrow/pull/46300#discussion_r2078378577
##########
cpp/src/arrow/acero/asof_join_node_test.cc:
##########
@@ -1770,5 +1771,38 @@ TEST(AsofJoinTest, DestroyNonStartedAsofJoinNode) {
DeclarationToStatus(std::move(sink)));
}
+// Reproduction of GH-46224: Hang when all left timestamps are greater than right
+// timestamps.
Review Comment:
The hang doesn't occur for the reverse situation. But test updated anyway.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-46224: [C++][Acero] Fix the hang in asof join [arrow]
Posted by "zanmato1984 (via GitHub)" <gi...@apache.org>.
zanmato1984 commented on code in PR #46300:
URL: https://github.com/apache/arrow/pull/46300#discussion_r2078138687
##########
cpp/src/arrow/acero/asof_join_node.cc:
##########
@@ -639,12 +639,8 @@ class InputState : public util::SerialSequencingQueue::Processor {
// hit the end of the batch, need to get the next batch if possible.
++batches_processed_;
latest_ref_row_ = 0;
- have_active_batch &= !queue_.TryPop();
- if (have_active_batch) {
- DCHECK_GT(queue_.Front()->num_rows(), 0); // empty batches disallowed
- memo_.UpdateTime(GetTime(queue_.Front().get(), time_type_id_, time_col_index_,
- 0)); // time changed
- }
+ std::ignore = queue_.TryPop();
Review Comment:
This is definitely a good point, will do. Thank you!
##########
cpp/src/arrow/acero/asof_join_node_test.cc:
##########
@@ -1770,5 +1771,38 @@ TEST(AsofJoinTest, DestroyNonStartedAsofJoinNode) {
DeclarationToStatus(std::move(sink)));
}
+// Reproduction of GH-46224: Hang when all left timestamps are greater than right
+// timestamps.
Review Comment:
Yeah, sure, will do.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-46224: [C++][Acero] Fix the hang in asof join [arrow]
Posted by "zanmato1984 (via GitHub)" <gi...@apache.org>.
zanmato1984 commented on code in PR #46300:
URL: https://github.com/apache/arrow/pull/46300#discussion_r2076586295
##########
cpp/src/arrow/acero/asof_join_node.cc:
##########
@@ -639,12 +639,8 @@ class InputState : public util::SerialSequencingQueue::Processor {
// hit the end of the batch, need to get the next batch if possible.
++batches_processed_;
latest_ref_row_ = 0;
- have_active_batch &= !queue_.TryPop();
Review Comment:
I noticed there are two fixes made before in the following `if` branch #36094 and #36499. Given that this `have_active_batch &= !queue_.TryPop()` exists since #13028 where it was introduced, and the lack of corresponding tests, I'm not sure how they fixed anything and what the bugs even were. So I just remove them.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-46224: [C++][Acero] Fix the hang in asof join [arrow]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #46300:
URL: https://github.com/apache/arrow/pull/46300#issuecomment-2848477981
Revision: 6ea4624a8ec7c27ab7c57bdcacf295995d0e12a5
Submitted crossbow builds: [ursacomputing/crossbow @ actions-a2fa793a58](https://github.com/ursacomputing/crossbow/branches/all?query=actions-a2fa793a58)
|Task|Status|
|----|------|
|example-cpp-minimal-build-static|[](https://github.com/ursacomputing/crossbow/actions/runs/14808629190/job/41580508896)|
|example-cpp-minimal-build-static-system-dependency|[](https://github.com/ursacomputing/crossbow/actions/runs/14808629507/job/41580510437)|
|example-cpp-tutorial|[](https://github.com/ursacomputing/crossbow/actions/runs/14808629034/job/41580508080)|
|r-binary-packages|[](https://github.com/ursacomputing/crossbow/actions/runs/14808629243/job/41580509061)|
|r-recheck-most|[](https://github.com/ursacomputing/crossbow/actions/runs/14808629211/job/41580509578)|
|test-alpine-linux-cpp|[](https://github.com/ursacomputing/crossbow/actions/runs/14808629505/job/41580510779)|
|test-build-cpp-fuzz|[](https://github.com/ursacomputing/crossbow/actions/runs/14808629265/job/41580509105)|
|test-conda-cpp|[](https://github.com/ursacomputing/crossbow/actions/runs/14808628921/job/41580507842)|
|test-conda-cpp-meson|[](https://github.com/ursacomputing/crossbow/actions/runs/14808629525/job/41580510381)|
|test-conda-cpp-valgrind|[](https://github.com/ursacomputing/crossbow/actions/runs/14808629287/job/41580509446)|
|test-cuda-cpp-ubuntu-22.04-cuda-11.7.1|[](https://github.com/ursacomputing/crossbow/actions/runs/14808629469/job/41580510279)|
|test-debian-12-cpp-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/14808629482/job/41580510310)|
|test-debian-12-cpp-i386|[](https://github.com/ursacomputing/crossbow/actions/runs/14808629305/job/41580509724)|
|test-fedora-39-cpp|[](https://github.com/ursacomputing/crossbow/actions/runs/14808629271/job/41580509149)|
|test-r-arrow-backwards-compatibility|[](https://github.com/ursacomputing/crossbow/actions/runs/14808629096/job/41580508627)|
|test-r-clang-sanitizer|[](https://github.com/ursacomputing/crossbow/actions/runs/14808629099/job/41580508569)|
|test-r-depsource-bundled|[](https://github.com/ursacomputing/crossbow/runs/41580509689)|
|test-r-depsource-system|[](https://github.com/ursacomputing/crossbow/actions/runs/14808629101/job/41580508455)|
|test-r-dev-duckdb|[](https://github.com/ursacomputing/crossbow/actions/runs/14808629366/job/41580510080)|
|test-r-devdocs|[](https://github.com/ursacomputing/crossbow/actions/runs/14808629074/job/41580508453)|
|test-r-extra-packages|[](https://github.com/ursacomputing/crossbow/actions/runs/14808629245/job/41580509064)|
|test-r-gcc-11|[](https://github.com/ursacomputing/crossbow/actions/runs/14808629210/job/41580508948)|
|test-r-gcc-12|[](https://github.com/ursacomputing/crossbow/actions/runs/14808629488/job/41580510369)|
|test-r-install-local|[](https://github.com/ursacomputing/crossbow/actions/runs/14808629275/job/41580509561)|
|test-r-install-local-minsizerel|[](https://github.com/ursacomputing/crossbow/actions/runs/14808629368/job/41580510576)|
|test-r-linux-as-cran|[](https://github.com/ursacomputing/crossbow/actions/runs/14808629244/job/41580510630)|
|test-r-linux-rchk|[](https://github.com/ursacomputing/crossbow/actions/runs/14808629447/job/41580510273)|
|test-r-linux-sanitizer|[](https://github.com/ursacomputing/crossbow/actions/runs/14808629201/job/41580508933)|
|test-r-linux-valgrind|[](https://github.com/ursacomputing/crossbow/actions/runs/14808629097/job/41580508449)|
|test-r-macos-as-cran|[](https://github.com/ursacomputing/crossbow/actions/runs/14808628850/job/41580507691)|
|test-r-minimal-build|[](https://github.com/ursacomputing/crossbow/runs/41580508861)|
|test-r-offline-maximal|[](https://github.com/ursacomputing/crossbow/actions/runs/14808629095/job/41580508444)|
|test-r-offline-minimal|[](https://github.com/ursacomputing/crossbow/runs/41580509991)|
|test-r-rhub-debian-gcc-devel-lto-latest|[](https://github.com/ursacomputing/crossbow/runs/41580509999)|
|test-r-rhub-debian-gcc-release-custom-ccache|[](https://github.com/ursacomputing/crossbow/runs/41580509512)|
|test-r-rhub-ubuntu-release-latest|[](https://github.com/ursacomputing/crossbow/runs/41580509388)|
|test-r-rocker-r-ver-latest|[](https://github.com/ursacomputing/crossbow/runs/41580509113)|
|test-r-rstudio-r-base-4.1-opensuse155|[](https://github.com/ursacomputing/crossbow/runs/41580509508)|
|test-r-rstudio-r-base-4.2-focal|[](https://github.com/ursacomputing/crossbow/runs/41580509828)|
|test-r-ubuntu-22.04|[](https://github.com/ursacomputing/crossbow/actions/runs/14808629371/job/41580510075)|
|test-r-versions|[](https://github.com/ursacomputing/crossbow/actions/runs/14808629136/job/41580509441)|
|test-ubuntu-22.04-cpp|[](https://github.com/ursacomputing/crossbow/actions/runs/14808629253/job/41580509091)|
|test-ubuntu-22.04-cpp-20|[](https://github.com/ursacomputing/crossbow/actions/runs/14808629296/job/41580509586)|
|test-ubuntu-22.04-cpp-bundled|[](https://github.com/ursacomputing/crossbow/actions/runs/14808628990/job/41580507965)|
|test-ubuntu-22.04-cpp-emscripten|[](https://github.com/ursacomputing/crossbow/actions/runs/14808629341/job/41580509837)|
|test-ubuntu-22.04-cpp-no-threading|[](https://github.com/ursacomputing/crossbow/actions/runs/14808629300/job/41580509608)|
|test-ubuntu-24.04-cpp|[](https://github.com/ursacomputing/crossbow/actions/runs/14808629400/job/41580510198)|
|test-ubuntu-24.04-cpp-bundled-offline|[](https://github.com/ursacomputing/crossbow/actions/runs/14808629356/job/41580509953)|
|test-ubuntu-24.04-cpp-gcc-13-bundled|[](https://github.com/ursacomputing/crossbow/actions/runs/14808629301/job/41580509696)|
|test-ubuntu-24.04-cpp-gcc-14|[](https://github.com/ursacomputing/crossbow/actions/runs/14808628828/job/41580507660)|
|test-ubuntu-24.04-cpp-minimal-with-formats|[](https://github.com/ursacomputing/crossbow/actions/runs/14808629535/job/41580510501)|
|test-ubuntu-24.04-cpp-thread-sanitizer|[](https://github.com/ursacomputing/crossbow/actions/runs/14808629279/job/41580509288)|
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-46224: [C++][Acero] Fix the hang in asof join [arrow]
Posted by "zanmato1984 (via GitHub)" <gi...@apache.org>.
zanmato1984 commented on PR #46300:
URL: https://github.com/apache/arrow/pull/46300#issuecomment-2848471406
@github-actions crossbow submit -g cpp -g r
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-46224: [C++][Acero] Fix the hang in asof join [arrow]
Posted by "pitrou (via GitHub)" <gi...@apache.org>.
pitrou commented on PR #46300:
URL: https://github.com/apache/arrow/pull/46300#issuecomment-2857444697
I'm curious, this does only happen when the right side is concerned? The update logic is not symmetric?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-46224: [C++][Acero] Fix the hang in asof join [arrow]
Posted by "zanmato1984 (via GitHub)" <gi...@apache.org>.
zanmato1984 commented on PR #46300:
URL: https://github.com/apache/arrow/pull/46300#issuecomment-2859600956
> I'm curious, this does only happen when the right side is concerned? The update logic is not symmetric?
Right, not symmetric as one might would naturally expect (the same situation for hash join as well - right side to build the hash table and left side to probe the hash table).
The left VS. right differs in the following aspects:
1. There is only one left side input but possibly multiple right side inputs. The right side inputs are flattened and equally iterated during the whole processing (as opposed to traversed in a tree-like fashion).
2. Several processing logic, and in addition some methods are right side inputs only, e.g.: https://github.com/apache/arrow/blob/03bdb2a1901a10fc1c0f41bcd7dfa0f68a9a5aff/cpp/src/arrow/acero/asof_join_node.cc#L949
and https://github.com/apache/arrow/blob/03bdb2a1901a10fc1c0f41bcd7dfa0f68a9a5aff/cpp/src/arrow/acero/asof_join_node.cc#L963
So it's normal that some issues are right side only.
But it does remind me that the method I was fixing, namely `‎InputState::Advance`, also applies to the left side input, so I think I should see if the issue exists for the left side as well, probably by adding a symmetric case you suggested.
Thanks for the question!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-46224: [C++][Acero] Fix the hang in asof join [arrow]
Posted by "zanmato1984 (via GitHub)" <gi...@apache.org>.
zanmato1984 commented on PR #46300:
URL: https://github.com/apache/arrow/pull/46300#issuecomment-2860073651
Hi @pitrou , comments all address. Would you take a look again? Thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-46224: [C++][Acero] Fix the hang in asof join [arrow]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #46300:
URL: https://github.com/apache/arrow/pull/46300#issuecomment-2873380072
Revision: dd7a66b2971acb4d0c66eeca47383d5a3fd27e53
Submitted crossbow builds: [ursacomputing/crossbow @ actions-7d095c8a25](https://github.com/ursacomputing/crossbow/branches/all?query=actions-7d095c8a25)
|Task|Status|
|----|------|
|example-cpp-minimal-build-static|[](https://github.com/ursacomputing/crossbow/actions/runs/14978577452/job/42076983271)|
|example-cpp-minimal-build-static-system-dependency|[](https://github.com/ursacomputing/crossbow/actions/runs/14978577470/job/42076983409)|
|example-cpp-tutorial|[](https://github.com/ursacomputing/crossbow/actions/runs/14978577350/job/42076982418)|
|test-alpine-linux-cpp|[](https://github.com/ursacomputing/crossbow/actions/runs/14978577305/job/42076982717)|
|test-build-cpp-fuzz|[](https://github.com/ursacomputing/crossbow/actions/runs/14978577567/job/42076984106)|
|test-conda-cpp|[](https://github.com/ursacomputing/crossbow/actions/runs/14978577860/job/42076985097)|
|test-conda-cpp-meson|[](https://github.com/ursacomputing/crossbow/actions/runs/14978577731/job/42076984549)|
|test-conda-cpp-valgrind|[](https://github.com/ursacomputing/crossbow/actions/runs/14978576935/job/42076981271)|
|test-cuda-cpp-ubuntu-22.04-cuda-11.7.1|[](https://github.com/ursacomputing/crossbow/actions/runs/14978577632/job/42076984180)|
|test-debian-12-cpp-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/14978577046/job/42076981827)|
|test-debian-12-cpp-i386|[](https://github.com/ursacomputing/crossbow/actions/runs/14978578104/job/42076985390)|
|test-fedora-39-cpp|[](https://github.com/ursacomputing/crossbow/actions/runs/14978577502/job/42076983843)|
|test-ubuntu-22.04-cpp|[](https://github.com/ursacomputing/crossbow/actions/runs/14978577157/job/42076982296)|
|test-ubuntu-22.04-cpp-20|[](https://github.com/ursacomputing/crossbow/actions/runs/14978578086/job/42076985460)|
|test-ubuntu-22.04-cpp-bundled|[](https://github.com/ursacomputing/crossbow/actions/runs/14978577195/job/42076982303)|
|test-ubuntu-22.04-cpp-emscripten|[](https://github.com/ursacomputing/crossbow/actions/runs/14978577384/job/42076983168)|
|test-ubuntu-22.04-cpp-no-threading|[](https://github.com/ursacomputing/crossbow/actions/runs/14978577796/job/42076984886)|
|test-ubuntu-24.04-cpp|[](https://github.com/ursacomputing/crossbow/actions/runs/14978577221/job/42076982657)|
|test-ubuntu-24.04-cpp-bundled-offline|[](https://github.com/ursacomputing/crossbow/actions/runs/14978577800/job/42076984663)|
|test-ubuntu-24.04-cpp-gcc-13-bundled|[](https://github.com/ursacomputing/crossbow/actions/runs/14978577552/job/42076984057)|
|test-ubuntu-24.04-cpp-gcc-14|[](https://github.com/ursacomputing/crossbow/actions/runs/14978577710/job/42076984501)|
|test-ubuntu-24.04-cpp-minimal-with-formats|[](https://github.com/ursacomputing/crossbow/actions/runs/14978577590/job/42076984178)|
|test-ubuntu-24.04-cpp-thread-sanitizer|[](https://github.com/ursacomputing/crossbow/actions/runs/14978577262/job/42076982215)|
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-46224: [C++][Acero] Fix the hang in asof join [arrow]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #46300:
URL: https://github.com/apache/arrow/pull/46300#issuecomment-2873496096
Revision: 5f5b8956196f706f49a382cb7934b5eb6012a615
Submitted crossbow builds: [ursacomputing/crossbow @ actions-973e5e92ed](https://github.com/ursacomputing/crossbow/branches/all?query=actions-973e5e92ed)
|Task|Status|
|----|------|
|example-cpp-minimal-build-static|[](https://github.com/ursacomputing/crossbow/actions/runs/14979279367/job/42079267397)|
|example-cpp-minimal-build-static-system-dependency|[](https://github.com/ursacomputing/crossbow/actions/runs/14979279057/job/42079263829)|
|example-cpp-tutorial|[](https://github.com/ursacomputing/crossbow/actions/runs/14979279712/job/42079268711)|
|test-alpine-linux-cpp|[](https://github.com/ursacomputing/crossbow/actions/runs/14979279228/job/42079266243)|
|test-build-cpp-fuzz|[](https://github.com/ursacomputing/crossbow/actions/runs/14979279271/job/42079265870)|
|test-conda-cpp|[](https://github.com/ursacomputing/crossbow/actions/runs/14979279059/job/42079263843)|
|test-conda-cpp-meson|[](https://github.com/ursacomputing/crossbow/actions/runs/14979279357/job/42079267183)|
|test-conda-cpp-valgrind|[](https://github.com/ursacomputing/crossbow/actions/runs/14979279056/job/42079263864)|
|test-cuda-cpp-ubuntu-22.04-cuda-11.7.1|[](https://github.com/ursacomputing/crossbow/actions/runs/14979279048/job/42079264257)|
|test-debian-12-cpp-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/14979279330/job/42079266139)|
|test-debian-12-cpp-i386|[](https://github.com/ursacomputing/crossbow/actions/runs/14979279320/job/42079267003)|
|test-fedora-39-cpp|[](https://github.com/ursacomputing/crossbow/actions/runs/14979279195/job/42079265772)|
|test-ubuntu-22.04-cpp|[](https://github.com/ursacomputing/crossbow/actions/runs/14979279378/job/42079267469)|
|test-ubuntu-22.04-cpp-20|[](https://github.com/ursacomputing/crossbow/actions/runs/14979279522/job/42079267743)|
|test-ubuntu-22.04-cpp-bundled|[](https://github.com/ursacomputing/crossbow/actions/runs/14979279381/job/42079267398)|
|test-ubuntu-22.04-cpp-emscripten|[](https://github.com/ursacomputing/crossbow/actions/runs/14979279344/job/42079267066)|
|test-ubuntu-22.04-cpp-no-threading|[](https://github.com/ursacomputing/crossbow/actions/runs/14979279098/job/42079264338)|
|test-ubuntu-24.04-cpp|[](https://github.com/ursacomputing/crossbow/actions/runs/14979279142/job/42079265150)|
|test-ubuntu-24.04-cpp-bundled-offline|[](https://github.com/ursacomputing/crossbow/actions/runs/14979279089/job/42079264242)|
|test-ubuntu-24.04-cpp-gcc-13-bundled|[](https://github.com/ursacomputing/crossbow/actions/runs/14979279240/job/42079265882)|
|test-ubuntu-24.04-cpp-gcc-14|[](https://github.com/ursacomputing/crossbow/actions/runs/14979279443/job/42079267716)|
|test-ubuntu-24.04-cpp-minimal-with-formats|[](https://github.com/ursacomputing/crossbow/actions/runs/14979279385/job/42079267557)|
|test-ubuntu-24.04-cpp-thread-sanitizer|[](https://github.com/ursacomputing/crossbow/actions/runs/14979279242/job/42079267073)|
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-46224: [C++][Acero] Fix the hang in asof join [arrow]
Posted by "pitrou (via GitHub)" <gi...@apache.org>.
pitrou commented on code in PR #46300:
URL: https://github.com/apache/arrow/pull/46300#discussion_r2086214440
##########
cpp/src/arrow/acero/asof_join_node_test.cc:
##########
@@ -1770,5 +1771,53 @@ TEST(AsofJoinTest, DestroyNonStartedAsofJoinNode) {
DeclarationToStatus(std::move(sink)));
}
+// Reproduction of GH-46224: Hang when all left timestamps are greater than right
+// timestamps.
+TEST(AsofJoinTest, OneSideTsAllGreaterThanTheOther) {
Review Comment:
Great, thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org