You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lucene.apache.org by michaelbraun <gi...@git.apache.org> on 2016/11/07 20:49:40 UTC
[GitHub] lucene-solr pull request #111: LUCENE-7544 - add UnifiedHighlighter extensio...
GitHub user michaelbraun opened a pull request:
https://github.com/apache/lucene-solr/pull/111
LUCENE-7544 - add UnifiedHighlighter extension points for custom queries
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/michaelbraun/lucene-solr lucene-7544
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/lucene-solr/pull/111.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #111
----
commit 871c6d24bca90e32a3c5dc3de54dd48d6229ffc7
Author: Michael Braun <mb...@bloomberg.net>
Date: 2016-11-07T20:36:41Z
LUCENE-7544 - add UnifiedHighlighter extension points for custom queries
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[GitHub] lucene-solr pull request #111: LUCENE-7544 - add UnifiedHighlighter extensio...
Posted by michaelbraun <gi...@git.apache.org>.
Github user michaelbraun commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/111#discussion_r86893258
--- Diff: lucene/highlighter/src/test/org/apache/lucene/search/uhighlight/TestUnifiedHighlighter.java ---
@@ -959,4 +961,84 @@ protected PassageFormatter getFormatter(String field) {
ir.close();
}
+ public void testBooleanWithSpanAndOverlappingTerms() throws IOException {
--- End diff --
I will fix the name of the test to clarify and move to the appropriate file. Regarding PhraseHelper, that should probably be a separate issue/commit I'd think, no? Agree it should be have package visibility rather than be public.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[GitHub] lucene-solr pull request #111: LUCENE-7544 - add UnifiedHighlighter extensio...
Posted by dsmiley <gi...@git.apache.org>.
Github user dsmiley commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/111#discussion_r86882518
--- Diff: lucene/highlighter/src/test/org/apache/lucene/search/uhighlight/TestUnifiedHighlighter.java ---
@@ -959,4 +961,84 @@ protected PassageFormatter getFormatter(String field) {
ir.close();
}
+ public void testBooleanWithSpanAndOverlappingTerms() throws IOException {
--- End diff --
Can you please simplify this one... it's ultimately testing preSpanQueryRewrite... maybe make it clear that it's testing that by naming the test method as-such? Maybe this test should go into TestUnifiedHighlighterStrictPhrases as it's pertinent to that and not general stuff.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[GitHub] lucene-solr pull request: Change languageLevel used by IntelliJ to...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/lucene-solr/pull/111
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[GitHub] lucene-solr pull request #111: LUCENE-7544 - add UnifiedHighlighter extensio...
Posted by michaelbraun <gi...@git.apache.org>.
Github user michaelbraun closed the pull request at:
https://github.com/apache/lucene-solr/pull/111
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org