[GitHub] [incubator-doris] HangyuanLiu commented on a change in pull request #2187: Fix bug : num_of_columns_from_file incompatibility cause BE crashed during the upgrade

[GitBox <gi...@apache.org>]

HangyuanLiu commented on a change in pull request #2187: Fix bug : num_of_columns_from_file incompatibility cause BE crashed during the upgrade
URL: https://github.com/apache/incubator-doris/pull/2187#discussion_r345660630
 
 

 ##########
 File path: gensrc/thrift/PlanNodes.thrift
 ##########
 @@ -116,7 +116,7 @@ struct TBrokerRangeDesc {
     // total size of the file
     8: optional i64 file_size
     // number of columns from file
-    9: optional i32 num_of_columns_from_file = 0
+    9: optional i32 num_of_columns_from_file
 
 Review comment:
   Because if code set the default value here, thrift's __isset will default to true, there's no way to determine the compatibility of fe/be, and the default value here of 0 doesn't make any sense, so I removed it

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org