[GitHub] [accumulo-testing] ctubbsii commented on issue #250: Build stopped by files with unapproved licenses

[GitBox <gi...@apache.org>]

ctubbsii commented on issue #250:
URL: https://github.com/apache/accumulo-testing/issues/250#issuecomment-1287386375

   Generated files for maven builds should be in the target/ directory, or elsewhere outside the source tree for most Maven plugins to ignore them. apache-rat-plugin won't automatically ignore them simply because they're in a folder's .gitignore, since it doesn't read those files There's no reason for apache-rat-plugin to expect you to be running in a git clone, regardless of whether it sees a .gitignore file or not, or to know that .gitignore'd files aren't going to be included in whatever assembly is being prepared but whether or not they are ignored by the SCM. Rat's job is to check for improperly licensed files anywhere in the source tree.
   
   We can add ignore rules for these, but really, generated files shouldn't be polluting the source tree in the first place. We used to do that with a lib directory in the main accumulo repo's source tree, and it caused all sorts of problems. We finally stopped doing that, and now put all generated stuff (that we don't check in) in the target directories.
   
   One way this can be solved is by, instead of relying on .gitignore, just copy it to another directory and run terraform there. This copy-and-run-elsewhere behavior could even be scripted for convenience.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org