[jira] [Comment Edited] (FLINK-30768) flink-web version cleanup

["Matthias Pohl (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/FLINK-30768?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17679788#comment-17679788 ] 

Matthias Pohl edited comment on FLINK-30768 at 1/23/23 12:59 PM:
-----------------------------------------------------------------

Similar issues exists in {{{}q/sbt-quickstart.sh{}}}. This issue should include doing a proper research on other code segments that can be improved in this matter. I didn't go through all the files


was (Author: mapohl):
Similar issues exists in q/sbt-quickstart.sh

> flink-web version cleanup
> -------------------------
>
>                 Key: FLINK-30768
>                 URL: https://issues.apache.org/jira/browse/FLINK-30768
>             Project: Flink
>          Issue Type: Improvement
>          Components: Project Website
>    Affects Versions: 1.16.0, 1.17.0, 1.15.3
>            Reporter: Matthias Pohl
>            Priority: Major
>              Labels: starter
>
> The Flink website sources have multiple dependency versions (e.g. log4j, sl4fj in q/gradle-quickstart.sh in {{q/gradle-quickstart.sh}}) that are not referenced in Flink's parent pom file. That means that contributors might forget updating the right locations in {{flink-web}} when updating the dependencies. Additionally, {{q/gradle-quickstart.sh}} specifies a {{$defaultFlinkVersion}} variable but requires to update a hardcoded Flink version further down in the script as well (see [q/gradle-quickstart.sh:119|https://github.com/apache/flink-web/blob/dc24124816d86617991050a2e36fe70ee40ff2dc/q/gradle-quickstart.sh#L119]). 
> This Jira issue is about reducing the location where we have to update versions (through variables) and adding references that these variables have to be updated to the appropriate locations in the Flink source code as well.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)