You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2019/06/20 11:17:29 UTC

[GitHub] [flink] zhijiangW commented on a change in pull request #8789: [FLINK-12890] Add partition lifecycle related Shuffle API

zhijiangW commented on a change in pull request #8789: [FLINK-12890] Add partition lifecycle related Shuffle API
URL: https://github.com/apache/flink/pull/8789#discussion_r295759493
 
 

 ##########
 File path: flink-runtime/src/main/java/org/apache/flink/runtime/deployment/ResultPartitionDeploymentDescriptor.java
 ##########
 @@ -92,6 +92,14 @@ public boolean sendScheduleOrUpdateConsumersMessage() {
 		return sendScheduleOrUpdateConsumersMessage;
 	}
 
+	/**
+	 * Returns whether to release the partition after having been fully consumed once.
+	 *
+	 * <p>Indicates whether the shuffle service should automatically release all partition resources after
+	 * the first full consumption has been acknowledged.
+	 *
+	 * @return whether to release the partition after having been fully consumed once.
 
 Review comment:
   It has the same information with above `Returns whether to release the partition after having been fully consumed once.`, so might be removed.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services