You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@nifi.apache.org by jskora <gi...@git.apache.org> on 2016/11/10 18:30:37 UTC
[GitHub] nifi pull request #1201: NIFI-2890 Provenance Repository Corruption
GitHub user jskora opened a pull request:
https://github.com/apache/nifi/pull/1201
NIFI-2890 Provenance Repository Corruption
Thank you for submitting a contribution to Apache NiFi.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [X ] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
- [X ] Does your PR title start with NIFI-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
- [X ] Has your PR been rebased against the latest commit within the target branch (typically master)?
- [X ] Is your initial contribution a single, squashed commit?
### For code changes:
- [X ] Have you ensured that the full suite of tests is executed via mvn -Pcontrib-check clean install at the root nifi folder?
- [X ] Have you written or updated unit tests to verify your changes?
- [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [ ] If applicable, have you updated the LICENSE file, including the main LICENSE file under nifi-assembly?
- [ ] If applicable, have you updated the NOTICE file, including the main NOTICE file found under nifi-assembly?
- [ ] If adding new Properties, have you added .displayName in addition to .name (programmatic access) for each of the new properties?
### For documentation related changes:
- [ ] Have you ensured that format looks appropriate for the output in which it is rendered?
### Note:
Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.
Correct handling of corrupt journal file that was preventing instance startup and causing loss of records from uncorrupt files.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/jskora/nifi NIFI-2890-1.x
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/nifi/pull/1201.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1201
----
commit d89d5f684e1ea19b74167a03c6b987e161fceab1
Author: Joe Skora <js...@apache.org>
Date: 2016-11-10T18:06:41Z
NIFI-2890 Provenance Repository Corruption - Correct handling of corrupt journal file that was preventing instance startup and causing loss of records from uncorrupt files.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] nifi issue #1201: NIFI-2890 Provenance Repository Corruption
Posted by jskora <gi...@git.apache.org>.
Github user jskora commented on the issue:
https://github.com/apache/nifi/pull/1201
@JPercivall, no problem. I'll take a look at this and [https://github.com/apache/nifi/pull/1203](1203)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] nifi issue #1201: NIFI-2890 Provenance Repository Corruption
Posted by JPercivall <gi...@git.apache.org>.
Github user JPercivall commented on the issue:
https://github.com/apache/nifi/pull/1201
Reviewing
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] nifi issue #1201: NIFI-2890 Provenance Repository Corruption
Posted by JPercivall <gi...@git.apache.org>.
Github user JPercivall commented on the issue:
https://github.com/apache/nifi/pull/1201
Hey @jskora, sorry this has sat for so long, this PR review should have been prioritized. That said, there appear to be merge conflicts and checkstyle issues. I could resolve them for you if you wanted but, if able, I'd prefer you fix them.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] nifi pull request #1201: NIFI-2890 Provenance Repository Corruption
Posted by jskora <gi...@git.apache.org>.
Github user jskora closed the pull request at:
https://github.com/apache/nifi/pull/1201
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] nifi issue #1201: NIFI-2890 Provenance Repository Corruption
Posted by jskora <gi...@git.apache.org>.
Github user jskora commented on the issue:
https://github.com/apache/nifi/pull/1201
@JPercivall this has been updated to align with other changes in Master. I couldn't squash without creating a new branch, but a diff with Master only shows the PersistentProvenanceRepository and TestPersistentProvenanceRepository classes.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] nifi issue #1201: NIFI-2890 Provenance Repository Corruption
Posted by JPercivall <gi...@git.apache.org>.
Github user JPercivall commented on the issue:
https://github.com/apache/nifi/pull/1201
Hey @jskora, it appears you have check style issues.
I'm not entirely sure how you pulled in the commits but are you able to rebase instead? This throws off how I normally squash/sign-off PRs.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] nifi issue #1201: NIFI-2890 Provenance Repository Corruption
Posted by jskora <gi...@git.apache.org>.
Github user jskora commented on the issue:
https://github.com/apache/nifi/pull/1201
Replaced by #1484.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---