You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@kylin.apache.org by GitBox <gi...@apache.org> on 2020/01/13 12:52:44 UTC
[GitHub] [kylin] wangxiaojing123 opened a new pull request #1057: KYLIN-4337
Global domain dict for Spark build engine
wangxiaojing123 opened a new pull request #1057: KYLIN-4337 Global domain dict for Spark build engine
URL: https://github.com/apache/kylin/pull/1057
issue link : https://issues.apache.org/jira/browse/KYLIN-4337
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [kylin] codecov-io edited a comment on issue #1057: KYLIN-4337
Global domain dict for Spark build engine
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #1057: KYLIN-4337 Global domain dict for Spark build engine
URL: https://github.com/apache/kylin/pull/1057#issuecomment-573687537
# [Codecov](https://codecov.io/gh/apache/kylin/pull/1057?src=pr&el=h1) Report
> Merging [#1057](https://codecov.io/gh/apache/kylin/pull/1057?src=pr&el=desc) into [master](https://codecov.io/gh/apache/kylin/commit/37770217b2a9d7a62a40acae74fe77ea1d170b2a?src=pr&el=desc) will **increase** coverage by `0.03%`.
> The diff coverage is `9.73%`.
[](https://codecov.io/gh/apache/kylin/pull/1057?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #1057 +/- ##
============================================
+ Coverage 25% 25.04% +0.03%
- Complexity 6180 6221 +41
============================================
Files 1438 1439 +1
Lines 87669 87773 +104
Branches 12256 12272 +16
============================================
+ Hits 21926 21981 +55
- Misses 63593 63636 +43
- Partials 2150 2156 +6
```
| [Impacted Files](https://codecov.io/gh/apache/kylin/pull/1057?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...be/model/CubeDescTiretreeGlobalDomainDictUtil.java](https://codecov.io/gh/apache/kylin/pull/1057/diff?src=pr&el=tree#diff-Y29yZS1jdWJlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9jdWJlL21vZGVsL0N1YmVEZXNjVGlyZXRyZWVHbG9iYWxEb21haW5EaWN0VXRpbC5qYXZh) | `0% <0%> (ø)` | `0 <0> (?)` | |
| [...apache/kylin/measure/bitmap/BitmapMeasureType.java](https://codecov.io/gh/apache/kylin/pull/1057/diff?src=pr&el=tree#diff-Y29yZS1tZXRhZGF0YS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUva3lsaW4vbWVhc3VyZS9iaXRtYXAvQml0bWFwTWVhc3VyZVR5cGUuamF2YQ==) | `18.86% <0%> (ø)` | `4 <0> (ø)` | :arrow_down: |
| [...ache/kylin/engine/mr/common/AbstractHadoopJob.java](https://codecov.io/gh/apache/kylin/pull/1057/diff?src=pr&el=tree#diff-ZW5naW5lLW1yL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9lbmdpbmUvbXIvY29tbW9uL0Fic3RyYWN0SGFkb29wSm9iLmphdmE=) | `15.21% <0%> (-0.04%)` | `2 <0> (ø)` | |
| [...org/apache/kylin/engine/spark/SparkExecutable.java](https://codecov.io/gh/apache/kylin/pull/1057/diff?src=pr&el=tree#diff-ZW5naW5lLXNwYXJrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9lbmdpbmUvc3BhcmsvU3BhcmtFeGVjdXRhYmxlLmphdmE=) | `0% <0%> (ø)` | `0 <0> (ø)` | :arrow_down: |
| [...va/org/apache/kylin/cube/model/DictionaryDesc.java](https://codecov.io/gh/apache/kylin/pull/1057/diff?src=pr&el=tree#diff-Y29yZS1jdWJlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9jdWJlL21vZGVsL0RpY3Rpb25hcnlEZXNjLmphdmE=) | `65.38% <10%> (-34.62%)` | `8 <1> (+1)` | |
| [...ain/java/org/apache/kylin/cube/model/CubeDesc.java](https://codecov.io/gh/apache/kylin/pull/1057/diff?src=pr&el=tree#diff-Y29yZS1jdWJlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9jdWJlL21vZGVsL0N1YmVEZXNjLmphdmE=) | `63.56% <20%> (-0.57%)` | `182 <1> (+1)` | |
| [...org/apache/kylin/metadata/model/DataModelDesc.java](https://codecov.io/gh/apache/kylin/pull/1057/diff?src=pr&el=tree#diff-Y29yZS1tZXRhZGF0YS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUva3lsaW4vbWV0YWRhdGEvbW9kZWwvRGF0YU1vZGVsRGVzYy5qYXZh) | `59.21% <25%> (-0.58%)` | `72 <1> (-1)` | |
| [...c/main/java/org/apache/kylin/cube/CubeManager.java](https://codecov.io/gh/apache/kylin/pull/1057/diff?src=pr&el=tree#diff-Y29yZS1jdWJlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9jdWJlL0N1YmVNYW5hZ2VyLmphdmE=) | `36.52% <50%> (+0.02%)` | `44 <0> (ø)` | :arrow_down: |
| [...lin/cube/model/validation/rule/DictionaryRule.java](https://codecov.io/gh/apache/kylin/pull/1057/diff?src=pr&el=tree#diff-Y29yZS1jdWJlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9jdWJlL21vZGVsL3ZhbGlkYXRpb24vcnVsZS9EaWN0aW9uYXJ5UnVsZS5qYXZh) | `86.84% <60%> (-4.59%)` | `16 <1> (+1)` | |
| [...ream/core/storage/columnar/ColumnarStoreCache.java](https://codecov.io/gh/apache/kylin/pull/1057/diff?src=pr&el=tree#diff-c3RyZWFtLWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL3N0cmVhbS9jb3JlL3N0b3JhZ2UvY29sdW1uYXIvQ29sdW1uYXJTdG9yZUNhY2hlLmphdmE=) | `50% <0%> (-5.69%)` | `7% <0%> (-1%)` | |
| ... and [8 more](https://codecov.io/gh/apache/kylin/pull/1057/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/kylin/pull/1057?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/kylin/pull/1057?src=pr&el=footer). Last update [3777021...11a80bb](https://codecov.io/gh/apache/kylin/pull/1057?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [kylin] nichunen closed pull request #1057: KYLIN-4337 Global
domain dict for Spark build engine
Posted by GitBox <gi...@apache.org>.
nichunen closed pull request #1057: KYLIN-4337 Global domain dict for Spark build engine
URL: https://github.com/apache/kylin/pull/1057
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [kylin] codecov-io edited a comment on issue #1057: KYLIN-4337
Global domain dict for Spark build engine
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #1057: KYLIN-4337 Global domain dict for Spark build engine
URL: https://github.com/apache/kylin/pull/1057#issuecomment-573687537
# [Codecov](https://codecov.io/gh/apache/kylin/pull/1057?src=pr&el=h1) Report
> Merging [#1057](https://codecov.io/gh/apache/kylin/pull/1057?src=pr&el=desc) into [master](https://codecov.io/gh/apache/kylin/commit/2a9aa87bb3833f80c29d462e5a1cd8c7a238b21e?src=pr&el=desc) will **decrease** coverage by `0.02%`.
> The diff coverage is `9.73%`.
[](https://codecov.io/gh/apache/kylin/pull/1057?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #1057 +/- ##
============================================
- Coverage 25.07% 25.04% -0.03%
- Complexity 6220 6221 +1
============================================
Files 1438 1439 +1
Lines 87673 87773 +100
Branches 12256 12272 +16
============================================
+ Hits 21980 21981 +1
- Misses 63545 63636 +91
- Partials 2148 2156 +8
```
| [Impacted Files](https://codecov.io/gh/apache/kylin/pull/1057?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...be/model/CubeDescTiretreeGlobalDomainDictUtil.java](https://codecov.io/gh/apache/kylin/pull/1057/diff?src=pr&el=tree#diff-Y29yZS1jdWJlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9jdWJlL21vZGVsL0N1YmVEZXNjVGlyZXRyZWVHbG9iYWxEb21haW5EaWN0VXRpbC5qYXZh) | `0% <0%> (ø)` | `0 <0> (?)` | |
| [...apache/kylin/measure/bitmap/BitmapMeasureType.java](https://codecov.io/gh/apache/kylin/pull/1057/diff?src=pr&el=tree#diff-Y29yZS1tZXRhZGF0YS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUva3lsaW4vbWVhc3VyZS9iaXRtYXAvQml0bWFwTWVhc3VyZVR5cGUuamF2YQ==) | `18.86% <0%> (ø)` | `4 <0> (ø)` | :arrow_down: |
| [...ache/kylin/engine/mr/common/AbstractHadoopJob.java](https://codecov.io/gh/apache/kylin/pull/1057/diff?src=pr&el=tree#diff-ZW5naW5lLW1yL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9lbmdpbmUvbXIvY29tbW9uL0Fic3RyYWN0SGFkb29wSm9iLmphdmE=) | `15.21% <0%> (-0.04%)` | `2 <0> (ø)` | |
| [...org/apache/kylin/engine/spark/SparkExecutable.java](https://codecov.io/gh/apache/kylin/pull/1057/diff?src=pr&el=tree#diff-ZW5naW5lLXNwYXJrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9lbmdpbmUvc3BhcmsvU3BhcmtFeGVjdXRhYmxlLmphdmE=) | `0% <0%> (ø)` | `0 <0> (ø)` | :arrow_down: |
| [...va/org/apache/kylin/cube/model/DictionaryDesc.java](https://codecov.io/gh/apache/kylin/pull/1057/diff?src=pr&el=tree#diff-Y29yZS1jdWJlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9jdWJlL21vZGVsL0RpY3Rpb25hcnlEZXNjLmphdmE=) | `65.38% <10%> (-34.62%)` | `8 <1> (+1)` | |
| [...ain/java/org/apache/kylin/cube/model/CubeDesc.java](https://codecov.io/gh/apache/kylin/pull/1057/diff?src=pr&el=tree#diff-Y29yZS1jdWJlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9jdWJlL21vZGVsL0N1YmVEZXNjLmphdmE=) | `63.56% <20%> (-0.57%)` | `182 <1> (+1)` | |
| [...org/apache/kylin/metadata/model/DataModelDesc.java](https://codecov.io/gh/apache/kylin/pull/1057/diff?src=pr&el=tree#diff-Y29yZS1tZXRhZGF0YS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUva3lsaW4vbWV0YWRhdGEvbW9kZWwvRGF0YU1vZGVsRGVzYy5qYXZh) | `59.21% <25%> (-0.58%)` | `72 <1> (-1)` | |
| [...c/main/java/org/apache/kylin/cube/CubeManager.java](https://codecov.io/gh/apache/kylin/pull/1057/diff?src=pr&el=tree#diff-Y29yZS1jdWJlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9jdWJlL0N1YmVNYW5hZ2VyLmphdmE=) | `36.52% <50%> (+0.02%)` | `44 <0> (ø)` | :arrow_down: |
| [...lin/cube/model/validation/rule/DictionaryRule.java](https://codecov.io/gh/apache/kylin/pull/1057/diff?src=pr&el=tree#diff-Y29yZS1jdWJlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9jdWJlL21vZGVsL3ZhbGlkYXRpb24vcnVsZS9EaWN0aW9uYXJ5UnVsZS5qYXZh) | `86.84% <60%> (-4.59%)` | `16 <1> (+1)` | |
| [...he/kylin/job/impl/threadpool/DefaultScheduler.java](https://codecov.io/gh/apache/kylin/pull/1057/diff?src=pr&el=tree#diff-Y29yZS1qb2Ivc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL2pvYi9pbXBsL3RocmVhZHBvb2wvRGVmYXVsdFNjaGVkdWxlci5qYXZh) | `74.41% <0%> (-2.33%)` | `12% <0%> (ø)` | |
| ... and [3 more](https://codecov.io/gh/apache/kylin/pull/1057/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/kylin/pull/1057?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/kylin/pull/1057?src=pr&el=footer). Last update [2a9aa87...11a80bb](https://codecov.io/gh/apache/kylin/pull/1057?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [kylin] codecov-io edited a comment on issue #1057: KYLIN-4337
Global domain dict for Spark build engine
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #1057: KYLIN-4337 Global domain dict for Spark build engine
URL: https://github.com/apache/kylin/pull/1057#issuecomment-573687537
# [Codecov](https://codecov.io/gh/apache/kylin/pull/1057?src=pr&el=h1) Report
> Merging [#1057](https://codecov.io/gh/apache/kylin/pull/1057?src=pr&el=desc) into [master](https://codecov.io/gh/apache/kylin/commit/37770217b2a9d7a62a40acae74fe77ea1d170b2a?src=pr&el=desc) will **increase** coverage by `0.03%`.
> The diff coverage is `9.73%`.
[](https://codecov.io/gh/apache/kylin/pull/1057?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #1057 +/- ##
============================================
+ Coverage 25% 25.04% +0.03%
- Complexity 6180 6221 +41
============================================
Files 1438 1439 +1
Lines 87669 87773 +104
Branches 12256 12272 +16
============================================
+ Hits 21926 21981 +55
- Misses 63593 63636 +43
- Partials 2150 2156 +6
```
| [Impacted Files](https://codecov.io/gh/apache/kylin/pull/1057?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...be/model/CubeDescTiretreeGlobalDomainDictUtil.java](https://codecov.io/gh/apache/kylin/pull/1057/diff?src=pr&el=tree#diff-Y29yZS1jdWJlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9jdWJlL21vZGVsL0N1YmVEZXNjVGlyZXRyZWVHbG9iYWxEb21haW5EaWN0VXRpbC5qYXZh) | `0% <0%> (ø)` | `0 <0> (?)` | |
| [...apache/kylin/measure/bitmap/BitmapMeasureType.java](https://codecov.io/gh/apache/kylin/pull/1057/diff?src=pr&el=tree#diff-Y29yZS1tZXRhZGF0YS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUva3lsaW4vbWVhc3VyZS9iaXRtYXAvQml0bWFwTWVhc3VyZVR5cGUuamF2YQ==) | `18.86% <0%> (ø)` | `4 <0> (ø)` | :arrow_down: |
| [...ache/kylin/engine/mr/common/AbstractHadoopJob.java](https://codecov.io/gh/apache/kylin/pull/1057/diff?src=pr&el=tree#diff-ZW5naW5lLW1yL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9lbmdpbmUvbXIvY29tbW9uL0Fic3RyYWN0SGFkb29wSm9iLmphdmE=) | `15.21% <0%> (-0.04%)` | `2 <0> (ø)` | |
| [...org/apache/kylin/engine/spark/SparkExecutable.java](https://codecov.io/gh/apache/kylin/pull/1057/diff?src=pr&el=tree#diff-ZW5naW5lLXNwYXJrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9lbmdpbmUvc3BhcmsvU3BhcmtFeGVjdXRhYmxlLmphdmE=) | `0% <0%> (ø)` | `0 <0> (ø)` | :arrow_down: |
| [...va/org/apache/kylin/cube/model/DictionaryDesc.java](https://codecov.io/gh/apache/kylin/pull/1057/diff?src=pr&el=tree#diff-Y29yZS1jdWJlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9jdWJlL21vZGVsL0RpY3Rpb25hcnlEZXNjLmphdmE=) | `65.38% <10%> (-34.62%)` | `8 <1> (+1)` | |
| [...ain/java/org/apache/kylin/cube/model/CubeDesc.java](https://codecov.io/gh/apache/kylin/pull/1057/diff?src=pr&el=tree#diff-Y29yZS1jdWJlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9jdWJlL21vZGVsL0N1YmVEZXNjLmphdmE=) | `63.56% <20%> (-0.57%)` | `182 <1> (+1)` | |
| [...org/apache/kylin/metadata/model/DataModelDesc.java](https://codecov.io/gh/apache/kylin/pull/1057/diff?src=pr&el=tree#diff-Y29yZS1tZXRhZGF0YS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUva3lsaW4vbWV0YWRhdGEvbW9kZWwvRGF0YU1vZGVsRGVzYy5qYXZh) | `59.21% <25%> (-0.58%)` | `72 <1> (-1)` | |
| [...c/main/java/org/apache/kylin/cube/CubeManager.java](https://codecov.io/gh/apache/kylin/pull/1057/diff?src=pr&el=tree#diff-Y29yZS1jdWJlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9jdWJlL0N1YmVNYW5hZ2VyLmphdmE=) | `36.52% <50%> (+0.02%)` | `44 <0> (ø)` | :arrow_down: |
| [...lin/cube/model/validation/rule/DictionaryRule.java](https://codecov.io/gh/apache/kylin/pull/1057/diff?src=pr&el=tree#diff-Y29yZS1jdWJlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9jdWJlL21vZGVsL3ZhbGlkYXRpb24vcnVsZS9EaWN0aW9uYXJ5UnVsZS5qYXZh) | `86.84% <60%> (-4.59%)` | `16 <1> (+1)` | |
| [...ream/core/storage/columnar/ColumnarStoreCache.java](https://codecov.io/gh/apache/kylin/pull/1057/diff?src=pr&el=tree#diff-c3RyZWFtLWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL3N0cmVhbS9jb3JlL3N0b3JhZ2UvY29sdW1uYXIvQ29sdW1uYXJTdG9yZUNhY2hlLmphdmE=) | `50% <0%> (-5.69%)` | `7% <0%> (-1%)` | |
| ... and [8 more](https://codecov.io/gh/apache/kylin/pull/1057/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/kylin/pull/1057?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/kylin/pull/1057?src=pr&el=footer). Last update [3777021...11a80bb](https://codecov.io/gh/apache/kylin/pull/1057?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [kylin] codecov-io edited a comment on issue #1057: KYLIN-4337
Global domain dict for Spark build engine
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #1057: KYLIN-4337 Global domain dict for Spark build engine
URL: https://github.com/apache/kylin/pull/1057#issuecomment-573687537
# [Codecov](https://codecov.io/gh/apache/kylin/pull/1057?src=pr&el=h1) Report
> Merging [#1057](https://codecov.io/gh/apache/kylin/pull/1057?src=pr&el=desc) into [master](https://codecov.io/gh/apache/kylin/commit/37770217b2a9d7a62a40acae74fe77ea1d170b2a?src=pr&el=desc) will **increase** coverage by `0.03%`.
> The diff coverage is `9.73%`.
[](https://codecov.io/gh/apache/kylin/pull/1057?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #1057 +/- ##
============================================
+ Coverage 25% 25.04% +0.03%
- Complexity 6180 6221 +41
============================================
Files 1438 1439 +1
Lines 87669 87773 +104
Branches 12256 12272 +16
============================================
+ Hits 21926 21981 +55
- Misses 63593 63636 +43
- Partials 2150 2156 +6
```
| [Impacted Files](https://codecov.io/gh/apache/kylin/pull/1057?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...be/model/CubeDescTiretreeGlobalDomainDictUtil.java](https://codecov.io/gh/apache/kylin/pull/1057/diff?src=pr&el=tree#diff-Y29yZS1jdWJlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9jdWJlL21vZGVsL0N1YmVEZXNjVGlyZXRyZWVHbG9iYWxEb21haW5EaWN0VXRpbC5qYXZh) | `0% <0%> (ø)` | `0 <0> (?)` | |
| [...apache/kylin/measure/bitmap/BitmapMeasureType.java](https://codecov.io/gh/apache/kylin/pull/1057/diff?src=pr&el=tree#diff-Y29yZS1tZXRhZGF0YS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUva3lsaW4vbWVhc3VyZS9iaXRtYXAvQml0bWFwTWVhc3VyZVR5cGUuamF2YQ==) | `18.86% <0%> (ø)` | `4 <0> (ø)` | :arrow_down: |
| [...ache/kylin/engine/mr/common/AbstractHadoopJob.java](https://codecov.io/gh/apache/kylin/pull/1057/diff?src=pr&el=tree#diff-ZW5naW5lLW1yL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9lbmdpbmUvbXIvY29tbW9uL0Fic3RyYWN0SGFkb29wSm9iLmphdmE=) | `15.21% <0%> (-0.04%)` | `2 <0> (ø)` | |
| [...org/apache/kylin/engine/spark/SparkExecutable.java](https://codecov.io/gh/apache/kylin/pull/1057/diff?src=pr&el=tree#diff-ZW5naW5lLXNwYXJrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9lbmdpbmUvc3BhcmsvU3BhcmtFeGVjdXRhYmxlLmphdmE=) | `0% <0%> (ø)` | `0 <0> (ø)` | :arrow_down: |
| [...va/org/apache/kylin/cube/model/DictionaryDesc.java](https://codecov.io/gh/apache/kylin/pull/1057/diff?src=pr&el=tree#diff-Y29yZS1jdWJlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9jdWJlL21vZGVsL0RpY3Rpb25hcnlEZXNjLmphdmE=) | `65.38% <10%> (-34.62%)` | `8 <1> (+1)` | |
| [...ain/java/org/apache/kylin/cube/model/CubeDesc.java](https://codecov.io/gh/apache/kylin/pull/1057/diff?src=pr&el=tree#diff-Y29yZS1jdWJlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9jdWJlL21vZGVsL0N1YmVEZXNjLmphdmE=) | `63.56% <20%> (-0.57%)` | `182 <1> (+1)` | |
| [...org/apache/kylin/metadata/model/DataModelDesc.java](https://codecov.io/gh/apache/kylin/pull/1057/diff?src=pr&el=tree#diff-Y29yZS1tZXRhZGF0YS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUva3lsaW4vbWV0YWRhdGEvbW9kZWwvRGF0YU1vZGVsRGVzYy5qYXZh) | `59.21% <25%> (-0.58%)` | `72 <1> (-1)` | |
| [...c/main/java/org/apache/kylin/cube/CubeManager.java](https://codecov.io/gh/apache/kylin/pull/1057/diff?src=pr&el=tree#diff-Y29yZS1jdWJlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9jdWJlL0N1YmVNYW5hZ2VyLmphdmE=) | `36.52% <50%> (+0.02%)` | `44 <0> (ø)` | :arrow_down: |
| [...lin/cube/model/validation/rule/DictionaryRule.java](https://codecov.io/gh/apache/kylin/pull/1057/diff?src=pr&el=tree#diff-Y29yZS1jdWJlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9jdWJlL21vZGVsL3ZhbGlkYXRpb24vcnVsZS9EaWN0aW9uYXJ5UnVsZS5qYXZh) | `86.84% <60%> (-4.59%)` | `16 <1> (+1)` | |
| [...ream/core/storage/columnar/ColumnarStoreCache.java](https://codecov.io/gh/apache/kylin/pull/1057/diff?src=pr&el=tree#diff-c3RyZWFtLWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL3N0cmVhbS9jb3JlL3N0b3JhZ2UvY29sdW1uYXIvQ29sdW1uYXJTdG9yZUNhY2hlLmphdmE=) | `50% <0%> (-5.69%)` | `7% <0%> (-1%)` | |
| ... and [8 more](https://codecov.io/gh/apache/kylin/pull/1057/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/kylin/pull/1057?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/kylin/pull/1057?src=pr&el=footer). Last update [3777021...11a80bb](https://codecov.io/gh/apache/kylin/pull/1057?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [kylin] codecov-io edited a comment on issue #1057: KYLIN-4337
Global domain dict for Spark build engine
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #1057: KYLIN-4337 Global domain dict for Spark build engine
URL: https://github.com/apache/kylin/pull/1057#issuecomment-573687537
# [Codecov](https://codecov.io/gh/apache/kylin/pull/1057?src=pr&el=h1) Report
> Merging [#1057](https://codecov.io/gh/apache/kylin/pull/1057?src=pr&el=desc) into [master](https://codecov.io/gh/apache/kylin/commit/37770217b2a9d7a62a40acae74fe77ea1d170b2a?src=pr&el=desc) will **increase** coverage by `0.03%`.
> The diff coverage is `9.73%`.
[](https://codecov.io/gh/apache/kylin/pull/1057?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #1057 +/- ##
============================================
+ Coverage 25% 25.04% +0.03%
- Complexity 6180 6221 +41
============================================
Files 1438 1439 +1
Lines 87669 87773 +104
Branches 12256 12272 +16
============================================
+ Hits 21926 21981 +55
- Misses 63593 63636 +43
- Partials 2150 2156 +6
```
| [Impacted Files](https://codecov.io/gh/apache/kylin/pull/1057?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...be/model/CubeDescTiretreeGlobalDomainDictUtil.java](https://codecov.io/gh/apache/kylin/pull/1057/diff?src=pr&el=tree#diff-Y29yZS1jdWJlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9jdWJlL21vZGVsL0N1YmVEZXNjVGlyZXRyZWVHbG9iYWxEb21haW5EaWN0VXRpbC5qYXZh) | `0% <0%> (ø)` | `0 <0> (?)` | |
| [...apache/kylin/measure/bitmap/BitmapMeasureType.java](https://codecov.io/gh/apache/kylin/pull/1057/diff?src=pr&el=tree#diff-Y29yZS1tZXRhZGF0YS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUva3lsaW4vbWVhc3VyZS9iaXRtYXAvQml0bWFwTWVhc3VyZVR5cGUuamF2YQ==) | `18.86% <0%> (ø)` | `4 <0> (ø)` | :arrow_down: |
| [...ache/kylin/engine/mr/common/AbstractHadoopJob.java](https://codecov.io/gh/apache/kylin/pull/1057/diff?src=pr&el=tree#diff-ZW5naW5lLW1yL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9lbmdpbmUvbXIvY29tbW9uL0Fic3RyYWN0SGFkb29wSm9iLmphdmE=) | `15.21% <0%> (-0.04%)` | `2 <0> (ø)` | |
| [...org/apache/kylin/engine/spark/SparkExecutable.java](https://codecov.io/gh/apache/kylin/pull/1057/diff?src=pr&el=tree#diff-ZW5naW5lLXNwYXJrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9lbmdpbmUvc3BhcmsvU3BhcmtFeGVjdXRhYmxlLmphdmE=) | `0% <0%> (ø)` | `0 <0> (ø)` | :arrow_down: |
| [...va/org/apache/kylin/cube/model/DictionaryDesc.java](https://codecov.io/gh/apache/kylin/pull/1057/diff?src=pr&el=tree#diff-Y29yZS1jdWJlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9jdWJlL21vZGVsL0RpY3Rpb25hcnlEZXNjLmphdmE=) | `65.38% <10%> (-34.62%)` | `8 <1> (+1)` | |
| [...ain/java/org/apache/kylin/cube/model/CubeDesc.java](https://codecov.io/gh/apache/kylin/pull/1057/diff?src=pr&el=tree#diff-Y29yZS1jdWJlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9jdWJlL21vZGVsL0N1YmVEZXNjLmphdmE=) | `63.56% <20%> (-0.57%)` | `182 <1> (+1)` | |
| [...org/apache/kylin/metadata/model/DataModelDesc.java](https://codecov.io/gh/apache/kylin/pull/1057/diff?src=pr&el=tree#diff-Y29yZS1tZXRhZGF0YS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUva3lsaW4vbWV0YWRhdGEvbW9kZWwvRGF0YU1vZGVsRGVzYy5qYXZh) | `59.21% <25%> (-0.58%)` | `72 <1> (-1)` | |
| [...c/main/java/org/apache/kylin/cube/CubeManager.java](https://codecov.io/gh/apache/kylin/pull/1057/diff?src=pr&el=tree#diff-Y29yZS1jdWJlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9jdWJlL0N1YmVNYW5hZ2VyLmphdmE=) | `36.52% <50%> (+0.02%)` | `44 <0> (ø)` | :arrow_down: |
| [...lin/cube/model/validation/rule/DictionaryRule.java](https://codecov.io/gh/apache/kylin/pull/1057/diff?src=pr&el=tree#diff-Y29yZS1jdWJlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9jdWJlL21vZGVsL3ZhbGlkYXRpb24vcnVsZS9EaWN0aW9uYXJ5UnVsZS5qYXZh) | `86.84% <60%> (-4.59%)` | `16 <1> (+1)` | |
| [...ream/core/storage/columnar/ColumnarStoreCache.java](https://codecov.io/gh/apache/kylin/pull/1057/diff?src=pr&el=tree#diff-c3RyZWFtLWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL3N0cmVhbS9jb3JlL3N0b3JhZ2UvY29sdW1uYXIvQ29sdW1uYXJTdG9yZUNhY2hlLmphdmE=) | `50% <0%> (-5.69%)` | `7% <0%> (-1%)` | |
| ... and [8 more](https://codecov.io/gh/apache/kylin/pull/1057/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/kylin/pull/1057?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/kylin/pull/1057?src=pr&el=footer). Last update [3777021...11a80bb](https://codecov.io/gh/apache/kylin/pull/1057?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [kylin] codecov-io edited a comment on issue #1057: KYLIN-4337
Global domain dict for Spark build engine
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #1057: KYLIN-4337 Global domain dict for Spark build engine
URL: https://github.com/apache/kylin/pull/1057#issuecomment-573687537
# [Codecov](https://codecov.io/gh/apache/kylin/pull/1057?src=pr&el=h1) Report
> Merging [#1057](https://codecov.io/gh/apache/kylin/pull/1057?src=pr&el=desc) into [master](https://codecov.io/gh/apache/kylin/commit/37770217b2a9d7a62a40acae74fe77ea1d170b2a?src=pr&el=desc) will **increase** coverage by `0.03%`.
> The diff coverage is `9.73%`.
[](https://codecov.io/gh/apache/kylin/pull/1057?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #1057 +/- ##
============================================
+ Coverage 25% 25.04% +0.03%
- Complexity 6180 6221 +41
============================================
Files 1438 1439 +1
Lines 87669 87773 +104
Branches 12256 12272 +16
============================================
+ Hits 21926 21981 +55
- Misses 63593 63636 +43
- Partials 2150 2156 +6
```
| [Impacted Files](https://codecov.io/gh/apache/kylin/pull/1057?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...be/model/CubeDescTiretreeGlobalDomainDictUtil.java](https://codecov.io/gh/apache/kylin/pull/1057/diff?src=pr&el=tree#diff-Y29yZS1jdWJlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9jdWJlL21vZGVsL0N1YmVEZXNjVGlyZXRyZWVHbG9iYWxEb21haW5EaWN0VXRpbC5qYXZh) | `0% <0%> (ø)` | `0 <0> (?)` | |
| [...apache/kylin/measure/bitmap/BitmapMeasureType.java](https://codecov.io/gh/apache/kylin/pull/1057/diff?src=pr&el=tree#diff-Y29yZS1tZXRhZGF0YS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUva3lsaW4vbWVhc3VyZS9iaXRtYXAvQml0bWFwTWVhc3VyZVR5cGUuamF2YQ==) | `18.86% <0%> (ø)` | `4 <0> (ø)` | :arrow_down: |
| [...ache/kylin/engine/mr/common/AbstractHadoopJob.java](https://codecov.io/gh/apache/kylin/pull/1057/diff?src=pr&el=tree#diff-ZW5naW5lLW1yL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9lbmdpbmUvbXIvY29tbW9uL0Fic3RyYWN0SGFkb29wSm9iLmphdmE=) | `15.21% <0%> (-0.04%)` | `2 <0> (ø)` | |
| [...org/apache/kylin/engine/spark/SparkExecutable.java](https://codecov.io/gh/apache/kylin/pull/1057/diff?src=pr&el=tree#diff-ZW5naW5lLXNwYXJrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9lbmdpbmUvc3BhcmsvU3BhcmtFeGVjdXRhYmxlLmphdmE=) | `0% <0%> (ø)` | `0 <0> (ø)` | :arrow_down: |
| [...va/org/apache/kylin/cube/model/DictionaryDesc.java](https://codecov.io/gh/apache/kylin/pull/1057/diff?src=pr&el=tree#diff-Y29yZS1jdWJlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9jdWJlL21vZGVsL0RpY3Rpb25hcnlEZXNjLmphdmE=) | `65.38% <10%> (-34.62%)` | `8 <1> (+1)` | |
| [...ain/java/org/apache/kylin/cube/model/CubeDesc.java](https://codecov.io/gh/apache/kylin/pull/1057/diff?src=pr&el=tree#diff-Y29yZS1jdWJlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9jdWJlL21vZGVsL0N1YmVEZXNjLmphdmE=) | `63.56% <20%> (-0.57%)` | `182 <1> (+1)` | |
| [...org/apache/kylin/metadata/model/DataModelDesc.java](https://codecov.io/gh/apache/kylin/pull/1057/diff?src=pr&el=tree#diff-Y29yZS1tZXRhZGF0YS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUva3lsaW4vbWV0YWRhdGEvbW9kZWwvRGF0YU1vZGVsRGVzYy5qYXZh) | `59.21% <25%> (-0.58%)` | `72 <1> (-1)` | |
| [...c/main/java/org/apache/kylin/cube/CubeManager.java](https://codecov.io/gh/apache/kylin/pull/1057/diff?src=pr&el=tree#diff-Y29yZS1jdWJlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9jdWJlL0N1YmVNYW5hZ2VyLmphdmE=) | `36.52% <50%> (+0.02%)` | `44 <0> (ø)` | :arrow_down: |
| [...lin/cube/model/validation/rule/DictionaryRule.java](https://codecov.io/gh/apache/kylin/pull/1057/diff?src=pr&el=tree#diff-Y29yZS1jdWJlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9jdWJlL21vZGVsL3ZhbGlkYXRpb24vcnVsZS9EaWN0aW9uYXJ5UnVsZS5qYXZh) | `86.84% <60%> (-4.59%)` | `16 <1> (+1)` | |
| [...ream/core/storage/columnar/ColumnarStoreCache.java](https://codecov.io/gh/apache/kylin/pull/1057/diff?src=pr&el=tree#diff-c3RyZWFtLWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL3N0cmVhbS9jb3JlL3N0b3JhZ2UvY29sdW1uYXIvQ29sdW1uYXJTdG9yZUNhY2hlLmphdmE=) | `50% <0%> (-5.69%)` | `7% <0%> (-1%)` | |
| ... and [8 more](https://codecov.io/gh/apache/kylin/pull/1057/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/kylin/pull/1057?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/kylin/pull/1057?src=pr&el=footer). Last update [3777021...11a80bb](https://codecov.io/gh/apache/kylin/pull/1057?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [kylin] codecov-io commented on issue #1057: KYLIN-4337 Global
domain dict for Spark build engine
Posted by GitBox <gi...@apache.org>.
codecov-io commented on issue #1057: KYLIN-4337 Global domain dict for Spark build engine
URL: https://github.com/apache/kylin/pull/1057#issuecomment-573687537
# [Codecov](https://codecov.io/gh/apache/kylin/pull/1057?src=pr&el=h1) Report
> Merging [#1057](https://codecov.io/gh/apache/kylin/pull/1057?src=pr&el=desc) into [master](https://codecov.io/gh/apache/kylin/commit/37770217b2a9d7a62a40acae74fe77ea1d170b2a?src=pr&el=desc) will **increase** coverage by `0.03%`.
> The diff coverage is `9.73%`.
[](https://codecov.io/gh/apache/kylin/pull/1057?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #1057 +/- ##
============================================
+ Coverage 25% 25.04% +0.03%
- Complexity 6180 6221 +41
============================================
Files 1438 1439 +1
Lines 87669 87773 +104
Branches 12256 12272 +16
============================================
+ Hits 21926 21981 +55
- Misses 63593 63636 +43
- Partials 2150 2156 +6
```
| [Impacted Files](https://codecov.io/gh/apache/kylin/pull/1057?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...be/model/CubeDescTiretreeGlobalDomainDictUtil.java](https://codecov.io/gh/apache/kylin/pull/1057/diff?src=pr&el=tree#diff-Y29yZS1jdWJlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9jdWJlL21vZGVsL0N1YmVEZXNjVGlyZXRyZWVHbG9iYWxEb21haW5EaWN0VXRpbC5qYXZh) | `0% <0%> (ø)` | `0 <0> (?)` | |
| [...apache/kylin/measure/bitmap/BitmapMeasureType.java](https://codecov.io/gh/apache/kylin/pull/1057/diff?src=pr&el=tree#diff-Y29yZS1tZXRhZGF0YS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUva3lsaW4vbWVhc3VyZS9iaXRtYXAvQml0bWFwTWVhc3VyZVR5cGUuamF2YQ==) | `18.86% <0%> (ø)` | `4 <0> (ø)` | :arrow_down: |
| [...ache/kylin/engine/mr/common/AbstractHadoopJob.java](https://codecov.io/gh/apache/kylin/pull/1057/diff?src=pr&el=tree#diff-ZW5naW5lLW1yL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9lbmdpbmUvbXIvY29tbW9uL0Fic3RyYWN0SGFkb29wSm9iLmphdmE=) | `15.21% <0%> (-0.04%)` | `2 <0> (ø)` | |
| [...org/apache/kylin/engine/spark/SparkExecutable.java](https://codecov.io/gh/apache/kylin/pull/1057/diff?src=pr&el=tree#diff-ZW5naW5lLXNwYXJrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9lbmdpbmUvc3BhcmsvU3BhcmtFeGVjdXRhYmxlLmphdmE=) | `0% <0%> (ø)` | `0 <0> (ø)` | :arrow_down: |
| [...va/org/apache/kylin/cube/model/DictionaryDesc.java](https://codecov.io/gh/apache/kylin/pull/1057/diff?src=pr&el=tree#diff-Y29yZS1jdWJlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9jdWJlL21vZGVsL0RpY3Rpb25hcnlEZXNjLmphdmE=) | `65.38% <10%> (-34.62%)` | `8 <1> (+1)` | |
| [...ain/java/org/apache/kylin/cube/model/CubeDesc.java](https://codecov.io/gh/apache/kylin/pull/1057/diff?src=pr&el=tree#diff-Y29yZS1jdWJlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9jdWJlL21vZGVsL0N1YmVEZXNjLmphdmE=) | `63.56% <20%> (-0.57%)` | `182 <1> (+1)` | |
| [...org/apache/kylin/metadata/model/DataModelDesc.java](https://codecov.io/gh/apache/kylin/pull/1057/diff?src=pr&el=tree#diff-Y29yZS1tZXRhZGF0YS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUva3lsaW4vbWV0YWRhdGEvbW9kZWwvRGF0YU1vZGVsRGVzYy5qYXZh) | `59.21% <25%> (-0.58%)` | `72 <1> (-1)` | |
| [...c/main/java/org/apache/kylin/cube/CubeManager.java](https://codecov.io/gh/apache/kylin/pull/1057/diff?src=pr&el=tree#diff-Y29yZS1jdWJlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9jdWJlL0N1YmVNYW5hZ2VyLmphdmE=) | `36.52% <50%> (+0.02%)` | `44 <0> (ø)` | :arrow_down: |
| [...lin/cube/model/validation/rule/DictionaryRule.java](https://codecov.io/gh/apache/kylin/pull/1057/diff?src=pr&el=tree#diff-Y29yZS1jdWJlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9jdWJlL21vZGVsL3ZhbGlkYXRpb24vcnVsZS9EaWN0aW9uYXJ5UnVsZS5qYXZh) | `86.84% <60%> (-4.59%)` | `16 <1> (+1)` | |
| [...ream/core/storage/columnar/ColumnarStoreCache.java](https://codecov.io/gh/apache/kylin/pull/1057/diff?src=pr&el=tree#diff-c3RyZWFtLWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL3N0cmVhbS9jb3JlL3N0b3JhZ2UvY29sdW1uYXIvQ29sdW1uYXJTdG9yZUNhY2hlLmphdmE=) | `50% <0%> (-5.69%)` | `7% <0%> (-1%)` | |
| ... and [8 more](https://codecov.io/gh/apache/kylin/pull/1057/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/kylin/pull/1057?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/kylin/pull/1057?src=pr&el=footer). Last update [3777021...11a80bb](https://codecov.io/gh/apache/kylin/pull/1057?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [kylin] coveralls commented on issue #1057: KYLIN-4337 Global
domain dict for Spark build engine
Posted by GitBox <gi...@apache.org>.
coveralls commented on issue #1057: KYLIN-4337 Global domain dict for Spark build engine
URL: https://github.com/apache/kylin/pull/1057#issuecomment-573690821
## Pull Request Test Coverage Report for [Build 5516](https://coveralls.io/builds/28070367)
* **19** of **113** **(16.81%)** changed or added relevant lines in **9** files are covered.
* **6** unchanged lines in **4** files lost coverage.
* Overall coverage decreased (**-0.02%**) to **27.503%**
---
| Changes Missing Coverage | Covered Lines | Changed/Added Lines | % |
| :-----|--------------|--------|---: |
| [core-cube/src/main/java/org/apache/kylin/cube/CubeManager.java](https://coveralls.io/builds/28070367/source?filename=core-cube%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fcube%2FCubeManager.java#L1196) | 5 | 6 | 83.33%
| [core-cube/src/main/java/org/apache/kylin/cube/model/validation/rule/DictionaryRule.java](https://coveralls.io/builds/28070367/source?filename=core-cube%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fcube%2Fmodel%2Fvalidation%2Frule%2FDictionaryRule.java#L88) | 4 | 5 | 80.0%
| [engine-mr/src/main/java/org/apache/kylin/engine/mr/common/AbstractHadoopJob.java](https://coveralls.io/builds/28070367/source?filename=engine-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fengine%2Fmr%2Fcommon%2FAbstractHadoopJob.java#L591) | 0 | 1 | 0.0%
| [engine-spark/src/main/java/org/apache/kylin/engine/spark/SparkExecutable.java](https://coveralls.io/builds/28070367/source?filename=engine-spark%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fengine%2Fspark%2FSparkExecutable.java#L508) | 0 | 2 | 0.0%
| [core-metadata/src/main/java/org/apache/kylin/metadata/model/DataModelDesc.java](https://coveralls.io/builds/28070367/source?filename=core-metadata%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fmetadata%2Fmodel%2FDataModelDesc.java#L296) | 5 | 8 | 62.5%
| [core-metadata/src/main/java/org/apache/kylin/measure/bitmap/BitmapMeasureType.java](https://coveralls.io/builds/28070367/source?filename=core-metadata%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fmeasure%2Fbitmap%2FBitmapMeasureType.java#L112) | 0 | 4 | 0.0%
| [core-cube/src/main/java/org/apache/kylin/cube/model/CubeDesc.java](https://coveralls.io/builds/28070367/source?filename=core-cube%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fcube%2Fmodel%2FCubeDesc.java#L1381) | 3 | 10 | 30.0%
| [core-cube/src/main/java/org/apache/kylin/cube/model/DictionaryDesc.java](https://coveralls.io/builds/28070367/source?filename=core-cube%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fcube%2Fmodel%2FDictionaryDesc.java#L82) | 2 | 10 | 20.0%
| [core-cube/src/main/java/org/apache/kylin/cube/model/CubeDescTiretreeGlobalDomainDictUtil.java](https://coveralls.io/builds/28070367/source?filename=core-cube%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fcube%2Fmodel%2FCubeDescTiretreeGlobalDomainDictUtil.java#L41) | 0 | 67 | 0.0%
<!-- | **Total:** | **19** | **113** | **16.81%** | -->
| Files with Coverage Reduction | New Missed Lines | % |
| :-----|--------------|--: |
| [core-cube/src/main/java/org/apache/kylin/cube/model/CubeDesc.java](https://coveralls.io/builds/28070367/source?filename=core-cube%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fcube%2Fmodel%2FCubeDesc.java#L1386) | 1 | 69.81% |
| [stream-core/src/main/java/org/apache/kylin/stream/core/storage/columnar/ColumnarStoreCache.java](https://coveralls.io/builds/28070367/source?filename=stream-core%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fstream%2Fcore%2Fstorage%2Fcolumnar%2FColumnarStoreCache.java#L146) | 1 | 56.82% |
| [core-job/src/main/java/org/apache/kylin/job/impl/threadpool/DefaultScheduler.java](https://coveralls.io/builds/28070367/source?filename=core-job%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fjob%2Fimpl%2Fthreadpool%2FDefaultScheduler.java#L194) | 2 | 80.23% |
| [engine-spark/src/main/java/org/apache/kylin/engine/spark/SparkExecutable.java](https://coveralls.io/builds/28070367/source?filename=engine-spark%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fengine%2Fspark%2FSparkExecutable.java#L525) | 2 | 0.0% |
<!-- | **Total:** | **6** | | -->
| Totals | [](https://coveralls.io/builds/28070367) |
| :-- | --: |
| Change from base [Build 5512](https://coveralls.io/builds/28061631): | -0.02% |
| Covered Lines: | 24140 |
| Relevant Lines: | 87773 |
---
##### 💛 - [Coveralls](https://coveralls.io)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [kylin] codecov-io edited a comment on issue #1057: KYLIN-4337
Global domain dict for Spark build engine
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #1057: KYLIN-4337 Global domain dict for Spark build engine
URL: https://github.com/apache/kylin/pull/1057#issuecomment-573687537
# [Codecov](https://codecov.io/gh/apache/kylin/pull/1057?src=pr&el=h1) Report
> Merging [#1057](https://codecov.io/gh/apache/kylin/pull/1057?src=pr&el=desc) into [master](https://codecov.io/gh/apache/kylin/commit/37770217b2a9d7a62a40acae74fe77ea1d170b2a?src=pr&el=desc) will **increase** coverage by `0.03%`.
> The diff coverage is `9.73%`.
[](https://codecov.io/gh/apache/kylin/pull/1057?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #1057 +/- ##
============================================
+ Coverage 25% 25.04% +0.03%
- Complexity 6180 6221 +41
============================================
Files 1438 1439 +1
Lines 87669 87773 +104
Branches 12256 12272 +16
============================================
+ Hits 21926 21981 +55
- Misses 63593 63636 +43
- Partials 2150 2156 +6
```
| [Impacted Files](https://codecov.io/gh/apache/kylin/pull/1057?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...be/model/CubeDescTiretreeGlobalDomainDictUtil.java](https://codecov.io/gh/apache/kylin/pull/1057/diff?src=pr&el=tree#diff-Y29yZS1jdWJlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9jdWJlL21vZGVsL0N1YmVEZXNjVGlyZXRyZWVHbG9iYWxEb21haW5EaWN0VXRpbC5qYXZh) | `0% <0%> (ø)` | `0 <0> (?)` | |
| [...apache/kylin/measure/bitmap/BitmapMeasureType.java](https://codecov.io/gh/apache/kylin/pull/1057/diff?src=pr&el=tree#diff-Y29yZS1tZXRhZGF0YS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUva3lsaW4vbWVhc3VyZS9iaXRtYXAvQml0bWFwTWVhc3VyZVR5cGUuamF2YQ==) | `18.86% <0%> (ø)` | `4 <0> (ø)` | :arrow_down: |
| [...ache/kylin/engine/mr/common/AbstractHadoopJob.java](https://codecov.io/gh/apache/kylin/pull/1057/diff?src=pr&el=tree#diff-ZW5naW5lLW1yL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9lbmdpbmUvbXIvY29tbW9uL0Fic3RyYWN0SGFkb29wSm9iLmphdmE=) | `15.21% <0%> (-0.04%)` | `2 <0> (ø)` | |
| [...org/apache/kylin/engine/spark/SparkExecutable.java](https://codecov.io/gh/apache/kylin/pull/1057/diff?src=pr&el=tree#diff-ZW5naW5lLXNwYXJrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9lbmdpbmUvc3BhcmsvU3BhcmtFeGVjdXRhYmxlLmphdmE=) | `0% <0%> (ø)` | `0 <0> (ø)` | :arrow_down: |
| [...va/org/apache/kylin/cube/model/DictionaryDesc.java](https://codecov.io/gh/apache/kylin/pull/1057/diff?src=pr&el=tree#diff-Y29yZS1jdWJlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9jdWJlL21vZGVsL0RpY3Rpb25hcnlEZXNjLmphdmE=) | `65.38% <10%> (-34.62%)` | `8 <1> (+1)` | |
| [...ain/java/org/apache/kylin/cube/model/CubeDesc.java](https://codecov.io/gh/apache/kylin/pull/1057/diff?src=pr&el=tree#diff-Y29yZS1jdWJlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9jdWJlL21vZGVsL0N1YmVEZXNjLmphdmE=) | `63.56% <20%> (-0.57%)` | `182 <1> (+1)` | |
| [...org/apache/kylin/metadata/model/DataModelDesc.java](https://codecov.io/gh/apache/kylin/pull/1057/diff?src=pr&el=tree#diff-Y29yZS1tZXRhZGF0YS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUva3lsaW4vbWV0YWRhdGEvbW9kZWwvRGF0YU1vZGVsRGVzYy5qYXZh) | `59.21% <25%> (-0.58%)` | `72 <1> (-1)` | |
| [...c/main/java/org/apache/kylin/cube/CubeManager.java](https://codecov.io/gh/apache/kylin/pull/1057/diff?src=pr&el=tree#diff-Y29yZS1jdWJlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9jdWJlL0N1YmVNYW5hZ2VyLmphdmE=) | `36.52% <50%> (+0.02%)` | `44 <0> (ø)` | :arrow_down: |
| [...lin/cube/model/validation/rule/DictionaryRule.java](https://codecov.io/gh/apache/kylin/pull/1057/diff?src=pr&el=tree#diff-Y29yZS1jdWJlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9jdWJlL21vZGVsL3ZhbGlkYXRpb24vcnVsZS9EaWN0aW9uYXJ5UnVsZS5qYXZh) | `86.84% <60%> (-4.59%)` | `16 <1> (+1)` | |
| [...ream/core/storage/columnar/ColumnarStoreCache.java](https://codecov.io/gh/apache/kylin/pull/1057/diff?src=pr&el=tree#diff-c3RyZWFtLWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL3N0cmVhbS9jb3JlL3N0b3JhZ2UvY29sdW1uYXIvQ29sdW1uYXJTdG9yZUNhY2hlLmphdmE=) | `50% <0%> (-5.69%)` | `7% <0%> (-1%)` | |
| ... and [8 more](https://codecov.io/gh/apache/kylin/pull/1057/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/kylin/pull/1057?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/kylin/pull/1057?src=pr&el=footer). Last update [3777021...11a80bb](https://codecov.io/gh/apache/kylin/pull/1057?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [kylin] codecov-io edited a comment on issue #1057: KYLIN-4337
Global domain dict for Spark build engine
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #1057: KYLIN-4337 Global domain dict for Spark build engine
URL: https://github.com/apache/kylin/pull/1057#issuecomment-573687537
# [Codecov](https://codecov.io/gh/apache/kylin/pull/1057?src=pr&el=h1) Report
> Merging [#1057](https://codecov.io/gh/apache/kylin/pull/1057?src=pr&el=desc) into [master](https://codecov.io/gh/apache/kylin/commit/37770217b2a9d7a62a40acae74fe77ea1d170b2a?src=pr&el=desc) will **increase** coverage by `0.03%`.
> The diff coverage is `9.73%`.
[](https://codecov.io/gh/apache/kylin/pull/1057?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #1057 +/- ##
============================================
+ Coverage 25% 25.04% +0.03%
- Complexity 6180 6221 +41
============================================
Files 1438 1439 +1
Lines 87669 87773 +104
Branches 12256 12272 +16
============================================
+ Hits 21926 21981 +55
- Misses 63593 63636 +43
- Partials 2150 2156 +6
```
| [Impacted Files](https://codecov.io/gh/apache/kylin/pull/1057?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...be/model/CubeDescTiretreeGlobalDomainDictUtil.java](https://codecov.io/gh/apache/kylin/pull/1057/diff?src=pr&el=tree#diff-Y29yZS1jdWJlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9jdWJlL21vZGVsL0N1YmVEZXNjVGlyZXRyZWVHbG9iYWxEb21haW5EaWN0VXRpbC5qYXZh) | `0% <0%> (ø)` | `0 <0> (?)` | |
| [...apache/kylin/measure/bitmap/BitmapMeasureType.java](https://codecov.io/gh/apache/kylin/pull/1057/diff?src=pr&el=tree#diff-Y29yZS1tZXRhZGF0YS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUva3lsaW4vbWVhc3VyZS9iaXRtYXAvQml0bWFwTWVhc3VyZVR5cGUuamF2YQ==) | `18.86% <0%> (ø)` | `4 <0> (ø)` | :arrow_down: |
| [...ache/kylin/engine/mr/common/AbstractHadoopJob.java](https://codecov.io/gh/apache/kylin/pull/1057/diff?src=pr&el=tree#diff-ZW5naW5lLW1yL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9lbmdpbmUvbXIvY29tbW9uL0Fic3RyYWN0SGFkb29wSm9iLmphdmE=) | `15.21% <0%> (-0.04%)` | `2 <0> (ø)` | |
| [...org/apache/kylin/engine/spark/SparkExecutable.java](https://codecov.io/gh/apache/kylin/pull/1057/diff?src=pr&el=tree#diff-ZW5naW5lLXNwYXJrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9lbmdpbmUvc3BhcmsvU3BhcmtFeGVjdXRhYmxlLmphdmE=) | `0% <0%> (ø)` | `0 <0> (ø)` | :arrow_down: |
| [...va/org/apache/kylin/cube/model/DictionaryDesc.java](https://codecov.io/gh/apache/kylin/pull/1057/diff?src=pr&el=tree#diff-Y29yZS1jdWJlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9jdWJlL21vZGVsL0RpY3Rpb25hcnlEZXNjLmphdmE=) | `65.38% <10%> (-34.62%)` | `8 <1> (+1)` | |
| [...ain/java/org/apache/kylin/cube/model/CubeDesc.java](https://codecov.io/gh/apache/kylin/pull/1057/diff?src=pr&el=tree#diff-Y29yZS1jdWJlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9jdWJlL21vZGVsL0N1YmVEZXNjLmphdmE=) | `63.56% <20%> (-0.57%)` | `182 <1> (+1)` | |
| [...org/apache/kylin/metadata/model/DataModelDesc.java](https://codecov.io/gh/apache/kylin/pull/1057/diff?src=pr&el=tree#diff-Y29yZS1tZXRhZGF0YS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUva3lsaW4vbWV0YWRhdGEvbW9kZWwvRGF0YU1vZGVsRGVzYy5qYXZh) | `59.21% <25%> (-0.58%)` | `72 <1> (-1)` | |
| [...c/main/java/org/apache/kylin/cube/CubeManager.java](https://codecov.io/gh/apache/kylin/pull/1057/diff?src=pr&el=tree#diff-Y29yZS1jdWJlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9jdWJlL0N1YmVNYW5hZ2VyLmphdmE=) | `36.52% <50%> (+0.02%)` | `44 <0> (ø)` | :arrow_down: |
| [...lin/cube/model/validation/rule/DictionaryRule.java](https://codecov.io/gh/apache/kylin/pull/1057/diff?src=pr&el=tree#diff-Y29yZS1jdWJlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9jdWJlL21vZGVsL3ZhbGlkYXRpb24vcnVsZS9EaWN0aW9uYXJ5UnVsZS5qYXZh) | `86.84% <60%> (-4.59%)` | `16 <1> (+1)` | |
| [...ream/core/storage/columnar/ColumnarStoreCache.java](https://codecov.io/gh/apache/kylin/pull/1057/diff?src=pr&el=tree#diff-c3RyZWFtLWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL3N0cmVhbS9jb3JlL3N0b3JhZ2UvY29sdW1uYXIvQ29sdW1uYXJTdG9yZUNhY2hlLmphdmE=) | `50% <0%> (-5.69%)` | `7% <0%> (-1%)` | |
| ... and [8 more](https://codecov.io/gh/apache/kylin/pull/1057/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/kylin/pull/1057?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/kylin/pull/1057?src=pr&el=footer). Last update [3777021...11a80bb](https://codecov.io/gh/apache/kylin/pull/1057?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [kylin] codecov-io edited a comment on issue #1057: KYLIN-4337
Global domain dict for Spark build engine
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #1057: KYLIN-4337 Global domain dict for Spark build engine
URL: https://github.com/apache/kylin/pull/1057#issuecomment-573687537
# [Codecov](https://codecov.io/gh/apache/kylin/pull/1057?src=pr&el=h1) Report
> Merging [#1057](https://codecov.io/gh/apache/kylin/pull/1057?src=pr&el=desc) into [master](https://codecov.io/gh/apache/kylin/commit/37770217b2a9d7a62a40acae74fe77ea1d170b2a?src=pr&el=desc) will **increase** coverage by `0.03%`.
> The diff coverage is `9.73%`.
[](https://codecov.io/gh/apache/kylin/pull/1057?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #1057 +/- ##
============================================
+ Coverage 25% 25.04% +0.03%
- Complexity 6180 6221 +41
============================================
Files 1438 1439 +1
Lines 87669 87773 +104
Branches 12256 12272 +16
============================================
+ Hits 21926 21981 +55
- Misses 63593 63636 +43
- Partials 2150 2156 +6
```
| [Impacted Files](https://codecov.io/gh/apache/kylin/pull/1057?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...be/model/CubeDescTiretreeGlobalDomainDictUtil.java](https://codecov.io/gh/apache/kylin/pull/1057/diff?src=pr&el=tree#diff-Y29yZS1jdWJlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9jdWJlL21vZGVsL0N1YmVEZXNjVGlyZXRyZWVHbG9iYWxEb21haW5EaWN0VXRpbC5qYXZh) | `0% <0%> (ø)` | `0 <0> (?)` | |
| [...apache/kylin/measure/bitmap/BitmapMeasureType.java](https://codecov.io/gh/apache/kylin/pull/1057/diff?src=pr&el=tree#diff-Y29yZS1tZXRhZGF0YS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUva3lsaW4vbWVhc3VyZS9iaXRtYXAvQml0bWFwTWVhc3VyZVR5cGUuamF2YQ==) | `18.86% <0%> (ø)` | `4 <0> (ø)` | :arrow_down: |
| [...ache/kylin/engine/mr/common/AbstractHadoopJob.java](https://codecov.io/gh/apache/kylin/pull/1057/diff?src=pr&el=tree#diff-ZW5naW5lLW1yL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9lbmdpbmUvbXIvY29tbW9uL0Fic3RyYWN0SGFkb29wSm9iLmphdmE=) | `15.21% <0%> (-0.04%)` | `2 <0> (ø)` | |
| [...org/apache/kylin/engine/spark/SparkExecutable.java](https://codecov.io/gh/apache/kylin/pull/1057/diff?src=pr&el=tree#diff-ZW5naW5lLXNwYXJrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9lbmdpbmUvc3BhcmsvU3BhcmtFeGVjdXRhYmxlLmphdmE=) | `0% <0%> (ø)` | `0 <0> (ø)` | :arrow_down: |
| [...va/org/apache/kylin/cube/model/DictionaryDesc.java](https://codecov.io/gh/apache/kylin/pull/1057/diff?src=pr&el=tree#diff-Y29yZS1jdWJlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9jdWJlL21vZGVsL0RpY3Rpb25hcnlEZXNjLmphdmE=) | `65.38% <10%> (-34.62%)` | `8 <1> (+1)` | |
| [...ain/java/org/apache/kylin/cube/model/CubeDesc.java](https://codecov.io/gh/apache/kylin/pull/1057/diff?src=pr&el=tree#diff-Y29yZS1jdWJlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9jdWJlL21vZGVsL0N1YmVEZXNjLmphdmE=) | `63.56% <20%> (-0.57%)` | `182 <1> (+1)` | |
| [...org/apache/kylin/metadata/model/DataModelDesc.java](https://codecov.io/gh/apache/kylin/pull/1057/diff?src=pr&el=tree#diff-Y29yZS1tZXRhZGF0YS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUva3lsaW4vbWV0YWRhdGEvbW9kZWwvRGF0YU1vZGVsRGVzYy5qYXZh) | `59.21% <25%> (-0.58%)` | `72 <1> (-1)` | |
| [...c/main/java/org/apache/kylin/cube/CubeManager.java](https://codecov.io/gh/apache/kylin/pull/1057/diff?src=pr&el=tree#diff-Y29yZS1jdWJlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9jdWJlL0N1YmVNYW5hZ2VyLmphdmE=) | `36.52% <50%> (+0.02%)` | `44 <0> (ø)` | :arrow_down: |
| [...lin/cube/model/validation/rule/DictionaryRule.java](https://codecov.io/gh/apache/kylin/pull/1057/diff?src=pr&el=tree#diff-Y29yZS1jdWJlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9jdWJlL21vZGVsL3ZhbGlkYXRpb24vcnVsZS9EaWN0aW9uYXJ5UnVsZS5qYXZh) | `86.84% <60%> (-4.59%)` | `16 <1> (+1)` | |
| [...ream/core/storage/columnar/ColumnarStoreCache.java](https://codecov.io/gh/apache/kylin/pull/1057/diff?src=pr&el=tree#diff-c3RyZWFtLWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL3N0cmVhbS9jb3JlL3N0b3JhZ2UvY29sdW1uYXIvQ29sdW1uYXJTdG9yZUNhY2hlLmphdmE=) | `50% <0%> (-5.69%)` | `7% <0%> (-1%)` | |
| ... and [8 more](https://codecov.io/gh/apache/kylin/pull/1057/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/kylin/pull/1057?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/kylin/pull/1057?src=pr&el=footer). Last update [3777021...11a80bb](https://codecov.io/gh/apache/kylin/pull/1057?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [kylin] codecov-io edited a comment on issue #1057: KYLIN-4337
Global domain dict for Spark build engine
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #1057: KYLIN-4337 Global domain dict for Spark build engine
URL: https://github.com/apache/kylin/pull/1057#issuecomment-573687537
# [Codecov](https://codecov.io/gh/apache/kylin/pull/1057?src=pr&el=h1) Report
> Merging [#1057](https://codecov.io/gh/apache/kylin/pull/1057?src=pr&el=desc) into [master](https://codecov.io/gh/apache/kylin/commit/2a9aa87bb3833f80c29d462e5a1cd8c7a238b21e?src=pr&el=desc) will **decrease** coverage by `0.02%`.
> The diff coverage is `9.73%`.
[](https://codecov.io/gh/apache/kylin/pull/1057?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #1057 +/- ##
============================================
- Coverage 25.07% 25.04% -0.03%
- Complexity 6220 6221 +1
============================================
Files 1438 1439 +1
Lines 87673 87773 +100
Branches 12256 12272 +16
============================================
+ Hits 21980 21981 +1
- Misses 63545 63636 +91
- Partials 2148 2156 +8
```
| [Impacted Files](https://codecov.io/gh/apache/kylin/pull/1057?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...be/model/CubeDescTiretreeGlobalDomainDictUtil.java](https://codecov.io/gh/apache/kylin/pull/1057/diff?src=pr&el=tree#diff-Y29yZS1jdWJlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9jdWJlL21vZGVsL0N1YmVEZXNjVGlyZXRyZWVHbG9iYWxEb21haW5EaWN0VXRpbC5qYXZh) | `0% <0%> (ø)` | `0 <0> (?)` | |
| [...apache/kylin/measure/bitmap/BitmapMeasureType.java](https://codecov.io/gh/apache/kylin/pull/1057/diff?src=pr&el=tree#diff-Y29yZS1tZXRhZGF0YS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUva3lsaW4vbWVhc3VyZS9iaXRtYXAvQml0bWFwTWVhc3VyZVR5cGUuamF2YQ==) | `18.86% <0%> (ø)` | `4 <0> (ø)` | :arrow_down: |
| [...ache/kylin/engine/mr/common/AbstractHadoopJob.java](https://codecov.io/gh/apache/kylin/pull/1057/diff?src=pr&el=tree#diff-ZW5naW5lLW1yL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9lbmdpbmUvbXIvY29tbW9uL0Fic3RyYWN0SGFkb29wSm9iLmphdmE=) | `15.21% <0%> (-0.04%)` | `2 <0> (ø)` | |
| [...org/apache/kylin/engine/spark/SparkExecutable.java](https://codecov.io/gh/apache/kylin/pull/1057/diff?src=pr&el=tree#diff-ZW5naW5lLXNwYXJrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9lbmdpbmUvc3BhcmsvU3BhcmtFeGVjdXRhYmxlLmphdmE=) | `0% <0%> (ø)` | `0 <0> (ø)` | :arrow_down: |
| [...va/org/apache/kylin/cube/model/DictionaryDesc.java](https://codecov.io/gh/apache/kylin/pull/1057/diff?src=pr&el=tree#diff-Y29yZS1jdWJlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9jdWJlL21vZGVsL0RpY3Rpb25hcnlEZXNjLmphdmE=) | `65.38% <10%> (-34.62%)` | `8 <1> (+1)` | |
| [...ain/java/org/apache/kylin/cube/model/CubeDesc.java](https://codecov.io/gh/apache/kylin/pull/1057/diff?src=pr&el=tree#diff-Y29yZS1jdWJlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9jdWJlL21vZGVsL0N1YmVEZXNjLmphdmE=) | `63.56% <20%> (-0.57%)` | `182 <1> (+1)` | |
| [...org/apache/kylin/metadata/model/DataModelDesc.java](https://codecov.io/gh/apache/kylin/pull/1057/diff?src=pr&el=tree#diff-Y29yZS1tZXRhZGF0YS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUva3lsaW4vbWV0YWRhdGEvbW9kZWwvRGF0YU1vZGVsRGVzYy5qYXZh) | `59.21% <25%> (-0.58%)` | `72 <1> (-1)` | |
| [...c/main/java/org/apache/kylin/cube/CubeManager.java](https://codecov.io/gh/apache/kylin/pull/1057/diff?src=pr&el=tree#diff-Y29yZS1jdWJlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9jdWJlL0N1YmVNYW5hZ2VyLmphdmE=) | `36.52% <50%> (+0.02%)` | `44 <0> (ø)` | :arrow_down: |
| [...lin/cube/model/validation/rule/DictionaryRule.java](https://codecov.io/gh/apache/kylin/pull/1057/diff?src=pr&el=tree#diff-Y29yZS1jdWJlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9jdWJlL21vZGVsL3ZhbGlkYXRpb24vcnVsZS9EaWN0aW9uYXJ5UnVsZS5qYXZh) | `86.84% <60%> (-4.59%)` | `16 <1> (+1)` | |
| [...he/kylin/job/impl/threadpool/DefaultScheduler.java](https://codecov.io/gh/apache/kylin/pull/1057/diff?src=pr&el=tree#diff-Y29yZS1qb2Ivc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL2pvYi9pbXBsL3RocmVhZHBvb2wvRGVmYXVsdFNjaGVkdWxlci5qYXZh) | `74.41% <0%> (-2.33%)` | `12% <0%> (ø)` | |
| ... and [3 more](https://codecov.io/gh/apache/kylin/pull/1057/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/kylin/pull/1057?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/kylin/pull/1057?src=pr&el=footer). Last update [2a9aa87...11a80bb](https://codecov.io/gh/apache/kylin/pull/1057?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [kylin] codecov-io edited a comment on issue #1057: KYLIN-4337
Global domain dict for Spark build engine
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #1057: KYLIN-4337 Global domain dict for Spark build engine
URL: https://github.com/apache/kylin/pull/1057#issuecomment-573687537
# [Codecov](https://codecov.io/gh/apache/kylin/pull/1057?src=pr&el=h1) Report
> Merging [#1057](https://codecov.io/gh/apache/kylin/pull/1057?src=pr&el=desc) into [master](https://codecov.io/gh/apache/kylin/commit/37770217b2a9d7a62a40acae74fe77ea1d170b2a?src=pr&el=desc) will **increase** coverage by `0.03%`.
> The diff coverage is `9.73%`.
[](https://codecov.io/gh/apache/kylin/pull/1057?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #1057 +/- ##
============================================
+ Coverage 25% 25.04% +0.03%
- Complexity 6180 6221 +41
============================================
Files 1438 1439 +1
Lines 87669 87773 +104
Branches 12256 12272 +16
============================================
+ Hits 21926 21981 +55
- Misses 63593 63636 +43
- Partials 2150 2156 +6
```
| [Impacted Files](https://codecov.io/gh/apache/kylin/pull/1057?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...be/model/CubeDescTiretreeGlobalDomainDictUtil.java](https://codecov.io/gh/apache/kylin/pull/1057/diff?src=pr&el=tree#diff-Y29yZS1jdWJlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9jdWJlL21vZGVsL0N1YmVEZXNjVGlyZXRyZWVHbG9iYWxEb21haW5EaWN0VXRpbC5qYXZh) | `0% <0%> (ø)` | `0 <0> (?)` | |
| [...apache/kylin/measure/bitmap/BitmapMeasureType.java](https://codecov.io/gh/apache/kylin/pull/1057/diff?src=pr&el=tree#diff-Y29yZS1tZXRhZGF0YS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUva3lsaW4vbWVhc3VyZS9iaXRtYXAvQml0bWFwTWVhc3VyZVR5cGUuamF2YQ==) | `18.86% <0%> (ø)` | `4 <0> (ø)` | :arrow_down: |
| [...ache/kylin/engine/mr/common/AbstractHadoopJob.java](https://codecov.io/gh/apache/kylin/pull/1057/diff?src=pr&el=tree#diff-ZW5naW5lLW1yL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9lbmdpbmUvbXIvY29tbW9uL0Fic3RyYWN0SGFkb29wSm9iLmphdmE=) | `15.21% <0%> (-0.04%)` | `2 <0> (ø)` | |
| [...org/apache/kylin/engine/spark/SparkExecutable.java](https://codecov.io/gh/apache/kylin/pull/1057/diff?src=pr&el=tree#diff-ZW5naW5lLXNwYXJrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9lbmdpbmUvc3BhcmsvU3BhcmtFeGVjdXRhYmxlLmphdmE=) | `0% <0%> (ø)` | `0 <0> (ø)` | :arrow_down: |
| [...va/org/apache/kylin/cube/model/DictionaryDesc.java](https://codecov.io/gh/apache/kylin/pull/1057/diff?src=pr&el=tree#diff-Y29yZS1jdWJlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9jdWJlL21vZGVsL0RpY3Rpb25hcnlEZXNjLmphdmE=) | `65.38% <10%> (-34.62%)` | `8 <1> (+1)` | |
| [...ain/java/org/apache/kylin/cube/model/CubeDesc.java](https://codecov.io/gh/apache/kylin/pull/1057/diff?src=pr&el=tree#diff-Y29yZS1jdWJlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9jdWJlL21vZGVsL0N1YmVEZXNjLmphdmE=) | `63.56% <20%> (-0.57%)` | `182 <1> (+1)` | |
| [...org/apache/kylin/metadata/model/DataModelDesc.java](https://codecov.io/gh/apache/kylin/pull/1057/diff?src=pr&el=tree#diff-Y29yZS1tZXRhZGF0YS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUva3lsaW4vbWV0YWRhdGEvbW9kZWwvRGF0YU1vZGVsRGVzYy5qYXZh) | `59.21% <25%> (-0.58%)` | `72 <1> (-1)` | |
| [...c/main/java/org/apache/kylin/cube/CubeManager.java](https://codecov.io/gh/apache/kylin/pull/1057/diff?src=pr&el=tree#diff-Y29yZS1jdWJlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9jdWJlL0N1YmVNYW5hZ2VyLmphdmE=) | `36.52% <50%> (+0.02%)` | `44 <0> (ø)` | :arrow_down: |
| [...lin/cube/model/validation/rule/DictionaryRule.java](https://codecov.io/gh/apache/kylin/pull/1057/diff?src=pr&el=tree#diff-Y29yZS1jdWJlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9jdWJlL21vZGVsL3ZhbGlkYXRpb24vcnVsZS9EaWN0aW9uYXJ5UnVsZS5qYXZh) | `86.84% <60%> (-4.59%)` | `16 <1> (+1)` | |
| [...ream/core/storage/columnar/ColumnarStoreCache.java](https://codecov.io/gh/apache/kylin/pull/1057/diff?src=pr&el=tree#diff-c3RyZWFtLWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL3N0cmVhbS9jb3JlL3N0b3JhZ2UvY29sdW1uYXIvQ29sdW1uYXJTdG9yZUNhY2hlLmphdmE=) | `50% <0%> (-5.69%)` | `7% <0%> (-1%)` | |
| ... and [8 more](https://codecov.io/gh/apache/kylin/pull/1057/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/kylin/pull/1057?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/kylin/pull/1057?src=pr&el=footer). Last update [3777021...11a80bb](https://codecov.io/gh/apache/kylin/pull/1057?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [kylin] codecov-io edited a comment on issue #1057: KYLIN-4337
Global domain dict for Spark build engine
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #1057: KYLIN-4337 Global domain dict for Spark build engine
URL: https://github.com/apache/kylin/pull/1057#issuecomment-573687537
# [Codecov](https://codecov.io/gh/apache/kylin/pull/1057?src=pr&el=h1) Report
> Merging [#1057](https://codecov.io/gh/apache/kylin/pull/1057?src=pr&el=desc) into [master](https://codecov.io/gh/apache/kylin/commit/2a9aa87bb3833f80c29d462e5a1cd8c7a238b21e?src=pr&el=desc) will **decrease** coverage by `0.02%`.
> The diff coverage is `9.73%`.
[](https://codecov.io/gh/apache/kylin/pull/1057?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #1057 +/- ##
============================================
- Coverage 25.07% 25.04% -0.03%
- Complexity 6220 6221 +1
============================================
Files 1438 1439 +1
Lines 87673 87773 +100
Branches 12256 12272 +16
============================================
+ Hits 21980 21981 +1
- Misses 63545 63636 +91
- Partials 2148 2156 +8
```
| [Impacted Files](https://codecov.io/gh/apache/kylin/pull/1057?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...be/model/CubeDescTiretreeGlobalDomainDictUtil.java](https://codecov.io/gh/apache/kylin/pull/1057/diff?src=pr&el=tree#diff-Y29yZS1jdWJlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9jdWJlL21vZGVsL0N1YmVEZXNjVGlyZXRyZWVHbG9iYWxEb21haW5EaWN0VXRpbC5qYXZh) | `0% <0%> (ø)` | `0 <0> (?)` | |
| [...apache/kylin/measure/bitmap/BitmapMeasureType.java](https://codecov.io/gh/apache/kylin/pull/1057/diff?src=pr&el=tree#diff-Y29yZS1tZXRhZGF0YS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUva3lsaW4vbWVhc3VyZS9iaXRtYXAvQml0bWFwTWVhc3VyZVR5cGUuamF2YQ==) | `18.86% <0%> (ø)` | `4 <0> (ø)` | :arrow_down: |
| [...ache/kylin/engine/mr/common/AbstractHadoopJob.java](https://codecov.io/gh/apache/kylin/pull/1057/diff?src=pr&el=tree#diff-ZW5naW5lLW1yL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9lbmdpbmUvbXIvY29tbW9uL0Fic3RyYWN0SGFkb29wSm9iLmphdmE=) | `15.21% <0%> (-0.04%)` | `2 <0> (ø)` | |
| [...org/apache/kylin/engine/spark/SparkExecutable.java](https://codecov.io/gh/apache/kylin/pull/1057/diff?src=pr&el=tree#diff-ZW5naW5lLXNwYXJrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9lbmdpbmUvc3BhcmsvU3BhcmtFeGVjdXRhYmxlLmphdmE=) | `0% <0%> (ø)` | `0 <0> (ø)` | :arrow_down: |
| [...va/org/apache/kylin/cube/model/DictionaryDesc.java](https://codecov.io/gh/apache/kylin/pull/1057/diff?src=pr&el=tree#diff-Y29yZS1jdWJlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9jdWJlL21vZGVsL0RpY3Rpb25hcnlEZXNjLmphdmE=) | `65.38% <10%> (-34.62%)` | `8 <1> (+1)` | |
| [...ain/java/org/apache/kylin/cube/model/CubeDesc.java](https://codecov.io/gh/apache/kylin/pull/1057/diff?src=pr&el=tree#diff-Y29yZS1jdWJlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9jdWJlL21vZGVsL0N1YmVEZXNjLmphdmE=) | `63.56% <20%> (-0.57%)` | `182 <1> (+1)` | |
| [...org/apache/kylin/metadata/model/DataModelDesc.java](https://codecov.io/gh/apache/kylin/pull/1057/diff?src=pr&el=tree#diff-Y29yZS1tZXRhZGF0YS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUva3lsaW4vbWV0YWRhdGEvbW9kZWwvRGF0YU1vZGVsRGVzYy5qYXZh) | `59.21% <25%> (-0.58%)` | `72 <1> (-1)` | |
| [...c/main/java/org/apache/kylin/cube/CubeManager.java](https://codecov.io/gh/apache/kylin/pull/1057/diff?src=pr&el=tree#diff-Y29yZS1jdWJlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9jdWJlL0N1YmVNYW5hZ2VyLmphdmE=) | `36.52% <50%> (+0.02%)` | `44 <0> (ø)` | :arrow_down: |
| [...lin/cube/model/validation/rule/DictionaryRule.java](https://codecov.io/gh/apache/kylin/pull/1057/diff?src=pr&el=tree#diff-Y29yZS1jdWJlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9jdWJlL21vZGVsL3ZhbGlkYXRpb24vcnVsZS9EaWN0aW9uYXJ5UnVsZS5qYXZh) | `86.84% <60%> (-4.59%)` | `16 <1> (+1)` | |
| [...he/kylin/job/impl/threadpool/DefaultScheduler.java](https://codecov.io/gh/apache/kylin/pull/1057/diff?src=pr&el=tree#diff-Y29yZS1qb2Ivc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL2pvYi9pbXBsL3RocmVhZHBvb2wvRGVmYXVsdFNjaGVkdWxlci5qYXZh) | `74.41% <0%> (-2.33%)` | `12% <0%> (ø)` | |
| ... and [3 more](https://codecov.io/gh/apache/kylin/pull/1057/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/kylin/pull/1057?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/kylin/pull/1057?src=pr&el=footer). Last update [2a9aa87...11a80bb](https://codecov.io/gh/apache/kylin/pull/1057?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [kylin] codecov-io edited a comment on issue #1057: KYLIN-4337
Global domain dict for Spark build engine
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #1057: KYLIN-4337 Global domain dict for Spark build engine
URL: https://github.com/apache/kylin/pull/1057#issuecomment-573687537
# [Codecov](https://codecov.io/gh/apache/kylin/pull/1057?src=pr&el=h1) Report
> Merging [#1057](https://codecov.io/gh/apache/kylin/pull/1057?src=pr&el=desc) into [master](https://codecov.io/gh/apache/kylin/commit/37770217b2a9d7a62a40acae74fe77ea1d170b2a?src=pr&el=desc) will **increase** coverage by `0.03%`.
> The diff coverage is `9.73%`.
[](https://codecov.io/gh/apache/kylin/pull/1057?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #1057 +/- ##
============================================
+ Coverage 25% 25.04% +0.03%
- Complexity 6180 6221 +41
============================================
Files 1438 1439 +1
Lines 87669 87773 +104
Branches 12256 12272 +16
============================================
+ Hits 21926 21981 +55
- Misses 63593 63636 +43
- Partials 2150 2156 +6
```
| [Impacted Files](https://codecov.io/gh/apache/kylin/pull/1057?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...be/model/CubeDescTiretreeGlobalDomainDictUtil.java](https://codecov.io/gh/apache/kylin/pull/1057/diff?src=pr&el=tree#diff-Y29yZS1jdWJlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9jdWJlL21vZGVsL0N1YmVEZXNjVGlyZXRyZWVHbG9iYWxEb21haW5EaWN0VXRpbC5qYXZh) | `0% <0%> (ø)` | `0 <0> (?)` | |
| [...apache/kylin/measure/bitmap/BitmapMeasureType.java](https://codecov.io/gh/apache/kylin/pull/1057/diff?src=pr&el=tree#diff-Y29yZS1tZXRhZGF0YS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUva3lsaW4vbWVhc3VyZS9iaXRtYXAvQml0bWFwTWVhc3VyZVR5cGUuamF2YQ==) | `18.86% <0%> (ø)` | `4 <0> (ø)` | :arrow_down: |
| [...ache/kylin/engine/mr/common/AbstractHadoopJob.java](https://codecov.io/gh/apache/kylin/pull/1057/diff?src=pr&el=tree#diff-ZW5naW5lLW1yL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9lbmdpbmUvbXIvY29tbW9uL0Fic3RyYWN0SGFkb29wSm9iLmphdmE=) | `15.21% <0%> (-0.04%)` | `2 <0> (ø)` | |
| [...org/apache/kylin/engine/spark/SparkExecutable.java](https://codecov.io/gh/apache/kylin/pull/1057/diff?src=pr&el=tree#diff-ZW5naW5lLXNwYXJrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9lbmdpbmUvc3BhcmsvU3BhcmtFeGVjdXRhYmxlLmphdmE=) | `0% <0%> (ø)` | `0 <0> (ø)` | :arrow_down: |
| [...va/org/apache/kylin/cube/model/DictionaryDesc.java](https://codecov.io/gh/apache/kylin/pull/1057/diff?src=pr&el=tree#diff-Y29yZS1jdWJlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9jdWJlL21vZGVsL0RpY3Rpb25hcnlEZXNjLmphdmE=) | `65.38% <10%> (-34.62%)` | `8 <1> (+1)` | |
| [...ain/java/org/apache/kylin/cube/model/CubeDesc.java](https://codecov.io/gh/apache/kylin/pull/1057/diff?src=pr&el=tree#diff-Y29yZS1jdWJlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9jdWJlL21vZGVsL0N1YmVEZXNjLmphdmE=) | `63.56% <20%> (-0.57%)` | `182 <1> (+1)` | |
| [...org/apache/kylin/metadata/model/DataModelDesc.java](https://codecov.io/gh/apache/kylin/pull/1057/diff?src=pr&el=tree#diff-Y29yZS1tZXRhZGF0YS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUva3lsaW4vbWV0YWRhdGEvbW9kZWwvRGF0YU1vZGVsRGVzYy5qYXZh) | `59.21% <25%> (-0.58%)` | `72 <1> (-1)` | |
| [...c/main/java/org/apache/kylin/cube/CubeManager.java](https://codecov.io/gh/apache/kylin/pull/1057/diff?src=pr&el=tree#diff-Y29yZS1jdWJlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9jdWJlL0N1YmVNYW5hZ2VyLmphdmE=) | `36.52% <50%> (+0.02%)` | `44 <0> (ø)` | :arrow_down: |
| [...lin/cube/model/validation/rule/DictionaryRule.java](https://codecov.io/gh/apache/kylin/pull/1057/diff?src=pr&el=tree#diff-Y29yZS1jdWJlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9jdWJlL21vZGVsL3ZhbGlkYXRpb24vcnVsZS9EaWN0aW9uYXJ5UnVsZS5qYXZh) | `86.84% <60%> (-4.59%)` | `16 <1> (+1)` | |
| [...ream/core/storage/columnar/ColumnarStoreCache.java](https://codecov.io/gh/apache/kylin/pull/1057/diff?src=pr&el=tree#diff-c3RyZWFtLWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL3N0cmVhbS9jb3JlL3N0b3JhZ2UvY29sdW1uYXIvQ29sdW1uYXJTdG9yZUNhY2hlLmphdmE=) | `50% <0%> (-5.69%)` | `7% <0%> (-1%)` | |
| ... and [8 more](https://codecov.io/gh/apache/kylin/pull/1057/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/kylin/pull/1057?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/kylin/pull/1057?src=pr&el=footer). Last update [3777021...11a80bb](https://codecov.io/gh/apache/kylin/pull/1057?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [kylin] nichunen commented on issue #1057: KYLIN-4337 Global domain
dict for Spark build engine
Posted by GitBox <gi...@apache.org>.
nichunen commented on issue #1057: KYLIN-4337 Global domain dict for Spark build engine
URL: https://github.com/apache/kylin/pull/1057#issuecomment-590746706
Merged in PR https://github.com/apache/kylin/pull/1058
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [kylin] codecov-io edited a comment on issue #1057: KYLIN-4337
Global domain dict for Spark build engine
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #1057: KYLIN-4337 Global domain dict for Spark build engine
URL: https://github.com/apache/kylin/pull/1057#issuecomment-573687537
# [Codecov](https://codecov.io/gh/apache/kylin/pull/1057?src=pr&el=h1) Report
> Merging [#1057](https://codecov.io/gh/apache/kylin/pull/1057?src=pr&el=desc) into [master](https://codecov.io/gh/apache/kylin/commit/37770217b2a9d7a62a40acae74fe77ea1d170b2a?src=pr&el=desc) will **increase** coverage by `0.03%`.
> The diff coverage is `9.73%`.
[](https://codecov.io/gh/apache/kylin/pull/1057?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #1057 +/- ##
============================================
+ Coverage 25% 25.04% +0.03%
- Complexity 6180 6221 +41
============================================
Files 1438 1439 +1
Lines 87669 87773 +104
Branches 12256 12272 +16
============================================
+ Hits 21926 21981 +55
- Misses 63593 63636 +43
- Partials 2150 2156 +6
```
| [Impacted Files](https://codecov.io/gh/apache/kylin/pull/1057?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...be/model/CubeDescTiretreeGlobalDomainDictUtil.java](https://codecov.io/gh/apache/kylin/pull/1057/diff?src=pr&el=tree#diff-Y29yZS1jdWJlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9jdWJlL21vZGVsL0N1YmVEZXNjVGlyZXRyZWVHbG9iYWxEb21haW5EaWN0VXRpbC5qYXZh) | `0% <0%> (ø)` | `0 <0> (?)` | |
| [...apache/kylin/measure/bitmap/BitmapMeasureType.java](https://codecov.io/gh/apache/kylin/pull/1057/diff?src=pr&el=tree#diff-Y29yZS1tZXRhZGF0YS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUva3lsaW4vbWVhc3VyZS9iaXRtYXAvQml0bWFwTWVhc3VyZVR5cGUuamF2YQ==) | `18.86% <0%> (ø)` | `4 <0> (ø)` | :arrow_down: |
| [...ache/kylin/engine/mr/common/AbstractHadoopJob.java](https://codecov.io/gh/apache/kylin/pull/1057/diff?src=pr&el=tree#diff-ZW5naW5lLW1yL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9lbmdpbmUvbXIvY29tbW9uL0Fic3RyYWN0SGFkb29wSm9iLmphdmE=) | `15.21% <0%> (-0.04%)` | `2 <0> (ø)` | |
| [...org/apache/kylin/engine/spark/SparkExecutable.java](https://codecov.io/gh/apache/kylin/pull/1057/diff?src=pr&el=tree#diff-ZW5naW5lLXNwYXJrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9lbmdpbmUvc3BhcmsvU3BhcmtFeGVjdXRhYmxlLmphdmE=) | `0% <0%> (ø)` | `0 <0> (ø)` | :arrow_down: |
| [...va/org/apache/kylin/cube/model/DictionaryDesc.java](https://codecov.io/gh/apache/kylin/pull/1057/diff?src=pr&el=tree#diff-Y29yZS1jdWJlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9jdWJlL21vZGVsL0RpY3Rpb25hcnlEZXNjLmphdmE=) | `65.38% <10%> (-34.62%)` | `8 <1> (+1)` | |
| [...ain/java/org/apache/kylin/cube/model/CubeDesc.java](https://codecov.io/gh/apache/kylin/pull/1057/diff?src=pr&el=tree#diff-Y29yZS1jdWJlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9jdWJlL21vZGVsL0N1YmVEZXNjLmphdmE=) | `63.56% <20%> (-0.57%)` | `182 <1> (+1)` | |
| [...org/apache/kylin/metadata/model/DataModelDesc.java](https://codecov.io/gh/apache/kylin/pull/1057/diff?src=pr&el=tree#diff-Y29yZS1tZXRhZGF0YS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUva3lsaW4vbWV0YWRhdGEvbW9kZWwvRGF0YU1vZGVsRGVzYy5qYXZh) | `59.21% <25%> (-0.58%)` | `72 <1> (-1)` | |
| [...c/main/java/org/apache/kylin/cube/CubeManager.java](https://codecov.io/gh/apache/kylin/pull/1057/diff?src=pr&el=tree#diff-Y29yZS1jdWJlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9jdWJlL0N1YmVNYW5hZ2VyLmphdmE=) | `36.52% <50%> (+0.02%)` | `44 <0> (ø)` | :arrow_down: |
| [...lin/cube/model/validation/rule/DictionaryRule.java](https://codecov.io/gh/apache/kylin/pull/1057/diff?src=pr&el=tree#diff-Y29yZS1jdWJlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9jdWJlL21vZGVsL3ZhbGlkYXRpb24vcnVsZS9EaWN0aW9uYXJ5UnVsZS5qYXZh) | `86.84% <60%> (-4.59%)` | `16 <1> (+1)` | |
| [...ream/core/storage/columnar/ColumnarStoreCache.java](https://codecov.io/gh/apache/kylin/pull/1057/diff?src=pr&el=tree#diff-c3RyZWFtLWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL3N0cmVhbS9jb3JlL3N0b3JhZ2UvY29sdW1uYXIvQ29sdW1uYXJTdG9yZUNhY2hlLmphdmE=) | `50% <0%> (-5.69%)` | `7% <0%> (-1%)` | |
| ... and [8 more](https://codecov.io/gh/apache/kylin/pull/1057/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/kylin/pull/1057?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/kylin/pull/1057?src=pr&el=footer). Last update [3777021...11a80bb](https://codecov.io/gh/apache/kylin/pull/1057?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [kylin] codecov-io edited a comment on issue #1057: KYLIN-4337
Global domain dict for Spark build engine
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #1057: KYLIN-4337 Global domain dict for Spark build engine
URL: https://github.com/apache/kylin/pull/1057#issuecomment-573687537
# [Codecov](https://codecov.io/gh/apache/kylin/pull/1057?src=pr&el=h1) Report
> Merging [#1057](https://codecov.io/gh/apache/kylin/pull/1057?src=pr&el=desc) into [master](https://codecov.io/gh/apache/kylin/commit/2a9aa87bb3833f80c29d462e5a1cd8c7a238b21e?src=pr&el=desc) will **decrease** coverage by `0.02%`.
> The diff coverage is `9.73%`.
[](https://codecov.io/gh/apache/kylin/pull/1057?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #1057 +/- ##
============================================
- Coverage 25.07% 25.04% -0.03%
- Complexity 6220 6221 +1
============================================
Files 1438 1439 +1
Lines 87673 87773 +100
Branches 12256 12272 +16
============================================
+ Hits 21980 21981 +1
- Misses 63545 63636 +91
- Partials 2148 2156 +8
```
| [Impacted Files](https://codecov.io/gh/apache/kylin/pull/1057?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...be/model/CubeDescTiretreeGlobalDomainDictUtil.java](https://codecov.io/gh/apache/kylin/pull/1057/diff?src=pr&el=tree#diff-Y29yZS1jdWJlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9jdWJlL21vZGVsL0N1YmVEZXNjVGlyZXRyZWVHbG9iYWxEb21haW5EaWN0VXRpbC5qYXZh) | `0% <0%> (ø)` | `0 <0> (?)` | |
| [...apache/kylin/measure/bitmap/BitmapMeasureType.java](https://codecov.io/gh/apache/kylin/pull/1057/diff?src=pr&el=tree#diff-Y29yZS1tZXRhZGF0YS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUva3lsaW4vbWVhc3VyZS9iaXRtYXAvQml0bWFwTWVhc3VyZVR5cGUuamF2YQ==) | `18.86% <0%> (ø)` | `4 <0> (ø)` | :arrow_down: |
| [...ache/kylin/engine/mr/common/AbstractHadoopJob.java](https://codecov.io/gh/apache/kylin/pull/1057/diff?src=pr&el=tree#diff-ZW5naW5lLW1yL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9lbmdpbmUvbXIvY29tbW9uL0Fic3RyYWN0SGFkb29wSm9iLmphdmE=) | `15.21% <0%> (-0.04%)` | `2 <0> (ø)` | |
| [...org/apache/kylin/engine/spark/SparkExecutable.java](https://codecov.io/gh/apache/kylin/pull/1057/diff?src=pr&el=tree#diff-ZW5naW5lLXNwYXJrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9lbmdpbmUvc3BhcmsvU3BhcmtFeGVjdXRhYmxlLmphdmE=) | `0% <0%> (ø)` | `0 <0> (ø)` | :arrow_down: |
| [...va/org/apache/kylin/cube/model/DictionaryDesc.java](https://codecov.io/gh/apache/kylin/pull/1057/diff?src=pr&el=tree#diff-Y29yZS1jdWJlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9jdWJlL21vZGVsL0RpY3Rpb25hcnlEZXNjLmphdmE=) | `65.38% <10%> (-34.62%)` | `8 <1> (+1)` | |
| [...ain/java/org/apache/kylin/cube/model/CubeDesc.java](https://codecov.io/gh/apache/kylin/pull/1057/diff?src=pr&el=tree#diff-Y29yZS1jdWJlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9jdWJlL21vZGVsL0N1YmVEZXNjLmphdmE=) | `63.56% <20%> (-0.57%)` | `182 <1> (+1)` | |
| [...org/apache/kylin/metadata/model/DataModelDesc.java](https://codecov.io/gh/apache/kylin/pull/1057/diff?src=pr&el=tree#diff-Y29yZS1tZXRhZGF0YS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUva3lsaW4vbWV0YWRhdGEvbW9kZWwvRGF0YU1vZGVsRGVzYy5qYXZh) | `59.21% <25%> (-0.58%)` | `72 <1> (-1)` | |
| [...c/main/java/org/apache/kylin/cube/CubeManager.java](https://codecov.io/gh/apache/kylin/pull/1057/diff?src=pr&el=tree#diff-Y29yZS1jdWJlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9jdWJlL0N1YmVNYW5hZ2VyLmphdmE=) | `36.52% <50%> (+0.02%)` | `44 <0> (ø)` | :arrow_down: |
| [...lin/cube/model/validation/rule/DictionaryRule.java](https://codecov.io/gh/apache/kylin/pull/1057/diff?src=pr&el=tree#diff-Y29yZS1jdWJlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9jdWJlL21vZGVsL3ZhbGlkYXRpb24vcnVsZS9EaWN0aW9uYXJ5UnVsZS5qYXZh) | `86.84% <60%> (-4.59%)` | `16 <1> (+1)` | |
| [...he/kylin/job/impl/threadpool/DefaultScheduler.java](https://codecov.io/gh/apache/kylin/pull/1057/diff?src=pr&el=tree#diff-Y29yZS1qb2Ivc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL2pvYi9pbXBsL3RocmVhZHBvb2wvRGVmYXVsdFNjaGVkdWxlci5qYXZh) | `74.41% <0%> (-2.33%)` | `12% <0%> (ø)` | |
| ... and [3 more](https://codecov.io/gh/apache/kylin/pull/1057/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/kylin/pull/1057?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/kylin/pull/1057?src=pr&el=footer). Last update [2a9aa87...11a80bb](https://codecov.io/gh/apache/kylin/pull/1057?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services