You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@creadur.apache.org by "Chris Burroughs (JIRA)" <ji...@apache.org> on 2014/09/11 16:24:34 UTC
[jira] [Updated] (RAT-174) CDDL1License still very slow
[ https://issues.apache.org/jira/browse/RAT-174?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Chris Burroughs updated RAT-174:
--------------------------------
Attachment: r174.v1.patch
Replace expensive regex patterns with simple text checks
With this change `apache-rat:rat` is approxiatly the same speed with and without CDDL1License checks enabled instead of being an order of magnitude slower.
Note: When developing I noticed that Illumos (the most prominent CDDL project I am aware of) uses a slightly different string than what was in the unit tests. The unit tests all pass, but this is a behavior change. For example some unrelated text and a mention of `https://oss.oracle.com/licenses/CDDL` would no longer match. I don't have enough familiarty with CDDL users to know if even wider variation is common.
> CDDL1License still very slow
> ----------------------------
>
> Key: RAT-174
> URL: https://issues.apache.org/jira/browse/RAT-174
> Project: Apache Rat
> Issue Type: Bug
> Affects Versions: 0.11
> Reporter: Chris Burroughs
> Attachments: r174.v1.patch
>
>
> This is on a laptop, but I think the disparity is large enough that it's sufficient test. With a moderate sized java project [1] `mvn apache-rat:rat` takes over 6 minutes. With `CDDL1License.matches` commented out it takes under 20 seconds.
> See also RAT-162
> [1] https://github.com/addthis/hydra/
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
Re: [jira] [Updated] (RAT-174) CDDL1License still very slow
Posted by Engel Nyst <en...@gmail.com>.
Hi,
On 09/11/2014 05:05 PM, P. Ottlinger wrote:
> since I don't have any clue about CDLL could anyone evaluate whether
> this fix should/could be applied?
>
> Do we need more testcases?
As far as I am aware, CDDL is a MPL variant with rare use, mainly
several bigger (former) Sun projects, such as NetBeans and Glassfish[1],
in addition to OpenSolaris (Illumos).
It might be useful to note, these two are dual-licensed, and the text of
the notices in files is a mixed text specifying both licenses[2], not
the text Rat expects.
SmartOS[3] contains some CDDL-only licensed code.
Just a couple of examples, hope it helps somewhat.
[1] https://java.net/projects/glassfish/sources/v2/show
[2] Example
http://hg.netbeans.org/main/file/70f703f12e62/cloud.oracle/src/org/netbeans/modules/cloud/oracle/DataCenterHandler.java
[3] https://github.com/joyent/smartos-live/blob/master/src/zfs_recv.c
--
~ "We like to think of our forums as a Free-Speech Zone. And freedom
works best at the point of a bayonet." (Amazon, Inc.)
Re: [jira] [Updated] (RAT-174) CDDL1License still very slow
Posted by "P. Ottlinger" <po...@apache.org>.
Hi,
since I don't have any clue about CDLL could anyone evaluate whether
this fix should/could be applied?
Do we need more testcases?
Am 11.09.2014 um 16:24 schrieb Chris Burroughs (JIRA):
> [ https://issues.apache.org/jira/browse/RAT-174?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
>
> Chris Burroughs updated RAT-174:
> --------------------------------
> Attachment: r174.v1.patch
>
> Replace expensive regex patterns with simple text checks
>
> With this change `apache-rat:rat` is approxiatly the same speed with and without CDDL1License checks enabled instead of being an order of magnitude slower.
>
> Note: When developing I noticed that Illumos (the most prominent CDDL project I am aware of) uses a slightly different string than what was in the unit tests. The unit tests all pass, but this is a behavior change. For example some unrelated text and a mention of `https://oss.oracle.com/licenses/CDDL` would no longer match. I don't have enough familiarty with CDDL users to know if even wider variation is common.
Thanks,
Phil