You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tvm.apache.org by GitBox <gi...@apache.org> on 2021/03/31 22:43:49 UTC

[GitHub] [tvm] CircleSpin opened a new pull request #7779: [TVMC] Runner.py Updates

CircleSpin opened a new pull request #7779:
URL: https://github.com/apache/tvm/pull/7779


   
   This PR does three things:
   1) Makes hostname optional in run_module
   2) Makes device mandatory in run_module
   3) Changes the runner time measurements to be in milliseconds rather than seconds (with additional test updates)
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [tvm] CircleSpin commented on pull request #7779: [TVMC] Runner.py Updates

Posted by GitBox <gi...@apache.org>.
CircleSpin commented on pull request #7779:
URL: https://github.com/apache/tvm/pull/7779#issuecomment-811513913


   @jwfromm @mdw-octoml @leandron @comaniac 
   
   Please let me know your thoughts :) 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [tvm] comaniac commented on pull request #7779: [TVMC] Runner.py Updates

Posted by GitBox <gi...@apache.org>.
comaniac commented on pull request #7779:
URL: https://github.com/apache/tvm/pull/7779#issuecomment-811548804


   > @comaniac, if you look at the full function, its already handling `hostname=None` and requiring that `device` is set. The change to the arguments here just more closely matches the actual behavior.
   
   You're right. Yeah then it makes sense to adjust the arguments to align the actual behavior. Then please change the order accordingly and update the type in docstring.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [tvm] jwfromm commented on pull request #7779: [TVMC] Runner.py Updates

Posted by GitBox <gi...@apache.org>.
jwfromm commented on pull request #7779:
URL: https://github.com/apache/tvm/pull/7779#issuecomment-811538135


   @comaniac, if you look at the full function, its already handling `hostname=None` and requiring that `device` is set. The change to the arguments here just more closely matches the actual behavior.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [tvm] jwfromm commented on pull request #7779: [TVMC] Runner.py Updates

Posted by GitBox <gi...@apache.org>.
jwfromm commented on pull request #7779:
URL: https://github.com/apache/tvm/pull/7779#issuecomment-814509610


   Thanks @CircleSpin and @comaniac. This is now merged.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [tvm] comaniac commented on a change in pull request #7779: [TVMC] Runner.py Updates

Posted by GitBox <gi...@apache.org>.
comaniac commented on a change in pull request #7779:
URL: https://github.com/apache/tvm/pull/7779#discussion_r605268380



##########
File path: python/tvm/driver/tvmc/runner.py
##########
@@ -455,13 +455,15 @@ def format_times(times):
     """
 
     # timestamps
-    mean_ts = np.mean(times)
-    std_ts = np.std(times)
-    max_ts = np.max(times)
-    min_ts = np.min(times)
+    mean_ts = np.mean(times) * 1000
+    std_ts = np.std(times) * 1000
+    max_ts = np.max(times) * 1000
+    min_ts = np.min(times) * 1000
 
     header = "Execution time summary:\n{0:^10} {1:^10} {2:^10} {3:^10}".format(
-        "mean (s)", "max (s)", "min (s)", "std (s)"
+        "mean (ms)", "max (ms)", "min (ms)", "std (ms)"
     )
-    stats = "{0:^10.5f} {1:^10.5f} {2:^10.5f} {3:^10.5f}".format(mean_ts, max_ts, min_ts, std_ts)
+    stats = "{0:^10.2f} {1:^10.2f} {2:^10.2f} {3:^10.2f}".format(mean_ts, max_ts, min_ts, std_ts)
+
+    print("%s\n%s\n" % (header, stats))

Review comment:
       Why print?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [tvm] jwfromm merged pull request #7779: [TVMC] Runner.py Updates

Posted by GitBox <gi...@apache.org>.
jwfromm merged pull request #7779:
URL: https://github.com/apache/tvm/pull/7779


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org