You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by alkagin <gi...@git.apache.org> on 2016/06/22 09:52:52 UTC
[GitHub] flink pull request #2144: [FLINK-4097] Cassandra Sink throws NPE on closing ...
GitHub user alkagin opened a pull request:
https://github.com/apache/flink/pull/2144
[FLINK-4097] Cassandra Sink throws NPE on closing if server is not available
[Jira Issue](https://issues.apache.org/jira/browse/FLINK-4097)
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/alkagin/flink FLINK-4097
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/2144.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2144
----
commit 058d5980ac4bf5b729fccbd35a618c9b4c70bb64
Author: Andrea Sella <an...@radicalbit.io>
Date: 2016-06-21T16:12:31Z
[FLINK-4097] Fix NullPointerException on CassandraSinkBase and CassandraTupleWriteAheadSink's close()
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #2144: [FLINK-4097] Cassandra Sink throws NPE on closing if serv...
Posted by zentol <gi...@git.apache.org>.
Github user zentol commented on the issue:
https://github.com/apache/flink/pull/2144
found a minor formatting issue, otherwise +1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #2144: [FLINK-4097] Cassandra Sink throws NPE on closing if serv...
Posted by zentol <gi...@git.apache.org>.
Github user zentol commented on the issue:
https://github.com/apache/flink/pull/2144
merging
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request #2144: [FLINK-4097] Cassandra Sink throws NPE on closing ...
Posted by zentol <gi...@git.apache.org>.
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/2144#discussion_r68026831
--- Diff: flink-streaming-connectors/flink-connector-cassandra/src/main/java/org/apache/flink/streaming/connectors/cassandra/CassandraSinkBase.java ---
@@ -81,12 +81,16 @@ public void invoke(IN value) throws Exception {
@Override
public void close() {
try {
- session.close();
+ if(session != null) {
--- End diff --
missing space after if, the same applie to the other 3 null checks as well
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request #2144: [FLINK-4097] Cassandra Sink throws NPE on closing ...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/flink/pull/2144
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---