[GitHub] [hive] deniskuzZ commented on a diff in pull request #3533: HIVE-26483: Use DDL_NO_LOCK when running iceberg CTAS query

[GitBox <gi...@apache.org>]

deniskuzZ commented on code in PR #3533:
URL: https://github.com/apache/hive/pull/3533#discussion_r949901668


##########
ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java:
##########
@@ -14046,7 +14046,8 @@ private void addDbAndTabToOutputs(String[] qualifiedTabName, TableType type,
       t.setSerdeParam(serdeMap.getKey(), serdeMap.getValue());
     }
     WriteType lockType = tblProps != null && Boolean.parseBoolean(tblProps.get(TABLE_IS_CTAS))
-        && AcidUtils.isExclusiveCTASEnabled(conf) ?
+        && AcidUtils.isExclusiveCTASEnabled(conf)
+        && (t.getStorageHandler() == null || !t.getStorageHandler().directInsertCTAS()) ?

Review Comment:
   could we please add a comment that with this construct we exclude the iceberg?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org