[GitHub] [nifi] ekovacs commented on a change in pull request #4182: NIFI-7318 Allow 'docker stop' to gracefully shutdown

[GitBox <gi...@apache.org>]

ekovacs commented on a change in pull request #4182: NIFI-7318 Allow 'docker stop' to gracefully shutdown
URL: https://github.com/apache/nifi/pull/4182#discussion_r404322732
 
 

 ##########
 File path: nifi-docker/dockerhub/sh/start.sh
 ##########
 @@ -79,11 +79,12 @@ case ${AUTH} in
 esac
 
 # Continuously provide logs so that 'docker logs' can    produce them
-tail -F "${NIFI_HOME}/logs/nifi-app.log" &
 "${NIFI_HOME}/bin/nifi.sh" run &
 nifi_pid="$!"
+tail -F --pid=${nifi_pid} "${NIFI_HOME}/logs/nifi-app.log" &
 
-trap "echo Received trapped signal, beginning shutdown...;" KILL TERM HUP INT EXIT;
+trap 'echo Received trapped signal, beginning shutdown...;./bin/nifi.sh stop;exit 0;' KILL TERM HUP INT;
 
 Review comment:
   I know it is not added in this change, but let's remove `KILL` SIGNAL_SPEC, as trap cannot / nothing can catch sigkill.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services