You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Alexey Serbin (Code Review)" <ge...@cloudera.org> on 2022/05/04 22:38:40 UTC
[kudu-CR] KUDU-2671 implement decoding of RowOperationsPB in Java client
Alexey Serbin has uploaded this change for review. ( http://gerrit.cloudera.org:8080/18494
Change subject: KUDU-2671 implement decoding of RowOperationsPB in Java client
......................................................................
KUDU-2671 implement decoding of RowOperationsPB in Java client
This patch implements decoding of range partitioning information
out of RowOperationsPB. A few tests added as well to cover the
new functionality.
In the context of supporting custom hash schemas per range in the
Kudu Java client, a few follow-up changelists need the newly introduced
functionality.
Change-Id: I4f69f89f6b9e47d79b83c2109d85a95288bec380
---
M java/kudu-client/src/main/java/org/apache/kudu/client/Operation.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestOperation.java
2 files changed, 374 insertions(+), 1 deletion(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/94/18494/1
--
To view, visit http://gerrit.cloudera.org:8080/18494
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I4f69f89f6b9e47d79b83c2109d85a95288bec380
Gerrit-Change-Number: 18494
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <al...@apache.org>
[kudu-CR] KUDU-2671 implement decoding of RowOperationsPB in Java client
Posted by "Attila Bukor (Code Review)" <ge...@cloudera.org>.
Attila Bukor has posted comments on this change. ( http://gerrit.cloudera.org:8080/18494 )
Change subject: KUDU-2671 implement decoding of RowOperationsPB in Java client
......................................................................
Patch Set 6: Code-Review+2
(1 comment)
http://gerrit.cloudera.org:8080/#/c/18494/6/java/kudu-client/src/main/java/org/apache/kudu/client/Operation.java
File java/kudu-client/src/main/java/org/apache/kudu/client/Operation.java:
http://gerrit.cloudera.org:8080/#/c/18494/6/java/kudu-client/src/main/java/org/apache/kudu/client/Operation.java@410
PS6, Line 410: if (col.getType() == Type.STRING || col.getType() == Type.BINARY ||
nit: can you replace this with the new isFixedSize() function as well?
--
To view, visit http://gerrit.cloudera.org:8080/18494
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I4f69f89f6b9e47d79b83c2109d85a95288bec380
Gerrit-Change-Number: 18494
Gerrit-PatchSet: 6
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Mahesh Reddy <mr...@cloudera.com>
Gerrit-Comment-Date: Wed, 11 May 2022 23:23:37 +0000
Gerrit-HasComments: Yes
[kudu-CR] KUDU-2671 implement decoding of RowOperationsPB in Java client
Posted by "Attila Bukor (Code Review)" <ge...@cloudera.org>.
Attila Bukor has posted comments on this change. ( http://gerrit.cloudera.org:8080/18494 )
Change subject: KUDU-2671 implement decoding of RowOperationsPB in Java client
......................................................................
Patch Set 2: Code-Review+2
(1 comment)
http://gerrit.cloudera.org:8080/#/c/18494/2/java/kudu-client/src/main/java/org/apache/kudu/client/Operation.java
File java/kudu-client/src/main/java/org/apache/kudu/client/Operation.java:
http://gerrit.cloudera.org:8080/#/c/18494/2/java/kudu-client/src/main/java/org/apache/kudu/client/Operation.java@618
PS2, Line 618: if (columnType == Type.STRING || columnType == Type.BINARY ||
nit: do you think it's worth refactoring into an isIndirectData() function?
--
To view, visit http://gerrit.cloudera.org:8080/18494
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I4f69f89f6b9e47d79b83c2109d85a95288bec380
Gerrit-Change-Number: 18494
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Mahesh Reddy <mr...@cloudera.com>
Gerrit-Comment-Date: Tue, 10 May 2022 18:02:39 +0000
Gerrit-HasComments: Yes
[kudu-CR] KUDU-2671 implement decoding of RowOperationsPB in Java client
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has removed a vote on this change.
Change subject: KUDU-2671 implement decoding of RowOperationsPB in Java client
......................................................................
Removed Verified-1 by Kudu Jenkins (120)
--
To view, visit http://gerrit.cloudera.org:8080/18494
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: deleteVote
Gerrit-Change-Id: I4f69f89f6b9e47d79b83c2109d85a95288bec380
Gerrit-Change-Number: 18494
Gerrit-PatchSet: 7
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Mahesh Reddy <mr...@cloudera.com>
[kudu-CR] KUDU-2671 implement decoding of RowOperationsPB in Java client
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/18494 )
Change subject: KUDU-2671 implement decoding of RowOperationsPB in Java client
......................................................................
Patch Set 6: Verified+1
unrelated test failure in CatalogManagerConfigurations/MasterStressTest.Test/1
--
To view, visit http://gerrit.cloudera.org:8080/18494
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I4f69f89f6b9e47d79b83c2109d85a95288bec380
Gerrit-Change-Number: 18494
Gerrit-PatchSet: 6
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Mahesh Reddy <mr...@cloudera.com>
Gerrit-Comment-Date: Wed, 11 May 2022 03:19:42 +0000
Gerrit-HasComments: No
[kudu-CR] KUDU-2671 implement decoding of RowOperationsPB in Java client
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Hello Mahesh Reddy, Attila Bukor, Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/18494
to look at the new patch set (#3).
Change subject: KUDU-2671 implement decoding of RowOperationsPB in Java client
......................................................................
KUDU-2671 implement decoding of RowOperationsPB in Java client
This patch implements decoding of range partitioning information
out of RowOperationsPB. A few tests added as well to cover the
new functionality.
In the context of supporting custom hash schemas per range in the
Kudu Java client, a few follow-up changelists need the newly introduced
functionality.
Change-Id: I4f69f89f6b9e47d79b83c2109d85a95288bec380
---
M java/kudu-client/src/main/java/org/apache/kudu/Type.java
M java/kudu-client/src/main/java/org/apache/kudu/client/KeyEncoder.java
M java/kudu-client/src/main/java/org/apache/kudu/client/Operation.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestOperation.java
4 files changed, 519 insertions(+), 16 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/94/18494/3
--
To view, visit http://gerrit.cloudera.org:8080/18494
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I4f69f89f6b9e47d79b83c2109d85a95288bec380
Gerrit-Change-Number: 18494
Gerrit-PatchSet: 3
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Mahesh Reddy <mr...@cloudera.com>
[kudu-CR] KUDU-2671 implement decoding of RowOperationsPB in Java client
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Hello Mahesh Reddy, Attila Bukor, Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/18494
to look at the new patch set (#7).
Change subject: KUDU-2671 implement decoding of RowOperationsPB in Java client
......................................................................
KUDU-2671 implement decoding of RowOperationsPB in Java client
This patch implements decoding of range partitioning information
out of RowOperationsPB. A few tests added as well to cover the
new functionality.
In the context of supporting custom hash schemas per range in the
Kudu Java client, a few follow-up changelists need the newly introduced
functionality.
Change-Id: I4f69f89f6b9e47d79b83c2109d85a95288bec380
---
M java/kudu-client/src/main/java/org/apache/kudu/Type.java
M java/kudu-client/src/main/java/org/apache/kudu/client/KeyEncoder.java
M java/kudu-client/src/main/java/org/apache/kudu/client/Operation.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestOperation.java
4 files changed, 506 insertions(+), 20 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/94/18494/7
--
To view, visit http://gerrit.cloudera.org:8080/18494
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I4f69f89f6b9e47d79b83c2109d85a95288bec380
Gerrit-Change-Number: 18494
Gerrit-PatchSet: 7
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Mahesh Reddy <mr...@cloudera.com>
[kudu-CR] KUDU-2671 implement decoding of RowOperationsPB in Java client
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has removed a vote on this change.
Change subject: KUDU-2671 implement decoding of RowOperationsPB in Java client
......................................................................
Removed Verified-1 by Kudu Jenkins (120)
--
To view, visit http://gerrit.cloudera.org:8080/18494
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: deleteVote
Gerrit-Change-Id: I4f69f89f6b9e47d79b83c2109d85a95288bec380
Gerrit-Change-Number: 18494
Gerrit-PatchSet: 6
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Mahesh Reddy <mr...@cloudera.com>
[kudu-CR] KUDU-2671 implement decoding of RowOperationsPB in Java client
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/18494 )
Change subject: KUDU-2671 implement decoding of RowOperationsPB in Java client
......................................................................
Patch Set 6:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/18494/6/java/kudu-client/src/main/java/org/apache/kudu/client/Operation.java
File java/kudu-client/src/main/java/org/apache/kudu/client/Operation.java:
http://gerrit.cloudera.org:8080/#/c/18494/6/java/kudu-client/src/main/java/org/apache/kudu/client/Operation.java@410
PS6, Line 410: if (col.getType() == Type.STRING || col.getType() == Type.BINARY ||
> nit: can you replace this with the new isFixedSize() function as well?
Whoops, missed this one. Good catch!
Done.
--
To view, visit http://gerrit.cloudera.org:8080/18494
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I4f69f89f6b9e47d79b83c2109d85a95288bec380
Gerrit-Change-Number: 18494
Gerrit-PatchSet: 6
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Mahesh Reddy <mr...@cloudera.com>
Gerrit-Comment-Date: Wed, 11 May 2022 23:48:43 +0000
Gerrit-HasComments: Yes
[kudu-CR] KUDU-2671 implement decoding of RowOperationsPB in Java client
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/18494 )
Change subject: KUDU-2671 implement decoding of RowOperationsPB in Java client
......................................................................
Patch Set 7: Verified+1
unrelated test failures:
DisableWriteWhenExceedingQuotaTest.TestDisableWritePrivilegeWhenExceedingSizeQuota
TestLeaderStepDown.TestRepeatedLeaderStepDown/1
--
To view, visit http://gerrit.cloudera.org:8080/18494
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I4f69f89f6b9e47d79b83c2109d85a95288bec380
Gerrit-Change-Number: 18494
Gerrit-PatchSet: 7
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Mahesh Reddy <mr...@cloudera.com>
Gerrit-Comment-Date: Thu, 12 May 2022 01:35:48 +0000
Gerrit-HasComments: No
[kudu-CR] KUDU-2671 implement decoding of RowOperationsPB in Java client
Posted by "Mahesh Reddy (Code Review)" <ge...@cloudera.org>.
Mahesh Reddy has posted comments on this change. ( http://gerrit.cloudera.org:8080/18494 )
Change subject: KUDU-2671 implement decoding of RowOperationsPB in Java client
......................................................................
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/18494/1/java/kudu-client/src/main/java/org/apache/kudu/client/Operation.java
File java/kudu-client/src/main/java/org/apache/kudu/client/Operation.java:
http://gerrit.cloudera.org:8080/#/c/18494/1/java/kudu-client/src/main/java/org/apache/kudu/client/Operation.java@603
PS1, Line 603: rowsBuf.array()
Should this be 'columnsNullArray' as defined on L601?
--
To view, visit http://gerrit.cloudera.org:8080/18494
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I4f69f89f6b9e47d79b83c2109d85a95288bec380
Gerrit-Change-Number: 18494
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Mahesh Reddy <mr...@cloudera.com>
Gerrit-Comment-Date: Fri, 06 May 2022 06:53:25 +0000
Gerrit-HasComments: Yes
[kudu-CR] KUDU-2671 implement decoding of RowOperationsPB in Java client
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Hello Mahesh Reddy, Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/18494
to look at the new patch set (#2).
Change subject: KUDU-2671 implement decoding of RowOperationsPB in Java client
......................................................................
KUDU-2671 implement decoding of RowOperationsPB in Java client
This patch implements decoding of range partitioning information
out of RowOperationsPB. A few tests added as well to cover the
new functionality.
In the context of supporting custom hash schemas per range in the
Kudu Java client, a few follow-up changelists need the newly introduced
functionality.
Change-Id: I4f69f89f6b9e47d79b83c2109d85a95288bec380
---
M java/kudu-client/src/main/java/org/apache/kudu/client/Operation.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestOperation.java
2 files changed, 489 insertions(+), 1 deletion(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/94/18494/2
--
To view, visit http://gerrit.cloudera.org:8080/18494
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I4f69f89f6b9e47d79b83c2109d85a95288bec380
Gerrit-Change-Number: 18494
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Mahesh Reddy <mr...@cloudera.com>
[kudu-CR] KUDU-2671 implement decoding of RowOperationsPB in Java client
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/18494 )
Change subject: KUDU-2671 implement decoding of RowOperationsPB in Java client
......................................................................
Patch Set 2:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/18494/2/java/kudu-client/src/main/java/org/apache/kudu/client/Operation.java
File java/kudu-client/src/main/java/org/apache/kudu/client/Operation.java:
http://gerrit.cloudera.org:8080/#/c/18494/2/java/kudu-client/src/main/java/org/apache/kudu/client/Operation.java@618
PS2, Line 618: if (columnType == Type.STRING || columnType == Type.BINARY ||
> nit: do you think it's worth refactoring into an isIndirectData() function?
Good idea! Done.
--
To view, visit http://gerrit.cloudera.org:8080/18494
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I4f69f89f6b9e47d79b83c2109d85a95288bec380
Gerrit-Change-Number: 18494
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Mahesh Reddy <mr...@cloudera.com>
Gerrit-Comment-Date: Tue, 10 May 2022 23:25:26 +0000
Gerrit-HasComments: Yes
[kudu-CR] KUDU-2671 implement decoding of RowOperationsPB in Java client
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Hello Mahesh Reddy, Attila Bukor, Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/18494
to look at the new patch set (#5).
Change subject: KUDU-2671 implement decoding of RowOperationsPB in Java client
......................................................................
KUDU-2671 implement decoding of RowOperationsPB in Java client
This patch implements decoding of range partitioning information
out of RowOperationsPB. A few tests added as well to cover the
new functionality.
In the context of supporting custom hash schemas per range in the
Kudu Java client, a few follow-up changelists need the newly introduced
functionality.
Change-Id: I4f69f89f6b9e47d79b83c2109d85a95288bec380
---
M java/kudu-client/src/main/java/org/apache/kudu/Type.java
M java/kudu-client/src/main/java/org/apache/kudu/client/KeyEncoder.java
M java/kudu-client/src/main/java/org/apache/kudu/client/Operation.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestOperation.java
4 files changed, 502 insertions(+), 9 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/94/18494/5
--
To view, visit http://gerrit.cloudera.org:8080/18494
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I4f69f89f6b9e47d79b83c2109d85a95288bec380
Gerrit-Change-Number: 18494
Gerrit-PatchSet: 5
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Mahesh Reddy <mr...@cloudera.com>
[kudu-CR] KUDU-2671 implement decoding of RowOperationsPB in Java client
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/18494 )
Change subject: KUDU-2671 implement decoding of RowOperationsPB in Java client
......................................................................
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/18494/1/java/kudu-client/src/main/java/org/apache/kudu/client/Operation.java
File java/kudu-client/src/main/java/org/apache/kudu/client/Operation.java:
http://gerrit.cloudera.org:8080/#/c/18494/1/java/kudu-client/src/main/java/org/apache/kudu/client/Operation.java@603
PS1, Line 603: rowsBuf.array()
> Should this be 'columnsNullArray' as defined on L601?
Good catch! Indeed, this is a typo.
--
To view, visit http://gerrit.cloudera.org:8080/18494
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I4f69f89f6b9e47d79b83c2109d85a95288bec380
Gerrit-Change-Number: 18494
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Mahesh Reddy <mr...@cloudera.com>
Gerrit-Comment-Date: Fri, 06 May 2022 18:14:10 +0000
Gerrit-HasComments: Yes
[kudu-CR] KUDU-2671 implement decoding of RowOperationsPB in Java client
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Hello Mahesh Reddy, Attila Bukor, Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/18494
to look at the new patch set (#6).
Change subject: KUDU-2671 implement decoding of RowOperationsPB in Java client
......................................................................
KUDU-2671 implement decoding of RowOperationsPB in Java client
This patch implements decoding of range partitioning information
out of RowOperationsPB. A few tests added as well to cover the
new functionality.
In the context of supporting custom hash schemas per range in the
Kudu Java client, a few follow-up changelists need the newly introduced
functionality.
Change-Id: I4f69f89f6b9e47d79b83c2109d85a95288bec380
---
M java/kudu-client/src/main/java/org/apache/kudu/Type.java
M java/kudu-client/src/main/java/org/apache/kudu/client/KeyEncoder.java
M java/kudu-client/src/main/java/org/apache/kudu/client/Operation.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestOperation.java
4 files changed, 503 insertions(+), 15 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/94/18494/6
--
To view, visit http://gerrit.cloudera.org:8080/18494
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I4f69f89f6b9e47d79b83c2109d85a95288bec380
Gerrit-Change-Number: 18494
Gerrit-PatchSet: 6
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Mahesh Reddy <mr...@cloudera.com>
[kudu-CR] KUDU-2671 implement decoding of RowOperationsPB in Java client
Posted by "Mahesh Reddy (Code Review)" <ge...@cloudera.org>.
Mahesh Reddy has posted comments on this change. ( http://gerrit.cloudera.org:8080/18494 )
Change subject: KUDU-2671 implement decoding of RowOperationsPB in Java client
......................................................................
Patch Set 7: Code-Review+1
--
To view, visit http://gerrit.cloudera.org:8080/18494
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I4f69f89f6b9e47d79b83c2109d85a95288bec380
Gerrit-Change-Number: 18494
Gerrit-PatchSet: 7
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Mahesh Reddy <mr...@cloudera.com>
Gerrit-Comment-Date: Thu, 12 May 2022 00:04:44 +0000
Gerrit-HasComments: No
[kudu-CR] KUDU-2671 implement decoding of RowOperationsPB in Java client
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Hello Mahesh Reddy, Attila Bukor, Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/18494
to look at the new patch set (#4).
Change subject: KUDU-2671 implement decoding of RowOperationsPB in Java client
......................................................................
KUDU-2671 implement decoding of RowOperationsPB in Java client
This patch implements decoding of range partitioning information
out of RowOperationsPB. A few tests added as well to cover the
new functionality.
In the context of supporting custom hash schemas per range in the
Kudu Java client, a few follow-up changelists need the newly introduced
functionality.
Change-Id: I4f69f89f6b9e47d79b83c2109d85a95288bec380
---
M java/kudu-client/src/main/java/org/apache/kudu/Type.java
M java/kudu-client/src/main/java/org/apache/kudu/client/KeyEncoder.java
M java/kudu-client/src/main/java/org/apache/kudu/client/Operation.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestOperation.java
4 files changed, 502 insertions(+), 9 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/94/18494/4
--
To view, visit http://gerrit.cloudera.org:8080/18494
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I4f69f89f6b9e47d79b83c2109d85a95288bec380
Gerrit-Change-Number: 18494
Gerrit-PatchSet: 4
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Mahesh Reddy <mr...@cloudera.com>
[kudu-CR] KUDU-2671 implement decoding of RowOperationsPB in Java client
Posted by "Mahesh Reddy (Code Review)" <ge...@cloudera.org>.
Mahesh Reddy has posted comments on this change. ( http://gerrit.cloudera.org:8080/18494 )
Change subject: KUDU-2671 implement decoding of RowOperationsPB in Java client
......................................................................
Patch Set 6: Code-Review+1
--
To view, visit http://gerrit.cloudera.org:8080/18494
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I4f69f89f6b9e47d79b83c2109d85a95288bec380
Gerrit-Change-Number: 18494
Gerrit-PatchSet: 6
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Mahesh Reddy <mr...@cloudera.com>
Gerrit-Comment-Date: Wed, 11 May 2022 06:52:22 +0000
Gerrit-HasComments: No
[kudu-CR] KUDU-2671 implement decoding of RowOperationsPB in Java client
Posted by "Attila Bukor (Code Review)" <ge...@cloudera.org>.
Attila Bukor has posted comments on this change. ( http://gerrit.cloudera.org:8080/18494 )
Change subject: KUDU-2671 implement decoding of RowOperationsPB in Java client
......................................................................
Patch Set 7: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/18494
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I4f69f89f6b9e47d79b83c2109d85a95288bec380
Gerrit-Change-Number: 18494
Gerrit-PatchSet: 7
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Mahesh Reddy <mr...@cloudera.com>
Gerrit-Comment-Date: Wed, 11 May 2022 23:50:27 +0000
Gerrit-HasComments: No
[kudu-CR] KUDU-2671 implement decoding of RowOperationsPB in Java client
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/18494 )
Change subject: KUDU-2671 implement decoding of RowOperationsPB in Java client
......................................................................
KUDU-2671 implement decoding of RowOperationsPB in Java client
This patch implements decoding of range partitioning information
out of RowOperationsPB. A few tests added as well to cover the
new functionality.
In the context of supporting custom hash schemas per range in the
Kudu Java client, a few follow-up changelists need the newly introduced
functionality.
Change-Id: I4f69f89f6b9e47d79b83c2109d85a95288bec380
Reviewed-on: http://gerrit.cloudera.org:8080/18494
Reviewed-by: Attila Bukor <ab...@apache.org>
Reviewed-by: Mahesh Reddy <mr...@cloudera.com>
Tested-by: Alexey Serbin <al...@apache.org>
---
M java/kudu-client/src/main/java/org/apache/kudu/Type.java
M java/kudu-client/src/main/java/org/apache/kudu/client/KeyEncoder.java
M java/kudu-client/src/main/java/org/apache/kudu/client/Operation.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestOperation.java
4 files changed, 506 insertions(+), 20 deletions(-)
Approvals:
Attila Bukor: Looks good to me, approved
Mahesh Reddy: Looks good to me, but someone else must approve
Alexey Serbin: Verified
--
To view, visit http://gerrit.cloudera.org:8080/18494
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I4f69f89f6b9e47d79b83c2109d85a95288bec380
Gerrit-Change-Number: 18494
Gerrit-PatchSet: 8
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Mahesh Reddy <mr...@cloudera.com>