Review board troubles

[Brenden Matthews <br...@airbedandbreakfast.com>]

Hey guys,

I'm not having a lot of success with review board and the post-reviews or
support/post-reviews.py scripts.  The current patches in review board don't
accurately reflect the state of my working tree.  When I try to run
support/post-reviews.py it doesn't correctly update the patches and I'm not
able to invest time into debugging why.

I'll be away for a week, so I'm writing this to let you know that you
shouldn't bother reviewing the patches in review board right now.  If you
want to see the current state of my work, you can get it from
https://github.com/airbnb/mesos/tree/testing.

Best,

Brenden

Re: Review board troubles

[Vinod Kone <vi...@gmail.com>]

Can you tell us your work flow of submitting a patch and how your git
branch looks before submitting? That will let us help you out?

FWIW, with mesos recently moving to git (from svn), there were some issues
with submitting patches with support/post-reviews.py.

This is what I had to do get it working again:

--> Got the latest support/post-reviews.py from master.
--> Manually deleted "Review: " lines from my pending commits. Note: If you
do this, new reviews will be created for patches, which means you will want
to discard old reviews.



On Wed, May 15, 2013 at 5:40 PM, Brenden Matthews <
brenden.matthews@airbedandbreakfast.com> wrote:

> Hey guys,
>
> I'm not having a lot of success with review board and the post-reviews or
> support/post-reviews.py scripts.  The current patches in review board don't
> accurately reflect the state of my working tree.  When I try to run
> support/post-reviews.py it doesn't correctly update the patches and I'm not
> able to invest time into debugging why.
>
> I'll be away for a week, so I'm writing this to let you know that you
> shouldn't bother reviewing the patches in review board right now.  If you
> want to see the current state of my work, you can get it from
> https://github.com/airbnb/mesos/tree/testing.
>
> Best,
>
> Brenden
>

Re: Review board troubles

["Mattmann, Chris A (398J)" <ch...@jpl.nasa.gov>]

Thanks Brenden.

The canonical Git repo/sources for Apache Mesos are at:

http://git-wip-us.apache.org/repos/asf/incubator-mesos.git


(committers use 'https' instead of 'http').

Feel free to use that as the source, are you pointing at Github
b/c you want folks to review?

Cheers,
Chris

++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Chris Mattmann, Ph.D.
Senior Computer Scientist
NASA Jet Propulsion Laboratory Pasadena, CA 91109 USA
Office: 171-266B, Mailstop: 171-246
Email: chris.a.mattmann@nasa.gov
WWW:  http://sunset.usc.edu/~mattmann/
++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Adjunct Assistant Professor, Computer Science Department
University of Southern California, Los Angeles, CA 90089 USA
++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++






-----Original Message-----
From: Brenden Matthews <br...@airbedandbreakfast.com>
Reply-To: "mesos-dev@incubator.apache.org" <me...@incubator.apache.org>
Date: Wednesday, May 15, 2013 5:40 PM
To: "mesos-dev@incubator.apache.org" <me...@incubator.apache.org>
Subject: Review board troubles

>Hey guys,
>
>I'm not having a lot of success with review board and the post-reviews or
>support/post-reviews.py scripts.  The current patches in review board
>don't
>accurately reflect the state of my working tree.  When I try to run
>support/post-reviews.py it doesn't correctly update the patches and I'm
>not
>able to invest time into debugging why.
>
>I'll be away for a week, so I'm writing this to let you know that you
>shouldn't bother reviewing the patches in review board right now.  If you
>want to see the current state of my work, you can get it from
>https://github.com/airbnb/mesos/tree/testing.
>
>Best,
>
>Brenden