You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@fineract.apache.org by GitBox <gi...@apache.org> on 2021/10/20 14:02:04 UTC
[GitHub] [fineract] sheminanto opened a new pull request #1918: FINERACT-1414 :Added subEntityType in global search result
sheminanto opened a new pull request #1918:
URL: https://github.com/apache/fineract/pull/1918
## Description
Added sub entity type in global search result in order to view fixeddeposit, savings, recurring deposit in their corresponding pages.
Ignore if these details are present on the associated [Apache Fineract JIRA ticket](https://github.com/apache/fineract/pull/1284).
## Checklist
Please make sure these boxes are checked before submitting your pull request - thanks!
- [x] Write the commit message as per https://github.com/apache/fineract/#pull-requests
- [x] Acknowledge that we will not review PRs that are not passing the build _("green")_ - it is your responsibility to get a proposed PR to pass the build, not primarily the project's maintainers.
- [ ] Create/update unit or integration tests for verifying the changes made.
- [x] Follow coding conventions at https://cwiki.apache.org/confluence/display/FINERACT/Coding+Conventions.
- [ ] Add required Swagger annotation and update API documentation at fineract-provider/src/main/resources/static/api-docs/apiLive.htm with details of any API changes
- [ ] Submission is not a "code dump". (Large changes can be made "in repository" via a branch. Ask on the developer mailing list for guidance, if required.)
FYI our guidelines for code reviews are at https://cwiki.apache.org/confluence/display/FINERACT/Code+Review+Guide.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] IOhacker commented on pull request #1918: FINERACT-1414 :Added subEntityType in global search result
Posted by GitBox <gi...@apache.org>.
IOhacker commented on pull request #1918:
URL: https://github.com/apache/fineract/pull/1918#issuecomment-949249144
Hello,
Now the building is completed. I will check the message about the SonarQube
Analysis about this message:
Quality Gate failed
[image: Failed condition]
<https://sonarcloud.io/dashboard?id=apache_fineract&branch=develop> [image:
0.0%] <https://sonarcloud.io/dashboard?id=apache_fineract&branch=develop> 0.0%
Security Hotspots Reviewed on New Code (is less than 100%)
[image: Failed condition]
<https://sonarcloud.io/dashboard?id=apache_fineract&branch=develop> [image:
0.0%] <https://sonarcloud.io/dashboard?id=apache_fineract&branch=develop> 0.0%
Coverage on New Code (is less than 80%)
El jue, 21 oct 2021 a las 17:01, VICTOR MANUEL ROMERO RODRIGUEZ (<
***@***.***>) escribió:
> Adding travis_wait variable to SonarQube analysis (FINERACT-1409)
>
> https://github.com/apache/fineract/pull/1922
>
> El jue, 21 oct 2021 a las 14:56, VICTOR MANUEL ROMERO RODRIGUEZ (<
> ***@***.***>) escribió:
>
>> Now checking
>>
>> El jue., 21 de octubre de 2021 2:34 p. m., Awasum Yannick <
>> ***@***.***> escribió:
>>
>>> Travis is refusing to run. @IOhacker <https://github.com/IOhacker> ,
>>> @ptuomola <https://github.com/ptuomola> any ideas?
>>>
>>> —
>>> You are receiving this because you were mentioned.
>>> Reply to this email directly, view it on GitHub
>>> <https://github.com/apache/fineract/pull/1918#issuecomment-948938756>,
>>> or unsubscribe
>>> <https://github.com/notifications/unsubscribe-auth/ALD2ZAR3YXPPHBXMTAPIHUTUIBTMJANCNFSM5GLXJ5ZA>
>>> .
>>> Triage notifications on the go with GitHub Mobile for iOS
>>> <https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675>
>>> or Android
>>> <https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.
>>>
>>>
>>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] awasum commented on pull request #1918: FINERACT-1414 :Added subEntityType in global search result
Posted by GitBox <gi...@apache.org>.
awasum commented on pull request #1918:
URL: https://github.com/apache/fineract/pull/1918#issuecomment-951834271
Closing JIRA issue as this has been merged: https://issues.apache.org/jira/browse/FINERACT-1414
Thank you @sheminanto for the fix.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] awasum commented on pull request #1918: FINERACT-1414 :Added subEntityType in global search result
Posted by GitBox <gi...@apache.org>.
awasum commented on pull request #1918:
URL: https://github.com/apache/fineract/pull/1918#issuecomment-948849131
Hello @sheminanto .. one tests is failing.. Please can you help fix it so Travis can pass? https://app.travis-ci.com/github/apache/fineract/builds/240240273
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] awasum closed pull request #1918: FINERACT-1414 :Added subEntityType in global search result
Posted by GitBox <gi...@apache.org>.
awasum closed pull request #1918:
URL: https://github.com/apache/fineract/pull/1918
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] ptuomola closed pull request #1918: FINERACT-1414 :Added subEntityType in global search result
Posted by GitBox <gi...@apache.org>.
ptuomola closed pull request #1918:
URL: https://github.com/apache/fineract/pull/1918
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] awasum commented on pull request #1918: FINERACT-1414 :Added subEntityType in global search result
Posted by GitBox <gi...@apache.org>.
awasum commented on pull request #1918:
URL: https://github.com/apache/fineract/pull/1918#issuecomment-948938756
Travis is refusing to run. @IOhacker , @ptuomola any ideas?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] sheminanto closed pull request #1918: FINERACT-1414 :Added subEntityType in global search result
Posted by GitBox <gi...@apache.org>.
sheminanto closed pull request #1918:
URL: https://github.com/apache/fineract/pull/1918
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] awasum commented on pull request #1918: FINERACT-1414 :Added subEntityType in global search result
Posted by GitBox <gi...@apache.org>.
awasum commented on pull request #1918:
URL: https://github.com/apache/fineract/pull/1918#issuecomment-948940719
Please, dont merge this.. Tests have not passed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] ptuomola merged pull request #1918: FINERACT-1414 :Added subEntityType in global search result
Posted by GitBox <gi...@apache.org>.
ptuomola merged pull request #1918:
URL: https://github.com/apache/fineract/pull/1918
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] awasum commented on pull request #1918: FINERACT-1414 :Added subEntityType in global search result
Posted by GitBox <gi...@apache.org>.
awasum commented on pull request #1918:
URL: https://github.com/apache/fineract/pull/1918#issuecomment-950124698
I wonder if there is a test for Global search? @sheminanto will you like to add one?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] IOhacker commented on pull request #1918: FINERACT-1414 :Added subEntityType in global search result
Posted by GitBox <gi...@apache.org>.
IOhacker commented on pull request #1918:
URL: https://github.com/apache/fineract/pull/1918#issuecomment-949035301
Adding travis_wait variable to SonarQube analysis (FINERACT-1409)
https://github.com/apache/fineract/pull/1922
El jue, 21 oct 2021 a las 14:56, VICTOR MANUEL ROMERO RODRIGUEZ (<
***@***.***>) escribió:
> Now checking
>
> El jue., 21 de octubre de 2021 2:34 p. m., Awasum Yannick <
> ***@***.***> escribió:
>
>> Travis is refusing to run. @IOhacker <https://github.com/IOhacker> ,
>> @ptuomola <https://github.com/ptuomola> any ideas?
>>
>> —
>> You are receiving this because you were mentioned.
>> Reply to this email directly, view it on GitHub
>> <https://github.com/apache/fineract/pull/1918#issuecomment-948938756>,
>> or unsubscribe
>> <https://github.com/notifications/unsubscribe-auth/ALD2ZAR3YXPPHBXMTAPIHUTUIBTMJANCNFSM5GLXJ5ZA>
>> .
>> Triage notifications on the go with GitHub Mobile for iOS
>> <https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675>
>> or Android
>> <https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.
>>
>>
>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] awasum commented on pull request #1918: FINERACT-1414 :Added subEntityType in global search result
Posted by GitBox <gi...@apache.org>.
awasum commented on pull request #1918:
URL: https://github.com/apache/fineract/pull/1918#issuecomment-950124595
Travis taking 84 minutes to build or is it counting queue period? Or did I misunderstand?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] ptuomola commented on pull request #1918: FINERACT-1414 :Added subEntityType in global search result
Posted by GitBox <gi...@apache.org>.
ptuomola commented on pull request #1918:
URL: https://github.com/apache/fineract/pull/1918#issuecomment-950037918
> Travis is refusing to run. @IOhacker , @ptuomola any ideas?
There was a problem earlier with Apache's account with Travis - some quota exceeded. Let me try to close/reopen to see if it works now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] ptuomola commented on pull request #1918: FINERACT-1414 :Added subEntityType in global search result
Posted by GitBox <gi...@apache.org>.
ptuomola commented on pull request #1918:
URL: https://github.com/apache/fineract/pull/1918#issuecomment-950038018
Ok now a Travis build got triggered. Let's see if it succeeds.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] IOhacker commented on pull request #1918: FINERACT-1414 :Added subEntityType in global search result
Posted by GitBox <gi...@apache.org>.
IOhacker commented on pull request #1918:
URL: https://github.com/apache/fineract/pull/1918#issuecomment-948956636
Now checking
El jue., 21 de octubre de 2021 2:34 p. m., Awasum Yannick <
***@***.***> escribió:
> Travis is refusing to run. @IOhacker <https://github.com/IOhacker> ,
> @ptuomola <https://github.com/ptuomola> any ideas?
>
> —
> You are receiving this because you were mentioned.
> Reply to this email directly, view it on GitHub
> <https://github.com/apache/fineract/pull/1918#issuecomment-948938756>, or
> unsubscribe
> <https://github.com/notifications/unsubscribe-auth/ALD2ZAR3YXPPHBXMTAPIHUTUIBTMJANCNFSM5GLXJ5ZA>
> .
> Triage notifications on the go with GitHub Mobile for iOS
> <https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675>
> or Android
> <https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.
>
>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org