You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@echarts.apache.org by sh...@apache.org on 2020/03/18 14:41:05 UTC

[incubator-echarts] 02/02: Merge from release. add missing merged file

This is an automated email from the ASF dual-hosted git repository.

shenyi pushed a commit to branch typescript
in repository https://gitbox.apache.org/repos/asf/incubator-echarts.git

commit 469259df22b746e84b7e47a44a41f0653acb71c3
Author: pissang <bm...@gmail.com>
AuthorDate: Wed Mar 18 22:40:11 2020 +0800

    Merge from release. add missing merged file
---
 src/coord/radar/Radar.ts | 17 +++++++----------
 1 file changed, 7 insertions(+), 10 deletions(-)

diff --git a/src/coord/radar/Radar.ts b/src/coord/radar/Radar.ts
index 2d6da96..14d40f7 100644
--- a/src/coord/radar/Radar.ts
+++ b/src/coord/radar/Radar.ts
@@ -204,7 +204,7 @@ class Radar implements CoordinateSystem, CoordinateSystemMaster {
                 );
             }
             else if (fixedMin != null) {
-                var max;
+                let max;
                 // User set min, expand extent on the other side
                 do {
                     max = fixedMin + interval * splitNumber;
@@ -217,7 +217,7 @@ class Radar implements CoordinateSystem, CoordinateSystemMaster {
                 } while (max < rawExtent[1] && isFinite(max) && isFinite(rawExtent[1]));
             }
             else if (fixedMax != null) {
-                var min;
+                let min;
                 // User set min, expand extent on the other side
                 do {
                     min = fixedMax - interval * splitNumber;
@@ -227,17 +227,14 @@ class Radar implements CoordinateSystem, CoordinateSystemMaster {
                 } while (min > rawExtent[0] && isFinite(min) && isFinite(rawExtent[0]));
             }
             else {
-                var nicedSplitNumber = scale.getTicks().length - 1;
+                const nicedSplitNumber = scale.getTicks().length - 1;
                 if (nicedSplitNumber > splitNumber) {
                     interval = increaseInterval(interval);
                 }
-                // PENDING
-                var center = Math.ceil((rawExtent[0] + rawExtent[1]) / 2 / interval) * interval;
-                var halfSplitNumber = Math.round(splitNumber / 2);
-                scale.setExtent(
-                    numberUtil.round(center - halfSplitNumber * interval),
-                    numberUtil.round(center + (splitNumber - halfSplitNumber) * interval)
-                );
+                // TODO
+                const max = Math.ceil(rawExtent[1] / interval) * interval;
+                const min = numberUtil.round(max - interval * splitNumber);
+                scale.setExtent(min, max);
                 scale.setInterval(interval);
             }
         });


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org