You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Tim Armstrong (Code Review)" <ge...@cloudera.org> on 2019/09/26 21:40:04 UTC
[Impala-ASF-CR] IMPALA-8451,IMPALA-8905: enable admission control for dockerised tests
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/13942 )
Change subject: IMPALA-8451,IMPALA-8905: enable admission control for dockerised tests
......................................................................
Patch Set 17:
(2 comments)
http://gerrit.cloudera.org:8080/#/c/13942/17//COMMIT_MSG
Commit Message:
http://gerrit.cloudera.org:8080/#/c/13942/17//COMMIT_MSG@27
PS17, Line 27: Added observability for the configured queue wait time for each pool.
> This also takes care of IMPALA-8905
Done
http://gerrit.cloudera.org:8080/#/c/13942/17/fe/src/test/resources/minicluster-llama-site.xml
File fe/src/test/resources/minicluster-llama-site.xml:
http://gerrit.cloudera.org:8080/#/c/13942/17/fe/src/test/resources/minicluster-llama-site.xml@3
PS17, Line 3: <property>
: <name>impala.admission-control.max-query-mem-limit.root.default</name>
: <value>4294967296</value><!--4GB-->
: </property>
: <property>
: <name>impala.admission-control.min-query-mem-limit.root.default</name>
: <value>268435
> nit: any reason for these specific values?
Elaborated a little bit on how I picked them. There wasn't a lot of science to it.
--
To view, visit http://gerrit.cloudera.org:8080/13942
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7517673f9e348780fcf7cd6ce1f12c9c5a55373a
Gerrit-Change-Number: 13942
Gerrit-PatchSet: 17
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Andrew Sherman <as...@cloudera.com>
Gerrit-Reviewer: Bikramjeet Vig <bi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Thu, 26 Sep 2019 21:40:04 +0000
Gerrit-HasComments: Yes