[GitHub] [gobblin] Will-Lo commented on a change in pull request #3381: [GOBBLIN-1530] Add error reporting for missing source nodes that may not exist

[GitBox <gi...@apache.org>]

Will-Lo commented on a change in pull request #3381:
URL: https://github.com/apache/gobblin/pull/3381#discussion_r700661656



##########
File path: gobblin-service/src/test/java/org/apache/gobblin/service/modules/flow/MultiHopFlowCompilerTest.java
##########
@@ -670,6 +670,28 @@ public void testUnresolvedFlow() throws Exception {
     spec.getCompilationErrors().stream().anyMatch(s -> s.contains(AzkabanProjectConfig.USER_TO_PROXY));
   }
 
+  @Test (dependsOnMethods = "testUnresolvedFlow")
+  public void testMissingSourceNodeError() throws Exception {
+    FlowSpec spec = createFlowSpec("flow/flow5.conf", "HDFS-NULL", "HDFS-3", false, false);
+
+    Dag<JobExecutionPlan> dag = specCompiler.compileFlow(spec);
+
+    Assert.assertEquals(dag, null);
+    Assert.assertEquals(spec.getCompilationErrors().size(), 1);
+    spec.getCompilationErrors().stream().anyMatch(s -> s.contains("Flowgraph does not have a node with id"));
+  }
+
+  @Test (dependsOnMethods = "testMissingSourceNodeError")
+  public void testMissingDestinationNodeError() throws Exception {

Review comment:
       Ah my bad I added that way too fast, good catch




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@gobblin.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org