You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@royale.apache.org by Christofer Dutz <ch...@c-ware.de> on 2021/03/05 09:10:17 UTC
PRs ready for distribution alignment
Hi all,
I have, as far as I know, finished the work on aligning the Maven built and the Ant built distribution.
A few things have changed in the Maven distribution compared to the earlier ones:
* All scripts (in the bin and js/bin) directory are now identical to the ones in the Ant distribution.
* The manifests are no longer contained in a "manifests" directory but are in the same location as they are for the Ant build.
* I now include the sources of the projects, which should simplify debugging.
The probably most important change is that I no longer have copies of the scripts and main manifests in the distribution resources. These resources now only contain the empty dummy files needed by FlashBuilder. It seems these were updated in the project, but the copies weren't. Therefore, the scripts as well as the manifests weren't identical in Ant and Maven distributions. I solved that problem by now taking the exact same files and copying them in the assembly. The manifests needed minor tweaking which I am now doing via an XSLT in the build.
Also did I refactor everything just needed for FlashBuilder support out into a separate assembly file. This way we have all the stuff that doesn't seem to make sense in one place and if we should decide to drop FB support, we just need to remove that assembly descriptor.
Would be cool if you could give the changes a try.
Please note that you need to checkout the feature branch "feature/distribution" in both the compiler as well as the asjs repo (For some reason my addition of the ACE typedef seems to have gone to the develop branch of the typedef repo, so it should already be available.
Hope you like the changes and hope they work for you the same way they do for me (I think Carlos also reported that he was successfully able to compile every example he tried in VSCode with it)
The two PRs needing merging after review are:
Feature/distribution allignment by chrisdutz * Pull Request #180 * apache/royale-compiler (github.com)<https://github.com/apache/royale-compiler/pull/180>
Feature/distribution allignment by chrisdutz * Pull Request #1087 * apache/royale-asjs (github.com)<https://github.com/apache/royale-asjs/pull/1087>
Chris
Re: PRs ready for distribution alignment
Posted by Piotr Zarzycki <pi...@gmail.com>.
Actually what I posted is full stacktrace. ;)
pt., 5 mar 2021 o 12:19 Piotr Zarzycki <pi...@gmail.com>
napisał(a):
> Hi Chris,
>
> Thanks for all work. After rebuilding whole framework I just tried produce
> distribution by going to the folder of it and do:
>
> mvn clean install
> -DdistributionTargetFolder=d:\Work\royale_ide\distribution
>
> It works without doing set
> distributionTargetFolder=d:\Work\royale_ide\distribution.
>
> I went to Moonshine and tried to build with produced distribution our
> project and I got following errors - I won't post here full stacktrace [1]
>
> [1] https://paste.apache.org/c2qv1
>
> Thanks,
> Piotr
>
>
>
>
>
>
>
>
> pt., 5 mar 2021 o 10:10 Christofer Dutz <ch...@c-ware.de>
> napisał(a):
>
>> Hi all,
>>
>> I have, as far as I know, finished the work on aligning the Maven built
>> and the Ant built distribution.
>> A few things have changed in the Maven distribution compared to the
>> earlier ones:
>>
>>
>> * All scripts (in the bin and js/bin) directory are now identical to
>> the ones in the Ant distribution.
>> * The manifests are no longer contained in a "manifests" directory
>> but are in the same location as they are for the Ant build.
>> * I now include the sources of the projects, which should simplify
>> debugging.
>>
>> The probably most important change is that I no longer have copies of the
>> scripts and main manifests in the distribution resources. These resources
>> now only contain the empty dummy files needed by FlashBuilder. It seems
>> these were updated in the project, but the copies weren't. Therefore, the
>> scripts as well as the manifests weren't identical in Ant and Maven
>> distributions. I solved that problem by now taking the exact same files and
>> copying them in the assembly. The manifests needed minor tweaking which I
>> am now doing via an XSLT in the build.
>>
>> Also did I refactor everything just needed for FlashBuilder support out
>> into a separate assembly file. This way we have all the stuff that doesn't
>> seem to make sense in one place and if we should decide to drop FB support,
>> we just need to remove that assembly descriptor.
>>
>> Would be cool if you could give the changes a try.
>>
>> Please note that you need to checkout the feature branch
>> "feature/distribution" in both the compiler as well as the asjs repo (For
>> some reason my addition of the ACE typedef seems to have gone to the
>> develop branch of the typedef repo, so it should already be available.
>>
>> Hope you like the changes and hope they work for you the same way they do
>> for me (I think Carlos also reported that he was successfully able to
>> compile every example he tried in VSCode with it)
>>
>> The two PRs needing merging after review are:
>> Feature/distribution allignment by chrisdutz * Pull Request #180 *
>> apache/royale-compiler (github.com)<
>> https://github.com/apache/royale-compiler/pull/180>
>> Feature/distribution allignment by chrisdutz * Pull Request #1087 *
>> apache/royale-asjs (github.com)<
>> https://github.com/apache/royale-asjs/pull/1087>
>>
>>
>> Chris
>>
>>
>
> --
>
> Piotr Zarzycki
>
--
Piotr Zarzycki
AW: PRs ready for distribution alignment
Posted by Christofer Dutz <ch...@c-ware.de>.
Hi Piotr,
if you don't enable the "option-with-swf" it's the JS-only version.
The reason for setting things up that way 5 years ago, was that we then knew that SWF was going to be fading out and JS to be the new standard.
So, we chose the default to work without having to accept Adobe License Agreements and build the JS-only version per default.
So, in order to build the full thing including SWF support, run this instead:
mvn clean install -DdistributionTargetFolder=d:\Work\royale_ide\distribution -Poption-with-swf
Chris
-----Ursprüngliche Nachricht-----
Von: Piotr Zarzycki <pi...@gmail.com>
Gesendet: Sonntag, 7. März 2021 13:13
An: dev@royale.apache.org
Betreff: Re: PRs ready for distribution alignment
Chris,
I have used on Friday version which has been build with following command:
mvn clean install -DdistributionTargetFolder=d:\Work\royale_ide\distribution
Which one is that ?
If this command build swf version - I think default should be ja only.
Thanks,
Piotr
On Sun, 7 Mar 2021 at 13:03, Christofer Dutz <ch...@c-ware.de>
wrote:
> Hi all,
>
> I just pushed some changes handing the "without-swf" version.
> I now create the dummy files the FlashBuilder seems to require.
> Also does the build now clean out the "library-path" for the
> without-swf version.
>
> So, it should now be more aligned with the Ant build.
>
> @Piotr ... Are you still using the "without-swf/JS-only" distribution
> or the one with swf?
>
> Chris
>
> -----Ursprüngliche Nachricht-----
> Von: Piotr Zarzycki <pi...@gmail.com>
> Gesendet: Sonntag, 7. März 2021 12:46
> An: dev@royale.apache.org
> Betreff: Re: PRs ready for distribution alignment
>
> Yep it doesn’t, but I can build my project with that sdk and cannot
> with maven distribution, so some configs has changed.
>
> On Sun, 7 Mar 2021 at 11:56, Christofer Dutz
> <ch...@c-ware.de>
> wrote:
>
> > Hi Piotr,
> >
> > So, I just downloaded the js-only version and that seems to be quite
> > empty too.
> >
> > It does seem to contain airglobal and playerglobal, JewelTheme and a
> > quite big lib called KeepsFBFromHanging.swc ... but in general this
> > directory doesn't contain any of the Project swcs.
> >
> > Chris
> >
> >
> > -----Ursprüngliche Nachricht-----
> > Von: Christofer Dutz <ch...@c-ware.de>
> > Gesendet: Freitag, 5. März 2021 18:07
> > An: dev@royale.apache.org
> > Betreff: AW: PRs ready for distribution alignment
> >
> > Hi Piotr,
> >
> > Guess I should have gotten the no-swf Ant version ... but I thought,
> > if you do a JS compile it uses the js/libs and if it's a SWF, it
> > uses
> "libs".
> > So right now, in case of the no-swf build, it doesn't add any of the
> > swc's ... but I'll investigate the no-swf ANT version and work on
> > that this weekend.
> >
> > So, for now it might make more sense to compare the "with-swf" versions.
> >
> > Chris
> >
> >
> > -----Ursprüngliche Nachricht-----
> > Von: Piotr Zarzycki <pi...@gmail.com>
> > Gesendet: Freitag, 5. März 2021 17:39
> > An: Apache Royale Development <de...@royale.apache.org>
> > Betreff: Re: PRs ready for distribution alignment
> >
> > Just an observation. In Ant distribution frameworks/libs does
> > exists, but it doesn't contains all those swc which you are seeing
> > in stacktrace. It means that Maven distribution is somehow "telling"
> > trough maybe some configs that I should use frameworks/libs swc
> > instead
> frameworks/js/libs...
> >
> > pt., 5 mar 2021 o 17:32 Christofer Dutz <ch...@c-ware.de>
> > napisał(a):
> >
> > > Hi Piotr,
> > >
> > > It should work in both.
> > >
> > > Chris
> > >
> > >
> > > -----Ursprüngliche Nachricht-----
> > > Von: Piotr Zarzycki <pi...@gmail.com>
> > > Gesendet: Freitag, 5. März 2021 17:04
> > > An: Apache Royale Development <de...@royale.apache.org>
> > > Betreff: Re: PRs ready for distribution alignment
> > >
> > > That options is working whether I build distribution in root
> > > folder of sdk and "distribution" folder as well ?
> > >
> > > pt., 5 mar 2021 o 17:00 Christofer Dutz
> > > <ch...@c-ware.de>
> > > napisał(a):
> > >
> > > > Hi Piotr,
> > > >
> > > > If you don't explicitly define the profile "option-with-swf"
> > > > it's the JS-only version.
> > > >
> > > > Chris
> > > >
> > > > -----Ursprüngliche Nachricht-----
> > > > Von: Piotr Zarzycki <pi...@gmail.com>
> > > > Gesendet: Freitag, 5. März 2021 16:11
> > > > An: Apache Royale Development <de...@royale.apache.org>
> > > > Betreff: Re: PRs ready for distribution alignment
> > > >
> > > > Chris,
> > > >
> > > > frameworks/libs doesn't exists at all.
> > > >
> > > > What occurs to me that I actually don't know what kind of
> > > > distribution package I'm building. Is it js-only distribution or
> > > > is it js-swf distribution ?
> > > >
> > > > Thanks,
> > > > Piotr
> > > >
> > > > pt., 5 mar 2021 o 15:41 Christofer Dutz
> > > > <ch...@c-ware.de>
> > > > napisał(a):
> > > >
> > > > > Hi Piotr,
> > > > >
> > > > > this is strange ... from the log output it seems as if the
> > > > > "frameworks/libs" doesn't contain any of the libraries.
> > > > > Could you please confirm if the directory really doesn't
> > > > > contain
> > them?
> > > > >
> > > > > Chris
> > > > >
> > > > >
> > > > >
> > > > > -----Ursprüngliche Nachricht-----
> > > > > Von: Piotr Zarzycki <pi...@gmail.com>
> > > > > Gesendet: Freitag, 5. März 2021 12:19
> > > > > An: Apache Royale Development <de...@royale.apache.org>
> > > > > Betreff: Re: PRs ready for distribution alignment
> > > > >
> > > > > Hi Chris,
> > > > >
> > > > > Thanks for all work. After rebuilding whole framework I just
> > > > > tried produce distribution by going to the folder of it and do:
> > > > >
> > > > > mvn clean install
> > > > > -DdistributionTargetFolder=d:\Work\royale_ide\distribution
> > > > >
> > > > > It works without doing set
> > > > > distributionTargetFolder=d:\Work\royale_ide\distribution.
> > > > >
> > > > > I went to Moonshine and tried to build with produced
> > > > > distribution our project and I got following errors - I won't
> > > > > post here full stacktrace [1]
> > > > >
> > > > > [1] https://paste.apache.org/c2qv1
> > > > >
> > > > > Thanks,
> > > > > Piotr
> > > > >
> > > > >
> > > > >
> > > > >
> > > > >
> > > > >
> > > > >
> > > > >
> > > > > pt., 5 mar 2021 o 10:10 Christofer Dutz
> > > > > <ch...@c-ware.de>
> > > > > napisał(a):
> > > > >
> > > > > > Hi all,
> > > > > >
> > > > > > I have, as far as I know, finished the work on aligning the
> > > > > > Maven built and the Ant built distribution.
> > > > > > A few things have changed in the Maven distribution compared
> > > > > > to the earlier ones:
> > > > > >
> > > > > >
> > > > > > * All scripts (in the bin and js/bin) directory are now
> > identical
> > > > to
> > > > > > the ones in the Ant distribution.
> > > > > > * The manifests are no longer contained in a "manifests"
> > > directory
> > > > > but
> > > > > > are in the same location as they are for the Ant build.
> > > > > > * I now include the sources of the projects, which should
> > > simplify
> > > > > > debugging.
> > > > > >
> > > > > > The probably most important change is that I no longer have
> > > > > > copies of the scripts and main manifests in the distribution
> > resources.
> > > > > > These resources now only contain the empty dummy files
> > > > > > needed by FlashBuilder. It seems these were updated in the
> > > > > > project, but the copies weren't. Therefore, the scripts as
> > > > > > well as the manifests weren't identical in Ant and Maven
> > > > > > distributions. I solved that problem by now taking the exact
> > > > > > same files and copying them in the assembly. The manifests
> > > > > > needed minor tweaking which I am now doing via
> > > > > an XSLT in the build.
> > > > > >
> > > > > > Also did I refactor everything just needed for FlashBuilder
> > > > > > support out into a separate assembly file. This way we have
> > > > > > all the stuff that doesn't seem to make sense in one place
> > > > > > and if we should decide to drop FB support, we just need to
> > > > > > remove that
> > > assembly descriptor.
> > > > > >
> > > > > > Would be cool if you could give the changes a try.
> > > > > >
> > > > > > Please note that you need to checkout the feature branch
> > > > > > "feature/distribution" in both the compiler as well as the
> > > > > > asjs repo (For some reason my addition of the ACE typedef
> > > > > > seems to have gone to the develop branch of the typedef
> > > > > > repo, so it should already be
> > > > > available.
> > > > > >
> > > > > > Hope you like the changes and hope they work for you the
> > > > > > same way they do for me (I think Carlos also reported that
> > > > > > he was successfully able to compile every example he tried
> > > > > > in VSCode with
> > > > > > it)
> > > > > >
> > > > > > The two PRs needing merging after review are:
> > > > > > Feature/distribution allignment by chrisdutz * Pull Request
> > > > > > #180
> > > > > > * apache/royale-compiler (github.com)<
> > > > > > https://github.com/apache/royale-compiler/pull/180>
> > > > > > Feature/distribution allignment by chrisdutz * Pull Request
> > > > > > #1087
> > > > > > * apache/royale-asjs (github.com)<
> > > > > > https://github.com/apache/royale-asjs/pull/1087>
> > > > > >
> > > > > >
> > > > > > Chris
> > > > > >
> > > > > >
> > > > >
> > > > > --
> > > > >
> > > > > Piotr Zarzycki
> > > > >
> > > >
> > > >
> > > > --
> > > >
> > > > Piotr Zarzycki
> > > >
> > >
> > >
> > > --
> > >
> > > Piotr Zarzycki
> > >
> >
> >
> > --
> >
> > Piotr Zarzycki
> >
> --
>
> Piotr Zarzycki
>
--
Piotr Zarzycki
Re: PRs ready for distribution alignment
Posted by Piotr Zarzycki <pi...@gmail.com>.
Chris,
I have used on Friday version which has been build with following command:
mvn clean install -DdistributionTargetFolder=d:\Work\royale_ide\distribution
Which one is that ?
If this command build swf version - I think default should be ja only.
Thanks,
Piotr
On Sun, 7 Mar 2021 at 13:03, Christofer Dutz <ch...@c-ware.de>
wrote:
> Hi all,
>
> I just pushed some changes handing the "without-swf" version.
> I now create the dummy files the FlashBuilder seems to require.
> Also does the build now clean out the "library-path" for the without-swf
> version.
>
> So, it should now be more aligned with the Ant build.
>
> @Piotr ... Are you still using the "without-swf/JS-only" distribution or
> the one with swf?
>
> Chris
>
> -----Ursprüngliche Nachricht-----
> Von: Piotr Zarzycki <pi...@gmail.com>
> Gesendet: Sonntag, 7. März 2021 12:46
> An: dev@royale.apache.org
> Betreff: Re: PRs ready for distribution alignment
>
> Yep it doesn’t, but I can build my project with that sdk and cannot with
> maven distribution, so some configs has changed.
>
> On Sun, 7 Mar 2021 at 11:56, Christofer Dutz <ch...@c-ware.de>
> wrote:
>
> > Hi Piotr,
> >
> > So, I just downloaded the js-only version and that seems to be quite
> > empty too.
> >
> > It does seem to contain airglobal and playerglobal, JewelTheme and a
> > quite big lib called KeepsFBFromHanging.swc ... but in general this
> > directory doesn't contain any of the Project swcs.
> >
> > Chris
> >
> >
> > -----Ursprüngliche Nachricht-----
> > Von: Christofer Dutz <ch...@c-ware.de>
> > Gesendet: Freitag, 5. März 2021 18:07
> > An: dev@royale.apache.org
> > Betreff: AW: PRs ready for distribution alignment
> >
> > Hi Piotr,
> >
> > Guess I should have gotten the no-swf Ant version ... but I thought,
> > if you do a JS compile it uses the js/libs and if it's a SWF, it uses
> "libs".
> > So right now, in case of the no-swf build, it doesn't add any of the
> > swc's ... but I'll investigate the no-swf ANT version and work on that
> > this weekend.
> >
> > So, for now it might make more sense to compare the "with-swf" versions.
> >
> > Chris
> >
> >
> > -----Ursprüngliche Nachricht-----
> > Von: Piotr Zarzycki <pi...@gmail.com>
> > Gesendet: Freitag, 5. März 2021 17:39
> > An: Apache Royale Development <de...@royale.apache.org>
> > Betreff: Re: PRs ready for distribution alignment
> >
> > Just an observation. In Ant distribution frameworks/libs does exists,
> > but it doesn't contains all those swc which you are seeing in
> > stacktrace. It means that Maven distribution is somehow "telling"
> > trough maybe some configs that I should use frameworks/libs swc instead
> frameworks/js/libs...
> >
> > pt., 5 mar 2021 o 17:32 Christofer Dutz <ch...@c-ware.de>
> > napisał(a):
> >
> > > Hi Piotr,
> > >
> > > It should work in both.
> > >
> > > Chris
> > >
> > >
> > > -----Ursprüngliche Nachricht-----
> > > Von: Piotr Zarzycki <pi...@gmail.com>
> > > Gesendet: Freitag, 5. März 2021 17:04
> > > An: Apache Royale Development <de...@royale.apache.org>
> > > Betreff: Re: PRs ready for distribution alignment
> > >
> > > That options is working whether I build distribution in root folder
> > > of sdk and "distribution" folder as well ?
> > >
> > > pt., 5 mar 2021 o 17:00 Christofer Dutz <ch...@c-ware.de>
> > > napisał(a):
> > >
> > > > Hi Piotr,
> > > >
> > > > If you don't explicitly define the profile "option-with-swf" it's
> > > > the JS-only version.
> > > >
> > > > Chris
> > > >
> > > > -----Ursprüngliche Nachricht-----
> > > > Von: Piotr Zarzycki <pi...@gmail.com>
> > > > Gesendet: Freitag, 5. März 2021 16:11
> > > > An: Apache Royale Development <de...@royale.apache.org>
> > > > Betreff: Re: PRs ready for distribution alignment
> > > >
> > > > Chris,
> > > >
> > > > frameworks/libs doesn't exists at all.
> > > >
> > > > What occurs to me that I actually don't know what kind of
> > > > distribution package I'm building. Is it js-only distribution or
> > > > is it js-swf distribution ?
> > > >
> > > > Thanks,
> > > > Piotr
> > > >
> > > > pt., 5 mar 2021 o 15:41 Christofer Dutz
> > > > <ch...@c-ware.de>
> > > > napisał(a):
> > > >
> > > > > Hi Piotr,
> > > > >
> > > > > this is strange ... from the log output it seems as if the
> > > > > "frameworks/libs" doesn't contain any of the libraries.
> > > > > Could you please confirm if the directory really doesn't contain
> > them?
> > > > >
> > > > > Chris
> > > > >
> > > > >
> > > > >
> > > > > -----Ursprüngliche Nachricht-----
> > > > > Von: Piotr Zarzycki <pi...@gmail.com>
> > > > > Gesendet: Freitag, 5. März 2021 12:19
> > > > > An: Apache Royale Development <de...@royale.apache.org>
> > > > > Betreff: Re: PRs ready for distribution alignment
> > > > >
> > > > > Hi Chris,
> > > > >
> > > > > Thanks for all work. After rebuilding whole framework I just
> > > > > tried produce distribution by going to the folder of it and do:
> > > > >
> > > > > mvn clean install
> > > > > -DdistributionTargetFolder=d:\Work\royale_ide\distribution
> > > > >
> > > > > It works without doing set
> > > > > distributionTargetFolder=d:\Work\royale_ide\distribution.
> > > > >
> > > > > I went to Moonshine and tried to build with produced
> > > > > distribution our project and I got following errors - I won't
> > > > > post here full stacktrace [1]
> > > > >
> > > > > [1] https://paste.apache.org/c2qv1
> > > > >
> > > > > Thanks,
> > > > > Piotr
> > > > >
> > > > >
> > > > >
> > > > >
> > > > >
> > > > >
> > > > >
> > > > >
> > > > > pt., 5 mar 2021 o 10:10 Christofer Dutz
> > > > > <ch...@c-ware.de>
> > > > > napisał(a):
> > > > >
> > > > > > Hi all,
> > > > > >
> > > > > > I have, as far as I know, finished the work on aligning the
> > > > > > Maven built and the Ant built distribution.
> > > > > > A few things have changed in the Maven distribution compared
> > > > > > to the earlier ones:
> > > > > >
> > > > > >
> > > > > > * All scripts (in the bin and js/bin) directory are now
> > identical
> > > > to
> > > > > > the ones in the Ant distribution.
> > > > > > * The manifests are no longer contained in a "manifests"
> > > directory
> > > > > but
> > > > > > are in the same location as they are for the Ant build.
> > > > > > * I now include the sources of the projects, which should
> > > simplify
> > > > > > debugging.
> > > > > >
> > > > > > The probably most important change is that I no longer have
> > > > > > copies of the scripts and main manifests in the distribution
> > resources.
> > > > > > These resources now only contain the empty dummy files needed
> > > > > > by FlashBuilder. It seems these were updated in the project,
> > > > > > but the copies weren't. Therefore, the scripts as well as the
> > > > > > manifests weren't identical in Ant and Maven distributions. I
> > > > > > solved that problem by now taking the exact same files and
> > > > > > copying them in the assembly. The manifests needed minor
> > > > > > tweaking which I am now doing via
> > > > > an XSLT in the build.
> > > > > >
> > > > > > Also did I refactor everything just needed for FlashBuilder
> > > > > > support out into a separate assembly file. This way we have
> > > > > > all the stuff that doesn't seem to make sense in one place and
> > > > > > if we should decide to drop FB support, we just need to remove
> > > > > > that
> > > assembly descriptor.
> > > > > >
> > > > > > Would be cool if you could give the changes a try.
> > > > > >
> > > > > > Please note that you need to checkout the feature branch
> > > > > > "feature/distribution" in both the compiler as well as the
> > > > > > asjs repo (For some reason my addition of the ACE typedef
> > > > > > seems to have gone to the develop branch of the typedef repo,
> > > > > > so it should already be
> > > > > available.
> > > > > >
> > > > > > Hope you like the changes and hope they work for you the same
> > > > > > way they do for me (I think Carlos also reported that he was
> > > > > > successfully able to compile every example he tried in VSCode
> > > > > > with
> > > > > > it)
> > > > > >
> > > > > > The two PRs needing merging after review are:
> > > > > > Feature/distribution allignment by chrisdutz * Pull Request
> > > > > > #180
> > > > > > * apache/royale-compiler (github.com)<
> > > > > > https://github.com/apache/royale-compiler/pull/180>
> > > > > > Feature/distribution allignment by chrisdutz * Pull Request
> > > > > > #1087
> > > > > > * apache/royale-asjs (github.com)<
> > > > > > https://github.com/apache/royale-asjs/pull/1087>
> > > > > >
> > > > > >
> > > > > > Chris
> > > > > >
> > > > > >
> > > > >
> > > > > --
> > > > >
> > > > > Piotr Zarzycki
> > > > >
> > > >
> > > >
> > > > --
> > > >
> > > > Piotr Zarzycki
> > > >
> > >
> > >
> > > --
> > >
> > > Piotr Zarzycki
> > >
> >
> >
> > --
> >
> > Piotr Zarzycki
> >
> --
>
> Piotr Zarzycki
>
--
Piotr Zarzycki
AW: PRs ready for distribution alignment
Posted by Christofer Dutz <ch...@c-ware.de>.
Hi all,
I just pushed some changes handing the "without-swf" version.
I now create the dummy files the FlashBuilder seems to require.
Also does the build now clean out the "library-path" for the without-swf version.
So, it should now be more aligned with the Ant build.
@Piotr ... Are you still using the "without-swf/JS-only" distribution or the one with swf?
Chris
-----Ursprüngliche Nachricht-----
Von: Piotr Zarzycki <pi...@gmail.com>
Gesendet: Sonntag, 7. März 2021 12:46
An: dev@royale.apache.org
Betreff: Re: PRs ready for distribution alignment
Yep it doesn’t, but I can build my project with that sdk and cannot with maven distribution, so some configs has changed.
On Sun, 7 Mar 2021 at 11:56, Christofer Dutz <ch...@c-ware.de>
wrote:
> Hi Piotr,
>
> So, I just downloaded the js-only version and that seems to be quite
> empty too.
>
> It does seem to contain airglobal and playerglobal, JewelTheme and a
> quite big lib called KeepsFBFromHanging.swc ... but in general this
> directory doesn't contain any of the Project swcs.
>
> Chris
>
>
> -----Ursprüngliche Nachricht-----
> Von: Christofer Dutz <ch...@c-ware.de>
> Gesendet: Freitag, 5. März 2021 18:07
> An: dev@royale.apache.org
> Betreff: AW: PRs ready for distribution alignment
>
> Hi Piotr,
>
> Guess I should have gotten the no-swf Ant version ... but I thought,
> if you do a JS compile it uses the js/libs and if it's a SWF, it uses "libs".
> So right now, in case of the no-swf build, it doesn't add any of the
> swc's ... but I'll investigate the no-swf ANT version and work on that
> this weekend.
>
> So, for now it might make more sense to compare the "with-swf" versions.
>
> Chris
>
>
> -----Ursprüngliche Nachricht-----
> Von: Piotr Zarzycki <pi...@gmail.com>
> Gesendet: Freitag, 5. März 2021 17:39
> An: Apache Royale Development <de...@royale.apache.org>
> Betreff: Re: PRs ready for distribution alignment
>
> Just an observation. In Ant distribution frameworks/libs does exists,
> but it doesn't contains all those swc which you are seeing in
> stacktrace. It means that Maven distribution is somehow "telling"
> trough maybe some configs that I should use frameworks/libs swc instead frameworks/js/libs...
>
> pt., 5 mar 2021 o 17:32 Christofer Dutz <ch...@c-ware.de>
> napisał(a):
>
> > Hi Piotr,
> >
> > It should work in both.
> >
> > Chris
> >
> >
> > -----Ursprüngliche Nachricht-----
> > Von: Piotr Zarzycki <pi...@gmail.com>
> > Gesendet: Freitag, 5. März 2021 17:04
> > An: Apache Royale Development <de...@royale.apache.org>
> > Betreff: Re: PRs ready for distribution alignment
> >
> > That options is working whether I build distribution in root folder
> > of sdk and "distribution" folder as well ?
> >
> > pt., 5 mar 2021 o 17:00 Christofer Dutz <ch...@c-ware.de>
> > napisał(a):
> >
> > > Hi Piotr,
> > >
> > > If you don't explicitly define the profile "option-with-swf" it's
> > > the JS-only version.
> > >
> > > Chris
> > >
> > > -----Ursprüngliche Nachricht-----
> > > Von: Piotr Zarzycki <pi...@gmail.com>
> > > Gesendet: Freitag, 5. März 2021 16:11
> > > An: Apache Royale Development <de...@royale.apache.org>
> > > Betreff: Re: PRs ready for distribution alignment
> > >
> > > Chris,
> > >
> > > frameworks/libs doesn't exists at all.
> > >
> > > What occurs to me that I actually don't know what kind of
> > > distribution package I'm building. Is it js-only distribution or
> > > is it js-swf distribution ?
> > >
> > > Thanks,
> > > Piotr
> > >
> > > pt., 5 mar 2021 o 15:41 Christofer Dutz
> > > <ch...@c-ware.de>
> > > napisał(a):
> > >
> > > > Hi Piotr,
> > > >
> > > > this is strange ... from the log output it seems as if the
> > > > "frameworks/libs" doesn't contain any of the libraries.
> > > > Could you please confirm if the directory really doesn't contain
> them?
> > > >
> > > > Chris
> > > >
> > > >
> > > >
> > > > -----Ursprüngliche Nachricht-----
> > > > Von: Piotr Zarzycki <pi...@gmail.com>
> > > > Gesendet: Freitag, 5. März 2021 12:19
> > > > An: Apache Royale Development <de...@royale.apache.org>
> > > > Betreff: Re: PRs ready for distribution alignment
> > > >
> > > > Hi Chris,
> > > >
> > > > Thanks for all work. After rebuilding whole framework I just
> > > > tried produce distribution by going to the folder of it and do:
> > > >
> > > > mvn clean install
> > > > -DdistributionTargetFolder=d:\Work\royale_ide\distribution
> > > >
> > > > It works without doing set
> > > > distributionTargetFolder=d:\Work\royale_ide\distribution.
> > > >
> > > > I went to Moonshine and tried to build with produced
> > > > distribution our project and I got following errors - I won't
> > > > post here full stacktrace [1]
> > > >
> > > > [1] https://paste.apache.org/c2qv1
> > > >
> > > > Thanks,
> > > > Piotr
> > > >
> > > >
> > > >
> > > >
> > > >
> > > >
> > > >
> > > >
> > > > pt., 5 mar 2021 o 10:10 Christofer Dutz
> > > > <ch...@c-ware.de>
> > > > napisał(a):
> > > >
> > > > > Hi all,
> > > > >
> > > > > I have, as far as I know, finished the work on aligning the
> > > > > Maven built and the Ant built distribution.
> > > > > A few things have changed in the Maven distribution compared
> > > > > to the earlier ones:
> > > > >
> > > > >
> > > > > * All scripts (in the bin and js/bin) directory are now
> identical
> > > to
> > > > > the ones in the Ant distribution.
> > > > > * The manifests are no longer contained in a "manifests"
> > directory
> > > > but
> > > > > are in the same location as they are for the Ant build.
> > > > > * I now include the sources of the projects, which should
> > simplify
> > > > > debugging.
> > > > >
> > > > > The probably most important change is that I no longer have
> > > > > copies of the scripts and main manifests in the distribution
> resources.
> > > > > These resources now only contain the empty dummy files needed
> > > > > by FlashBuilder. It seems these were updated in the project,
> > > > > but the copies weren't. Therefore, the scripts as well as the
> > > > > manifests weren't identical in Ant and Maven distributions. I
> > > > > solved that problem by now taking the exact same files and
> > > > > copying them in the assembly. The manifests needed minor
> > > > > tweaking which I am now doing via
> > > > an XSLT in the build.
> > > > >
> > > > > Also did I refactor everything just needed for FlashBuilder
> > > > > support out into a separate assembly file. This way we have
> > > > > all the stuff that doesn't seem to make sense in one place and
> > > > > if we should decide to drop FB support, we just need to remove
> > > > > that
> > assembly descriptor.
> > > > >
> > > > > Would be cool if you could give the changes a try.
> > > > >
> > > > > Please note that you need to checkout the feature branch
> > > > > "feature/distribution" in both the compiler as well as the
> > > > > asjs repo (For some reason my addition of the ACE typedef
> > > > > seems to have gone to the develop branch of the typedef repo,
> > > > > so it should already be
> > > > available.
> > > > >
> > > > > Hope you like the changes and hope they work for you the same
> > > > > way they do for me (I think Carlos also reported that he was
> > > > > successfully able to compile every example he tried in VSCode
> > > > > with
> > > > > it)
> > > > >
> > > > > The two PRs needing merging after review are:
> > > > > Feature/distribution allignment by chrisdutz * Pull Request
> > > > > #180
> > > > > * apache/royale-compiler (github.com)<
> > > > > https://github.com/apache/royale-compiler/pull/180>
> > > > > Feature/distribution allignment by chrisdutz * Pull Request
> > > > > #1087
> > > > > * apache/royale-asjs (github.com)<
> > > > > https://github.com/apache/royale-asjs/pull/1087>
> > > > >
> > > > >
> > > > > Chris
> > > > >
> > > > >
> > > >
> > > > --
> > > >
> > > > Piotr Zarzycki
> > > >
> > >
> > >
> > > --
> > >
> > > Piotr Zarzycki
> > >
> >
> >
> > --
> >
> > Piotr Zarzycki
> >
>
>
> --
>
> Piotr Zarzycki
>
--
Piotr Zarzycki
Re: PRs ready for distribution alignment
Posted by Piotr Zarzycki <pi...@gmail.com>.
Yep it doesn’t, but I can build my project with that sdk and cannot with
maven distribution, so some configs has changed.
On Sun, 7 Mar 2021 at 11:56, Christofer Dutz <ch...@c-ware.de>
wrote:
> Hi Piotr,
>
> So, I just downloaded the js-only version and that seems to be quite empty
> too.
>
> It does seem to contain airglobal and playerglobal, JewelTheme and a quite
> big lib called KeepsFBFromHanging.swc ... but in general this directory
> doesn't contain any of the Project swcs.
>
> Chris
>
>
> -----Ursprüngliche Nachricht-----
> Von: Christofer Dutz <ch...@c-ware.de>
> Gesendet: Freitag, 5. März 2021 18:07
> An: dev@royale.apache.org
> Betreff: AW: PRs ready for distribution alignment
>
> Hi Piotr,
>
> Guess I should have gotten the no-swf Ant version ... but I thought, if
> you do a JS compile it uses the js/libs and if it's a SWF, it uses "libs".
> So right now, in case of the no-swf build, it doesn't add any of the swc's
> ... but I'll investigate the no-swf ANT version and work on that this
> weekend.
>
> So, for now it might make more sense to compare the "with-swf" versions.
>
> Chris
>
>
> -----Ursprüngliche Nachricht-----
> Von: Piotr Zarzycki <pi...@gmail.com>
> Gesendet: Freitag, 5. März 2021 17:39
> An: Apache Royale Development <de...@royale.apache.org>
> Betreff: Re: PRs ready for distribution alignment
>
> Just an observation. In Ant distribution frameworks/libs does exists, but
> it doesn't contains all those swc which you are seeing in stacktrace. It
> means that Maven distribution is somehow "telling" trough maybe some
> configs that I should use frameworks/libs swc instead frameworks/js/libs...
>
> pt., 5 mar 2021 o 17:32 Christofer Dutz <ch...@c-ware.de>
> napisał(a):
>
> > Hi Piotr,
> >
> > It should work in both.
> >
> > Chris
> >
> >
> > -----Ursprüngliche Nachricht-----
> > Von: Piotr Zarzycki <pi...@gmail.com>
> > Gesendet: Freitag, 5. März 2021 17:04
> > An: Apache Royale Development <de...@royale.apache.org>
> > Betreff: Re: PRs ready for distribution alignment
> >
> > That options is working whether I build distribution in root folder of
> > sdk and "distribution" folder as well ?
> >
> > pt., 5 mar 2021 o 17:00 Christofer Dutz <ch...@c-ware.de>
> > napisał(a):
> >
> > > Hi Piotr,
> > >
> > > If you don't explicitly define the profile "option-with-swf" it's
> > > the JS-only version.
> > >
> > > Chris
> > >
> > > -----Ursprüngliche Nachricht-----
> > > Von: Piotr Zarzycki <pi...@gmail.com>
> > > Gesendet: Freitag, 5. März 2021 16:11
> > > An: Apache Royale Development <de...@royale.apache.org>
> > > Betreff: Re: PRs ready for distribution alignment
> > >
> > > Chris,
> > >
> > > frameworks/libs doesn't exists at all.
> > >
> > > What occurs to me that I actually don't know what kind of
> > > distribution package I'm building. Is it js-only distribution or is
> > > it js-swf distribution ?
> > >
> > > Thanks,
> > > Piotr
> > >
> > > pt., 5 mar 2021 o 15:41 Christofer Dutz <ch...@c-ware.de>
> > > napisał(a):
> > >
> > > > Hi Piotr,
> > > >
> > > > this is strange ... from the log output it seems as if the
> > > > "frameworks/libs" doesn't contain any of the libraries.
> > > > Could you please confirm if the directory really doesn't contain
> them?
> > > >
> > > > Chris
> > > >
> > > >
> > > >
> > > > -----Ursprüngliche Nachricht-----
> > > > Von: Piotr Zarzycki <pi...@gmail.com>
> > > > Gesendet: Freitag, 5. März 2021 12:19
> > > > An: Apache Royale Development <de...@royale.apache.org>
> > > > Betreff: Re: PRs ready for distribution alignment
> > > >
> > > > Hi Chris,
> > > >
> > > > Thanks for all work. After rebuilding whole framework I just tried
> > > > produce distribution by going to the folder of it and do:
> > > >
> > > > mvn clean install
> > > > -DdistributionTargetFolder=d:\Work\royale_ide\distribution
> > > >
> > > > It works without doing set
> > > > distributionTargetFolder=d:\Work\royale_ide\distribution.
> > > >
> > > > I went to Moonshine and tried to build with produced distribution
> > > > our project and I got following errors - I won't post here full
> > > > stacktrace [1]
> > > >
> > > > [1] https://paste.apache.org/c2qv1
> > > >
> > > > Thanks,
> > > > Piotr
> > > >
> > > >
> > > >
> > > >
> > > >
> > > >
> > > >
> > > >
> > > > pt., 5 mar 2021 o 10:10 Christofer Dutz
> > > > <ch...@c-ware.de>
> > > > napisał(a):
> > > >
> > > > > Hi all,
> > > > >
> > > > > I have, as far as I know, finished the work on aligning the
> > > > > Maven built and the Ant built distribution.
> > > > > A few things have changed in the Maven distribution compared to
> > > > > the earlier ones:
> > > > >
> > > > >
> > > > > * All scripts (in the bin and js/bin) directory are now
> identical
> > > to
> > > > > the ones in the Ant distribution.
> > > > > * The manifests are no longer contained in a "manifests"
> > directory
> > > > but
> > > > > are in the same location as they are for the Ant build.
> > > > > * I now include the sources of the projects, which should
> > simplify
> > > > > debugging.
> > > > >
> > > > > The probably most important change is that I no longer have
> > > > > copies of the scripts and main manifests in the distribution
> resources.
> > > > > These resources now only contain the empty dummy files needed by
> > > > > FlashBuilder. It seems these were updated in the project, but
> > > > > the copies weren't. Therefore, the scripts as well as the
> > > > > manifests weren't identical in Ant and Maven distributions. I
> > > > > solved that problem by now taking the exact same files and
> > > > > copying them in the assembly. The manifests needed minor
> > > > > tweaking which I am now doing via
> > > > an XSLT in the build.
> > > > >
> > > > > Also did I refactor everything just needed for FlashBuilder
> > > > > support out into a separate assembly file. This way we have all
> > > > > the stuff that doesn't seem to make sense in one place and if we
> > > > > should decide to drop FB support, we just need to remove that
> > assembly descriptor.
> > > > >
> > > > > Would be cool if you could give the changes a try.
> > > > >
> > > > > Please note that you need to checkout the feature branch
> > > > > "feature/distribution" in both the compiler as well as the asjs
> > > > > repo (For some reason my addition of the ACE typedef seems to
> > > > > have gone to the develop branch of the typedef repo, so it
> > > > > should already be
> > > > available.
> > > > >
> > > > > Hope you like the changes and hope they work for you the same
> > > > > way they do for me (I think Carlos also reported that he was
> > > > > successfully able to compile every example he tried in VSCode
> > > > > with
> > > > > it)
> > > > >
> > > > > The two PRs needing merging after review are:
> > > > > Feature/distribution allignment by chrisdutz * Pull Request #180
> > > > > * apache/royale-compiler (github.com)<
> > > > > https://github.com/apache/royale-compiler/pull/180>
> > > > > Feature/distribution allignment by chrisdutz * Pull Request
> > > > > #1087
> > > > > * apache/royale-asjs (github.com)<
> > > > > https://github.com/apache/royale-asjs/pull/1087>
> > > > >
> > > > >
> > > > > Chris
> > > > >
> > > > >
> > > >
> > > > --
> > > >
> > > > Piotr Zarzycki
> > > >
> > >
> > >
> > > --
> > >
> > > Piotr Zarzycki
> > >
> >
> >
> > --
> >
> > Piotr Zarzycki
> >
>
>
> --
>
> Piotr Zarzycki
>
--
Piotr Zarzycki
AW: PRs ready for distribution alignment
Posted by Christofer Dutz <ch...@c-ware.de>.
Hi Piotr,
So, I just downloaded the js-only version and that seems to be quite empty too.
It does seem to contain airglobal and playerglobal, JewelTheme and a quite big lib called KeepsFBFromHanging.swc ... but in general this directory doesn't contain any of the Project swcs.
Chris
-----Ursprüngliche Nachricht-----
Von: Christofer Dutz <ch...@c-ware.de>
Gesendet: Freitag, 5. März 2021 18:07
An: dev@royale.apache.org
Betreff: AW: PRs ready for distribution alignment
Hi Piotr,
Guess I should have gotten the no-swf Ant version ... but I thought, if you do a JS compile it uses the js/libs and if it's a SWF, it uses "libs". So right now, in case of the no-swf build, it doesn't add any of the swc's ... but I'll investigate the no-swf ANT version and work on that this weekend.
So, for now it might make more sense to compare the "with-swf" versions.
Chris
-----Ursprüngliche Nachricht-----
Von: Piotr Zarzycki <pi...@gmail.com>
Gesendet: Freitag, 5. März 2021 17:39
An: Apache Royale Development <de...@royale.apache.org>
Betreff: Re: PRs ready for distribution alignment
Just an observation. In Ant distribution frameworks/libs does exists, but it doesn't contains all those swc which you are seeing in stacktrace. It means that Maven distribution is somehow "telling" trough maybe some configs that I should use frameworks/libs swc instead frameworks/js/libs...
pt., 5 mar 2021 o 17:32 Christofer Dutz <ch...@c-ware.de>
napisał(a):
> Hi Piotr,
>
> It should work in both.
>
> Chris
>
>
> -----Ursprüngliche Nachricht-----
> Von: Piotr Zarzycki <pi...@gmail.com>
> Gesendet: Freitag, 5. März 2021 17:04
> An: Apache Royale Development <de...@royale.apache.org>
> Betreff: Re: PRs ready for distribution alignment
>
> That options is working whether I build distribution in root folder of
> sdk and "distribution" folder as well ?
>
> pt., 5 mar 2021 o 17:00 Christofer Dutz <ch...@c-ware.de>
> napisał(a):
>
> > Hi Piotr,
> >
> > If you don't explicitly define the profile "option-with-swf" it's
> > the JS-only version.
> >
> > Chris
> >
> > -----Ursprüngliche Nachricht-----
> > Von: Piotr Zarzycki <pi...@gmail.com>
> > Gesendet: Freitag, 5. März 2021 16:11
> > An: Apache Royale Development <de...@royale.apache.org>
> > Betreff: Re: PRs ready for distribution alignment
> >
> > Chris,
> >
> > frameworks/libs doesn't exists at all.
> >
> > What occurs to me that I actually don't know what kind of
> > distribution package I'm building. Is it js-only distribution or is
> > it js-swf distribution ?
> >
> > Thanks,
> > Piotr
> >
> > pt., 5 mar 2021 o 15:41 Christofer Dutz <ch...@c-ware.de>
> > napisał(a):
> >
> > > Hi Piotr,
> > >
> > > this is strange ... from the log output it seems as if the
> > > "frameworks/libs" doesn't contain any of the libraries.
> > > Could you please confirm if the directory really doesn't contain them?
> > >
> > > Chris
> > >
> > >
> > >
> > > -----Ursprüngliche Nachricht-----
> > > Von: Piotr Zarzycki <pi...@gmail.com>
> > > Gesendet: Freitag, 5. März 2021 12:19
> > > An: Apache Royale Development <de...@royale.apache.org>
> > > Betreff: Re: PRs ready for distribution alignment
> > >
> > > Hi Chris,
> > >
> > > Thanks for all work. After rebuilding whole framework I just tried
> > > produce distribution by going to the folder of it and do:
> > >
> > > mvn clean install
> > > -DdistributionTargetFolder=d:\Work\royale_ide\distribution
> > >
> > > It works without doing set
> > > distributionTargetFolder=d:\Work\royale_ide\distribution.
> > >
> > > I went to Moonshine and tried to build with produced distribution
> > > our project and I got following errors - I won't post here full
> > > stacktrace [1]
> > >
> > > [1] https://paste.apache.org/c2qv1
> > >
> > > Thanks,
> > > Piotr
> > >
> > >
> > >
> > >
> > >
> > >
> > >
> > >
> > > pt., 5 mar 2021 o 10:10 Christofer Dutz
> > > <ch...@c-ware.de>
> > > napisał(a):
> > >
> > > > Hi all,
> > > >
> > > > I have, as far as I know, finished the work on aligning the
> > > > Maven built and the Ant built distribution.
> > > > A few things have changed in the Maven distribution compared to
> > > > the earlier ones:
> > > >
> > > >
> > > > * All scripts (in the bin and js/bin) directory are now identical
> > to
> > > > the ones in the Ant distribution.
> > > > * The manifests are no longer contained in a "manifests"
> directory
> > > but
> > > > are in the same location as they are for the Ant build.
> > > > * I now include the sources of the projects, which should
> simplify
> > > > debugging.
> > > >
> > > > The probably most important change is that I no longer have
> > > > copies of the scripts and main manifests in the distribution resources.
> > > > These resources now only contain the empty dummy files needed by
> > > > FlashBuilder. It seems these were updated in the project, but
> > > > the copies weren't. Therefore, the scripts as well as the
> > > > manifests weren't identical in Ant and Maven distributions. I
> > > > solved that problem by now taking the exact same files and
> > > > copying them in the assembly. The manifests needed minor
> > > > tweaking which I am now doing via
> > > an XSLT in the build.
> > > >
> > > > Also did I refactor everything just needed for FlashBuilder
> > > > support out into a separate assembly file. This way we have all
> > > > the stuff that doesn't seem to make sense in one place and if we
> > > > should decide to drop FB support, we just need to remove that
> assembly descriptor.
> > > >
> > > > Would be cool if you could give the changes a try.
> > > >
> > > > Please note that you need to checkout the feature branch
> > > > "feature/distribution" in both the compiler as well as the asjs
> > > > repo (For some reason my addition of the ACE typedef seems to
> > > > have gone to the develop branch of the typedef repo, so it
> > > > should already be
> > > available.
> > > >
> > > > Hope you like the changes and hope they work for you the same
> > > > way they do for me (I think Carlos also reported that he was
> > > > successfully able to compile every example he tried in VSCode
> > > > with
> > > > it)
> > > >
> > > > The two PRs needing merging after review are:
> > > > Feature/distribution allignment by chrisdutz * Pull Request #180
> > > > * apache/royale-compiler (github.com)<
> > > > https://github.com/apache/royale-compiler/pull/180>
> > > > Feature/distribution allignment by chrisdutz * Pull Request
> > > > #1087
> > > > * apache/royale-asjs (github.com)<
> > > > https://github.com/apache/royale-asjs/pull/1087>
> > > >
> > > >
> > > > Chris
> > > >
> > > >
> > >
> > > --
> > >
> > > Piotr Zarzycki
> > >
> >
> >
> > --
> >
> > Piotr Zarzycki
> >
>
>
> --
>
> Piotr Zarzycki
>
--
Piotr Zarzycki
AW: PRs ready for distribution alignment
Posted by Christofer Dutz <ch...@c-ware.de>.
Hi Piotr,
Guess I should have gotten the no-swf Ant version ... but I thought, if you do a JS compile it uses the js/libs and if it's a SWF, it uses "libs". So right now, in case of the no-swf build, it doesn't add any of the swc's ... but I'll investigate the no-swf ANT version and work on that this weekend.
So, for now it might make more sense to compare the "with-swf" versions.
Chris
-----Ursprüngliche Nachricht-----
Von: Piotr Zarzycki <pi...@gmail.com>
Gesendet: Freitag, 5. März 2021 17:39
An: Apache Royale Development <de...@royale.apache.org>
Betreff: Re: PRs ready for distribution alignment
Just an observation. In Ant distribution frameworks/libs does exists, but it doesn't contains all those swc which you are seeing in stacktrace. It means that Maven distribution is somehow "telling" trough maybe some configs that I should use frameworks/libs swc instead frameworks/js/libs...
pt., 5 mar 2021 o 17:32 Christofer Dutz <ch...@c-ware.de>
napisał(a):
> Hi Piotr,
>
> It should work in both.
>
> Chris
>
>
> -----Ursprüngliche Nachricht-----
> Von: Piotr Zarzycki <pi...@gmail.com>
> Gesendet: Freitag, 5. März 2021 17:04
> An: Apache Royale Development <de...@royale.apache.org>
> Betreff: Re: PRs ready for distribution alignment
>
> That options is working whether I build distribution in root folder of
> sdk and "distribution" folder as well ?
>
> pt., 5 mar 2021 o 17:00 Christofer Dutz <ch...@c-ware.de>
> napisał(a):
>
> > Hi Piotr,
> >
> > If you don't explicitly define the profile "option-with-swf" it's
> > the JS-only version.
> >
> > Chris
> >
> > -----Ursprüngliche Nachricht-----
> > Von: Piotr Zarzycki <pi...@gmail.com>
> > Gesendet: Freitag, 5. März 2021 16:11
> > An: Apache Royale Development <de...@royale.apache.org>
> > Betreff: Re: PRs ready for distribution alignment
> >
> > Chris,
> >
> > frameworks/libs doesn't exists at all.
> >
> > What occurs to me that I actually don't know what kind of
> > distribution package I'm building. Is it js-only distribution or is
> > it js-swf distribution ?
> >
> > Thanks,
> > Piotr
> >
> > pt., 5 mar 2021 o 15:41 Christofer Dutz <ch...@c-ware.de>
> > napisał(a):
> >
> > > Hi Piotr,
> > >
> > > this is strange ... from the log output it seems as if the
> > > "frameworks/libs" doesn't contain any of the libraries.
> > > Could you please confirm if the directory really doesn't contain them?
> > >
> > > Chris
> > >
> > >
> > >
> > > -----Ursprüngliche Nachricht-----
> > > Von: Piotr Zarzycki <pi...@gmail.com>
> > > Gesendet: Freitag, 5. März 2021 12:19
> > > An: Apache Royale Development <de...@royale.apache.org>
> > > Betreff: Re: PRs ready for distribution alignment
> > >
> > > Hi Chris,
> > >
> > > Thanks for all work. After rebuilding whole framework I just tried
> > > produce distribution by going to the folder of it and do:
> > >
> > > mvn clean install
> > > -DdistributionTargetFolder=d:\Work\royale_ide\distribution
> > >
> > > It works without doing set
> > > distributionTargetFolder=d:\Work\royale_ide\distribution.
> > >
> > > I went to Moonshine and tried to build with produced distribution
> > > our project and I got following errors - I won't post here full
> > > stacktrace [1]
> > >
> > > [1] https://paste.apache.org/c2qv1
> > >
> > > Thanks,
> > > Piotr
> > >
> > >
> > >
> > >
> > >
> > >
> > >
> > >
> > > pt., 5 mar 2021 o 10:10 Christofer Dutz
> > > <ch...@c-ware.de>
> > > napisał(a):
> > >
> > > > Hi all,
> > > >
> > > > I have, as far as I know, finished the work on aligning the
> > > > Maven built and the Ant built distribution.
> > > > A few things have changed in the Maven distribution compared to
> > > > the earlier ones:
> > > >
> > > >
> > > > * All scripts (in the bin and js/bin) directory are now identical
> > to
> > > > the ones in the Ant distribution.
> > > > * The manifests are no longer contained in a "manifests"
> directory
> > > but
> > > > are in the same location as they are for the Ant build.
> > > > * I now include the sources of the projects, which should
> simplify
> > > > debugging.
> > > >
> > > > The probably most important change is that I no longer have
> > > > copies of the scripts and main manifests in the distribution resources.
> > > > These resources now only contain the empty dummy files needed by
> > > > FlashBuilder. It seems these were updated in the project, but
> > > > the copies weren't. Therefore, the scripts as well as the
> > > > manifests weren't identical in Ant and Maven distributions. I
> > > > solved that problem by now taking the exact same files and
> > > > copying them in the assembly. The manifests needed minor
> > > > tweaking which I am now doing via
> > > an XSLT in the build.
> > > >
> > > > Also did I refactor everything just needed for FlashBuilder
> > > > support out into a separate assembly file. This way we have all
> > > > the stuff that doesn't seem to make sense in one place and if we
> > > > should decide to drop FB support, we just need to remove that
> assembly descriptor.
> > > >
> > > > Would be cool if you could give the changes a try.
> > > >
> > > > Please note that you need to checkout the feature branch
> > > > "feature/distribution" in both the compiler as well as the asjs
> > > > repo (For some reason my addition of the ACE typedef seems to
> > > > have gone to the develop branch of the typedef repo, so it
> > > > should already be
> > > available.
> > > >
> > > > Hope you like the changes and hope they work for you the same
> > > > way they do for me (I think Carlos also reported that he was
> > > > successfully able to compile every example he tried in VSCode
> > > > with
> > > > it)
> > > >
> > > > The two PRs needing merging after review are:
> > > > Feature/distribution allignment by chrisdutz * Pull Request #180
> > > > * apache/royale-compiler (github.com)<
> > > > https://github.com/apache/royale-compiler/pull/180>
> > > > Feature/distribution allignment by chrisdutz * Pull Request
> > > > #1087
> > > > * apache/royale-asjs (github.com)<
> > > > https://github.com/apache/royale-asjs/pull/1087>
> > > >
> > > >
> > > > Chris
> > > >
> > > >
> > >
> > > --
> > >
> > > Piotr Zarzycki
> > >
> >
> >
> > --
> >
> > Piotr Zarzycki
> >
>
>
> --
>
> Piotr Zarzycki
>
--
Piotr Zarzycki
Re: PRs ready for distribution alignment
Posted by Piotr Zarzycki <pi...@gmail.com>.
Just an observation. In Ant distribution frameworks/libs does exists, but
it doesn't contains all those swc which you are seeing in stacktrace. It
means that Maven distribution is somehow "telling" trough maybe some
configs that I should use frameworks/libs swc instead frameworks/js/libs...
pt., 5 mar 2021 o 17:32 Christofer Dutz <ch...@c-ware.de>
napisał(a):
> Hi Piotr,
>
> It should work in both.
>
> Chris
>
>
> -----Ursprüngliche Nachricht-----
> Von: Piotr Zarzycki <pi...@gmail.com>
> Gesendet: Freitag, 5. März 2021 17:04
> An: Apache Royale Development <de...@royale.apache.org>
> Betreff: Re: PRs ready for distribution alignment
>
> That options is working whether I build distribution in root folder of sdk
> and "distribution" folder as well ?
>
> pt., 5 mar 2021 o 17:00 Christofer Dutz <ch...@c-ware.de>
> napisał(a):
>
> > Hi Piotr,
> >
> > If you don't explicitly define the profile "option-with-swf" it's the
> > JS-only version.
> >
> > Chris
> >
> > -----Ursprüngliche Nachricht-----
> > Von: Piotr Zarzycki <pi...@gmail.com>
> > Gesendet: Freitag, 5. März 2021 16:11
> > An: Apache Royale Development <de...@royale.apache.org>
> > Betreff: Re: PRs ready for distribution alignment
> >
> > Chris,
> >
> > frameworks/libs doesn't exists at all.
> >
> > What occurs to me that I actually don't know what kind of distribution
> > package I'm building. Is it js-only distribution or is it js-swf
> > distribution ?
> >
> > Thanks,
> > Piotr
> >
> > pt., 5 mar 2021 o 15:41 Christofer Dutz <ch...@c-ware.de>
> > napisał(a):
> >
> > > Hi Piotr,
> > >
> > > this is strange ... from the log output it seems as if the
> > > "frameworks/libs" doesn't contain any of the libraries.
> > > Could you please confirm if the directory really doesn't contain them?
> > >
> > > Chris
> > >
> > >
> > >
> > > -----Ursprüngliche Nachricht-----
> > > Von: Piotr Zarzycki <pi...@gmail.com>
> > > Gesendet: Freitag, 5. März 2021 12:19
> > > An: Apache Royale Development <de...@royale.apache.org>
> > > Betreff: Re: PRs ready for distribution alignment
> > >
> > > Hi Chris,
> > >
> > > Thanks for all work. After rebuilding whole framework I just tried
> > > produce distribution by going to the folder of it and do:
> > >
> > > mvn clean install
> > > -DdistributionTargetFolder=d:\Work\royale_ide\distribution
> > >
> > > It works without doing set
> > > distributionTargetFolder=d:\Work\royale_ide\distribution.
> > >
> > > I went to Moonshine and tried to build with produced distribution
> > > our project and I got following errors - I won't post here full
> > > stacktrace [1]
> > >
> > > [1] https://paste.apache.org/c2qv1
> > >
> > > Thanks,
> > > Piotr
> > >
> > >
> > >
> > >
> > >
> > >
> > >
> > >
> > > pt., 5 mar 2021 o 10:10 Christofer Dutz <ch...@c-ware.de>
> > > napisał(a):
> > >
> > > > Hi all,
> > > >
> > > > I have, as far as I know, finished the work on aligning the Maven
> > > > built and the Ant built distribution.
> > > > A few things have changed in the Maven distribution compared to
> > > > the earlier ones:
> > > >
> > > >
> > > > * All scripts (in the bin and js/bin) directory are now identical
> > to
> > > > the ones in the Ant distribution.
> > > > * The manifests are no longer contained in a "manifests"
> directory
> > > but
> > > > are in the same location as they are for the Ant build.
> > > > * I now include the sources of the projects, which should
> simplify
> > > > debugging.
> > > >
> > > > The probably most important change is that I no longer have copies
> > > > of the scripts and main manifests in the distribution resources.
> > > > These resources now only contain the empty dummy files needed by
> > > > FlashBuilder. It seems these were updated in the project, but the
> > > > copies weren't. Therefore, the scripts as well as the manifests
> > > > weren't identical in Ant and Maven distributions. I solved that
> > > > problem by now taking the exact same files and copying them in the
> > > > assembly. The manifests needed minor tweaking which I am now doing
> > > > via
> > > an XSLT in the build.
> > > >
> > > > Also did I refactor everything just needed for FlashBuilder
> > > > support out into a separate assembly file. This way we have all
> > > > the stuff that doesn't seem to make sense in one place and if we
> > > > should decide to drop FB support, we just need to remove that
> assembly descriptor.
> > > >
> > > > Would be cool if you could give the changes a try.
> > > >
> > > > Please note that you need to checkout the feature branch
> > > > "feature/distribution" in both the compiler as well as the asjs
> > > > repo (For some reason my addition of the ACE typedef seems to have
> > > > gone to the develop branch of the typedef repo, so it should
> > > > already be
> > > available.
> > > >
> > > > Hope you like the changes and hope they work for you the same way
> > > > they do for me (I think Carlos also reported that he was
> > > > successfully able to compile every example he tried in VSCode with
> > > > it)
> > > >
> > > > The two PRs needing merging after review are:
> > > > Feature/distribution allignment by chrisdutz * Pull Request #180 *
> > > > apache/royale-compiler (github.com)<
> > > > https://github.com/apache/royale-compiler/pull/180>
> > > > Feature/distribution allignment by chrisdutz * Pull Request #1087
> > > > * apache/royale-asjs (github.com)<
> > > > https://github.com/apache/royale-asjs/pull/1087>
> > > >
> > > >
> > > > Chris
> > > >
> > > >
> > >
> > > --
> > >
> > > Piotr Zarzycki
> > >
> >
> >
> > --
> >
> > Piotr Zarzycki
> >
>
>
> --
>
> Piotr Zarzycki
>
--
Piotr Zarzycki
AW: PRs ready for distribution alignment
Posted by Christofer Dutz <ch...@c-ware.de>.
Hi Piotr,
It should work in both.
Chris
-----Ursprüngliche Nachricht-----
Von: Piotr Zarzycki <pi...@gmail.com>
Gesendet: Freitag, 5. März 2021 17:04
An: Apache Royale Development <de...@royale.apache.org>
Betreff: Re: PRs ready for distribution alignment
That options is working whether I build distribution in root folder of sdk and "distribution" folder as well ?
pt., 5 mar 2021 o 17:00 Christofer Dutz <ch...@c-ware.de>
napisał(a):
> Hi Piotr,
>
> If you don't explicitly define the profile "option-with-swf" it's the
> JS-only version.
>
> Chris
>
> -----Ursprüngliche Nachricht-----
> Von: Piotr Zarzycki <pi...@gmail.com>
> Gesendet: Freitag, 5. März 2021 16:11
> An: Apache Royale Development <de...@royale.apache.org>
> Betreff: Re: PRs ready for distribution alignment
>
> Chris,
>
> frameworks/libs doesn't exists at all.
>
> What occurs to me that I actually don't know what kind of distribution
> package I'm building. Is it js-only distribution or is it js-swf
> distribution ?
>
> Thanks,
> Piotr
>
> pt., 5 mar 2021 o 15:41 Christofer Dutz <ch...@c-ware.de>
> napisał(a):
>
> > Hi Piotr,
> >
> > this is strange ... from the log output it seems as if the
> > "frameworks/libs" doesn't contain any of the libraries.
> > Could you please confirm if the directory really doesn't contain them?
> >
> > Chris
> >
> >
> >
> > -----Ursprüngliche Nachricht-----
> > Von: Piotr Zarzycki <pi...@gmail.com>
> > Gesendet: Freitag, 5. März 2021 12:19
> > An: Apache Royale Development <de...@royale.apache.org>
> > Betreff: Re: PRs ready for distribution alignment
> >
> > Hi Chris,
> >
> > Thanks for all work. After rebuilding whole framework I just tried
> > produce distribution by going to the folder of it and do:
> >
> > mvn clean install
> > -DdistributionTargetFolder=d:\Work\royale_ide\distribution
> >
> > It works without doing set
> > distributionTargetFolder=d:\Work\royale_ide\distribution.
> >
> > I went to Moonshine and tried to build with produced distribution
> > our project and I got following errors - I won't post here full
> > stacktrace [1]
> >
> > [1] https://paste.apache.org/c2qv1
> >
> > Thanks,
> > Piotr
> >
> >
> >
> >
> >
> >
> >
> >
> > pt., 5 mar 2021 o 10:10 Christofer Dutz <ch...@c-ware.de>
> > napisał(a):
> >
> > > Hi all,
> > >
> > > I have, as far as I know, finished the work on aligning the Maven
> > > built and the Ant built distribution.
> > > A few things have changed in the Maven distribution compared to
> > > the earlier ones:
> > >
> > >
> > > * All scripts (in the bin and js/bin) directory are now identical
> to
> > > the ones in the Ant distribution.
> > > * The manifests are no longer contained in a "manifests" directory
> > but
> > > are in the same location as they are for the Ant build.
> > > * I now include the sources of the projects, which should simplify
> > > debugging.
> > >
> > > The probably most important change is that I no longer have copies
> > > of the scripts and main manifests in the distribution resources.
> > > These resources now only contain the empty dummy files needed by
> > > FlashBuilder. It seems these were updated in the project, but the
> > > copies weren't. Therefore, the scripts as well as the manifests
> > > weren't identical in Ant and Maven distributions. I solved that
> > > problem by now taking the exact same files and copying them in the
> > > assembly. The manifests needed minor tweaking which I am now doing
> > > via
> > an XSLT in the build.
> > >
> > > Also did I refactor everything just needed for FlashBuilder
> > > support out into a separate assembly file. This way we have all
> > > the stuff that doesn't seem to make sense in one place and if we
> > > should decide to drop FB support, we just need to remove that assembly descriptor.
> > >
> > > Would be cool if you could give the changes a try.
> > >
> > > Please note that you need to checkout the feature branch
> > > "feature/distribution" in both the compiler as well as the asjs
> > > repo (For some reason my addition of the ACE typedef seems to have
> > > gone to the develop branch of the typedef repo, so it should
> > > already be
> > available.
> > >
> > > Hope you like the changes and hope they work for you the same way
> > > they do for me (I think Carlos also reported that he was
> > > successfully able to compile every example he tried in VSCode with
> > > it)
> > >
> > > The two PRs needing merging after review are:
> > > Feature/distribution allignment by chrisdutz * Pull Request #180 *
> > > apache/royale-compiler (github.com)<
> > > https://github.com/apache/royale-compiler/pull/180>
> > > Feature/distribution allignment by chrisdutz * Pull Request #1087
> > > * apache/royale-asjs (github.com)<
> > > https://github.com/apache/royale-asjs/pull/1087>
> > >
> > >
> > > Chris
> > >
> > >
> >
> > --
> >
> > Piotr Zarzycki
> >
>
>
> --
>
> Piotr Zarzycki
>
--
Piotr Zarzycki
Re: PRs ready for distribution alignment
Posted by Piotr Zarzycki <pi...@gmail.com>.
That options is working whether I build distribution in root folder of sdk
and "distribution" folder as well ?
pt., 5 mar 2021 o 17:00 Christofer Dutz <ch...@c-ware.de>
napisał(a):
> Hi Piotr,
>
> If you don't explicitly define the profile "option-with-swf" it's the
> JS-only version.
>
> Chris
>
> -----Ursprüngliche Nachricht-----
> Von: Piotr Zarzycki <pi...@gmail.com>
> Gesendet: Freitag, 5. März 2021 16:11
> An: Apache Royale Development <de...@royale.apache.org>
> Betreff: Re: PRs ready for distribution alignment
>
> Chris,
>
> frameworks/libs doesn't exists at all.
>
> What occurs to me that I actually don't know what kind of distribution
> package I'm building. Is it js-only distribution or is it js-swf
> distribution ?
>
> Thanks,
> Piotr
>
> pt., 5 mar 2021 o 15:41 Christofer Dutz <ch...@c-ware.de>
> napisał(a):
>
> > Hi Piotr,
> >
> > this is strange ... from the log output it seems as if the
> > "frameworks/libs" doesn't contain any of the libraries.
> > Could you please confirm if the directory really doesn't contain them?
> >
> > Chris
> >
> >
> >
> > -----Ursprüngliche Nachricht-----
> > Von: Piotr Zarzycki <pi...@gmail.com>
> > Gesendet: Freitag, 5. März 2021 12:19
> > An: Apache Royale Development <de...@royale.apache.org>
> > Betreff: Re: PRs ready for distribution alignment
> >
> > Hi Chris,
> >
> > Thanks for all work. After rebuilding whole framework I just tried
> > produce distribution by going to the folder of it and do:
> >
> > mvn clean install
> > -DdistributionTargetFolder=d:\Work\royale_ide\distribution
> >
> > It works without doing set
> > distributionTargetFolder=d:\Work\royale_ide\distribution.
> >
> > I went to Moonshine and tried to build with produced distribution our
> > project and I got following errors - I won't post here full stacktrace
> > [1]
> >
> > [1] https://paste.apache.org/c2qv1
> >
> > Thanks,
> > Piotr
> >
> >
> >
> >
> >
> >
> >
> >
> > pt., 5 mar 2021 o 10:10 Christofer Dutz <ch...@c-ware.de>
> > napisał(a):
> >
> > > Hi all,
> > >
> > > I have, as far as I know, finished the work on aligning the Maven
> > > built and the Ant built distribution.
> > > A few things have changed in the Maven distribution compared to the
> > > earlier ones:
> > >
> > >
> > > * All scripts (in the bin and js/bin) directory are now identical
> to
> > > the ones in the Ant distribution.
> > > * The manifests are no longer contained in a "manifests" directory
> > but
> > > are in the same location as they are for the Ant build.
> > > * I now include the sources of the projects, which should simplify
> > > debugging.
> > >
> > > The probably most important change is that I no longer have copies
> > > of the scripts and main manifests in the distribution resources.
> > > These resources now only contain the empty dummy files needed by
> > > FlashBuilder. It seems these were updated in the project, but the
> > > copies weren't. Therefore, the scripts as well as the manifests
> > > weren't identical in Ant and Maven distributions. I solved that
> > > problem by now taking the exact same files and copying them in the
> > > assembly. The manifests needed minor tweaking which I am now doing
> > > via
> > an XSLT in the build.
> > >
> > > Also did I refactor everything just needed for FlashBuilder support
> > > out into a separate assembly file. This way we have all the stuff
> > > that doesn't seem to make sense in one place and if we should decide
> > > to drop FB support, we just need to remove that assembly descriptor.
> > >
> > > Would be cool if you could give the changes a try.
> > >
> > > Please note that you need to checkout the feature branch
> > > "feature/distribution" in both the compiler as well as the asjs repo
> > > (For some reason my addition of the ACE typedef seems to have gone
> > > to the develop branch of the typedef repo, so it should already be
> > available.
> > >
> > > Hope you like the changes and hope they work for you the same way
> > > they do for me (I think Carlos also reported that he was
> > > successfully able to compile every example he tried in VSCode with
> > > it)
> > >
> > > The two PRs needing merging after review are:
> > > Feature/distribution allignment by chrisdutz * Pull Request #180 *
> > > apache/royale-compiler (github.com)<
> > > https://github.com/apache/royale-compiler/pull/180>
> > > Feature/distribution allignment by chrisdutz * Pull Request #1087 *
> > > apache/royale-asjs (github.com)<
> > > https://github.com/apache/royale-asjs/pull/1087>
> > >
> > >
> > > Chris
> > >
> > >
> >
> > --
> >
> > Piotr Zarzycki
> >
>
>
> --
>
> Piotr Zarzycki
>
--
Piotr Zarzycki
AW: PRs ready for distribution alignment
Posted by Christofer Dutz <ch...@c-ware.de>.
Hi Piotr,
If you don't explicitly define the profile "option-with-swf" it's the JS-only version.
Chris
-----Ursprüngliche Nachricht-----
Von: Piotr Zarzycki <pi...@gmail.com>
Gesendet: Freitag, 5. März 2021 16:11
An: Apache Royale Development <de...@royale.apache.org>
Betreff: Re: PRs ready for distribution alignment
Chris,
frameworks/libs doesn't exists at all.
What occurs to me that I actually don't know what kind of distribution package I'm building. Is it js-only distribution or is it js-swf distribution ?
Thanks,
Piotr
pt., 5 mar 2021 o 15:41 Christofer Dutz <ch...@c-ware.de>
napisał(a):
> Hi Piotr,
>
> this is strange ... from the log output it seems as if the
> "frameworks/libs" doesn't contain any of the libraries.
> Could you please confirm if the directory really doesn't contain them?
>
> Chris
>
>
>
> -----Ursprüngliche Nachricht-----
> Von: Piotr Zarzycki <pi...@gmail.com>
> Gesendet: Freitag, 5. März 2021 12:19
> An: Apache Royale Development <de...@royale.apache.org>
> Betreff: Re: PRs ready for distribution alignment
>
> Hi Chris,
>
> Thanks for all work. After rebuilding whole framework I just tried
> produce distribution by going to the folder of it and do:
>
> mvn clean install
> -DdistributionTargetFolder=d:\Work\royale_ide\distribution
>
> It works without doing set
> distributionTargetFolder=d:\Work\royale_ide\distribution.
>
> I went to Moonshine and tried to build with produced distribution our
> project and I got following errors - I won't post here full stacktrace
> [1]
>
> [1] https://paste.apache.org/c2qv1
>
> Thanks,
> Piotr
>
>
>
>
>
>
>
>
> pt., 5 mar 2021 o 10:10 Christofer Dutz <ch...@c-ware.de>
> napisał(a):
>
> > Hi all,
> >
> > I have, as far as I know, finished the work on aligning the Maven
> > built and the Ant built distribution.
> > A few things have changed in the Maven distribution compared to the
> > earlier ones:
> >
> >
> > * All scripts (in the bin and js/bin) directory are now identical to
> > the ones in the Ant distribution.
> > * The manifests are no longer contained in a "manifests" directory
> but
> > are in the same location as they are for the Ant build.
> > * I now include the sources of the projects, which should simplify
> > debugging.
> >
> > The probably most important change is that I no longer have copies
> > of the scripts and main manifests in the distribution resources.
> > These resources now only contain the empty dummy files needed by
> > FlashBuilder. It seems these were updated in the project, but the
> > copies weren't. Therefore, the scripts as well as the manifests
> > weren't identical in Ant and Maven distributions. I solved that
> > problem by now taking the exact same files and copying them in the
> > assembly. The manifests needed minor tweaking which I am now doing
> > via
> an XSLT in the build.
> >
> > Also did I refactor everything just needed for FlashBuilder support
> > out into a separate assembly file. This way we have all the stuff
> > that doesn't seem to make sense in one place and if we should decide
> > to drop FB support, we just need to remove that assembly descriptor.
> >
> > Would be cool if you could give the changes a try.
> >
> > Please note that you need to checkout the feature branch
> > "feature/distribution" in both the compiler as well as the asjs repo
> > (For some reason my addition of the ACE typedef seems to have gone
> > to the develop branch of the typedef repo, so it should already be
> available.
> >
> > Hope you like the changes and hope they work for you the same way
> > they do for me (I think Carlos also reported that he was
> > successfully able to compile every example he tried in VSCode with
> > it)
> >
> > The two PRs needing merging after review are:
> > Feature/distribution allignment by chrisdutz * Pull Request #180 *
> > apache/royale-compiler (github.com)<
> > https://github.com/apache/royale-compiler/pull/180>
> > Feature/distribution allignment by chrisdutz * Pull Request #1087 *
> > apache/royale-asjs (github.com)<
> > https://github.com/apache/royale-asjs/pull/1087>
> >
> >
> > Chris
> >
> >
>
> --
>
> Piotr Zarzycki
>
--
Piotr Zarzycki
Re: PRs ready for distribution alignment
Posted by Piotr Zarzycki <pi...@gmail.com>.
Chris,
frameworks/libs doesn't exists at all.
What occurs to me that I actually don't know what kind of distribution
package I'm building. Is it js-only distribution or is it js-swf
distribution ?
Thanks,
Piotr
pt., 5 mar 2021 o 15:41 Christofer Dutz <ch...@c-ware.de>
napisał(a):
> Hi Piotr,
>
> this is strange ... from the log output it seems as if the
> "frameworks/libs" doesn't contain any of the libraries.
> Could you please confirm if the directory really doesn't contain them?
>
> Chris
>
>
>
> -----Ursprüngliche Nachricht-----
> Von: Piotr Zarzycki <pi...@gmail.com>
> Gesendet: Freitag, 5. März 2021 12:19
> An: Apache Royale Development <de...@royale.apache.org>
> Betreff: Re: PRs ready for distribution alignment
>
> Hi Chris,
>
> Thanks for all work. After rebuilding whole framework I just tried produce
> distribution by going to the folder of it and do:
>
> mvn clean install
> -DdistributionTargetFolder=d:\Work\royale_ide\distribution
>
> It works without doing set
> distributionTargetFolder=d:\Work\royale_ide\distribution.
>
> I went to Moonshine and tried to build with produced distribution our
> project and I got following errors - I won't post here full stacktrace [1]
>
> [1] https://paste.apache.org/c2qv1
>
> Thanks,
> Piotr
>
>
>
>
>
>
>
>
> pt., 5 mar 2021 o 10:10 Christofer Dutz <ch...@c-ware.de>
> napisał(a):
>
> > Hi all,
> >
> > I have, as far as I know, finished the work on aligning the Maven
> > built and the Ant built distribution.
> > A few things have changed in the Maven distribution compared to the
> > earlier ones:
> >
> >
> > * All scripts (in the bin and js/bin) directory are now identical to
> > the ones in the Ant distribution.
> > * The manifests are no longer contained in a "manifests" directory
> but
> > are in the same location as they are for the Ant build.
> > * I now include the sources of the projects, which should simplify
> > debugging.
> >
> > The probably most important change is that I no longer have copies of
> > the scripts and main manifests in the distribution resources. These
> > resources now only contain the empty dummy files needed by
> > FlashBuilder. It seems these were updated in the project, but the
> > copies weren't. Therefore, the scripts as well as the manifests
> > weren't identical in Ant and Maven distributions. I solved that
> > problem by now taking the exact same files and copying them in the
> > assembly. The manifests needed minor tweaking which I am now doing via
> an XSLT in the build.
> >
> > Also did I refactor everything just needed for FlashBuilder support
> > out into a separate assembly file. This way we have all the stuff that
> > doesn't seem to make sense in one place and if we should decide to
> > drop FB support, we just need to remove that assembly descriptor.
> >
> > Would be cool if you could give the changes a try.
> >
> > Please note that you need to checkout the feature branch
> > "feature/distribution" in both the compiler as well as the asjs repo
> > (For some reason my addition of the ACE typedef seems to have gone to
> > the develop branch of the typedef repo, so it should already be
> available.
> >
> > Hope you like the changes and hope they work for you the same way they
> > do for me (I think Carlos also reported that he was successfully able
> > to compile every example he tried in VSCode with it)
> >
> > The two PRs needing merging after review are:
> > Feature/distribution allignment by chrisdutz * Pull Request #180 *
> > apache/royale-compiler (github.com)<
> > https://github.com/apache/royale-compiler/pull/180>
> > Feature/distribution allignment by chrisdutz * Pull Request #1087 *
> > apache/royale-asjs (github.com)<
> > https://github.com/apache/royale-asjs/pull/1087>
> >
> >
> > Chris
> >
> >
>
> --
>
> Piotr Zarzycki
>
--
Piotr Zarzycki
AW: PRs ready for distribution alignment
Posted by Christofer Dutz <ch...@c-ware.de>.
Hi Piotr,
this is strange ... from the log output it seems as if the "frameworks/libs" doesn't contain any of the libraries.
Could you please confirm if the directory really doesn't contain them?
Chris
-----Ursprüngliche Nachricht-----
Von: Piotr Zarzycki <pi...@gmail.com>
Gesendet: Freitag, 5. März 2021 12:19
An: Apache Royale Development <de...@royale.apache.org>
Betreff: Re: PRs ready for distribution alignment
Hi Chris,
Thanks for all work. After rebuilding whole framework I just tried produce distribution by going to the folder of it and do:
mvn clean install -DdistributionTargetFolder=d:\Work\royale_ide\distribution
It works without doing set
distributionTargetFolder=d:\Work\royale_ide\distribution.
I went to Moonshine and tried to build with produced distribution our project and I got following errors - I won't post here full stacktrace [1]
[1] https://paste.apache.org/c2qv1
Thanks,
Piotr
pt., 5 mar 2021 o 10:10 Christofer Dutz <ch...@c-ware.de>
napisał(a):
> Hi all,
>
> I have, as far as I know, finished the work on aligning the Maven
> built and the Ant built distribution.
> A few things have changed in the Maven distribution compared to the
> earlier ones:
>
>
> * All scripts (in the bin and js/bin) directory are now identical to
> the ones in the Ant distribution.
> * The manifests are no longer contained in a "manifests" directory but
> are in the same location as they are for the Ant build.
> * I now include the sources of the projects, which should simplify
> debugging.
>
> The probably most important change is that I no longer have copies of
> the scripts and main manifests in the distribution resources. These
> resources now only contain the empty dummy files needed by
> FlashBuilder. It seems these were updated in the project, but the
> copies weren't. Therefore, the scripts as well as the manifests
> weren't identical in Ant and Maven distributions. I solved that
> problem by now taking the exact same files and copying them in the
> assembly. The manifests needed minor tweaking which I am now doing via an XSLT in the build.
>
> Also did I refactor everything just needed for FlashBuilder support
> out into a separate assembly file. This way we have all the stuff that
> doesn't seem to make sense in one place and if we should decide to
> drop FB support, we just need to remove that assembly descriptor.
>
> Would be cool if you could give the changes a try.
>
> Please note that you need to checkout the feature branch
> "feature/distribution" in both the compiler as well as the asjs repo
> (For some reason my addition of the ACE typedef seems to have gone to
> the develop branch of the typedef repo, so it should already be available.
>
> Hope you like the changes and hope they work for you the same way they
> do for me (I think Carlos also reported that he was successfully able
> to compile every example he tried in VSCode with it)
>
> The two PRs needing merging after review are:
> Feature/distribution allignment by chrisdutz * Pull Request #180 *
> apache/royale-compiler (github.com)<
> https://github.com/apache/royale-compiler/pull/180>
> Feature/distribution allignment by chrisdutz * Pull Request #1087 *
> apache/royale-asjs (github.com)<
> https://github.com/apache/royale-asjs/pull/1087>
>
>
> Chris
>
>
--
Piotr Zarzycki
Re: PRs ready for distribution alignment
Posted by Piotr Zarzycki <pi...@gmail.com>.
Hi Chris,
Thanks for all work. After rebuilding whole framework I just tried produce
distribution by going to the folder of it and do:
mvn clean install -DdistributionTargetFolder=d:\Work\royale_ide\distribution
It works without doing set
distributionTargetFolder=d:\Work\royale_ide\distribution.
I went to Moonshine and tried to build with produced distribution our
project and I got following errors - I won't post here full stacktrace [1]
[1] https://paste.apache.org/c2qv1
Thanks,
Piotr
pt., 5 mar 2021 o 10:10 Christofer Dutz <ch...@c-ware.de>
napisał(a):
> Hi all,
>
> I have, as far as I know, finished the work on aligning the Maven built
> and the Ant built distribution.
> A few things have changed in the Maven distribution compared to the
> earlier ones:
>
>
> * All scripts (in the bin and js/bin) directory are now identical to
> the ones in the Ant distribution.
> * The manifests are no longer contained in a "manifests" directory but
> are in the same location as they are for the Ant build.
> * I now include the sources of the projects, which should simplify
> debugging.
>
> The probably most important change is that I no longer have copies of the
> scripts and main manifests in the distribution resources. These resources
> now only contain the empty dummy files needed by FlashBuilder. It seems
> these were updated in the project, but the copies weren't. Therefore, the
> scripts as well as the manifests weren't identical in Ant and Maven
> distributions. I solved that problem by now taking the exact same files and
> copying them in the assembly. The manifests needed minor tweaking which I
> am now doing via an XSLT in the build.
>
> Also did I refactor everything just needed for FlashBuilder support out
> into a separate assembly file. This way we have all the stuff that doesn't
> seem to make sense in one place and if we should decide to drop FB support,
> we just need to remove that assembly descriptor.
>
> Would be cool if you could give the changes a try.
>
> Please note that you need to checkout the feature branch
> "feature/distribution" in both the compiler as well as the asjs repo (For
> some reason my addition of the ACE typedef seems to have gone to the
> develop branch of the typedef repo, so it should already be available.
>
> Hope you like the changes and hope they work for you the same way they do
> for me (I think Carlos also reported that he was successfully able to
> compile every example he tried in VSCode with it)
>
> The two PRs needing merging after review are:
> Feature/distribution allignment by chrisdutz * Pull Request #180 *
> apache/royale-compiler (github.com)<
> https://github.com/apache/royale-compiler/pull/180>
> Feature/distribution allignment by chrisdutz * Pull Request #1087 *
> apache/royale-asjs (github.com)<
> https://github.com/apache/royale-asjs/pull/1087>
>
>
> Chris
>
>
--
Piotr Zarzycki