You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@aurora.apache.org by Zameer Manji <zm...@apache.org> on 2017/03/07 02:35:14 UTC
Review Request 57357: Remove SerializableClock interface.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57357/
-----------------------------------------------------------
Review request for Aurora and Mehrdad Nurolahzade.
Repository: aurora
Description
-------
This removes the `SerializableClock` interface. We are not serializing `Clock`
classes anywhere, so this should be safe to remove.
Diffs
-----
commons/src/main/java/org/apache/aurora/common/util/Clock.java 87afb4ee0072d9a95c79c128042bc63cfafa74e2
Diff: https://reviews.apache.org/r/57357/diff/1/
Testing
-------
Thanks,
Zameer Manji
Re: Review Request 57357: Remove SerializableClock interface.
Posted by Zameer Manji <zm...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57357/#review168090
-----------------------------------------------------------
@ReviewBot retry
- Zameer Manji
On March 6, 2017, 6:42 p.m., Zameer Manji wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57357/
> -----------------------------------------------------------
>
> (Updated March 6, 2017, 6:42 p.m.)
>
>
> Review request for Aurora and Mehrdad Nurolahzade.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> This removes the `SerializableClock` interface. We are not serializing `Clock`
> classes anywhere, so this should be safe to remove.
>
>
> Diffs
> -----
>
> commons/src/main/java/org/apache/aurora/common/util/Clock.java 87afb4ee0072d9a95c79c128042bc63cfafa74e2
>
>
> Diff: https://reviews.apache.org/r/57357/diff/2/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Zameer Manji
>
>
Re: Review Request 57357: Remove SerializableClock interface.
Posted by Aurora ReviewBot <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57357/#review168081
-----------------------------------------------------------
Ship it!
Master (705dbc7) is green with this patch.
./build-support/jenkins/build.sh
I will refresh this build result if you post a review containing "@ReviewBot retry"
- Aurora ReviewBot
On March 7, 2017, 2:42 a.m., Zameer Manji wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57357/
> -----------------------------------------------------------
>
> (Updated March 7, 2017, 2:42 a.m.)
>
>
> Review request for Aurora and Mehrdad Nurolahzade.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> This removes the `SerializableClock` interface. We are not serializing `Clock`
> classes anywhere, so this should be safe to remove.
>
>
> Diffs
> -----
>
> commons/src/main/java/org/apache/aurora/common/util/Clock.java 87afb4ee0072d9a95c79c128042bc63cfafa74e2
>
>
> Diff: https://reviews.apache.org/r/57357/diff/2/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Zameer Manji
>
>
Re: Review Request 57357: Remove SerializableClock interface.
Posted by Aurora ReviewBot <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57357/#review168092
-----------------------------------------------------------
Ship it!
Master (705dbc7) is green with this patch.
./build-support/jenkins/build.sh
I will refresh this build result if you post a review containing "@ReviewBot retry"
- Aurora ReviewBot
On March 6, 2017, 6:42 p.m., Zameer Manji wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57357/
> -----------------------------------------------------------
>
> (Updated March 6, 2017, 6:42 p.m.)
>
>
> Review request for Aurora and Mehrdad Nurolahzade.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> This removes the `SerializableClock` interface. We are not serializing `Clock`
> classes anywhere, so this should be safe to remove.
>
>
> Diffs
> -----
>
> commons/src/main/java/org/apache/aurora/common/util/Clock.java 87afb4ee0072d9a95c79c128042bc63cfafa74e2
>
>
> Diff: https://reviews.apache.org/r/57357/diff/2/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Zameer Manji
>
>
Re: Review Request 57357: Remove SerializableClock interface.
Posted by Mehrdad Nurolahzade <me...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57357/#review168086
-----------------------------------------------------------
Ship it!
Ship It!
- Mehrdad Nurolahzade
On March 6, 2017, 6:42 p.m., Zameer Manji wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57357/
> -----------------------------------------------------------
>
> (Updated March 6, 2017, 6:42 p.m.)
>
>
> Review request for Aurora and Mehrdad Nurolahzade.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> This removes the `SerializableClock` interface. We are not serializing `Clock`
> classes anywhere, so this should be safe to remove.
>
>
> Diffs
> -----
>
> commons/src/main/java/org/apache/aurora/common/util/Clock.java 87afb4ee0072d9a95c79c128042bc63cfafa74e2
>
>
> Diff: https://reviews.apache.org/r/57357/diff/2/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Zameer Manji
>
>
Re: Review Request 57357: Remove SerializableClock interface.
Posted by Zameer Manji <zm...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57357/
-----------------------------------------------------------
(Updated March 6, 2017, 6:42 p.m.)
Review request for Aurora and Mehrdad Nurolahzade.
Changes
-------
Add TODO to replace this with something more reasonable.
Repository: aurora
Description
-------
This removes the `SerializableClock` interface. We are not serializing `Clock`
classes anywhere, so this should be safe to remove.
Diffs (updated)
-----
commons/src/main/java/org/apache/aurora/common/util/Clock.java 87afb4ee0072d9a95c79c128042bc63cfafa74e2
Diff: https://reviews.apache.org/r/57357/diff/2/
Changes: https://reviews.apache.org/r/57357/diff/1-2/
Testing
-------
Thanks,
Zameer Manji