You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@maven.apache.org by hb...@apache.org on 2018/05/21 16:52:32 UTC

[maven-integration-testing] 02/02: Fixed IT's related to JDK 9 o Need to separate between JDK..8 and JDK 9 cause the error output looks different for JDK 9.

This is an automated email from the ASF dual-hosted git repository.

hboutemy pushed a commit to branch MNG-6364
in repository https://gitbox.apache.org/repos/asf/maven-integration-testing.git

commit b06408906d47dfb7723270036ee46347a02b54dd
Author: Karl Heinz Marbaise <kh...@apache.org>
AuthorDate: Sun Feb 18 20:10:46 2018 +0100

    Fixed IT's related to JDK 9
     o Need to separate between JDK..8 and JDK 9 cause
       the error output looks different for JDK 9.
---
 .../MavenITmng5958LifecyclePhaseBinaryCompat.java  | 28 ++++++++++++++++++----
 1 file changed, 24 insertions(+), 4 deletions(-)

diff --git a/core-it-suite/src/test/java/org/apache/maven/it/MavenITmng5958LifecyclePhaseBinaryCompat.java b/core-it-suite/src/test/java/org/apache/maven/it/MavenITmng5958LifecyclePhaseBinaryCompat.java
index 3ee3fe1..4891fe2 100644
--- a/core-it-suite/src/test/java/org/apache/maven/it/MavenITmng5958LifecyclePhaseBinaryCompat.java
+++ b/core-it-suite/src/test/java/org/apache/maven/it/MavenITmng5958LifecyclePhaseBinaryCompat.java
@@ -17,19 +17,20 @@ public class MavenITmng5958LifecyclePhaseBinaryCompat
         throws Exception
     {
         File testDir = ResourceExtractor.simpleExtractResources( getClass(), "/mng-5958-lifecycle-phases/good" );
-        
+
         Verifier verifier = newVerifier( testDir.getAbsolutePath() );
         verifier.executeGoal( "validate" );
         verifier.verifyErrorFreeLog();
         verifier.verifyTextInLog( "CLASS_NAME=java.lang.String" );
         verifier.resetStreams();
     }
-    
-    public void testBad()
+
+    public void testBadTillJDK8()
         throws Exception
     {
+        requiresJavaVersion( "[,1.8]" );
         File testDir = ResourceExtractor.simpleExtractResources( getClass(), "/mng-5958-lifecycle-phases/bad" );
-        
+
         Verifier verifier = newVerifier( testDir.getAbsolutePath() );
         try
         {
@@ -42,4 +43,23 @@ public class MavenITmng5958LifecyclePhaseBinaryCompat
         }
         verifier.resetStreams();
     }
+
+    public void testBadJDK9()
+        throws Exception
+    {
+        requiresJavaVersion( "[9.0,)" );
+        File testDir = ResourceExtractor.simpleExtractResources( getClass(), "/mng-5958-lifecycle-phases/bad" );
+        
+        Verifier verifier = newVerifier( testDir.getAbsolutePath() );
+        try
+        {
+            verifier.executeGoal( "validate" );
+        }
+        catch ( VerificationException e )
+        {
+            verifier.verifyTextInLog( "[ERROR] Internal error: java.lang.ClassCastException: "
+                + "org.apache.maven.lifecycle.mapping.LifecyclePhase cannot be cast to java.base/java.lang.String -> [Help 1]" );
+        }
+        verifier.resetStreams();
+    }
 }

-- 
To stop receiving notification emails like this one, please contact
hboutemy@apache.org.