You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2021/05/02 04:07:43 UTC

[GitHub] [spark] AngersZhuuuu commented on a change in pull request #32271: [SPARK-35112][SQL] Support Cast string to day-second interval

AngersZhuuuu commented on a change in pull request #32271:
URL: https://github.com/apache/spark/pull/32271#discussion_r624611785



##########
File path: sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/CastSuite.scala
##########
@@ -1775,6 +1775,48 @@ class CastSuite extends CastSuiteBase {
     }
   }
 
+  test("SPARK-35112: Cast string to day-time interval") {
+    checkEvaluation(cast(Literal.create("0 0:0:0"), DayTimeIntervalType), 0L)
+    checkEvaluation(cast(Literal.create("INTERVAL '0 0:0:0' DAY TO SECOND"),

Review comment:
       > @AngersZhuuuu Your force push reverted the changes I approved. Please, revert them back.
   
   Updated




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org