[GitHub] [httpd] michael-o commented on a change in pull request #177: Add SSL_{CLIENT,SERVER}_B64CERT

[GitBox <gi...@apache.org>]

michael-o commented on a change in pull request #177:
URL: https://github.com/apache/httpd/pull/177#discussion_r590740544



##########
File path: modules/ssl/ssl_engine_vars.c
##########
@@ -71,6 +76,21 @@ static int ssl_is_https(conn_rec *c)
     return sslconn && sslconn->ssl;
 }
 
+#if APR_VERSION_AT_LEAST(1,7,0)

Review comment:
       Is this really available in 1.7.0+ only?

##########
File path: modules/ssl/ssl_engine_vars.c
##########
@@ -71,6 +76,21 @@ static int ssl_is_https(conn_rec *c)
     return sslconn && sslconn->ssl;
 }
 
+#if APR_VERSION_AT_LEAST(1,7,0)
+static const char *ssl_var_lookup_ssl_cert_b64url(apr_pool_t *p, X509 *xs)

Review comment:
       The function name is wrong now.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@httpd.apache.org
For additional commands, e-mail: notifications-help@httpd.apache.org