You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2020/06/30 12:16:38 UTC
[GitHub] [airflow] kaxil opened a new pull request #9589: Fix failing test in test_webserver_command
kaxil opened a new pull request #9589:
URL: https://github.com/apache/airflow/pull/9589
Test was failing:
```
FAILED tests/cli/commands/test_webserver_command.py::TestCliWebServer::test_cli_webserver_shutdown_when_gunicorn_master_is_killed
```
```
if not self.create and original is DEFAULT:
raise AttributeError(
> "{} does not have the attribute {!r}".format(target, name)
)
E AttributeError: <module 'airflow.bin.cli' from '/opt/airflow/airflow/bin/cli.py'> does not have the attribute 'get_num_workers_running'
/usr/local/lib/python3.5/site-packages/mock/mock.py:1368: AttributeError
```
---
Make sure to mark the boxes below before creating PR: [x]
- [x] Description above provides context of the change
- [x] Unit tests coverage for changes (not needed for documentation changes)
- [x] Target Github ISSUE in description if exists
- [x] Commits follow "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)"
- [x] Relevant documentation is updated including usage instructions.
- [x] I will engage committers as explained in [Contribution Workflow Example](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#contribution-workflow-example).
---
In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/master/UPDATING.md).
Read the [Pull Request Guidelines](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#pull-request-guidelines) for more information.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] kaxil merged pull request #9589: Fix failing test in test_webserver_command
Posted by GitBox <gi...@apache.org>.
kaxil merged pull request #9589:
URL: https://github.com/apache/airflow/pull/9589
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] mik-laj commented on pull request #9589: Fix failing test in test_webserver_command
Posted by GitBox <gi...@apache.org>.
mik-laj commented on pull request #9589:
URL: https://github.com/apache/airflow/pull/9589#issuecomment-651775441
Og. I'm sorry for the trouble. I did not notice that these tests did not run.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] kaxil commented on pull request #9589: Fix failing test in test_webserver_command
Posted by GitBox <gi...@apache.org>.
kaxil commented on pull request #9589:
URL: https://github.com/apache/airflow/pull/9589#issuecomment-651756484
We also need to backport this PR to v1-10-test as tests are failing on that branch too
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] kaxil commented on pull request #9589: Fix failing test in test_webserver_command
Posted by GitBox <gi...@apache.org>.
kaxil commented on pull request #9589:
URL: https://github.com/apache/airflow/pull/9589#issuecomment-651776243
> Og. I'm sorry for the trouble. I did not notice that these tests did not run.
:) No worries at all, happens to all of us . Thanks for approving
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org