Re: Review Request 37541: Add trace event API

[Cong Wang <cw...@twopensource.com>]

> On Nov. 24, 2015, 12:53 a.m., Vinod Kone wrote:
> > src/linux/perf.hpp, lines 108-110
> > <https://reviews.apache.org/r/37541/diff/9/?file=1087482#file1087482line108>
> >
> >     why are these public?

Easy to access, instead of adding a get/set for each of them.


> On Nov. 24, 2015, 12:53 a.m., Vinod Kone wrote:
> > src/linux/perf.cpp, lines 1125-1128
> > <https://reviews.apache.org/r/37541/diff/9/?file=1087483#file1087483line1125>
> >
> >     this could use some comments.

What comments do you expect here? Some comment to explain what ID is? I thought the code is clear.


> On Nov. 24, 2015, 12:53 a.m., Vinod Kone wrote:
> > src/tests/containerizer/cgroups_tests.cpp, line 1105
> > <https://reviews.apache.org/r/37541/diff/9/?file=1087484#file1087484line1105>
> >
> >     no need for this?

We need this, otherwise we would still hold a ref to the cgroup which causes a failure to destroy it later.


> On Nov. 24, 2015, 12:53 a.m., Vinod Kone wrote:
> > src/linux/perf.cpp, lines 974-1029
> > <https://reviews.apache.org/r/37541/diff/9/?file=1087483#file1087483line974>
> >
> >     this could use some comments.

I will add some ASCII arts here to draw the ring buffer.


- Cong


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37541/#review107680
-----------------------------------------------------------


On Sept. 30, 2015, 12:14 a.m., Cong Wang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37541/
> -----------------------------------------------------------
> 
> (Updated Sept. 30, 2015, 12:14 a.m.)
> 
> 
> Review request for mesos, Chi Zhang, Ian Downes, Jie Yu, and Vinod Kone.
> 
> 
> Bugs: MESOS-2769
>     https://issues.apache.org/jira/browse/MESOS-2769
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Based on the PerfEvent API's, add API for Linux kernel trace events, especially the schedule trace events.
> 
> 
> Diffs
> -----
> 
>   src/linux/perf.hpp d10968ca670eb516bae08385fd0ddde8e8ad83b5 
>   src/linux/perf.cpp f7035ddb2507a7646d88dd517d048018f695448a 
>   src/tests/containerizer/cgroups_tests.cpp 75a3bc0009c037dc18ce319db2eb44630f083e8c 
>   src/tests/containerizer/perf_tests.cpp ed5212ee31b8aa47339b8b8fab184bbdf85be82a 
> 
> Diff: https://reviews.apache.org/r/37541/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Cong Wang
> 
>