You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@thrift.apache.org by "Jens Geyer (JIRA)" <ji...@apache.org> on 2013/05/10 19:27:16 UTC
[jira] [Comment Edited] (THRIFT-1965) Adds dot (graph language)
generator
[ https://issues.apache.org/jira/browse/THRIFT-1965?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13654624#comment-13654624 ]
Jens Geyer edited comment on THRIFT-1965 at 5/10/13 5:26 PM:
-------------------------------------------------------------
I just tried it and I think it is a great documentation tool. Nice idea! (y)
A few comments:
1. Can the layout of the generated graphis be improved somehow? I rendered the Cassandra 1.1.0 interface and converted it into PNG using "sfdp -Gsize=67! -Goverlap=prism -Tpng file.gv > file.png" and got [this huge graphic|http://abload.de/img/cassandra_110c6yve.png] (~1.2 MB) where there is slight chaos especially around the Consistency enum. Maybe this a pure rendering issue only?
2. Another Thrift file gave me number of warnings "Warning: node Foo, port base_ unrecognized". The mentioned "base_" is a sub-struct referenced by the Foo structure.
was (Author: jensg):
I just tried it and I think it is a great documentation tool. Nice idea! (y)
A few comments:
1. Can the layout of the generated graphis be improved somehow? I rendered the Cassandra 1.1.0 interface and converted it into PNG using "sfdp -Gsize=67! -Goverlap=prism -Tpng file.gv > file.png" and got [this huge graphic|http://abload.de/img/cassandra_110c6yve.png] (~1.2 MB) where there is slight chaos especially around the Consistency enum.
2. I got a number of warnings "Warning: node Foo, port base_ unrecognized". The mentioned "base_" is a sub-struct referenced by the Foo structure.
> Adds dot (graph language) generator
> -----------------------------------
>
> Key: THRIFT-1965
> URL: https://issues.apache.org/jira/browse/THRIFT-1965
> Project: Thrift
> Issue Type: Improvement
> Reporter: Rodrigo Setti
> Priority: Minor
> Labels: generate
> Attachments: thrift-latest-gen-dot.patch
>
>
> Adds DOT - the graph language - generator.
> {noformat}
> thrift --gen dot
> {noformat}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira