You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by "lhotari (via GitHub)" <gi...@apache.org> on 2024/03/16 16:24:29 UTC

[I] IntelliJ checkstyle plugin dropped support for checkstyle 8.x, upgrade checkstyle to newer version [pulsar]

lhotari opened a new issue, #22286:
URL: https://github.com/apache/pulsar/issues/22286

   ### Search before asking
   
   - [X] I searched in the [issues](https://github.com/apache/pulsar/issues) and found nothing similar.
   
   
   ### Motivation
   
   [IntelliJ checkstyle plugin](https://plugins.jetbrains.com/plugin/1065-checkstyle-idea) dropped support for checkstyle 8.x in the 5.88.0 version update. 
   
   Fails with this error message:
   > The Checkstyle rules file could not be parsed. cannot initialize module TreeWalker - cannot initialize module JavadocMethod - Property 'scope' does not exist, please check the documentation The file has been blocked for 60s
   
   
   
   ### Solution
   
   - Upgrade `buildtools/src/main/resources/pulsar/checkstyle.xml` to support newer checkstyle 10.x version
   - Upgrade checkstyle to 10.x
   
   ### Alternatives
   
   _No response_
   
   ### Anything else?
   
   _No response_
   
   ### Are you willing to submit a PR?
   
   - [ ] I'm willing to submit a PR!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [I] IntelliJ checkstyle plugin dropped support for checkstyle 8.x, upgrade checkstyle to newer version [pulsar]

Posted by "lhotari (via GitHub)" <gi...@apache.org>.
lhotari closed issue #22286: IntelliJ checkstyle plugin dropped support for checkstyle 8.x, upgrade checkstyle to newer version
URL: https://github.com/apache/pulsar/issues/22286


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [I] IntelliJ checkstyle plugin dropped support for checkstyle 8.x, upgrade checkstyle to newer version [pulsar]

Posted by "lhotari (via GitHub)" <gi...@apache.org>.
lhotari commented on issue #22286:
URL: https://github.com/apache/pulsar/issues/22286#issuecomment-2003550178

   > What do you think about https://github.com/diffplug/spotless?
   > 
   > This plugin supports check and format code, I think we can use spotless instead of checkstyle.
   > 
   > Once we notice that the code has been formatted by spotless on the master branch, we will be limited when doing cherry-pick operations. If we can double-check by spotless and checkstyle, this will be simpler.
   > 
   > We have this discussion thread on the [dev@pulsar.apache.org](mailto:dev@pulsar.apache.org), but I don't know this URL, which title is `[DISCUSS] Consistent code style (esp. ws/indent) and autotools`
   
   @nodece What you are proposing is a completely different thing. I don't think that we want to change the way how code is formatted in Pulsar right now. Such changes cause unnecessary code changes without valuable benefits. 
   
   We should simply upgrade checkstyle to a supported version right now. That requires migrating the configuration file slightly.
   
   
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [I] IntelliJ checkstyle plugin dropped support for checkstyle 8.x, upgrade checkstyle to newer version [pulsar]

Posted by "lhotari (via GitHub)" <gi...@apache.org>.
lhotari commented on issue #22286:
URL: https://github.com/apache/pulsar/issues/22286#issuecomment-2003627143

   > Upgrading the checkstyle is simpler, I agree with you. PR: https://github.com/apache/pulsar/pull/22291
   > 
   > Right now, the checkstyle is not strict, some places have extra indentation, while others have extra spaces, so I suggest using spotless.
   
   Making a change to formatting is a broad change that cause more harm than benefit to the Pulsar project currently. We can reconsider after the maintenance strategy has been revisited.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [I] IntelliJ checkstyle plugin dropped support for checkstyle 8.x, upgrade checkstyle to newer version [pulsar]

Posted by "nodece (via GitHub)" <gi...@apache.org>.
nodece commented on issue #22286:
URL: https://github.com/apache/pulsar/issues/22286#issuecomment-2003297756

   What do you think about https://github.com/diffplug/spotless? 
   
   This plugin supports check and format code, I think we can use spotless instead of checkstyle. 
   
   Once we notice that the code has been formatted by spotless on the master branch,  we will be limited when doing cherry-pick operations. If we can double-check by spotless and checkstyle, this will be simpler.
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [I] IntelliJ checkstyle plugin dropped support for checkstyle 8.x, upgrade checkstyle to newer version [pulsar]

Posted by "nodece (via GitHub)" <gi...@apache.org>.
nodece commented on issue #22286:
URL: https://github.com/apache/pulsar/issues/22286#issuecomment-2003579905

   Upgrading the checkstyle is simpler, I agree with you. 
   
   Right now, the checkstyle is not strict, some places have extra indentation, while others have extra spaces, so I suggest using spotless.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org