You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@geronimo.apache.org by "Jason Warner (JIRA)" <ji...@apache.org> on 2007/07/11 20:30:04 UTC

[jira] Created: (GERONIMO-3309) Add missing LICENSE.txt and NOTICE.txt files to the J2G conversion tool

Add missing LICENSE.txt and NOTICE.txt files to the J2G conversion tool
-----------------------------------------------------------------------

                 Key: GERONIMO-3309
                 URL: https://issues.apache.org/jira/browse/GERONIMO-3309
             Project: Geronimo
          Issue Type: Improvement
      Security Level: public (Regular issues)
          Components: J2G
            Reporter: Jason Warner
            Assignee: Jason Warner


The J2G conversion tool is missing the LICENSE.txt and NOTICE.txt files. 

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Re: [jira] Commented: (GERONIMO-3309) Add missing LICENSE.txt and NOTICE.txt files to the J2G conversion tool

Posted by Lin Sun <li...@gmail.com>.
Hi Kevan,

You are right, mvn install assembly:assembly would bring the target dir 
that contains the j2g-conversion-1.0.0-SNAPSHOT-bin.zip file which can 
be consumed by a user.   I just did mvn install assembly:assembly and it 
worked fine too.   I hadn't used this zip file I built from devtools 
tree but I used the zip file I built from sandbox before.

Could you send me your full j2g build log?

Thanks,

Lin

Kevan Miller wrote:
> 
> On Oct 8, 2007, at 2:31 PM, Lin Sun wrote:
> 
>> Hi Kevan,
>>
>> Could you try building with mvn install?   I am able to build j2g fine 
>> with that.
> 
> Yes, 'mvn install' completes without error. However, I don't think 
> that's running a full build... I see individual jar files are built, but 
> there's no aggregation of jars, dependent jars, command scripts, etc. 
> Nothing that a user can actually download...
> 
> Lin,
> are you building and running j2g?
> 
> --kevan
> 
> 
> 
> 


Re: [jira] Commented: (GERONIMO-3309) Add missing LICENSE.txt and NOTICE.txt files to the J2G conversion tool

Posted by Kevan Miller <ke...@gmail.com>.
On Oct 8, 2007, at 2:31 PM, Lin Sun wrote:

> Hi Kevan,
>
> Could you try building with mvn install?   I am able to build j2g  
> fine with that.

Yes, 'mvn install' completes without error. However, I don't think  
that's running a full build... I see individual jar files are built,  
but there's no aggregation of jars, dependent jars, command scripts,  
etc. Nothing that a user can actually download...

Lin,
are you building and running j2g?

--kevan




Re: [jira] Commented: (GERONIMO-3309) Add missing LICENSE.txt and NOTICE.txt files to the J2G conversion tool

Posted by Lin Sun <li...@gmail.com>.
Hi Kevan,

Could you try building with mvn install?   I am able to build j2g fine 
with that.

Thanks,

Lin

Kevan Miller wrote:
> 
> On Oct 8, 2007, at 12:53 PM, Jason Warner wrote:
> 
>> It looks like you're building from the ui package.  The ui package has 
>> dependencies on a few other packages in j2g.  The error your getting 
>> is complaining about not being able to find a built version of those 
>> packages.  That error message seems to lack a description of which 
>> package it wants that it can't find.  I took a look at the pom, but 
>> didn't really see anything regarding what packages it would want.  Can 
>> you try building j2g completely from your root j2g directory?  The 
>> same command can be used.
> 
> I'm building from j2g/trunk. The error occurs when the build reaches 
> org.apache.geronimo.j2g.ui.
> 
> Here's output with -e option:
> 
> [INFO] 
> ---------------------------------------------------------------------------- 
> 
> [INFO] Building org.apache.geronimo.j2g.ui
> [INFO] 
> ---------------------------------------------------------------------------- 
> 
> [INFO] [eclipsepde:manifestbundles {execution: default}]
> [INFO] [eclipsepde:install {execution: default}]
> [INFO] org.eclipse.equinox.registry : 3.3.0-v20070522 already exists in 
> local repository.
> [INFO] org.eclipse.ui.console : 3.2.0-v20070530 already exists in local 
> repository.
> [INFO] org.eclipse.jface : 3.3.0-I20070606-0010 already exists in local 
> repository.
> [INFO] SWTFragment:  Dependency {groupId=org.eclipse.plugins, 
> artifactId=org.eclipse.swt.carbon.macosx, version=3.3.0-v3346, type=jar}
> [INFO] org.eclipse.swt.carbon.macosx : 3.3.0-v3346 already exists in 
> local repository.
> [INFO] org.eclipse.swt : 3.3.0-v3346 already exists in local repository.
> [INFO] org.eclipse.equinox.preferences : 3.2.100-v20070522 already 
> exists in local repository.
> [INFO] org.eclipse.ui : 3.3.0-I20070614-0800 already exists in local 
> repository.
> [INFO] org.eclipse.core.jobs : 3.3.0-v20070423 already exists in local 
> repository.
> [INFO] org.eclipse.equinox.app : 1.0.0-v20070606 already exists in local 
> repository.
> [INFO] org.eclipse.core.contenttype : 3.2.100-v20070319 already exists 
> in local repository.
> [INFO] org.eclipse.ui.workbench : 3.3.0-I20070608-1100 already exists in 
> local repository.
> [INFO] org.eclipse.debug.ui : 3.3.0-v20070607-1800 already exists in 
> local repository.
> [INFO] org.eclipse.osgi : 3.3.0-v20070530 already exists in local 
> repository.
> [INFO] org.eclipse.core.runtime : 3.3.100-v20070530 already exists in 
> local repository.
> [INFO] org.eclipse.debug.core : 3.3.0-v20070607-1800 already exists in 
> local repository.
> [INFO] org.eclipse.equinox.common : 3.3.0-v20070426 already exists in 
> local repository.
> [INFO] org.eclipse.swt.carbon.macosx : 3.3.0-v3346 already exists in 
> local repository.
> [INFO] [resources:resources]
> [INFO] Using default encoding to copy filtered resources.
> [INFO] [eclipsepde:validatemanifest {execution: validate-bundle-classpath}]
> [INFO] [compiler:compile]
> [INFO] Nothing to compile - all classes are up to date
> [INFO] [resources:testResources]
> [INFO] Using default encoding to copy filtered resources.
> [INFO] [compiler:testCompile]
> [INFO] No sources to compile
> [INFO] [surefire:test]
> [INFO] No tests to run.
> [INFO] [jar:jar]
> [INFO] Building jar: 
> /Users/kevan/geronimo/devtools/j2g/trunk/plugins/org.apache.geronimo.j2g.ui/target/org.apache.geronimo.j2g.ui-1.0.0-SNAPSHOT.jar 
> 
> [INFO] [assembly:assembly]
> [INFO] 
> ------------------------------------------------------------------------
> [ERROR] BUILD ERROR
> [INFO] 
> ------------------------------------------------------------------------
> [INFO] Included module: 
> org.apache.geronimo.tools:j2g-plugins:pom:1.0.0-SNAPSHOT does not have 
> an artifact with a file. Please ensure the package phase is run before 
> the assembly is generated.
> [INFO] 
> ------------------------------------------------------------------------
> [INFO] Trace
> org.apache.maven.lifecycle.LifecycleExecutionException: Included module: 
> org.apache.geronimo.tools:j2g-plugins:pom:1.0.0-SNAPSHOT does not have 
> an artifact with a file. Please ensure the package phase is run before 
> the assembly is generated.
>     at 
> org.apache.maven.lifecycle.DefaultLifecycleExecutor.executeGoals(DefaultLifecycleExecutor.java:564) 
> 
>     at 
> org.apache.maven.lifecycle.DefaultLifecycleExecutor.executeStandaloneGoal(DefaultLifecycleExecutor.java:493) 
> 
>     at 
> org.apache.maven.lifecycle.DefaultLifecycleExecutor.executeGoal(DefaultLifecycleExecutor.java:463) 
> 
>     at 
> org.apache.maven.lifecycle.DefaultLifecycleExecutor.executeGoalAndHandleFailures(DefaultLifecycleExecutor.java:311) 
> 
>     at 
> org.apache.maven.lifecycle.DefaultLifecycleExecutor.executeTaskSegments(DefaultLifecycleExecutor.java:224) 
> 
>     at 
> org.apache.maven.lifecycle.DefaultLifecycleExecutor.execute(DefaultLifecycleExecutor.java:143) 
> 
>     at org.apache.maven.DefaultMaven.doExecute(DefaultMaven.java:334)
>     at org.apache.maven.DefaultMaven.execute(DefaultMaven.java:125)
>     at org.apache.maven.cli.MavenCli.main(MavenCli.java:280)
>     at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
>     at 
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39) 
> 
>     at 
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25) 
> 
>     at java.lang.reflect.Method.invoke(Method.java:585)
>     at org.codehaus.classworlds.Launcher.launchEnhanced(Launcher.java:315)
>     at org.codehaus.classworlds.Launcher.launch(Launcher.java:255)
>     at 
> org.codehaus.classworlds.Launcher.mainWithExitCode(Launcher.java:430)
>     at org.codehaus.classworlds.Launcher.main(Launcher.java:375)
> Caused by: org.apache.maven.plugin.MojoExecutionException: Included 
> module: org.apache.geronimo.tools:j2g-plugins:pom:1.0.0-SNAPSHOT does 
> not have an artifact with a file. Please ensure the package phase is run 
> before the assembly is generated.
>     at 
> org.apache.maven.plugin.assembly.AbstractAssemblyMojo.processModules(AbstractAssemblyMojo.java:520) 
> 
>     at 
> org.apache.maven.plugin.assembly.AbstractAssemblyMojo.createArchive(AbstractAssemblyMojo.java:323) 
> 
>     at 
> org.apache.maven.plugin.assembly.AbstractAssemblyMojo.createAssembly(AbstractAssemblyMojo.java:261) 
> 
>     at 
> org.apache.maven.plugin.assembly.AbstractAssemblyMojo.execute(AbstractAssemblyMojo.java:241) 
> 
>     at 
> org.apache.maven.plugin.DefaultPluginManager.executeMojo(DefaultPluginManager.java:443) 
> 
>     at 
> org.apache.maven.lifecycle.DefaultLifecycleExecutor.executeGoals(DefaultLifecycleExecutor.java:539) 
> 
>     ... 16 more
> [INFO] 
> ------------------------------------------------------------------------
> [INFO] Total time: 2 minutes 39 seconds
> [INFO] Finished at: Mon Oct 08 13:49:59 EDT 2007
> [INFO] Final Memory: 15M/84M
> [INFO] 
> ------------------------------------------------------------------------
> 
> --kevan
> 
> 


Re: [jira] Commented: (GERONIMO-3309) Add missing LICENSE.txt and NOTICE.txt files to the J2G conversion tool

Posted by "Erik B. Craig" <gi...@gmail.com>.
Kevan,

Strange... I also just attempted a build, and it went through 
flawlessly. I did the following.

rm -rf ~/.m2/repository
svn co https://svn.apache.org/repos/asf/geronimo/devtools/j2g/trunk 
j2g-build
cd j2g-build
mvn clean install

Environment is Linux - CentOS 4.5 with Sun 1.5.0_12 JDK, maven 2.0.7

Kevan Miller wrote:
>
> On Oct 8, 2007, at 12:53 PM, Jason Warner wrote:
>
>> It looks like you're building from the ui package.  The ui package 
>> has dependencies on a few other packages in j2g.  The error your 
>> getting is complaining about not being able to find a built version 
>> of those packages.  That error message seems to lack a description of 
>> which package it wants that it can't find.  I took a look at the pom, 
>> but didn't really see anything regarding what packages it would 
>> want.  Can you try building j2g completely from your root j2g 
>> directory?  The same command can be used.
>
> I'm building from j2g/trunk. The error occurs when the build reaches 
> org.apache.geronimo.j2g.ui.
>
> Here's output with -e option:
>
> [INFO] 
> ---------------------------------------------------------------------------- 
>
> [INFO] Building org.apache.geronimo.j2g.ui
> [INFO] 
> ---------------------------------------------------------------------------- 
>
> [INFO] [eclipsepde:manifestbundles {execution: default}]
> [INFO] [eclipsepde:install {execution: default}]
> [INFO] org.eclipse.equinox.registry : 3.3.0-v20070522 already exists 
> in local repository.
> [INFO] org.eclipse.ui.console : 3.2.0-v20070530 already exists in 
> local repository.
> [INFO] org.eclipse.jface : 3.3.0-I20070606-0010 already exists in 
> local repository.
> [INFO] SWTFragment:  Dependency {groupId=org.eclipse.plugins, 
> artifactId=org.eclipse.swt.carbon.macosx, version=3.3.0-v3346, type=jar}
> [INFO] org.eclipse.swt.carbon.macosx : 3.3.0-v3346 already exists in 
> local repository.
> [INFO] org.eclipse.swt : 3.3.0-v3346 already exists in local repository.
> [INFO] org.eclipse.equinox.preferences : 3.2.100-v20070522 already 
> exists in local repository.
> [INFO] org.eclipse.ui : 3.3.0-I20070614-0800 already exists in local 
> repository.
> [INFO] org.eclipse.core.jobs : 3.3.0-v20070423 already exists in local 
> repository.
> [INFO] org.eclipse.equinox.app : 1.0.0-v20070606 already exists in 
> local repository.
> [INFO] org.eclipse.core.contenttype : 3.2.100-v20070319 already exists 
> in local repository.
> [INFO] org.eclipse.ui.workbench : 3.3.0-I20070608-1100 already exists 
> in local repository.
> [INFO] org.eclipse.debug.ui : 3.3.0-v20070607-1800 already exists in 
> local repository.
> [INFO] org.eclipse.osgi : 3.3.0-v20070530 already exists in local 
> repository.
> [INFO] org.eclipse.core.runtime : 3.3.100-v20070530 already exists in 
> local repository.
> [INFO] org.eclipse.debug.core : 3.3.0-v20070607-1800 already exists in 
> local repository.
> [INFO] org.eclipse.equinox.common : 3.3.0-v20070426 already exists in 
> local repository.
> [INFO] org.eclipse.swt.carbon.macosx : 3.3.0-v3346 already exists in 
> local repository.
> [INFO] [resources:resources]
> [INFO] Using default encoding to copy filtered resources.
> [INFO] [eclipsepde:validatemanifest {execution: 
> validate-bundle-classpath}]
> [INFO] [compiler:compile]
> [INFO] Nothing to compile - all classes are up to date
> [INFO] [resources:testResources]
> [INFO] Using default encoding to copy filtered resources.
> [INFO] [compiler:testCompile]
> [INFO] No sources to compile
> [INFO] [surefire:test]
> [INFO] No tests to run.
> [INFO] [jar:jar]
> [INFO] Building jar: 
> /Users/kevan/geronimo/devtools/j2g/trunk/plugins/org.apache.geronimo.j2g.ui/target/org.apache.geronimo.j2g.ui-1.0.0-SNAPSHOT.jar 
>
> [INFO] [assembly:assembly]
> [INFO] 
> ------------------------------------------------------------------------
> [ERROR] BUILD ERROR
> [INFO] 
> ------------------------------------------------------------------------
> [INFO] Included module: 
> org.apache.geronimo.tools:j2g-plugins:pom:1.0.0-SNAPSHOT does not have 
> an artifact with a file. Please ensure the package phase is run before 
> the assembly is generated.
> [INFO] 
> ------------------------------------------------------------------------
> [INFO] Trace
> org.apache.maven.lifecycle.LifecycleExecutionException: Included 
> module: org.apache.geronimo.tools:j2g-plugins:pom:1.0.0-SNAPSHOT does 
> not have an artifact with a file. Please ensure the package phase is 
> run before the assembly is generated.
>     at 
> org.apache.maven.lifecycle.DefaultLifecycleExecutor.executeGoals(DefaultLifecycleExecutor.java:564) 
>
>     at 
> org.apache.maven.lifecycle.DefaultLifecycleExecutor.executeStandaloneGoal(DefaultLifecycleExecutor.java:493) 
>
>     at 
> org.apache.maven.lifecycle.DefaultLifecycleExecutor.executeGoal(DefaultLifecycleExecutor.java:463) 
>
>     at 
> org.apache.maven.lifecycle.DefaultLifecycleExecutor.executeGoalAndHandleFailures(DefaultLifecycleExecutor.java:311) 
>
>     at 
> org.apache.maven.lifecycle.DefaultLifecycleExecutor.executeTaskSegments(DefaultLifecycleExecutor.java:224) 
>
>     at 
> org.apache.maven.lifecycle.DefaultLifecycleExecutor.execute(DefaultLifecycleExecutor.java:143) 
>
>     at org.apache.maven.DefaultMaven.doExecute(DefaultMaven.java:334)
>     at org.apache.maven.DefaultMaven.execute(DefaultMaven.java:125)
>     at org.apache.maven.cli.MavenCli.main(MavenCli.java:280)
>     at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
>     at 
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39) 
>
>     at 
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25) 
>
>     at java.lang.reflect.Method.invoke(Method.java:585)
>     at 
> org.codehaus.classworlds.Launcher.launchEnhanced(Launcher.java:315)
>     at org.codehaus.classworlds.Launcher.launch(Launcher.java:255)
>     at 
> org.codehaus.classworlds.Launcher.mainWithExitCode(Launcher.java:430)
>     at org.codehaus.classworlds.Launcher.main(Launcher.java:375)
> Caused by: org.apache.maven.plugin.MojoExecutionException: Included 
> module: org.apache.geronimo.tools:j2g-plugins:pom:1.0.0-SNAPSHOT does 
> not have an artifact with a file. Please ensure the package phase is 
> run before the assembly is generated.
>     at 
> org.apache.maven.plugin.assembly.AbstractAssemblyMojo.processModules(AbstractAssemblyMojo.java:520) 
>
>     at 
> org.apache.maven.plugin.assembly.AbstractAssemblyMojo.createArchive(AbstractAssemblyMojo.java:323) 
>
>     at 
> org.apache.maven.plugin.assembly.AbstractAssemblyMojo.createAssembly(AbstractAssemblyMojo.java:261) 
>
>     at 
> org.apache.maven.plugin.assembly.AbstractAssemblyMojo.execute(AbstractAssemblyMojo.java:241) 
>
>     at 
> org.apache.maven.plugin.DefaultPluginManager.executeMojo(DefaultPluginManager.java:443) 
>
>     at 
> org.apache.maven.lifecycle.DefaultLifecycleExecutor.executeGoals(DefaultLifecycleExecutor.java:539) 
>
>     ... 16 more
> [INFO] 
> ------------------------------------------------------------------------
> [INFO] Total time: 2 minutes 39 seconds
> [INFO] Finished at: Mon Oct 08 13:49:59 EDT 2007
> [INFO] Final Memory: 15M/84M
> [INFO] 
> ------------------------------------------------------------------------
>
> --kevan
>
>

Re: [jira] Commented: (GERONIMO-3309) Add missing LICENSE.txt and NOTICE.txt files to the J2G conversion tool

Posted by Kevan Miller <ke...@gmail.com>.
On Oct 8, 2007, at 12:53 PM, Jason Warner wrote:

> It looks like you're building from the ui package.  The ui package  
> has dependencies on a few other packages in j2g.  The error your  
> getting is complaining about not being able to find a built version  
> of those packages.  That error message seems to lack a description  
> of which package it wants that it can't find.  I took a look at the  
> pom, but didn't really see anything regarding what packages it  
> would want.  Can you try building j2g completely from your root j2g  
> directory?  The same command can be used.

I'm building from j2g/trunk. The error occurs when the build reaches  
org.apache.geronimo.j2g.ui.

Here's output with -e option:

[INFO]  
------------------------------------------------------------------------ 
----
[INFO] Building org.apache.geronimo.j2g.ui
[INFO]  
------------------------------------------------------------------------ 
----
[INFO] [eclipsepde:manifestbundles {execution: default}]
[INFO] [eclipsepde:install {execution: default}]
[INFO] org.eclipse.equinox.registry : 3.3.0-v20070522 already exists  
in local repository.
[INFO] org.eclipse.ui.console : 3.2.0-v20070530 already exists in  
local repository.
[INFO] org.eclipse.jface : 3.3.0-I20070606-0010 already exists in  
local repository.
[INFO] SWTFragment:  Dependency {groupId=org.eclipse.plugins,  
artifactId=org.eclipse.swt.carbon.macosx, version=3.3.0-v3346, type=jar}
[INFO] org.eclipse.swt.carbon.macosx : 3.3.0-v3346 already exists in  
local repository.
[INFO] org.eclipse.swt : 3.3.0-v3346 already exists in local repository.
[INFO] org.eclipse.equinox.preferences : 3.2.100-v20070522 already  
exists in local repository.
[INFO] org.eclipse.ui : 3.3.0-I20070614-0800 already exists in local  
repository.
[INFO] org.eclipse.core.jobs : 3.3.0-v20070423 already exists in  
local repository.
[INFO] org.eclipse.equinox.app : 1.0.0-v20070606 already exists in  
local repository.
[INFO] org.eclipse.core.contenttype : 3.2.100-v20070319 already  
exists in local repository.
[INFO] org.eclipse.ui.workbench : 3.3.0-I20070608-1100 already exists  
in local repository.
[INFO] org.eclipse.debug.ui : 3.3.0-v20070607-1800 already exists in  
local repository.
[INFO] org.eclipse.osgi : 3.3.0-v20070530 already exists in local  
repository.
[INFO] org.eclipse.core.runtime : 3.3.100-v20070530 already exists in  
local repository.
[INFO] org.eclipse.debug.core : 3.3.0-v20070607-1800 already exists  
in local repository.
[INFO] org.eclipse.equinox.common : 3.3.0-v20070426 already exists in  
local repository.
[INFO] org.eclipse.swt.carbon.macosx : 3.3.0-v3346 already exists in  
local repository.
[INFO] [resources:resources]
[INFO] Using default encoding to copy filtered resources.
[INFO] [eclipsepde:validatemanifest {execution: validate-bundle- 
classpath}]
[INFO] [compiler:compile]
[INFO] Nothing to compile - all classes are up to date
[INFO] [resources:testResources]
[INFO] Using default encoding to copy filtered resources.
[INFO] [compiler:testCompile]
[INFO] No sources to compile
[INFO] [surefire:test]
[INFO] No tests to run.
[INFO] [jar:jar]
[INFO] Building jar: /Users/kevan/geronimo/devtools/j2g/trunk/plugins/ 
org.apache.geronimo.j2g.ui/target/org.apache.geronimo.j2g.ui-1.0.0- 
SNAPSHOT.jar
[INFO] [assembly:assembly]
[INFO]  
------------------------------------------------------------------------
[ERROR] BUILD ERROR
[INFO]  
------------------------------------------------------------------------
[INFO] Included module: org.apache.geronimo.tools:j2g-plugins:pom: 
1.0.0-SNAPSHOT does not have an artifact with a file. Please ensure  
the package phase is run before the assembly is generated.
[INFO]  
------------------------------------------------------------------------
[INFO] Trace
org.apache.maven.lifecycle.LifecycleExecutionException: Included  
module: org.apache.geronimo.tools:j2g-plugins:pom:1.0.0-SNAPSHOT does  
not have an artifact with a file. Please ensure the package phase is  
run before the assembly is generated.
	at org.apache.maven.lifecycle.DefaultLifecycleExecutor.executeGoals 
(DefaultLifecycleExecutor.java:564)
	at  
org.apache.maven.lifecycle.DefaultLifecycleExecutor.executeStandaloneGoa 
l(DefaultLifecycleExecutor.java:493)
	at org.apache.maven.lifecycle.DefaultLifecycleExecutor.executeGoal 
(DefaultLifecycleExecutor.java:463)
	at  
org.apache.maven.lifecycle.DefaultLifecycleExecutor.executeGoalAndHandle 
Failures(DefaultLifecycleExecutor.java:311)
	at  
org.apache.maven.lifecycle.DefaultLifecycleExecutor.executeTaskSegments( 
DefaultLifecycleExecutor.java:224)
	at org.apache.maven.lifecycle.DefaultLifecycleExecutor.execute 
(DefaultLifecycleExecutor.java:143)
	at org.apache.maven.DefaultMaven.doExecute(DefaultMaven.java:334)
	at org.apache.maven.DefaultMaven.execute(DefaultMaven.java:125)
	at org.apache.maven.cli.MavenCli.main(MavenCli.java:280)
	at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at sun.reflect.NativeMethodAccessorImpl.invoke 
(NativeMethodAccessorImpl.java:39)
	at sun.reflect.DelegatingMethodAccessorImpl.invoke 
(DelegatingMethodAccessorImpl.java:25)
	at java.lang.reflect.Method.invoke(Method.java:585)
	at org.codehaus.classworlds.Launcher.launchEnhanced(Launcher.java:315)
	at org.codehaus.classworlds.Launcher.launch(Launcher.java:255)
	at org.codehaus.classworlds.Launcher.mainWithExitCode(Launcher.java: 
430)
	at org.codehaus.classworlds.Launcher.main(Launcher.java:375)
Caused by: org.apache.maven.plugin.MojoExecutionException: Included  
module: org.apache.geronimo.tools:j2g-plugins:pom:1.0.0-SNAPSHOT does  
not have an artifact with a file. Please ensure the package phase is  
run before the assembly is generated.
	at  
org.apache.maven.plugin.assembly.AbstractAssemblyMojo.processModules 
(AbstractAssemblyMojo.java:520)
	at  
org.apache.maven.plugin.assembly.AbstractAssemblyMojo.createArchive 
(AbstractAssemblyMojo.java:323)
	at  
org.apache.maven.plugin.assembly.AbstractAssemblyMojo.createAssembly 
(AbstractAssemblyMojo.java:261)
	at org.apache.maven.plugin.assembly.AbstractAssemblyMojo.execute 
(AbstractAssemblyMojo.java:241)
	at org.apache.maven.plugin.DefaultPluginManager.executeMojo 
(DefaultPluginManager.java:443)
	at org.apache.maven.lifecycle.DefaultLifecycleExecutor.executeGoals 
(DefaultLifecycleExecutor.java:539)
	... 16 more
[INFO]  
------------------------------------------------------------------------
[INFO] Total time: 2 minutes 39 seconds
[INFO] Finished at: Mon Oct 08 13:49:59 EDT 2007
[INFO] Final Memory: 15M/84M
[INFO]  
------------------------------------------------------------------------

--kevan


Re: [jira] Commented: (GERONIMO-3309) Add missing LICENSE.txt and NOTICE.txt files to the J2G conversion tool

Posted by Jason Warner <ja...@gmail.com>.
It looks like you're building from the ui package.  The ui package has
dependencies on a few other packages in j2g.  The error your getting is
complaining about not being able to find a built version of those packages.
That error message seems to lack a description of which package it wants
that it can't find.  I took a look at the pom, but didn't really see
anything regarding what packages it would want.  Can you try building j2g
completely from your root j2g directory?  The same command can be used.

On 10/8/07, Kevan Miller <ke...@gmail.com> wrote:
>
>
> On Oct 8, 2007, at 11:29 AM, Jason Warner wrote:
>
> >
> > You're using the correct command to build the tool.  I just checked
> > out the latest version and built it with no issues?  It was
> > recently moved to the devtools component.  Is that where you
> > checked it out from?  What problems are you having?
>
> mvn install assembly:assembly
> ...
> [INFO] Building jar: /Users/kevan/geronimo/devtools/j2g/trunk/plugins/
> org.apache.geronimo.j2g.ui/target/org.apache.geronimo.j2g.ui-1.0.0-
> SNAPSHOT.jar
> [INFO] [assembly:assembly]
> [INFO]
> ------------------------------------------------------------------------
> [ERROR] BUILD ERROR
> [INFO]
> ------------------------------------------------------------------------
> [INFO] Included module: org.apache.geronimo.tools:j2g-plugins:pom:
> 1.0.0-SNAPSHOT does not have an artifact with a file. Please ensure
> the package phase is run before the assembly is generated.
> [INFO]
> ------------------------------------------------------------------------
> [INFO] For more information, run Maven with the -e switch
> [INFO]
> ------------------------------------------------------------------------
> [INFO] Total time: 1 minute 58 seconds
> [INFO] Finished at: Mon Oct 08 10:42:01 EDT 2007
> [INFO] Final Memory: 30M/85M
> [INFO]
> ------------------------------------------------------------------------
>
> --kevan
>
>
>

Re: [jira] Commented: (GERONIMO-3309) Add missing LICENSE.txt and NOTICE.txt files to the J2G conversion tool

Posted by Kevan Miller <ke...@gmail.com>.
On Oct 8, 2007, at 11:29 AM, Jason Warner wrote:

>
> You're using the correct command to build the tool.  I just checked  
> out the latest version and built it with no issues?  It was  
> recently moved to the devtools component.  Is that where you  
> checked it out from?  What problems are you having?

mvn install assembly:assembly
...
[INFO] Building jar: /Users/kevan/geronimo/devtools/j2g/trunk/plugins/ 
org.apache.geronimo.j2g.ui/target/org.apache.geronimo.j2g.ui-1.0.0- 
SNAPSHOT.jar
[INFO] [assembly:assembly]
[INFO]  
------------------------------------------------------------------------
[ERROR] BUILD ERROR
[INFO]  
------------------------------------------------------------------------
[INFO] Included module: org.apache.geronimo.tools:j2g-plugins:pom: 
1.0.0-SNAPSHOT does not have an artifact with a file. Please ensure  
the package phase is run before the assembly is generated.
[INFO]  
------------------------------------------------------------------------
[INFO] For more information, run Maven with the -e switch
[INFO]  
------------------------------------------------------------------------
[INFO] Total time: 1 minute 58 seconds
[INFO] Finished at: Mon Oct 08 10:42:01 EDT 2007
[INFO] Final Memory: 30M/85M
[INFO]  
------------------------------------------------------------------------

--kevan



Re: [jira] Commented: (GERONIMO-3309) Add missing LICENSE.txt and NOTICE.txt files to the J2G conversion tool

Posted by Jason Warner <ja...@gmail.com>.
You're using the correct command to build the tool.  I just checked out the
latest version and built it with no issues?  It was recently moved to the
devtools component.  Is that where you checked it out from?  What problems
are you having?
On 10/8/07, Kevan Miller (JIRA) <ji...@apache.org> wrote:
>
>
>     [
> https://issues.apache.org/jira/browse/GERONIMO-3309?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12533139]
>
> Kevan Miller commented on GERONIMO-3309:
> ----------------------------------------
>
> Hi Jason,
> Apologies.
>
> Although you mention a number of licenses in a previous comment, I don't
> see these licenses in either of your patch files.
>
> I'm not currently able to build j2g (mvn install assembly:assembly). How
> should I be building?
>
> > Add missing LICENSE.txt and NOTICE.txt files to the J2G conversion tool
> > -----------------------------------------------------------------------
> >
> >                 Key: GERONIMO-3309
> >                 URL: https://issues.apache.org/jira/browse/GERONIMO-3309
> >             Project: Geronimo
> >          Issue Type: Improvement
> >      Security Level: public(Regular issues)
> >          Components: J2G
> >            Reporter: Jason Warner
> >            Assignee: Kevan Miller
> >         Attachments: Geronimo-3309.patch, Geronimo-3309Update.patch
> >
> >
> > The J2G conversion tool is missing the LICENSE.txt and NOTICE.txt files.
>
> --
> This message is automatically generated by JIRA.
> -
> You can reply to this email to add a comment to the issue online.
>
>

[jira] Assigned: (GERONIMO-3309) Add missing LICENSE.txt and NOTICE.txt files to the J2G conversion tool

Posted by "Lin Sun (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/GERONIMO-3309?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Lin Sun reassigned GERONIMO-3309:
---------------------------------

    Assignee: Lin Sun  (was: Kevan Miller)

> Add missing LICENSE.txt and NOTICE.txt files to the J2G conversion tool
> -----------------------------------------------------------------------
>
>                 Key: GERONIMO-3309
>                 URL: https://issues.apache.org/jira/browse/GERONIMO-3309
>             Project: Geronimo
>          Issue Type: Improvement
>      Security Level: public(Regular issues) 
>          Components: J2G
>            Reporter: Jason Warner
>            Assignee: Lin Sun
>         Attachments: Geronimo-3309.patch, Geronimo-3309Update.patch
>
>
> The J2G conversion tool is missing the LICENSE.txt and NOTICE.txt files. 

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (GERONIMO-3309) Add missing LICENSE.txt and NOTICE.txt files to the J2G conversion tool

Posted by "Jason Warner (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/GERONIMO-3309?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jason Warner updated GERONIMO-3309:
-----------------------------------

    Attachment: Geronimo-3309.patch

The LICENSE.txt file is just a straight copy and paste job.  I had to fill in some details for the orginal code donation in NOTICE.txt, though.  If someone could peek at that and make sure the wording and such is alright, I'd appreciate it.  The JIRA for the original code donation is here https://issues.apache.org/jira/browse/GERONIMO-2743.  

> Add missing LICENSE.txt and NOTICE.txt files to the J2G conversion tool
> -----------------------------------------------------------------------
>
>                 Key: GERONIMO-3309
>                 URL: https://issues.apache.org/jira/browse/GERONIMO-3309
>             Project: Geronimo
>          Issue Type: Improvement
>      Security Level: public(Regular issues) 
>          Components: J2G
>            Reporter: Jason Warner
>            Assignee: Jason Warner
>         Attachments: Geronimo-3309.patch
>
>
> The J2G conversion tool is missing the LICENSE.txt and NOTICE.txt files. 

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (GERONIMO-3309) Add missing LICENSE.txt and NOTICE.txt files to the J2G conversion tool

Posted by "Jason Warner (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/GERONIMO-3309?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jason Warner updated GERONIMO-3309:
-----------------------------------

    Assignee: Kevan Miller  (was: Jason Warner)

> Add missing LICENSE.txt and NOTICE.txt files to the J2G conversion tool
> -----------------------------------------------------------------------
>
>                 Key: GERONIMO-3309
>                 URL: https://issues.apache.org/jira/browse/GERONIMO-3309
>             Project: Geronimo
>          Issue Type: Improvement
>      Security Level: public(Regular issues) 
>          Components: J2G
>            Reporter: Jason Warner
>            Assignee: Kevan Miller
>         Attachments: Geronimo-3309.patch, Geronimo-3309Update.patch
>
>
> The J2G conversion tool is missing the LICENSE.txt and NOTICE.txt files. 

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (GERONIMO-3309) Add missing LICENSE.txt and NOTICE.txt files to the J2G conversion tool

Posted by "Lin Sun (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/GERONIMO-3309?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12534966 ] 

Lin Sun commented on GERONIMO-3309:
-----------------------------------

I think there are a few remaining work items need to be done for this jira (checked in some of the patch in rev 584907 -

-make sure all the jars we include in the plugin jars are needed for runtime.   I removed junit today as it is only used at build time.

-update license and notice file.   I checked in the proposed build script changes to include the license and notice files when they are in place.




> Add missing LICENSE.txt and NOTICE.txt files to the J2G conversion tool
> -----------------------------------------------------------------------
>
>                 Key: GERONIMO-3309
>                 URL: https://issues.apache.org/jira/browse/GERONIMO-3309
>             Project: Geronimo
>          Issue Type: Improvement
>      Security Level: public(Regular issues) 
>          Components: J2G
>            Reporter: Jason Warner
>            Assignee: Lin Sun
>         Attachments: Geronimo-3309.patch, Geronimo-3309Update.patch
>
>
> The J2G conversion tool is missing the LICENSE.txt and NOTICE.txt files. 

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (GERONIMO-3309) Add missing LICENSE.txt and NOTICE.txt files to the J2G conversion tool

Posted by "Jason Warner (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/GERONIMO-3309?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jason Warner updated GERONIMO-3309:
-----------------------------------

    Attachment: Geronimo-3309Update.patch

This patch should contain all the necessary updates to the LICENSE.txt and NOTICE.txt files.  Each jar within the deployable now contains an appropriate LICENSE.txt and NOTICE.txt file in their respective META-INF directory.  I think that I've included all the appropriate licenses and such but I would very much appreciate someone with more license experience taking a look at this.  There are a few non-standard licenses that needed to be included that looked ok to me but I could be wrong.  I only know enough legalese to ask where the bathroom is.

List of non-Apache product licenses included in this tool:

BouncyCastle (As part of geronimo-util) - http://bouncycastle.org/license.html
DOM4J - http://www.dom4j.org/license.html
Jaxen - http://jaxen.org/license.html
Junit - Uses CPL 1.0
XML Pull Parser - http://www.extreme.indiana.edu/xgws/xsoap/xpp/download/PullParser2/LICENSE.txt



> Add missing LICENSE.txt and NOTICE.txt files to the J2G conversion tool
> -----------------------------------------------------------------------
>
>                 Key: GERONIMO-3309
>                 URL: https://issues.apache.org/jira/browse/GERONIMO-3309
>             Project: Geronimo
>          Issue Type: Improvement
>      Security Level: public(Regular issues) 
>          Components: J2G
>            Reporter: Jason Warner
>            Assignee: Jason Warner
>         Attachments: Geronimo-3309.patch, Geronimo-3309Update.patch
>
>
> The J2G conversion tool is missing the LICENSE.txt and NOTICE.txt files. 

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (GERONIMO-3309) Add missing LICENSE.txt and NOTICE.txt files to the J2G conversion tool

Posted by "Jason Warner (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/GERONIMO-3309?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12531518 ] 

Jason Warner commented on GERONIMO-3309:
----------------------------------------

Kevan,

I'd like to close out all the old J2G issues that have carried over from sandbox, if possible.  Have you taken a look at the files to verfiy whether they are correct or not?

> Add missing LICENSE.txt and NOTICE.txt files to the J2G conversion tool
> -----------------------------------------------------------------------
>
>                 Key: GERONIMO-3309
>                 URL: https://issues.apache.org/jira/browse/GERONIMO-3309
>             Project: Geronimo
>          Issue Type: Improvement
>      Security Level: public(Regular issues) 
>          Components: J2G
>            Reporter: Jason Warner
>            Assignee: Kevan Miller
>         Attachments: Geronimo-3309.patch, Geronimo-3309Update.patch
>
>
> The J2G conversion tool is missing the LICENSE.txt and NOTICE.txt files. 

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (GERONIMO-3309) Add missing LICENSE.txt and NOTICE.txt files to the J2G conversion tool

Posted by "Jason Warner (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/GERONIMO-3309?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12514623 ] 

Jason Warner commented on GERONIMO-3309:
----------------------------------------

I'll definitely take a look into this, Kevan.  In regards to J2G not building completely for you, what command did you use to build?  It should be built using "mvn install assembly:assembly" if you want the deployable to be built as well.

> Add missing LICENSE.txt and NOTICE.txt files to the J2G conversion tool
> -----------------------------------------------------------------------
>
>                 Key: GERONIMO-3309
>                 URL: https://issues.apache.org/jira/browse/GERONIMO-3309
>             Project: Geronimo
>          Issue Type: Improvement
>      Security Level: public(Regular issues) 
>          Components: J2G
>            Reporter: Jason Warner
>            Assignee: Kevan Miller
>         Attachments: Geronimo-3309.patch
>
>
> The J2G conversion tool is missing the LICENSE.txt and NOTICE.txt files. 

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (GERONIMO-3309) Add missing LICENSE.txt and NOTICE.txt files to the J2G conversion tool

Posted by "Kevan Miller (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/GERONIMO-3309?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12514522 ] 

Kevan Miller commented on GERONIMO-3309:
----------------------------------------

J2G is not building completely for me, at the moment. I can build enough to see that there's additional licensing work required.

For instance, there are a number of jar files being included in j2g jar files. For instance, org.apache.geronimo.j2g.util-1.0.0-SNAPSHOT.jar includes pull-parser-2.1.10.jar. We need to know the license(s) that apply to this jar file. pull-parser comes out of Extreme Labs, it looks like. It's not clear to me what license(s) apply to this jar. We need to pin this down precisely. This process needs to occur for all such dependencies. As apropriate, these licenses need to be reflected in the J2G license and notice files.

I also noted that the J2G jar files are missing license and notice files. They must have them. These files should reflect the license and notice information for each jar file.

For general guidance on apache license and notice file handling, see -- http://www.apache.org/legal/src-headers.html
 
For guidance on what licenses are acceptable to Apache, see -- http://people.apache.org/~cliffs/3party.html

Jason, if you're interested in doing this investigation, that would be great. However, a Geronimo committer is going to need to carefully review all of this...

 

> Add missing LICENSE.txt and NOTICE.txt files to the J2G conversion tool
> -----------------------------------------------------------------------
>
>                 Key: GERONIMO-3309
>                 URL: https://issues.apache.org/jira/browse/GERONIMO-3309
>             Project: Geronimo
>          Issue Type: Improvement
>      Security Level: public(Regular issues) 
>          Components: J2G
>            Reporter: Jason Warner
>            Assignee: Kevan Miller
>         Attachments: Geronimo-3309.patch
>
>
> The J2G conversion tool is missing the LICENSE.txt and NOTICE.txt files. 

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (GERONIMO-3309) Add missing LICENSE.txt and NOTICE.txt files to the J2G conversion tool

Posted by "Kevan Miller (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/GERONIMO-3309?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12514690 ] 

Kevan Miller commented on GERONIMO-3309:
----------------------------------------

Cool. I'm going to assign back to you then. Will hold off applying the patch, also. Let's get everything right, first...

FYI, here's the error i get from 'mvn clean install assembly:assembly'

[INFO] [assembly:assembly]
[INFO] ------------------------------------------------------------------------
[ERROR] BUILD ERROR
[INFO] ------------------------------------------------------------------------
[INFO] Included module: org.apache.geronimo.tools:j2g-plugins:pom:1.0.0-SNAPSHOT does not have an artifact with a file. Please ensure the package phase is run before the assembly is generated.


> Add missing LICENSE.txt and NOTICE.txt files to the J2G conversion tool
> -----------------------------------------------------------------------
>
>                 Key: GERONIMO-3309
>                 URL: https://issues.apache.org/jira/browse/GERONIMO-3309
>             Project: Geronimo
>          Issue Type: Improvement
>      Security Level: public(Regular issues) 
>          Components: J2G
>            Reporter: Jason Warner
>            Assignee: Kevan Miller
>         Attachments: Geronimo-3309.patch
>
>
> The J2G conversion tool is missing the LICENSE.txt and NOTICE.txt files. 

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Assigned: (GERONIMO-3309) Add missing LICENSE.txt and NOTICE.txt files to the J2G conversion tool

Posted by "Kevan Miller (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/GERONIMO-3309?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Kevan Miller reassigned GERONIMO-3309:
--------------------------------------

    Assignee: Kevan Miller  (was: Jason Warner)

> Add missing LICENSE.txt and NOTICE.txt files to the J2G conversion tool
> -----------------------------------------------------------------------
>
>                 Key: GERONIMO-3309
>                 URL: https://issues.apache.org/jira/browse/GERONIMO-3309
>             Project: Geronimo
>          Issue Type: Improvement
>      Security Level: public(Regular issues) 
>          Components: J2G
>            Reporter: Jason Warner
>            Assignee: Kevan Miller
>         Attachments: Geronimo-3309.patch
>
>
> The J2G conversion tool is missing the LICENSE.txt and NOTICE.txt files. 

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (GERONIMO-3309) Add missing LICENSE.txt and NOTICE.txt files to the J2G conversion tool

Posted by "Kevan Miller (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/GERONIMO-3309?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12533139 ] 

Kevan Miller commented on GERONIMO-3309:
----------------------------------------

Hi Jason,
Apologies. 

Although you mention a number of licenses in a previous comment, I don't see these licenses in either of your patch files.

I'm not currently able to build j2g (mvn install assembly:assembly). How should I be building?

> Add missing LICENSE.txt and NOTICE.txt files to the J2G conversion tool
> -----------------------------------------------------------------------
>
>                 Key: GERONIMO-3309
>                 URL: https://issues.apache.org/jira/browse/GERONIMO-3309
>             Project: Geronimo
>          Issue Type: Improvement
>      Security Level: public(Regular issues) 
>          Components: J2G
>            Reporter: Jason Warner
>            Assignee: Kevan Miller
>         Attachments: Geronimo-3309.patch, Geronimo-3309Update.patch
>
>
> The J2G conversion tool is missing the LICENSE.txt and NOTICE.txt files. 

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Assigned: (GERONIMO-3309) Add missing LICENSE.txt and NOTICE.txt files to the J2G conversion tool

Posted by "Kevan Miller (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/GERONIMO-3309?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Kevan Miller reassigned GERONIMO-3309:
--------------------------------------

    Assignee: Jason Warner  (was: Kevan Miller)

> Add missing LICENSE.txt and NOTICE.txt files to the J2G conversion tool
> -----------------------------------------------------------------------
>
>                 Key: GERONIMO-3309
>                 URL: https://issues.apache.org/jira/browse/GERONIMO-3309
>             Project: Geronimo
>          Issue Type: Improvement
>      Security Level: public(Regular issues) 
>          Components: J2G
>            Reporter: Jason Warner
>            Assignee: Jason Warner
>         Attachments: Geronimo-3309.patch
>
>
> The J2G conversion tool is missing the LICENSE.txt and NOTICE.txt files. 

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (GERONIMO-3309) Add missing LICENSE.txt and NOTICE.txt files to the J2G conversion tool

Posted by "Kevan Miller (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/GERONIMO-3309?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12514259 ] 

Kevan Miller commented on GERONIMO-3309:
----------------------------------------

Looks good. I'd update the following in the NOTICE file: informally known as the "IBM Console CLA"

That pertains to a previous software grant for the admin console. I see no reason to mention an informal name for the CCLA. I'll change that. I haven't tested a build, yet. Once I do, I'll commit.

> Add missing LICENSE.txt and NOTICE.txt files to the J2G conversion tool
> -----------------------------------------------------------------------
>
>                 Key: GERONIMO-3309
>                 URL: https://issues.apache.org/jira/browse/GERONIMO-3309
>             Project: Geronimo
>          Issue Type: Improvement
>      Security Level: public(Regular issues) 
>          Components: J2G
>            Reporter: Jason Warner
>            Assignee: Kevan Miller
>         Attachments: Geronimo-3309.patch
>
>
> The J2G conversion tool is missing the LICENSE.txt and NOTICE.txt files. 

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (GERONIMO-3309) Add missing LICENSE.txt and NOTICE.txt files to the J2G conversion tool

Posted by "Jason Warner (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/GERONIMO-3309?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jason Warner updated GERONIMO-3309:
-----------------------------------

    Patch Info: [Patch Available]

> Add missing LICENSE.txt and NOTICE.txt files to the J2G conversion tool
> -----------------------------------------------------------------------
>
>                 Key: GERONIMO-3309
>                 URL: https://issues.apache.org/jira/browse/GERONIMO-3309
>             Project: Geronimo
>          Issue Type: Improvement
>      Security Level: public(Regular issues) 
>          Components: J2G
>            Reporter: Jason Warner
>            Assignee: Jason Warner
>         Attachments: Geronimo-3309.patch
>
>
> The J2G conversion tool is missing the LICENSE.txt and NOTICE.txt files. 

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Resolved: (GERONIMO-3309) Add missing LICENSE.txt and NOTICE.txt files to the J2G conversion tool

Posted by "Lin Sun (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/GERONIMO-3309?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Lin Sun resolved GERONIMO-3309.
-------------------------------

    Resolution: Fixed

Made more changes in rev 585796 + 585797.  Added Dom4j, pull-paser, and jaxen licenses to j2g license.txt file.   J2g also uses some other dependencies but they are ASL 2.0 license - Commons Logging, commons-el, jasper-5.5.15 runtime, compiler, compiler-jdt, geronimo-jsp_sepc, geronimo-servlet-spec, 

Removed unneeded geronimo-util and geronimo-security dependencies.

For the notice.txt, I just used the ASL notice.txt proposed in the patch, as I cannot find notice file provided by Dom4j, pull-paser, or jaxen.

> Add missing LICENSE.txt and NOTICE.txt files to the J2G conversion tool
> -----------------------------------------------------------------------
>
>                 Key: GERONIMO-3309
>                 URL: https://issues.apache.org/jira/browse/GERONIMO-3309
>             Project: Geronimo
>          Issue Type: Improvement
>      Security Level: public(Regular issues) 
>          Components: J2G
>            Reporter: Jason Warner
>            Assignee: Lin Sun
>         Attachments: Geronimo-3309.patch, Geronimo-3309Update.patch
>
>
> The J2G conversion tool is missing the LICENSE.txt and NOTICE.txt files. 

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.