You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@apr.apache.org by wr...@apache.org on 2002/06/03 21:25:35 UTC
cvs commit: apr/file_io/win32 open.c
wrowe 2002/06/03 12:25:35
Modified: file_io/win32 open.c
Log:
Needs research and a decision
Revision Changes Path
1.102 +9 -2 apr/file_io/win32/open.c
Index: open.c
===================================================================
RCS file: /home/cvs/apr/file_io/win32/open.c,v
retrieving revision 1.101
retrieving revision 1.102
diff -u -r1.101 -r1.102
--- open.c 30 May 2002 05:25:00 -0000 1.101
+++ open.c 3 Jun 2002 19:25:34 -0000 1.102
@@ -518,8 +518,15 @@
(*file)->pool = pool;
(*file)->filehand = *thefile;
(*file)->ungetchar = -1; /* no char avail */
- (*file)->flags;
- (*file)->pipe;
+
+ /* XXX... we pcalloc above so these are zeroed. Is zero really
+ * the right answer when we passed flags into os_file_put?
+ * Should we be testing if thefile is a handle to a PIPE and
+ * set up the mechanics appropriately?
+ *
+ * (*file)->flags;
+ * (*file)->pipe;
+ */
return APR_SUCCESS;
}