You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by GitBox <gi...@apache.org> on 2019/12/10 11:41:30 UTC
[GitHub] [camel-k] astefanutti commented on a change in pull request #1127:
Don't write to platform spec to allow upgrades
astefanutti commented on a change in pull request #1127: Don't write to platform spec to allow upgrades
URL: https://github.com/apache/camel-k/pull/1127#discussion_r355987160
##########
File path: pkg/cmd/install.go
##########
@@ -269,12 +272,8 @@ func (o *installCmdOptions) install(cobraCmd *cobra.Command, _ []string) error {
kanikoBuildCacheFlag := cobraCmd.Flags().Lookup("kaniko-build-cache")
- defaultKanikoBuildCache := true
-
if kanikoBuildCacheFlag.Changed {
platform.Spec.Build.KanikoBuildCache = &o.kanikoBuildCache
- } else {
- platform.Spec.Build.KanikoBuildCache = &defaultKanikoBuildCache
Review comment:
Can you confirm it is intended to be part of that PR?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services