You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@drill.apache.org by "ASF GitHub Bot (Jira)" <ji...@apache.org> on 2020/03/09 18:46:00 UTC

[jira] [Commented] (DRILL-7631) Updates to the Json Structure Parser

    [ https://issues.apache.org/jira/browse/DRILL-7631?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17055299#comment-17055299 ] 

ASF GitHub Bot commented on DRILL-7631:
---------------------------------------

paul-rogers commented on pull request #2016: DRILL-7631: Updates to the Json Structure Parser
URL: https://github.com/apache/drill/pull/2016
 
 
   # [DRILL-7631](https://issues.apache.org/jira/browse/DRILL-7631): Updates to the Json Structure Parser
   
   ## Description
   
   The JSON structure parser converts JSON tokens from the Jackson JSON parser into a structure consisting of values, arrays and objects. The structure parser handles the JSON aspects. An associated set of listeners converts JSON values to some other format (such as to vectors via the column writers.) This PR covers only the structure parser.
   
   Work to create a new JSON record reader using this parser revealed several required revisions:
   
   * Convert the various typed listener creation calls in the listener to a generic call that takes a `ValueDef` value description.
   * Add support to replace listeners as is needed when starting with an "unknown" field, which later resolves to some type, such as `Integer`.
   * Reorganized the code to build sub-parsers based on incoming JSON structure.
   
   Note that, at present, no code uses the JSON structure parser. That code will come in a later PR.
   
   ## Documentation
   
   None
   
   ## Testing
   
   Expanded an reran the associated unit tests. Moved the unit tests so that they are in the same package as the code.
   
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> Updates to the Json Structure Parser
> ------------------------------------
>
>                 Key: DRILL-7631
>                 URL: https://issues.apache.org/jira/browse/DRILL-7631
>             Project: Apache Drill
>          Issue Type: Improvement
>    Affects Versions: 1.17.0
>            Reporter: Paul Rogers
>            Assignee: Paul Rogers
>            Priority: Minor
>             Fix For: 1.18.0
>
>
> Updates to the JSON structure parser based on using it to create a revised JSON record reader.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)