You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@flink.apache.org by fhueske <gi...@git.apache.org> on 2015/12/04 14:58:03 UTC

[GitHub] flink pull request: [FLINK-3112] Remove unused RecordModelPostPass

GitHub user fhueske opened a pull request:

    https://github.com/apache/flink/pull/1436

    [FLINK-3112] Remove unused RecordModelPostPass

    Class is not used and a leftover of the Record API.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/fhueske/flink rmRecordPostPass

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/flink/pull/1436.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1436
    
----
commit c8635f67855f037f2c5524176b672bfcc95f9455
Author: Fabian Hueske <fh...@apache.org>
Date:   2015-12-04T12:13:05Z

    [FLINK-3112] Remove unused RecordModelPostPass

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] flink pull request: [FLINK-3112] Remove unused RecordModelPostPass

Posted by fhueske <gi...@git.apache.org>.

Github user fhueske commented on the pull request:

    https://github.com/apache/flink/pull/1436#issuecomment-162530467
  
    Good catch, @jaoki and thanks for making me aware of this @zentol.
    
    `Plan` was originally implemented for the Record API. For the later DataSet API, `JavaPlan` extends `Plan` and only overrides the `getPostPassClassName()` method. I checked the code and `Plan` is nowhere instantiated, only `JavaPlan`. 
    
    I will move the `getPostPassClassName()` from `JavaPlan` to `Plan` and remove `JavaPlan`.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] flink pull request: [FLINK-3112] Remove unused RecordModelPostPass

Posted by jaoki <gi...@git.apache.org>.

Github user jaoki commented on the pull request:

    https://github.com/apache/flink/pull/1436#issuecomment-162690732
  
    @fhueske , I'm glad to make myself a bit useful to the project. :)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] flink pull request: [FLINK-3112] Remove unused RecordModelPostPass

Posted by fhueske <gi...@git.apache.org>.

Github user fhueske commented on the pull request:

    https://github.com/apache/flink/pull/1436#issuecomment-162680884
  
    Going to merge this PR.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] flink pull request: [FLINK-3112] Remove unused RecordModelPostPass

Posted by zentol <gi...@git.apache.org>.

Github user zentol commented on the pull request:

    https://github.com/apache/flink/pull/1436#issuecomment-162176217
  
    @jaoki found a reference to this class in
    
    https://github.com/apache/flink/blob/master/flink-core/src/main/java/org/apache/flink/api/common/Plan.java#L318-L319


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] flink pull request: [FLINK-3112] Remove unused RecordModelPostPass

Posted by asfgit <gi...@git.apache.org>.

Github user asfgit closed the pull request at:

    https://github.com/apache/flink/pull/1436


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---