You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2022/12/19 02:57:27 UTC

[GitHub] [spark] LuciferYang opened a new pull request, #39118: [SPARK-41567][BUILD] Move configuration of `versions-maven-plugin` to parent pom

LuciferYang opened a new pull request, #39118:
URL: https://github.com/apache/spark/pull/39118

   ### What changes were proposed in this pull request?
   SPARK-41544 make `test-dependencies.sh` to use specified version of `versions-maven-plugin` to run `build/mvn versions:set` command, but except for
   `test-dependencies.sh`, `release-build.sh` and `release-tag.sh` also use the `build/mvn versions:set` command. 
   
   release-build.sh:
   
   https://github.com/apache/spark/blob/90120f0ae4b472e2517c8288ea53baf6bcb38c22/dev/create-release/release-build.sh#L420
   
   https://github.com/apache/spark/blob/90120f0ae4b472e2517c8288ea53baf6bcb38c22/dev/create-release/release-build.sh#L445
   
   release-tag.sh:
   
   https://github.com/apache/spark/blob/90120f0ae4b472e2517c8288ea53baf6bcb38c22/dev/create-release/release-tag.sh#L77
   
   https://github.com/apache/spark/blob/90120f0ae4b472e2517c8288ea53baf6bcb38c22/dev/create-release/release-tag.sh#L99
   
   So this pr move the configuration of `versions-maven-plugin` to parent pom to make the whole Spark project use same version of `versions-maven-plugin`.
   
   
   ### Why are the changes needed?
   Make the whole Spark project use same version of `versions-maven-plugin`
   
   
   ### Does this PR introduce _any_ user-facing change?
   No
   
   
   ### How was this patch tested?
   Pass GitHub Actions and manually check the script is executable


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] LuciferYang commented on pull request #39118: [SPARK-41567][BUILD] Move configuration of `versions-maven-plugin` to parent pom

Posted by GitBox <gi...@apache.org>.
LuciferYang commented on PR #39118:
URL: https://github.com/apache/spark/pull/39118#issuecomment-1373078963

   Thanks @dongjoon-hyun 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] dongjoon-hyun closed pull request #39118: [SPARK-41567][BUILD] Move configuration of `versions-maven-plugin` to parent pom

Posted by GitBox <gi...@apache.org>.
dongjoon-hyun closed pull request #39118: [SPARK-41567][BUILD] Move configuration of `versions-maven-plugin` to parent pom
URL: https://github.com/apache/spark/pull/39118


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] LuciferYang commented on a diff in pull request #39118: [SPARK-41567][BUILD] Move configuration of `versions-maven-plugin` to parent pom

Posted by GitBox <gi...@apache.org>.
LuciferYang commented on code in PR #39118:
URL: https://github.com/apache/spark/pull/39118#discussion_r1051889927


##########
pom.xml:
##########
@@ -3422,6 +3428,10 @@
         <version>4.2.0</version>
         <extensions>true</extensions>
       </plugin>
+      <plugin>

Review Comment:
   Do more tests,  It's OK to configure it only in `pluginManagement`. Will remove this.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org