You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cordova.apache.org by "Josh Pettett (JIRA)" <ji...@apache.org> on 2012/08/14 19:43:38 UTC
[jira] [Created] (CB-1235) Android create script on Windows fails
to copy config.xml
Josh Pettett created CB-1235:
--------------------------------
Summary: Android create script on Windows fails to copy config.xml
Key: CB-1235
URL: https://issues.apache.org/jira/browse/CB-1235
Project: Apache Cordova
Issue Type: Bug
Components: Android
Affects Versions: 2.0.0, Master
Environment: Windows
Reporter: Josh Pettett
Assignee: Joe Bowser
The "create" script for Android on Windows still refers to the old cordova.xml and plugins.xml files instead of config.xml, and fails to copy the later to the newly created project. This prevents the new app from initializing properly, creating a very poor experience for new users especially. Patch for fix:
diff --git a/bin/create.js b/bin/create.js
index bec182b..e0886f6 100644
--- a/bin/create.js
+++ b/bin/create.js
@@ -154,8 +154,7 @@ if(fso.FolderExists(ROOT + '\\framework')) {
exec('%comspec% /c copy '+ROOT+'\\framework\\assets\\www\\cordova-'+VERSION+'.js '+PROJECT_PATH+'\\assets\\www\\cordova-'+VERSION+'.js /Y');
exec('%comspec% /c copy '+ROOT+'\\framework\\cordova-'+VERSION+'.jar '+PROJECT_PATH+'\\libs\\cordova-'+VERSION+'.jar /Y');
fso.CreateFolder(PROJECT_PATH + '\\res\\xml');
- exec('%comspec% /c copy '+ROOT+'\\framework\\res\\xml\\cordova.xml ' + PROJECT_PATH + '\\res\\xml\\cordova.xml /Y');
- exec('%comspec% /c copy '+ROOT+'\\framework\\res\\xml\\plugins.xml ' + PROJECT_PATH + '\\res\\xml\\plugins.xml /Y');
+ exec('%comspec% /c copy '+ROOT+'\\framework\\res\\xml\\config.xml ' + PROJECT_PATH + '\\res\\xml\\config.xml /Y');
} else {
// copy in cordova.js
exec('%comspec% /c copy '+ROOT+'\\cordova-'+VERSION+'.js '+PROJECT_PATH+'\\assets\\www\\cordova-'+VERSION+'.js /Y');
@@ -163,8 +162,7 @@ if(fso.FolderExists(ROOT + '\\framework')) {
exec('%comspec% /c copy '+ROOT+'\\cordova-'+VERSION+'.jar '+PROJECT_PATH+'\\libs\\cordova-'+VERSION+'.jar /Y');
// copy in xml
fso.CreateFolder(PROJECT_PATH + '\\res\\xml');
- exec('%comspec% /c copy '+ROOT+'\\xml\\cordova.xml ' + PROJECT_PATH + '\\res\\xml\\cordova.xml /Y');
- exec('%comspec% /c copy '+ROOT+'\\xml\\plugins.xml ' + PROJECT_PATH + '\\res\\xml\\plugins.xml /Y');
+ exec('%comspec% /c copy '+ROOT+'\\xml\\config.xml ' + PROJECT_PATH + '\\res\\xml\\config.xml /Y');
}
// copy cordova scripts
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (CB-1235) Android create script on Windows fails
to copy config.xml
Posted by "Josh Pettett (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CB-1235?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Josh Pettett updated CB-1235:
-----------------------------
Attachment: create.js.patch
Patch formatting munged in comment
> Android create script on Windows fails to copy config.xml
> ---------------------------------------------------------
>
> Key: CB-1235
> URL: https://issues.apache.org/jira/browse/CB-1235
> Project: Apache Cordova
> Issue Type: Bug
> Components: Android
> Affects Versions: 2.0.0, Master
> Environment: Windows
> Reporter: Josh Pettett
> Assignee: Anis Kadri
> Attachments: create.js.patch
>
>
> The "create" script for Android on Windows still refers to the old cordova.xml and plugins.xml files instead of config.xml, and fails to copy the later to the newly created project. This prevents the new app from initializing properly, creating a very poor experience for new users especially. Patch for fix:
> diff --git a/bin/create.js b/bin/create.js
> index bec182b..e0886f6 100644
> --- a/bin/create.js
> +++ b/bin/create.js
> @@ -154,8 +154,7 @@ if(fso.FolderExists(ROOT + '\\framework')) {
> exec('%comspec% /c copy '+ROOT+'\\framework\\assets\\www\\cordova-'+VERSION+'.js '+PROJECT_PATH+'\\assets\\www\\cordova-'+VERSION+'.js /Y');
> exec('%comspec% /c copy '+ROOT+'\\framework\\cordova-'+VERSION+'.jar '+PROJECT_PATH+'\\libs\\cordova-'+VERSION+'.jar /Y');
> fso.CreateFolder(PROJECT_PATH + '\\res\\xml');
> - exec('%comspec% /c copy '+ROOT+'\\framework\\res\\xml\\cordova.xml ' + PROJECT_PATH + '\\res\\xml\\cordova.xml /Y');
> - exec('%comspec% /c copy '+ROOT+'\\framework\\res\\xml\\plugins.xml ' + PROJECT_PATH + '\\res\\xml\\plugins.xml /Y');
> + exec('%comspec% /c copy '+ROOT+'\\framework\\res\\xml\\config.xml ' + PROJECT_PATH + '\\res\\xml\\config.xml /Y');
> } else {
> // copy in cordova.js
> exec('%comspec% /c copy '+ROOT+'\\cordova-'+VERSION+'.js '+PROJECT_PATH+'\\assets\\www\\cordova-'+VERSION+'.js /Y');
> @@ -163,8 +162,7 @@ if(fso.FolderExists(ROOT + '\\framework')) {
> exec('%comspec% /c copy '+ROOT+'\\cordova-'+VERSION+'.jar '+PROJECT_PATH+'\\libs\\cordova-'+VERSION+'.jar /Y');
> // copy in xml
> fso.CreateFolder(PROJECT_PATH + '\\res\\xml');
> - exec('%comspec% /c copy '+ROOT+'\\xml\\cordova.xml ' + PROJECT_PATH + '\\res\\xml\\cordova.xml /Y');
> - exec('%comspec% /c copy '+ROOT+'\\xml\\plugins.xml ' + PROJECT_PATH + '\\res\\xml\\plugins.xml /Y');
> + exec('%comspec% /c copy '+ROOT+'\\xml\\config.xml ' + PROJECT_PATH + '\\res\\xml\\config.xml /Y');
> }
>
> // copy cordova scripts
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Assigned] (CB-1235) Android create script on Windows fails
to copy config.xml
Posted by "Joe Bowser (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CB-1235?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Joe Bowser reassigned CB-1235:
------------------------------
Assignee: Anis Kadri (was: Joe Bowser)
> Android create script on Windows fails to copy config.xml
> ---------------------------------------------------------
>
> Key: CB-1235
> URL: https://issues.apache.org/jira/browse/CB-1235
> Project: Apache Cordova
> Issue Type: Bug
> Components: Android
> Affects Versions: 2.0.0, Master
> Environment: Windows
> Reporter: Josh Pettett
> Assignee: Anis Kadri
>
> The "create" script for Android on Windows still refers to the old cordova.xml and plugins.xml files instead of config.xml, and fails to copy the later to the newly created project. This prevents the new app from initializing properly, creating a very poor experience for new users especially. Patch for fix:
> diff --git a/bin/create.js b/bin/create.js
> index bec182b..e0886f6 100644
> --- a/bin/create.js
> +++ b/bin/create.js
> @@ -154,8 +154,7 @@ if(fso.FolderExists(ROOT + '\\framework')) {
> exec('%comspec% /c copy '+ROOT+'\\framework\\assets\\www\\cordova-'+VERSION+'.js '+PROJECT_PATH+'\\assets\\www\\cordova-'+VERSION+'.js /Y');
> exec('%comspec% /c copy '+ROOT+'\\framework\\cordova-'+VERSION+'.jar '+PROJECT_PATH+'\\libs\\cordova-'+VERSION+'.jar /Y');
> fso.CreateFolder(PROJECT_PATH + '\\res\\xml');
> - exec('%comspec% /c copy '+ROOT+'\\framework\\res\\xml\\cordova.xml ' + PROJECT_PATH + '\\res\\xml\\cordova.xml /Y');
> - exec('%comspec% /c copy '+ROOT+'\\framework\\res\\xml\\plugins.xml ' + PROJECT_PATH + '\\res\\xml\\plugins.xml /Y');
> + exec('%comspec% /c copy '+ROOT+'\\framework\\res\\xml\\config.xml ' + PROJECT_PATH + '\\res\\xml\\config.xml /Y');
> } else {
> // copy in cordova.js
> exec('%comspec% /c copy '+ROOT+'\\cordova-'+VERSION+'.js '+PROJECT_PATH+'\\assets\\www\\cordova-'+VERSION+'.js /Y');
> @@ -163,8 +162,7 @@ if(fso.FolderExists(ROOT + '\\framework')) {
> exec('%comspec% /c copy '+ROOT+'\\cordova-'+VERSION+'.jar '+PROJECT_PATH+'\\libs\\cordova-'+VERSION+'.jar /Y');
> // copy in xml
> fso.CreateFolder(PROJECT_PATH + '\\res\\xml');
> - exec('%comspec% /c copy '+ROOT+'\\xml\\cordova.xml ' + PROJECT_PATH + '\\res\\xml\\cordova.xml /Y');
> - exec('%comspec% /c copy '+ROOT+'\\xml\\plugins.xml ' + PROJECT_PATH + '\\res\\xml\\plugins.xml /Y');
> + exec('%comspec% /c copy '+ROOT+'\\xml\\config.xml ' + PROJECT_PATH + '\\res\\xml\\config.xml /Y');
> }
>
> // copy cordova scripts
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira