You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@tinkerpop.apache.org by "nastra (GitHub)" <gi...@apache.org> on 2019/01/29 10:01:39 UTC

[GitHub] [tinkerpop] nastra opened pull request #1051: Make readValue(..) public

This is so that simple custom type serializers can reuse the same logic
without having to put their type serializer into the same package
structure.

[ Full content available at: https://github.com/apache/tinkerpop/pull/1051 ]
This message was relayed via gitbox.apache.org for dev@tinkerpop.apache.org

[GitHub] [tinkerpop] jorgebay closed pull request #1051: Make readValue(..)/writeValue(..) protected

Posted by "jorgebay (GitHub)" <gi...@apache.org>.

[ pull request closed by jorgebay ]

[ Full content available at: https://github.com/apache/tinkerpop/pull/1051 ]
This message was relayed via gitbox.apache.org for dev@tinkerpop.apache.org

[GitHub] [tinkerpop] jorgebay commented on issue #1051: Make readValue(..)/writeValue(..) protected

Posted by "jorgebay (GitHub)" <gi...@apache.org>.

My intention was to make it `protected` initially (not package-private), thanks @nastra for the fix!

I'll merge it via CTR once the build finishes.

[ Full content available at: https://github.com/apache/tinkerpop/pull/1051 ]
This message was relayed via gitbox.apache.org for dev@tinkerpop.apache.org

[GitHub] [tinkerpop] jorgebay commented on issue #1051: Make readValue(..)/writeValue(..) protected

Posted by "jorgebay (GitHub)" <gi...@apache.org>.

My intention was to make it `protected` initially (not package-private), thanks @nastra !

I'll merge it via CTR once the build finishes.

[ Full content available at: https://github.com/apache/tinkerpop/pull/1051 ]
This message was relayed via gitbox.apache.org for dev@tinkerpop.apache.org