You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Dimitris Tsirogiannis (Code Review)" <ge...@cloudera.org> on 2017/06/26 18:18:25 UTC
[Impala-ASF-CR] IMPALA-5579: Fix IndexOutOfBoundsException in GetTables metadata request
Dimitris Tsirogiannis has uploaded a new change for review.
http://gerrit.cloudera.org:8080/7296
Change subject: IMPALA-5579: Fix IndexOutOfBoundsException in GetTables metadata request
......................................................................
IMPALA-5579: Fix IndexOutOfBoundsException in GetTables metadata request
Issue:
GetTables metadata request may result in an IndexOutOfBoundsException
while accessing table comments fields if one or more tables can't be
retrieved from the catalog cache.
Fix:
Only add tables that can be retrieved from the catalog cache (i.e. no
TableLoadingException is thrown) in the result of a GetTables request.
Change-Id: Ic933b9950d58e6f880d4078faf1a69ee7c6adbf1
---
M fe/src/main/java/org/apache/impala/service/MetadataOp.java
M fe/src/test/java/org/apache/impala/service/FrontendTest.java
2 files changed, 11 insertions(+), 1 deletion(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/96/7296/1
--
To view, visit http://gerrit.cloudera.org:8080/7296
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ic933b9950d58e6f880d4078faf1a69ee7c6adbf1
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Dimitris Tsirogiannis <dt...@cloudera.com>
[Impala-ASF-CR] IMPALA-5579: Fix IndexOutOfBoundsException in GetTables metadata request
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has submitted this change and it was merged.
Change subject: IMPALA-5579: Fix IndexOutOfBoundsException in GetTables metadata request
......................................................................
IMPALA-5579: Fix IndexOutOfBoundsException in GetTables metadata request
Issue:
GetTables metadata request may result in an IndexOutOfBoundsException
while accessing table comments fields if one or more tables can't be
retrieved from the catalog cache.
Fix:
Only add tables that can be retrieved from the catalog cache (i.e. no
TableLoadingException is thrown) in the result of a GetTables request.
Change-Id: Ic933b9950d58e6f880d4078faf1a69ee7c6adbf1
Reviewed-on: http://gerrit.cloudera.org:8080/7296
Reviewed-by: Dimitris Tsirogiannis <dt...@cloudera.com>
Tested-by: Impala Public Jenkins
---
M fe/src/main/java/org/apache/impala/service/MetadataOp.java
M fe/src/test/java/org/apache/impala/service/FrontendTest.java
2 files changed, 11 insertions(+), 1 deletion(-)
Approvals:
Impala Public Jenkins: Verified
Dimitris Tsirogiannis: Looks good to me, approved
--
To view, visit http://gerrit.cloudera.org:8080/7296
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ic933b9950d58e6f880d4078faf1a69ee7c6adbf1
Gerrit-PatchSet: 3
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Dimitris Tsirogiannis <dt...@cloudera.com>
Gerrit-Reviewer: Alex Behm <al...@cloudera.com>
Gerrit-Reviewer: Bharath Vissapragada <bh...@cloudera.com>
Gerrit-Reviewer: Dimitris Tsirogiannis <dt...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins
[Impala-ASF-CR] IMPALA-5579: Fix IndexOutOfBoundsException in GetTables metadata request
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change.
Change subject: IMPALA-5579: Fix IndexOutOfBoundsException in GetTables metadata request
......................................................................
Patch Set 2:
Build started: http://jenkins.impala.io:8080/job/gerrit-verify-dryrun/790/
--
To view, visit http://gerrit.cloudera.org:8080/7296
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic933b9950d58e6f880d4078faf1a69ee7c6adbf1
Gerrit-PatchSet: 2
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Dimitris Tsirogiannis <dt...@cloudera.com>
Gerrit-Reviewer: Alex Behm <al...@cloudera.com>
Gerrit-Reviewer: Bharath Vissapragada <bh...@cloudera.com>
Gerrit-Reviewer: Dimitris Tsirogiannis <dt...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-5579: Fix IndexOutOfBoundsException in GetTables metadata request
Posted by "Dimitris Tsirogiannis (Code Review)" <ge...@cloudera.org>.
Dimitris Tsirogiannis has posted comments on this change.
Change subject: IMPALA-5579: Fix IndexOutOfBoundsException in GetTables metadata request
......................................................................
Patch Set 2: Code-Review+2
Rebase and keep Alex's +2
--
To view, visit http://gerrit.cloudera.org:8080/7296
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic933b9950d58e6f880d4078faf1a69ee7c6adbf1
Gerrit-PatchSet: 2
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Dimitris Tsirogiannis <dt...@cloudera.com>
Gerrit-Reviewer: Alex Behm <al...@cloudera.com>
Gerrit-Reviewer: Bharath Vissapragada <bh...@cloudera.com>
Gerrit-Reviewer: Dimitris Tsirogiannis <dt...@cloudera.com>
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-5579: Fix IndexOutOfBoundsException in GetTables metadata request
Posted by "Alex Behm (Code Review)" <ge...@cloudera.org>.
Alex Behm has posted comments on this change.
Change subject: IMPALA-5579: Fix IndexOutOfBoundsException in GetTables metadata request
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/7296
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic933b9950d58e6f880d4078faf1a69ee7c6adbf1
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Dimitris Tsirogiannis <dt...@cloudera.com>
Gerrit-Reviewer: Alex Behm <al...@cloudera.com>
Gerrit-Reviewer: Bharath Vissapragada <bh...@cloudera.com>
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-5579: Fix IndexOutOfBoundsException in GetTables metadata request
Posted by "Bharath Vissapragada (Code Review)" <ge...@cloudera.org>.
Bharath Vissapragada has posted comments on this change.
Change subject: IMPALA-5579: Fix IndexOutOfBoundsException in GetTables metadata request
......................................................................
Patch Set 1: Code-Review+1
--
To view, visit http://gerrit.cloudera.org:8080/7296
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic933b9950d58e6f880d4078faf1a69ee7c6adbf1
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Dimitris Tsirogiannis <dt...@cloudera.com>
Gerrit-Reviewer: Bharath Vissapragada <bh...@cloudera.com>
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-5579: Fix IndexOutOfBoundsException in GetTables metadata request
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change.
Change subject: IMPALA-5579: Fix IndexOutOfBoundsException in GetTables metadata request
......................................................................
Patch Set 2: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/7296
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic933b9950d58e6f880d4078faf1a69ee7c6adbf1
Gerrit-PatchSet: 2
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Dimitris Tsirogiannis <dt...@cloudera.com>
Gerrit-Reviewer: Alex Behm <al...@cloudera.com>
Gerrit-Reviewer: Bharath Vissapragada <bh...@cloudera.com>
Gerrit-Reviewer: Dimitris Tsirogiannis <dt...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-HasComments: No