You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hbase.apache.org by GitBox <gi...@apache.org> on 2020/03/08 08:35:02 UTC

[GitHub] [hbase] kai33 opened a new pull request #1251: HBASE-23950. Backport HBASE-22480 to branch-2.1

kai33 opened a new pull request #1251: HBASE-23950. Backport HBASE-22480 to branch-2.1
URL: https://github.com/apache/hbase/pull/1251
 
 
   Link to Jira:
   https://issues.apache.org/jira/browse/HBASE-23950
   
   My HBase 2.0/2.1 cluster experienced severe performance drop after running reversed scans for days. When debug into regionserver logs, it appears the bucket cache is full for every ~100 ms and its eviction can't work properly because ref count has become negative: 
   ```
   (every ~100 ms)
   Free started because "Full!"
   This block AAA is still referred by -1 readers. Can not be freed now
   This block BBB is still referred by -2 readers. Can not be freed now
   This block CCC is still referred by -3 readers. Can not be freed now
   ...
   This block ... is still referred by (negative number) readers. Can not be freed now
   ```
   There have been patch HBASE-22480 addressing this ref count problem in 2.2+. I'd like to backport it to 2.1 (understand that 2.0 is EOL)

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [hbase] Apache-HBase commented on issue #1251: HBASE-23950. Backport HBASE-22480 to branch-2.1

Posted by GitBox <gi...@apache.org>.
Apache-HBase commented on issue #1251: HBASE-23950. Backport HBASE-22480 to branch-2.1
URL: https://github.com/apache/hbase/pull/1251#issuecomment-596198542
 
 
   :broken_heart: **-1 overall**
   
   
   
   
   
   
   | Vote | Subsystem | Runtime | Comment |
   |:----:|----------:|--------:|:--------|
   | +0 :ok: |  reexec  |   2m  8s |  Docker mode activated.  |
   ||| _ Prechecks _ |
   | +1 :green_heart: |  dupname  |   0m  0s |  No case conflicting files found.  |
   | +1 :green_heart: |  hbaseanti  |   0m  0s |  Patch does not have any anti-patterns.  |
   | +1 :green_heart: |  @author  |   0m  0s |  The patch does not contain any @author tags.  |
   | +1 :green_heart: |  test4tests  |   0m  0s |  The patch appears to include 1 new or modified test files.  |
   ||| _ branch-2.1 Compile Tests _ |
   | +1 :green_heart: |  mvninstall  |   5m  9s |  branch-2.1 passed  |
   | +1 :green_heart: |  compile  |   0m 55s |  branch-2.1 passed  |
   | +1 :green_heart: |  checkstyle  |   1m 21s |  branch-2.1 passed  |
   | +1 :green_heart: |  shadedjars  |   4m 19s |  branch has no errors when building our shaded downstream artifacts.  |
   | +1 :green_heart: |  javadoc  |   0m 38s |  branch-2.1 passed  |
   | +0 :ok: |  spotbugs  |   2m 53s |  Used deprecated FindBugs config; considering switching to SpotBugs.  |
   | +1 :green_heart: |  findbugs  |   2m 51s |  branch-2.1 passed  |
   ||| _ Patch Compile Tests _ |
   | +1 :green_heart: |  mvninstall  |   5m 19s |  the patch passed  |
   | +1 :green_heart: |  compile  |   1m  0s |  the patch passed  |
   | +1 :green_heart: |  javac  |   1m  0s |  the patch passed  |
   | -1 :x: |  checkstyle  |   1m 31s |  hbase-server: The patch generated 7 new + 49 unchanged - 3 fixed = 56 total (was 52)  |
   | +1 :green_heart: |  whitespace  |   0m  0s |  The patch has no whitespace issues.  |
   | +1 :green_heart: |  shadedjars  |   4m 40s |  patch has no errors when building our shaded downstream artifacts.  |
   | +1 :green_heart: |  hadoopcheck  |  20m 28s |  Patch does not cause any errors with Hadoop 2.7.7 2.8.5 or 3.0.3 3.1.2.  |
   | +1 :green_heart: |  javadoc  |   0m 34s |  the patch passed  |
   | +1 :green_heart: |  findbugs  |   2m 49s |  the patch passed  |
   ||| _ Other Tests _ |
   | -1 :x: |  unit  | 149m 41s |  hbase-server in the patch failed.  |
   | +1 :green_heart: |  asflicense  |   0m 32s |  The patch does not generate ASF License warnings.  |
   |  |   | 210m  3s |   |
   
   
   | Reason | Tests |
   |-------:|:------|
   | Failed junit tests | hadoop.hbase.regionserver.TestHRegionWithInMemoryFlush |
   
   
   | Subsystem | Report/Notes |
   |----------:|:-------------|
   | Docker | Client=19.03.7 Server=19.03.7 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1251/1/artifact/out/Dockerfile |
   | GITHUB PR | https://github.com/apache/hbase/pull/1251 |
   | Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile |
   | uname | Linux 788d110863d6 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 GNU/Linux |
   | Build tool | maven |
   | Personality | /home/jenkins/jenkins-slave/workspace/Base-PreCommit-GitHub-PR_PR-1251/out/precommit/personality/provided.sh |
   | git revision | branch-2.1 / cd89fc273c |
   | Default Java | 1.8.0_181 |
   | checkstyle | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1251/1/artifact/out/diff-checkstyle-hbase-server.txt |
   | unit | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1251/1/artifact/out/patch-unit-hbase-server.txt |
   |  Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1251/1/testReport/ |
   | Max. process+thread count | 4623 (vs. ulimit of 10000) |
   | modules | C: hbase-server U: hbase-server |
   | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1251/1/console |
   | versions | git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11 |
   | Powered by | Apache Yetus 0.11.1 https://yetus.apache.org |
   
   
   This message was automatically generated.
   
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [hbase] Apache-HBase commented on issue #1251: HBASE-23950. Backport HBASE-22480 to branch-2.1

Posted by GitBox <gi...@apache.org>.
Apache-HBase commented on issue #1251: HBASE-23950. Backport HBASE-22480 to branch-2.1
URL: https://github.com/apache/hbase/pull/1251#issuecomment-596218627
 
 
   :broken_heart: **-1 overall**
   
   
   
   
   
   
   | Vote | Subsystem | Runtime | Comment |
   |:----:|----------:|--------:|:--------|
   | +0 :ok: |  reexec  |   0m 40s |  Docker mode activated.  |
   ||| _ Prechecks _ |
   | +1 :green_heart: |  dupname  |   0m  0s |  No case conflicting files found.  |
   | +1 :green_heart: |  hbaseanti  |   0m  0s |  Patch does not have any anti-patterns.  |
   | +1 :green_heart: |  @author  |   0m  0s |  The patch does not contain any @author tags.  |
   | +1 :green_heart: |  test4tests  |   0m  0s |  The patch appears to include 1 new or modified test files.  |
   ||| _ branch-2.1 Compile Tests _ |
   | +1 :green_heart: |  mvninstall  |   5m 49s |  branch-2.1 passed  |
   | +1 :green_heart: |  compile  |   0m 57s |  branch-2.1 passed  |
   | +1 :green_heart: |  checkstyle  |   1m 23s |  branch-2.1 passed  |
   | +1 :green_heart: |  shadedjars  |   4m  7s |  branch has no errors when building our shaded downstream artifacts.  |
   | +1 :green_heart: |  javadoc  |   0m 38s |  branch-2.1 passed  |
   | +0 :ok: |  spotbugs  |   2m 49s |  Used deprecated FindBugs config; considering switching to SpotBugs.  |
   | +1 :green_heart: |  findbugs  |   2m 47s |  branch-2.1 passed  |
   ||| _ Patch Compile Tests _ |
   | +1 :green_heart: |  mvninstall  |   4m 43s |  the patch passed  |
   | +1 :green_heart: |  compile  |   0m 54s |  the patch passed  |
   | +1 :green_heart: |  javac  |   0m 54s |  the patch passed  |
   | +1 :green_heart: |  checkstyle  |   1m 19s |  hbase-server: The patch generated 0 new + 26 unchanged - 26 fixed = 26 total (was 52)  |
   | +1 :green_heart: |  whitespace  |   0m  0s |  The patch has no whitespace issues.  |
   | +1 :green_heart: |  shadedjars  |   3m 59s |  patch has no errors when building our shaded downstream artifacts.  |
   | +1 :green_heart: |  hadoopcheck  |  20m 21s |  Patch does not cause any errors with Hadoop 2.7.7 2.8.5 or 3.0.3 3.1.2.  |
   | +1 :green_heart: |  javadoc  |   0m 37s |  the patch passed  |
   | +1 :green_heart: |  findbugs  |   3m 12s |  the patch passed  |
   ||| _ Other Tests _ |
   | -1 :x: |  unit  | 148m 33s |  hbase-server in the patch failed.  |
   | +1 :green_heart: |  asflicense  |   0m 33s |  The patch does not generate ASF License warnings.  |
   |  |   | 207m 27s |   |
   
   
   | Reason | Tests |
   |-------:|:------|
   | Failed junit tests | hadoop.hbase.regionserver.TestHRegionWithInMemoryFlush |
   
   
   | Subsystem | Report/Notes |
   |----------:|:-------------|
   | Docker | Client=19.03.7 Server=19.03.7 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1251/2/artifact/out/Dockerfile |
   | GITHUB PR | https://github.com/apache/hbase/pull/1251 |
   | Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile |
   | uname | Linux 4cbd293f9f3c 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 GNU/Linux |
   | Build tool | maven |
   | Personality | /home/jenkins/jenkins-slave/workspace/Base-PreCommit-GitHub-PR_PR-1251/out/precommit/personality/provided.sh |
   | git revision | branch-2.1 / cd89fc273c |
   | Default Java | 1.8.0_181 |
   | unit | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1251/2/artifact/out/patch-unit-hbase-server.txt |
   |  Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1251/2/testReport/ |
   | Max. process+thread count | 4637 (vs. ulimit of 10000) |
   | modules | C: hbase-server U: hbase-server |
   | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1251/2/console |
   | versions | git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11 |
   | Powered by | Apache Yetus 0.11.1 https://yetus.apache.org |
   
   
   This message was automatically generated.
   
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [hbase] kai33 commented on issue #1251: HBASE-23950. Backport HBASE-22480 to branch-2.1

Posted by GitBox <gi...@apache.org>.
kai33 commented on issue #1251: HBASE-23950. Backport HBASE-22480 to branch-2.1
URL: https://github.com/apache/hbase/pull/1251#issuecomment-596222416
 
 
   The failed test (TestHRegionWithInMemoryFlush) passed in local though

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services