You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@iceberg.apache.org by GitBox <gi...@apache.org> on 2020/10/10 08:23:02 UTC

[GitHub] [iceberg] chenjunjiedada commented on a change in pull request #1565: Flink: move hadoop configuration to Loaders from Source/Sink API

chenjunjiedada commented on a change in pull request #1565:
URL: https://github.com/apache/iceberg/pull/1565#discussion_r502763688



##########
File path: flink/src/main/java/org/apache/iceberg/flink/CatalogLoader.java
##########
@@ -43,18 +44,18 @@ static CatalogLoader hive(String name, Configuration hadoopConf, String uri, int
 
   class HadoopCatalogLoader implements CatalogLoader {
     private final String catalogName;
-    private final Configuration hadoopConf;
+    private final SerializableConfiguration hadoopConf;

Review comment:
       What do you mean ITCases?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org