You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@datafusion.apache.org by "Tpt (via GitHub)" <gi...@apache.org> on 2026/08/27 09:45:23 UTC
[PR] Fix panic on RightMark hash joins when propagating ordering [datafusion]
Tpt opened a new pull request, #24718:
URL: https://github.com/apache/datafusion/pull/24718
## Which issue does this PR close?
- Closes #24717 (affecting DF 55)
## Rationale for this change
Fixes a panic in `enforce_sorting` when given a `RightMark` hash join: `HashjoinExec::maintains_input_order` has been changed to also return `true` on `RightMark` but `enforce_sorting` has not been updated
## What changes are included in this PR?
Adds support of `RightMark` joins to `enforce_sorting` they keep the input sorting.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] Fix panic on RightMark hash joins when propagating ordering [datafusion]
Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb commented on code in PR #24718:
URL: https://github.com/apache/datafusion/pull/24718#discussion_r3871545008
##########
datafusion/physical-optimizer/src/ensure_requirements/enforce_sorting/sort_pushdown.rs:
##########
@@ -1045,7 +1045,7 @@ fn build_join_column_index(plan: &HashJoinExec) -> Vec<ColumnIndex> {
.chain(map_fields(plan.right().schema(), JoinSide::Right))
.collect::<Vec<_>>()
}
- JoinType::RightSemi | JoinType::RightAnti => {
+ JoinType::RightSemi | JoinType::RightAnti | JoinType::RightMark => {
map_fields(plan.right().schema(), JoinSide::Right)
}
_ => unreachable!("unexpected join type: {}", plan.join_type()),
Review Comment:
To make this more defensive, it would be great to make this unreachable into an internal error
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] Fix panic on RightMark hash joins when propagating ordering [datafusion]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #24718:
URL: https://github.com/apache/datafusion/pull/24718#issuecomment-5437797178
## [Codecov](https://app.codecov.io/gh/apache/datafusion/pull/24718?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:white_check_mark: All modified and coverable lines are covered by tests.
:white_check_mark: Project coverage is 81.45%. Comparing base ([`a38bb10`](https://app.codecov.io/gh/apache/datafusion/commit/a38bb10c33cff4e99a2707059df99f6971c96f33?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`3b969f4`](https://app.codecov.io/gh/apache/datafusion/commit/3b969f49f5566f71e7a3389234898359769d0dc3?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## main #24718 +/- ##
==========================================
- Coverage 81.45% 81.45% -0.01%
==========================================
Files 1120 1120
Lines 401289 401289
Branches 401289 401289
==========================================
- Hits 326871 326866 -5
- Misses 55295 55300 +5
Partials 19123 19123
```
</details>
[:umbrella: View full report in Codecov by Harness](https://app.codecov.io/gh/apache/datafusion/pull/24718?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
:loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
- :package: [JS Bundle Analysis](https://docs.codecov.com/docs/javascript-bundle-analysis): Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] Fix panic on RightMark hash joins when propagating ordering [datafusion]
Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb merged PR #24718:
URL: https://github.com/apache/datafusion/pull/24718
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org