[GitHub] [superset] zhaoyongjie commented on a change in pull request #18171: fix: null value and empty string in filter

[GitBox <gi...@apache.org>]

zhaoyongjie commented on a change in pull request #18171:
URL: https://github.com/apache/superset/pull/18171#discussion_r793600807



##########
File path: superset/connectors/base/models.py
##########
@@ -404,7 +404,7 @@ def handle_single_value(value: Optional[FilterValue]) -> Optional[FilterValue]:
                     return utils.cast_to_num(value)
                 if value == NULL_STRING:
                     return None
-                if value == "<empty string>":
+                if value == EMPTY_STRING:

Review comment:
       I think it's used to adapt some legacy Select component.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org