You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by GitBox <gi...@apache.org> on 2021/04/14 23:24:31 UTC

[GitHub] [kafka] jolshan opened a new pull request #10540: MINOR: update default for field in DeleteTopicsRequest

jolshan opened a new pull request #10540:
URL: https://github.com/apache/kafka/pull/10540


   When using DeleteTopicsRequest with topic IDs, the topic name field should be null. Before, the code was programmatically assigning null, but it will be easier and less error prone to simply set that as the default. 
   
   Tested using the previously created `DeleteTopicsRequestTest.java` file.
   
   ### Committer Checklist (excluded from commit message)
   - [ ] Verify design and implementation 
   - [ ] Verify test coverage and CI build status
   - [ ] Verify documentation (including upgrade notes)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [kafka] dajac merged pull request #10540: MINOR: update default for field in DeleteTopicsRequest

Posted by GitBox <gi...@apache.org>.
dajac merged pull request #10540:
URL: https://github.com/apache/kafka/pull/10540


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [kafka] dajac commented on pull request #10540: MINOR: update default for field in DeleteTopicsRequest

Posted by GitBox <gi...@apache.org>.
dajac commented on pull request #10540:
URL: https://github.com/apache/kafka/pull/10540#issuecomment-820497042


   Test failures are not related. Merging to trunk.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org