[GitHub] zhaoyongjie closed pull request #5048: [bugfix] Render to section by override value

[GitBox <gi...@apache.org>]

zhaoyongjie closed pull request #5048: [bugfix] Render to section by override value
URL: https://github.com/apache/incubator-superset/pull/5048
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git a/superset/assets/src/explore/components/ControlPanelsContainer.jsx b/superset/assets/src/explore/components/ControlPanelsContainer.jsx
index 1bf653f938..631caaf0b7 100644
--- a/superset/assets/src/explore/components/ControlPanelsContainer.jsx
+++ b/superset/assets/src/explore/components/ControlPanelsContainer.jsx
@@ -96,8 +96,8 @@ class ControlPanelsContainer extends React.Component {
         control => (
           controls[control] &&
           (
-            !controls[control].renderTrigger ||
-            controls[control].tabOverride === 'data'
+            !this.getControlData(control).renderTrigger ||
+            this.getControlData(control).tabOverride === 'data'
           )
         )))) {
         querySectionsToRender.push(section);
diff --git a/superset/assets/src/explore/visTypes.js b/superset/assets/src/explore/visTypes.js
index 35e49d4587..0018ab9d6a 100644
--- a/superset/assets/src/explore/visTypes.js
+++ b/superset/assets/src/explore/visTypes.js
@@ -1206,6 +1206,7 @@ export const visTypes = {
         label: t('No of Bins'),
         description: t('Select number of bins for the histogram'),
         default: 5,
+        renderTrigger: true,
       },
       global_opacity: {
         description: t('Opacity of the bars. Between 0 and 1'),


 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org