You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@wicket.apache.org by "Juergen Donnerstag (JIRA)" <ji...@apache.org> on 2009/09/26 14:39:16 UTC

[jira] Resolved: (WICKET-2372) Include component does not handle UTF-8 content correctly

     [ https://issues.apache.org/jira/browse/WICKET-2372?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Juergen Donnerstag resolved WICKET-2372.
----------------------------------------

       Resolution: Fixed
    Fix Version/s:     (was: 1.3.8)
                   1.5-M1
         Assignee: Juergen Donnerstag

fixed

> Include component does not handle UTF-8 content correctly
> ---------------------------------------------------------
>
>                 Key: WICKET-2372
>                 URL: https://issues.apache.org/jira/browse/WICKET-2372
>             Project: Wicket
>          Issue Type: Bug
>          Components: wicket
>    Affects Versions: 1.3.6
>         Environment: Mac OS 10.5.7, Java 1.6
>            Reporter: Jeff Chiu
>            Assignee: Juergen Donnerstag
>             Fix For: 1.5-M1
>
>
> To reproduce this bug, use the Include component to include content that contains UTF-8 encoded characters. If the jvm's default charset is anything besides UTF-8, the resulting page mangles the characters.
> Include uses a utility class, UrlResourceStream, to make the http connection and grab the data. Internally, UrlResourceStream runs the response through an InputStreamReader (the code is actually in the parent class, AbstractResourceStream). While UrlResourceStream allows you to specify a charset to pass to the InputStreamReader, Include doesn't allow callers to do this, so the default jvm charset is always used.
> On my machine, that's "MacRoman." Changing the jvm's default charset by using "-Dfile.encoding=UTF-8" when starting the jvm causes the content to be included correctly.
> Fix is to change Include to have getters/setters so that a character set can be set for each instance, which it then passes along to underlying code as described above.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.