You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@beam.apache.org by pabloem <gi...@git.apache.org> on 2017/01/10 21:41:08 UTC

[GitHub] beam pull request #1761: [BEAM-147] Adding proto buff matchers for dataflow ...

GitHub user pabloem opened a pull request:

    https://github.com/apache/beam/pull/1761

    [BEAM-147] Adding proto buff matchers for dataflow client

    Be sure to do all of the following to help us incorporate your contribution
    quickly and easily:
    
     - [x] Make sure the PR title is formatted like:
       `[BEAM-<Jira issue #>] Description of pull request`
     - [x] Make sure tests pass via `mvn clean verify`. (Even better, enable
           Travis-CI on your fork and ensure the whole test matrix passes).
     - [x] Replace `<Jira issue #>` in the title with the actual Jira issue
           number, if there is one.
     - [ ] If this contribution is large, please file an Apache
           [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.txt).
    
    ---
    Adding these matchers to test changes to dataflow client - service communication in metrics.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/pabloem/incubator-beam proto-matchers

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/beam/pull/1761.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1761
    
----
commit e8be8fa28a1095c8e881a1d48bb4a0265ab42ed4
Author: Pablo <pa...@google.com>
Date:   2017-01-10T21:38:48Z

    Adding proto buff matchers for dataflow client

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] beam pull request #1761: [BEAM-147] Adding proto buff matchers for dataflow ...

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/beam/pull/1761


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---